Adding exception handling to remove the problem of propogating error codes all the way up the stack. Still not quite super-consistant, but getting there. Util functions still return true/false since they just ask questions, but API functions will throw errors to ensure they are being dealt with. Main CLI class needs to take advantage of this fact and become simpler. Tests are already modified to detect new exceptions with one exception :)

1 files changed, 4 insertions, 4 deletions

diff --git a/cobbler/item_system.py b/cobbler/item_system.py
index fef3743..4607623 100644
--- a/cobbler/item_system.py
+++ b/cobbler/item_system.py
@@ -6,7 +6,7 @@ Michael DeHaan <mdehaan@redhat.com>
 
 import utils
 import item
-from cobbler_exception import CobblerException
+import cexceptions
 
 class System(item.Item):
 
@@ -33,7 +33,7 @@ class System(item.Item):
         """
         new_name = utils.find_system_identifier(name)
         if not new_name:
-            raise CobblerException("bad_sys_name")
+            raise cexceptions.CobblerException("bad_sys_name")
         self.name = name  # we check it add time, but store the original value.
         return True
 
@@ -45,14 +45,14 @@ class System(item.Item):
         if self.config.profiles().find(profile_name):
             self.profile = profile_name
             return True
-        return False
+        raise cexceptions.CobblerException("exc_profile")
 
     def is_valid(self):
         """
 	A system is valid when it contains a valid name and a profile.
 	"""
         if self.name is None:
-            raise CobblerException("bad_sys_name")
+            return False
         if self.profile is None:
             return False
         return True