diff options
| author | Heinrich Schuchardt <xypron.glpk@gmx.de> | 2018-10-02 05:57:32 +0200 |
|---|---|---|
| committer | Alexander Graf <agraf@suse.de> | 2018-10-16 16:39:57 +0200 |
| commit | 2c61e0cc5c67345d2d3e4a66f6e22899afa381cc (patch) | |
| tree | dab61b15eff79f52607f8a6bdc0bc75833e22cca /lib/efi_loader/efi_file.c | |
| parent | 6f566c231d93050e9366bc32067fdecd2aa8d8c6 (diff) | |
| download | u-boot-2c61e0cc5c67345d2d3e4a66f6e22899afa381cc.tar.gz u-boot-2c61e0cc5c67345d2d3e4a66f6e22899afa381cc.tar.xz u-boot-2c61e0cc5c67345d2d3e4a66f6e22899afa381cc.zip | |
efi_loader: superfluous statement in is_dir()
When is_dir() is called we have already execute set_blk_dev(fh).
So don't call it again.
This fixes CoverityScan CID 184093.
Reported-by: Tom Rini <trini@konsulko.com>
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Signed-off-by: Alexander Graf <agraf@suse.de>
Diffstat (limited to 'lib/efi_loader/efi_file.c')
| -rw-r--r-- | lib/efi_loader/efi_file.c | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/lib/efi_loader/efi_file.c b/lib/efi_loader/efi_file.c index c1e285e9f7..beb4fba917 100644 --- a/lib/efi_loader/efi_file.c +++ b/lib/efi_loader/efi_file.c @@ -52,11 +52,18 @@ static int set_blk_dev(struct file_handle *fh) return fs_set_blk_dev_with_part(fh->fs->desc, fh->fs->part); } +/** + * is_dir() - check if file handle points to directory + * + * We assume that set_blk_dev(fh) has been called already. + * + * @fh: file handle + * Return: true if file handle points to a directory + */ static int is_dir(struct file_handle *fh) { struct fs_dir_stream *dirs; - set_blk_dev(fh); dirs = fs_opendir(fh->path); if (!dirs) return 0; |