summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorPatrick Wildt <patrick@blueri.se>2020-06-07 20:36:12 +0200
committerKever Yang <kever.yang@rock-chips.com>2020-06-28 09:56:11 +0800
commit673eb44e91bc0c06cb1e3f353f5d07b4f9e5a586 (patch)
tree96ea9b362542cae72026a70f4a8f110a000cfa14 /drivers
parent5e15dcb4cbc7906690a759554be082b025d2aa52 (diff)
downloadu-boot-673eb44e91bc0c06cb1e3f353f5d07b4f9e5a586.tar.gz
u-boot-673eb44e91bc0c06cb1e3f353f5d07b4f9e5a586.tar.xz
u-boot-673eb44e91bc0c06cb1e3f353f5d07b4f9e5a586.zip
rockchip: correctly set vop0 or vop1
The EDP_LCDC_SEL bit has to be set correctly to select vop0 or vop1, but so far we have set it in both conditions, which is not correct. Can someone verify this is the correct way round? vop1 -> set, vop0 -> clear? Signed-off-by: Patrick Wildt <patrick@blueri.se> Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/video/rockchip/rk_edp.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/video/rockchip/rk_edp.c b/drivers/video/rockchip/rk_edp.c
index 92188be927..000bd48140 100644
--- a/drivers/video/rockchip/rk_edp.c
+++ b/drivers/video/rockchip/rk_edp.c
@@ -1062,7 +1062,8 @@ static int rk_edp_probe(struct udevice *dev)
rk_setreg(&priv->grf->soc_con12, 1 << 4);
/* select epd signal from vop0 or vop1 */
- rk_setreg(&priv->grf->soc_con6, (vop_id == 1) ? (1 << 5) : (1 << 5));
+ rk_clrsetreg(&priv->grf->soc_con6, (1 << 5),
+ (vop_id == 1) ? (1 << 5) : (0 << 5));
rockchip_edp_wait_hpd(priv);