summaryrefslogtreecommitdiffstats
path: root/common/usb_hub.c
diff options
context:
space:
mode:
authorIsmael Luceno Cortes <ismael.luceno@silicon-gears.com>2019-04-01 16:09:13 +0000
committerMarek Vasut <marex@denx.de>2019-04-09 13:11:45 +0200
commit51f60a89b75e5b71c747e15b8247abae798244ec (patch)
tree0dac3be4a666790ea62dab4312ee567cd8035702 /common/usb_hub.c
parent89aea23abb971fa89b7a96c02024b63d0b918a78 (diff)
downloadu-boot-51f60a89b75e5b71c747e15b8247abae798244ec.tar.gz
u-boot-51f60a89b75e5b71c747e15b8247abae798244ec.tar.xz
u-boot-51f60a89b75e5b71c747e15b8247abae798244ec.zip
usb: Make portspeed return a read-only string
Current code is plain wrong, and there's no need to have a mutable string, so fix function type and remove the intermediate variable. Signed-off-by: Ismael Luceno <ismael.luceno@silicon-gears.com>
Diffstat (limited to 'common/usb_hub.c')
-rw-r--r--common/usb_hub.c18
1 files changed, 5 insertions, 13 deletions
diff --git a/common/usb_hub.c b/common/usb_hub.c
index 33aaeb8e44..9069f4b33a 100644
--- a/common/usb_hub.c
+++ b/common/usb_hub.c
@@ -233,26 +233,18 @@ static struct usb_hub_device *usb_hub_allocate(void)
#define MAX_TRIES 5
-static inline char *portspeed(int portstatus)
+static inline const char *portspeed(int portstatus)
{
- char *speed_str;
-
switch (portstatus & USB_PORT_STAT_SPEED_MASK) {
case USB_PORT_STAT_SUPER_SPEED:
- speed_str = "5 Gb/s";
- break;
+ return "5 Gb/s";
case USB_PORT_STAT_HIGH_SPEED:
- speed_str = "480 Mb/s";
- break;
+ return "480 Mb/s";
case USB_PORT_STAT_LOW_SPEED:
- speed_str = "1.5 Mb/s";
- break;
+ return "1.5 Mb/s";
default:
- speed_str = "12 Mb/s";
- break;
+ return "12 Mb/s";
}
-
- return speed_str;
}
/**