diff options
author | Masahiro Yamada <masahiroy@kernel.org> | 2020-06-26 15:13:33 +0900 |
---|---|---|
committer | Tom Rini <trini@konsulko.com> | 2020-07-17 09:30:13 -0400 |
commit | b75d8dc5642b71eb029e7cd38031a32029e736cc (patch) | |
tree | e13a2c309a27c528a79f7c49b468c0c2d246a499 /arch/arm/mach-omap2/omap5 | |
parent | 02ff91e8c60f1f48bee8f4bd1c87ea0892cc5dae (diff) | |
download | u-boot-b75d8dc5642b71eb029e7cd38031a32029e736cc.tar.gz u-boot-b75d8dc5642b71eb029e7cd38031a32029e736cc.tar.xz u-boot-b75d8dc5642b71eb029e7cd38031a32029e736cc.zip |
treewide: convert bd_t to struct bd_info by coccinelle
The Linux coding style guide (Documentation/process/coding-style.rst)
clearly says:
It's a **mistake** to use typedef for structures and pointers.
Besides, using typedef for structures is annoying when you try to make
headers self-contained.
Let's say you have the following function declaration in a header:
void foo(bd_t *bd);
This is not self-contained since bd_t is not defined.
To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h>
#include <asm/u-boot.h>
void foo(bd_t *bd);
Then, the include direcective pulls in more bloat needlessly.
If you use 'struct bd_info' instead, it is enough to put a forward
declaration as follows:
struct bd_info;
void foo(struct bd_info *bd);
Right, typedef'ing bd_t is a mistake.
I used coccinelle to generate this commit.
The semantic patch that makes this change is as follows:
<smpl>
@@
typedef bd_t;
@@
-bd_t
+struct bd_info
</smpl>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to 'arch/arm/mach-omap2/omap5')
-rw-r--r-- | arch/arm/mach-omap2/omap5/fdt.c | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/arch/arm/mach-omap2/omap5/fdt.c b/arch/arm/mach-omap2/omap5/fdt.c index 3f8474b8d0..c4162420f3 100644 --- a/arch/arm/mach-omap2/omap5/fdt.c +++ b/arch/arm/mach-omap2/omap5/fdt.c @@ -29,7 +29,7 @@ static u32 hs_irq_skip[] = { 118 /* One interrupt for Crypto DMA by secure world */ }; -static int ft_hs_fixup_crossbar(void *fdt, bd_t *bd) +static int ft_hs_fixup_crossbar(void *fdt, struct bd_info *bd) { const char *path; int offs; @@ -93,7 +93,7 @@ static int ft_hs_fixup_crossbar(void *fdt, bd_t *bd) #if ((TI_OMAP5_SECURE_BOOT_RESV_SRAM_SZ != 0) || \ (CONFIG_SECURE_RUNTIME_RESV_SRAM_SZ != 0)) -static int ft_hs_fixup_sram(void *fdt, bd_t *bd) +static int ft_hs_fixup_sram(void *fdt, struct bd_info *bd) { const char *path; int offs; @@ -128,10 +128,10 @@ static int ft_hs_fixup_sram(void *fdt, bd_t *bd) return 0; } #else -static int ft_hs_fixup_sram(void *fdt, bd_t *bd) { return 0; } +static int ft_hs_fixup_sram(void *fdt, struct bd_info *bd) { return 0; } #endif -static void ft_hs_fixups(void *fdt, bd_t *bd) +static void ft_hs_fixups(void *fdt, struct bd_info *bd) { /* Check we are running on an HS/EMU device type */ if (GP_DEVICE != get_device_type()) { @@ -148,7 +148,7 @@ static void ft_hs_fixups(void *fdt, bd_t *bd) hang(); } #else -static void ft_hs_fixups(void *fdt, bd_t *bd) +static void ft_hs_fixups(void *fdt, struct bd_info *bd) { } #endif /* #ifdef CONFIG_TI_SECURE_DEVICE */ @@ -255,7 +255,7 @@ static int ft_fixup_clocks(void *fdt, const char **names, u32 *rates, int num) return 0; } -static void ft_opp_clock_fixups(void *fdt, bd_t *bd) +static void ft_opp_clock_fixups(void *fdt, struct bd_info *bd) { const char **clk_names; u32 *clk_rates; @@ -299,7 +299,7 @@ static void ft_opp_clock_fixups(void *fdt, bd_t *bd) } } #else -static void ft_opp_clock_fixups(void *fdt, bd_t *bd) { } +static void ft_opp_clock_fixups(void *fdt, struct bd_info *bd) { } #endif /* CONFIG_TARGET_DRA7XX_EVM || CONFIG_TARGET_AM57XX_EVM */ /* @@ -307,7 +307,7 @@ static void ft_opp_clock_fixups(void *fdt, bd_t *bd) { } * fixups should remain in the board files which is where * this function should be called from. */ -void ft_cpu_setup(void *fdt, bd_t *bd) +void ft_cpu_setup(void *fdt, struct bd_info *bd) { ft_hs_fixups(fdt, bd); ft_opp_clock_fixups(fdt, bd); |