diff options
| author | Simon Glass <sjg@chromium.org> | 2021-03-25 10:26:11 +1300 |
|---|---|---|
| committer | Simon Glass <sjg@chromium.org> | 2021-04-06 16:33:19 +1200 |
| commit | bddac45d0422acbba5bf01406d27eedb429a1f42 (patch) | |
| tree | ea1ed5badfce825b12e3c43718a76e0dc6a734e5 | |
| parent | d6332d59d25c26b9f21e04792686c4989a9382a4 (diff) | |
| download | u-boot-bddac45d0422acbba5bf01406d27eedb429a1f42.tar.gz u-boot-bddac45d0422acbba5bf01406d27eedb429a1f42.tar.xz u-boot-bddac45d0422acbba5bf01406d27eedb429a1f42.zip | |
pinctrl: Return -ENOSYS when system call is not available
Update the code to use -ENOSYS, which is the correct error code for an
unimplemented system call in U-Boot.
Also we should not check for a missing operations array as this is not
permitted. For now this can be covered by an assert().
Signed-off-by: Simon Glass <sjg@chromium.org>
| -rw-r--r-- | drivers/pinctrl/pinctrl-uclass.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/drivers/pinctrl/pinctrl-uclass.c b/drivers/pinctrl/pinctrl-uclass.c index b0f30aa1f7..6e68e52c32 100644 --- a/drivers/pinctrl/pinctrl-uclass.c +++ b/drivers/pinctrl/pinctrl-uclass.c @@ -235,8 +235,9 @@ int pinctrl_gpio_request(struct udevice *dev, unsigned offset) return ret; ops = pinctrl_get_ops(pctldev); - if (!ops || !ops->gpio_request_enable) - return -ENOTSUPP; + assert(ops); + if (!ops->gpio_request_enable) + return -ENOSYS; return ops->gpio_request_enable(pctldev, pin_selector); } @@ -261,8 +262,9 @@ int pinctrl_gpio_free(struct udevice *dev, unsigned offset) return ret; ops = pinctrl_get_ops(pctldev); - if (!ops || !ops->gpio_disable_free) - return -ENOTSUPP; + assert(ops); + if (!ops->gpio_disable_free) + return -ENOSYS; return ops->gpio_disable_free(pctldev, pin_selector); } |