| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
All previous comments about test mode being untested apply to loader, but
doubly so.
|
|
|
|
| |
This is a migration of the patch 22e2548cbb41a0c32fa3a0a2e67e67bbf3109155 from rhel5-branch, BZ#493052.
|
|
|
|
|
|
|
|
|
| |
terminates program in OOM scenarios.
This is to avoid having to copy-paste the asprintf-log-abort if branch
all the time. This commit also modifies existing asprintf() calls to
use the new macro in places where the change wouldn't modify program's
semantics.
|
|
|
|
|
| |
We have glib for other things, so we can use it for option parsing and
dump another library dependency.
|
|
|
|
|
|
| |
Makes sure that NFS options can be used in both parameters. Previously
this was only parsed for ks= and not for stage2= using two separate
code paths. Move this to a shared function in loader/nfsinstall.c.
|
|
|
|
|
| |
Also, rip out all the username/password stuff too. That's not needed for
nfs.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We need to clear stage2Data when going back so that
* we don't sigsegv on it later if we change nfs method to url (and also if
we change from url to nfs in case of location specified via ks or boot opts)
* we don't try to fetch stage2 from the location in stage2Data right after
reselecting the method.
Also fixes [C] and [A] from
https://www.redhat.com/archives/anaconda-devel-list/2009-August/msg00043.html
(sigsegv after going Back when incorrect stage2 url is specified via ks or boot
params) which were partly fixed by Jeremy's
ad1e95df0e277442a19f7989afe3bd758cfccb47.
|
| |
|
|
|
|
|
|
|
| |
This fix makes loaderData->stage2Data be initialized unconditionally.
Without it, we sometimes get a garbage pointer there, and that results
in a segfault (if you're lucky) in mountNfsImage when it tries to use
the data.
|
|
|
|
|
|
| |
This reverts commit 5a0189827c1c6db21ecbfd01f00ee1f5edbb7a77.
gcc-4.4.0-0.31 in rawhide fixes the problem we were seeing.
|
|
|
|
|
|
|
|
|
| |
Problem with -O2 and some string functions with the latest version of
gcc in rawhide. Work around the problem for now so we can compile,
ideally we can revert this patch in the future.
gcc bug:
https://bugzilla.redhat.com/show_bug.cgi?id=492973
|
| |
|
|
|
|
|
|
|
|
|
| |
This is a much more readable and reasonable patch to restore the
'ks' boot option functionality. The nextserver and bootfile are
read from the DHCP option set and used to build the URL to find
the kickstart file.
[rawhide]
|
|
|
|
|
| |
Mount options are handled elsewhere, we do not need to store them
in the instRepo variable.
|
|
|
|
|
|
| |
We don't really need to do this anymore because if the user has
provided an invalid host, the mount will fail and we pop up the
dialog box anyway.
|
|
|
|
|
|
|
|
|
| |
Since we're using NetworkManager, just try things and see if they
work. For example, try to do a hostname lookup when mounting the
NFS source. If it works, we have working DNS and can move on.
If it fails, we can tell the user they are missing DNS information
and maybe they'll get the hint to either configure DNS servers or
to specify the NFS source using an IP address.
|
| |
|
|
|
|
|
| |
iface_ip2str() requires the interface device name and the address
family (e.g., AF_INET).
|
|
|