| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
| |
Required for getlangnames.py
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
The DASD kernel parameters will be coming from DASDDevice objects.
|
|\ |
|
| | |
|
|/
|
|
|
|
| |
If we just iterate over the task list selecting and deselecting groups,
then we'll deselect groups we want if a later task also contains those
groups. So deselect all unchecked tasks, then select all checked tasks.
|
|
|
|
|
|
|
| |
it (#506073).
Just update the order of drives instead of using only drives entered in
--driveorder option.
|
|
|
|
|
| |
multipath and multipathd expect the leading "3" in wwids, but that's bad
in the user interface. So use one for one and the other for the other.
|
|
|
|
|
|
|
|
| |
The livecd includes anaconda, for obvious reasons. However this means that
70-anaconda.rules will be installed on the finished system and running our
rules has some unusual side effects. While we slowly push our udev rules
changes into upstream packages, this should make them a no-op on the
installed system.
|
|
|
|
|
|
|
|
|
|
| |
With present UI, edit repos, not base repos (methodstr). Works with
assumption that base repo (repo/method) url points to a single repo, which is
true for Fedora (as opposed to RHEL5 where we various repos in directories).
dgregor told me that the target for RHEL6 is to have just one repo and handle
product differentiation by comps. If we had to work with multirepo base
urls, the UI for repo editing would need to be redesigned and rewritten because
now we are mixing base urls with repo urls there.
|
|
|
|
| |
We need to pass dummy repo object. Also pass methodstr as argument.
|
|
|
|
|
| |
We need it for repo editing or correction of repo= arguments in UI, especially
in case of nfs: or cdrom: which can't be stored in AnacondaYum.baseurl,
|
|
|
|
|
| |
I'd set insensitive also the other elements instead of hiding them which makes
the dialog desert. The dialog probably needs some more polishing.
|
| |
|
| |
|
|
|
|
|
|
| |
Live images don't contain volume_key, which makes sense since key
escrow is kickstart-only functionality. At any rate, failure to
import volume_key should only break key escrow.
|
|
|
|
|
|
| |
This writes a multipathd.conf that whitelists the devices we're using in
our multipath devices. It's a fairly basic configuration, and it doesn't
handle ALUA yet.
|
| |
|
|
|
|
|
|
| |
(#524417).
Concerns cases when stage2= can't be parsed as http or ftp url.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
This patch fixes 2 issues with the parsing of the optional portnr in
iscsi target IP's:
1) We don't want to include the : in the portno, so port = target[idx:]
should be port = target[idx+1:]
2) An IPV6 IP always includes the : character, so specifying the port
was mandatory with IPV6, this patch looks for "]:" inside the
string to determine if a port is present for IPV6 strings.
|
| |
|
| |
|
|
|
|
|
|
| |
If we are editing, not creating, we overwite several attributes
instead of creating a new device/action pair. Since these changes
have no corresponding action they need to be reversed manually.
|
|
|
|
| |
This should have been part of the previous commit but wasn't.
|
|
|
|
|
| |
MultipathDevice needs its own .updateSysfsPath(), because self.name is
"mpath0" but the sysfs directory is /sys/class/block/dm-0 .
|
|
|
|
|
| |
We're doing this on other architectures but not here, and we prompt to
run mediacheck on the disc, so we ought to be checksumming it.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a patch to fix installation of grub in case we have md raid 1 /boot
device. I posted similar patch some time ago, Hans reviewed it, but it
didn't gather much attention so I was afraid to push it - it changes behavior.
Now I decided to do things a bit differently. Also, some weeks ago Hans has
pushed a patch fixing bootloader target selection for mdraid (commit
45a7048e5f56316e052e4699b5ec70aa291ddd5e) upon which my patch is standing. So
here I come again (sorry for repeating myself).
We offer installation into mbr or boot partition (/dev/mdX) in UI. In F11 and RHEL5
if md boot partition was on /dev/sda1 and /dev/sdb1, in case of "mbr" we
installed grub twice into mbr of /dev/sda, and in case of "partition" into mbr
of /dev/sda and /dev/sdb. Member drive removal in the second case didn't work
I think (no boot).
Hans's patch changed the behavior (it was expected) - we are really installing
bootloader into boot device if /dev/mdX is selected, and if mbr is selected,
we are installing twice into mbr of selected drive as before.
My patch wants to make it behave "the right" way, that is - install where you
were asked to, and be able to boot when one member disk is removed (see bug
https://bugzilla.redhat.com/show_bug.cgi?id=213578), so:
A) In case of installing into boot partition: install it there in a way that the
boot works if one member is removed.
B) In case of installing into mbr: iff the disk contains member of boot md
array, install also into mbrs of other members. If one member is removed, be
able to boot - this is fixed by the patch.
Note: I'd like to fix upgrade of grub part too, especially when now the
behavior has changed wrt what we write out in grub.conf and
/etc/sysconfig/grub. Also UI can writing for mbr could say that we'd
install into mbr of other member disks too (if it is the case)
If you want details, below are some cases that illustrate the change (also the
code may be hard to follow for given case, I can post a test script using
which you can get resulting grub input for given case)
1) sda, sdb, install to mbr, /boot is sdb1
works both with and without the patch, the same grub commands are run
2) sda, sdb, sdc, install to mbr of sda, /boot is mdarray of sdb3 and sdc3
without the patch:
- boots with both disks, doesn't if any is removed
- log:
Running... ['/sbin/grub-install', '--just-copy']
Running... ['/sbin/grub', '--batch', '--no-floppy', '--device-map=/boot/grub/device.map']
GNU GRUB version 0.97 (640K lower / 3072K upper memory)
[ Minimal BASH-like line editing is supported. For the first word, TAB
lists possible command completions. Anywhere else TAB lists the possible
completions of a device/filename.]
grub> root (hd0,2)
Filesystem type is ext2fs, partition type 0xfd
grub> install --stage2=/boot/grub/stage2 /grub/stage1 d (hd0) /grub/stage2 p (hd0,2)/grub/grub.conf
grub> Running... ['/sbin/grub-install', '--just-copy']
Running... ['/sbin/grub', '--batch', '--no-floppy', '--device-map=/boot/grub/device.map']
GNU GRUB version 0.97 (640K lower / 3072K upper memory)
[ Minimal BASH-like line editing is supported. For the first word, TAB
lists possible command completions. Anywhere else TAB lists the possible
completions of a device/filename.]
grub> root (hd1,2)
Filesystem type is ext2fs, partition type 0xfd
grub> install --stage2=/boot/grub/stage2 /grub/stage1 d (hd0) /grub/stage2 p (hd1,2)/grub/grub.conf
grub>
both disks - OK
2nd disk removed - OK
1st disk removed - OK
with the patch:
- boots even when any of member disks is removed
- log:
Running... ['/sbin/grub-install', '--just-copy']
Running... ['/sbin/grub', '--batch', '--no-floppy', '--device-map=/boot/grub/device.map']
GNU GRUB version 0.97 (640K lower / 3072K upper memory)
[ Minimal BASH-like line editing is supported. For the first word, TAB
lists possible command completions. Anywhere else TAB lists the possible
completions of a device/filename.]
grub> root (hd1,2)
Filesystem type is ext2fs, partition type 0xfd
grub> install --stage2=/boot/grub/stage2 /grub/stage1 d (hd0) /grub/stage2 p (hd1,2)/grub/grub.conf
grub>
3) sda, sdb, install to mbr of sda, /boot is mdarray of sda3 and sdb3
without patch:
- it boots with both disks, doesn't find stage1 (_ on screen) if any of them
is removed
- log:
Running... ['/sbin/grub-install', '--just-copy']
Running... ['/sbin/grub', '--batch', '--no-floppy', '--device-map=/boot/grub/device.map']
GNU GRUB version 0.97 (640K lower / 3072K upper memory)
[ Minimal BASH-like line editing is supported. For the first word, TAB
lists possible command completions. Anywhere else TAB lists the possible
completions of a device/filename.]
grub> root (hd1,1)
Filesystem type is ext2fs, partition type 0xfd
grub> install --stage2=/boot/grub/stage2 /grub/stage1 d (hd0) /grub/stage2 p (hd1,1)/grub/grub.conf
grub> Running... ['/sbin/grub-install', '--just-copy']
Running... ['/sbin/grub', '--batch', '--no-floppy', '--device-map=/boot/grub/device.map']
GNU GRUB version 0.97 (640K lower / 3072K upper memory)
[ Minimal BASH-like line editing is supported. For the first word, TAB
lists possible command completions. Anywhere else TAB lists the possible
completions of a device/filename.]
grub> root (hd2,1)
Filesystem type is ext2fs, partition type 0xfd
grub> install --stage2=/boot/grub/stage2 /grub/stage1 d (hd0) /grub/stage2 p (hd2,1)/grub/grub.conf
grub>
with the patch:
- boots even when one of member disks is removed
- log:
Running... ['/sbin/grub-install', '--just-copy']
Running... ['/sbin/grub', '--batch', '--no-floppy', '--device-map=/boot/grub/device.map']
GNU GRUB version 0.97 (640K lower / 3072K upper memory)
[ Minimal BASH-like line editing is supported. For the first word, TAB
lists possible command completions. Anywhere else TAB lists the possible
completions of a device/filename.]
grub> device (hd0) /dev/sdb
grub> root (hd0,2)
Filesystem type is ext2fs, partition type 0xfd
grub> install --stage2=/boot/grub/stage2 /grub/stage1 d (hd0) /grub/stage2 p (hd0,2)/grub/grub.conf
grub> Running... ['/sbin/grub', '--batch', '--no-floppy', '--device-map=/boot/grub/device.map']
GNU GRUB version 0.97 (640K lower / 3072K upper memory)
[ Minimal BASH-like line editing is supported. For the first word, TAB
lists possible command completions. Anywhere else TAB lists the possible
completions of a device/filename.]
grub> root (hd0,2)
Filesystem type is ext2fs, partition type 0xfd
grub> install --stage2=/boot/grub/stage2 /grub/stage1 d (hd0) /grub/stage2 p (hd0,2)/grub/grub.conf
grub>
4) like 3), but /boot is mdarray of sda3 and sdb2 - notice different partition
numbers - removing a specific one of member disks can't work as location of
grub.conf file stored in first block of stage2 is shared and so contains only
the last grub-installed value.
without the patch:
- doesn't boot with both disks, doesn't boot with any single disk
- log:
Running... ['/sbin/grub-install', '--just-copy']
Running... ['/sbin/grub', '--batch', '--no-floppy', '--device-map=/boot/grub/device.map']
GNU GRUB version 0.97 (640K lower / 3072K upper memory)
[ Minimal BASH-like line editing is supported. For the first word, TAB
lists possible command completions. Anywhere else TAB lists the possible
completions of a device/filename.]
grub> root (hd0,2)
Filesystem type is ext2fs, partition type 0xfd
grub> install --stage2=/boot/grub/stage2 /grub/stage1 d (hd0) /grub/stage2 p (hd0,2)/grub/grub.conf
grub> Running... ['/sbin/grub-install', '--just-copy']
Running... ['/sbin/grub', '--batch', '--no-floppy', '--device-map=/boot/grub/device.map']
GNU GRUB version 0.97 (640K lower / 3072K upper memory)
[ Minimal BASH-like line editing is supported. For the first word, TAB
lists possible command completions. Anywhere else TAB lists the possible
completions of a device/filename.]
grub> root (hd1,1)
Filesystem type is ext2fs, partition type 0xfd
grub> install --stage2=/boot/grub/stage2 /grub/stage1 d (hd0) /grub/stage2 p (hd1,1)/grub/grub.conf
grub>
with the patch:
- boots when one second disk is removed, not when the first one is removed
(in the sense of boot order)
- log:
Running... ['/sbin/grub-install', '--just-copy']
Running... ['/sbin/grub', '--batch', '--no-floppy', '--device-map=/boot/grub/device.map']
GNU GRUB version 0.97 (640K lower / 3072K upper memory)
[ Minimal BASH-like line editing is supported. For the first word, TAB
lists possible command completions. Anywhere else TAB lists the possible
completions of a device/filename.]
grub> device (hd0) /dev/sdb
grub> root (hd0,1)
Filesystem type is ext2fs, partition type 0xfd
grub> install --stage2=/boot/grub/stage2 /grub/stage1 d (hd0) /grub/stage2 p (hd0,1)/grub/grub.conf
grub> Running... ['/sbin/grub', '--batch', '--no-floppy', '--device-map=/boot/grub/device.map']
GNU GRUB version 0.97 (640K lower / 3072K upper memory)
[ Minimal BASH-like line editing is supported. For the first word, TAB
lists possible command completions. Anywhere else TAB lists the possible
completions of a device/filename.]
grub> root (hd0,2)
Filesystem type is ext2fs, partition type 0xfd
grub> install --stage2=/boot/grub/stage2 /grub/stage1 d (hd0) /grub/stage2 p (hd0,2)/grub/grub.conf
grub>
|
|
|
|
| |
GUI (#527979)
|
|
|
|
|
| |
I hit it in the last build that I've done where the filtering was introduced
(and I have to add that I also acked the original patch).
|
|
|
|
|
|
|
|
|
|
| |
With a kickstart install, with "clearpart --label", we will end up
scanning pre-existing partitions after clearing the label. This leads
to the backtrace as seen in #527785 and #526517.
addUdevPartitionDevice() has special handling for this case, instead of
copy and pasting this, this patch modifies addUdevPartitionDevice() so
that it can be used for dmraid and multipath partitions too.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The playing around with partedPartition flags only allows us to determine
the partition table entry for certain usuages which are deemed special
by parted. For normal FS usuage, parted will default to the type for the FS
it has detected (for pre-existing partitions) or to Linux (83) for new
partitions.
This means that for example reformatting a vfat partition as ext3, or a new
partition as vfat will lead to incorrect partition type entries in the
partition table. This patch fixes this.
This patch is intended for both master and F-12.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were resetting the parted flags for re-use of existing partitions in
destroyFormat, but this assumes that the existing partition actually has
a type in the partition table matching its current formatting, this has 2
problems:
1: If the partition has a type which needs to have flags reset to become
the correct type for the new format (for example swap -> ext2), but it
is not formatted, the flags wont get reset
2: If the partition has a type which does not match the formatting (for
example type linux raid, formatting ext2), the flags won't get reset
This patch moves the resetting of the flags to the creation of the new
format, and resets all flags except for the one for the to be created
format (and boot and lba which are special).
|
|
|
|
|
|
|
| |
It used to be so, because for boot device target (/dev/mdX) we installed into
MBRs anyway. With Hans's patch 45a7048e5f56316e052e4699b5ec70aa291ddd5e we do
what we promise (install to boot device) in this case, but it is a change and
it doesn't seem to be expected as default by users.
|
| |
|
| |
|
|
|
|
|
| |
If the partition is on a DASD disk, write out the /dev/disk/by-path/...
value to the /etc/fstab file rather than a UUID= line.
|
|
|
|
|
| |
When building the device tree, if the block device is a DASD, create a
DASDDevice object rather than a DiskDevice object.
|
|
|
|
|
|
| |
The only thing I can tell is available for us from the udev db is to see
if the DEVNAME starts with 'dasd'. We'll need this for the dracut
changes for DASD later.
|
|
|
|
|
|
| |
The only existing use of deviceNameToDiskByPath() expected the basename
returned. Since the function returns the full /dev/disk/by-path/...
path, take the basename of the returned value.
|
|
|
|
|
|
|
|
|
| |
Have deviceNameToDiskByPath() return the full device path rather than
just the basename path. Have it check to see if the entry in
/dev/disk/by-path is actually a symlink, then readlink that. Otherwise
just take the basename of the entry. Also fix a problem where passing
it a full device path would not match (e.g., '/dev/dasdb1'). Take the
basename of deviceName and match that against the readlink() value.
|
| |
|
|
|
|
| |
We don't want these messages in the RPM changelog entries.
|
|
|
|
|
|
|
|
| |
block.dmraid.RaidSet keeps track of the state of the devicemaps and will
try to add / remove maps when activating / deactivating the set depending
on its internal state, shallow copying it copies this state, creating
2 copies of it, which can result in trying to bring the set up or down
twice, which causes a backtrace.
|
| |
|
|
|
|
|
| |
map() gives us a list of bool objects, filter() gives us the actual
device objects we are expecting.
|