diff options
author | Ravishankar N <ravishankar@redhat.com> | 2017-05-30 10:18:04 +0530 |
---|---|---|
committer | Jeff Darcy <jeff@pl.atyp.us> | 2017-05-30 15:34:51 +0000 |
commit | ec86167d09bcbb763e31b73fb3d688efaa5444d7 (patch) | |
tree | 6d171c06917e71c871ae6aecb778cdbbee8b7b0d /xlators/performance | |
parent | f618c7e606caaf8371aea4a02b352c987b3b1a40 (diff) | |
download | glusterfs-ec86167d09bcbb763e31b73fb3d688efaa5444d7.tar.gz glusterfs-ec86167d09bcbb763e31b73fb3d688efaa5444d7.tar.xz glusterfs-ec86167d09bcbb763e31b73fb3d688efaa5444d7.zip |
nl-cache: Remove null check validation for frame->local in lookup cbk
For nameless lookups, nl-cache does not init frame local, so the cbk
throws up messages like these flooding the logs, especially whenenver
gfid lookup on '/' is done (i.e. loc.path="/" and loc.gfid=1).
[2017-05-30 04:35:31.628443] E [nl-cache.c:201:nlc_lookup_cbk]
(-->/usr/lib64/glusterfs/3.8.4/xlator/performance/io-cache.so(+0x3d81)
[0x7f0883005d81]
-->/usr/lib64/glusterfs/3.8.4/xlator/performance/quick-read.so(+0x3127)
[0x7f0882dfb127]
-->/usr/lib64/glusterfs/3.8.4/xlator/performance/nl-cache.so(+0x4cd3)
[0x7f08829e0cd3] ) 0-distrep-nl-cache: invalid argument: local [Invalid
argument]
Fixed it.
Change-Id: I21cb44a9d2a324617e43f46fed83c9a0942d3a0b
BUG: 1456653
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: https://review.gluster.org/17417
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Poornima G <pgurusid@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Diffstat (limited to 'xlators/performance')
-rw-r--r-- | xlators/performance/nl-cache/src/nl-cache.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/xlators/performance/nl-cache/src/nl-cache.c b/xlators/performance/nl-cache/src/nl-cache.c index 8a130dc235..a72f03993a 100644 --- a/xlators/performance/nl-cache/src/nl-cache.c +++ b/xlators/performance/nl-cache/src/nl-cache.c @@ -198,7 +198,8 @@ nlc_lookup_cbk (call_frame_t *frame, void *cookie, xlator_t *this, local = frame->local; conf = this->private; - GF_VALIDATE_OR_GOTO (this->name, local, out); + if (!local) + goto out; /* Donot add to pe, this may lead to duplicate entry and * requires search before adding if list of strings */ |