diff options
| author | Ravishankar N <ravishankar@redhat.com> | 2016-06-16 10:21:53 +0530 |
|---|---|---|
| committer | gluster-ant <bugzilla-bot@gluster.org> | 2016-06-16 10:21:53 +0530 |
| commit | ca52d54167f3e77f3e7802e9fde0c6cc70676209 (patch) | |
| tree | 0c5b4c0d43542381cd02ba71fa55d1c697c448e2 /cli/src/cli-cmd-parser.c | |
| parent | dcbe97a81668d9d5552028d4c36cb5068323492e (diff) | |
cli: fix crash in arbiter keyword parsing
A negative case like `gluster volume create volname arbiter 3 /bricks{1..3}`
must not crash. 'arbiter' keyword is valid only for (3 way) replica volumes.
The .t that is added will crash and create a core *without* the fix when
run but will still pass all TESTs. Since the regression framework fails
the .t if it creates a core, we can consider it a valid test 'that
fails without the fix'.
Change-Id: Ie2d7ced66025ea3617d30f6f823b22401e6d2fde
BUG: 1346821
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/14738
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Diffstat (limited to 'cli/src/cli-cmd-parser.c')
| -rw-r--r-- | cli/src/cli-cmd-parser.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/cli/src/cli-cmd-parser.c b/cli/src/cli-cmd-parser.c index f60e5fb04a..e8c4ea7d08 100644 --- a/cli/src/cli-cmd-parser.c +++ b/cli/src/cli-cmd-parser.c @@ -628,6 +628,11 @@ cli_cmd_volume_create_parse (struct cli_state *state, const char **words, goto out; index += ret; type = GF_CLUSTER_TYPE_DISPERSE; + } else if ((strcmp (w, "arbiter") == 0)) { + cli_err ("arbiter option must be preceded by replica " + "option."); + ret = -1; + goto out; } else { GF_ASSERT (!"opword mismatch"); ret = -1; |