diff options
| author | Mohammed Azhar Padariyakam <mpadariy@redhat.com> | 2017-09-21 20:55:05 +0530 |
|---|---|---|
| committer | Niels de Vos <ndevos@redhat.com> | 2017-09-29 09:27:46 +0000 |
| commit | d01a674077f2411ecde7bd6037efbfcf6faa65ba (patch) | |
| tree | db3014570a8361e4087f067b2c681ef509674b16 | |
| parent | eebeb504578e774eef6e762326baadaab014b9ae (diff) | |
| download | glusterfs-d01a674077f2411ecde7bd6037efbfcf6faa65ba.tar.gz glusterfs-d01a674077f2411ecde7bd6037efbfcf6faa65ba.tar.xz glusterfs-d01a674077f2411ecde7bd6037efbfcf6faa65ba.zip | |
protocol/client: Coverity Fix IDENTICAL_BRANCHES in client3_3_flush_cbk
Issue : The same code is executed when the condition "ret < 0" is true
or false, because the code in the if-then branch and after the if
statement is identical.
Solution : Remove the if-condition whose output does not alter the
program flow of control
Fix : The identical branching condition was removed.
Change-Id: Iae40f068e5a03946273e1091886ba7011460fcc8
BUG: 789278
Signed-off-by: Mohammed Azhar Padariyakam <mpadariy@redhat.com>
| -rw-r--r-- | xlators/protocol/client/src/client-rpc-fops.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/xlators/protocol/client/src/client-rpc-fops.c b/xlators/protocol/client/src/client-rpc-fops.c index 973a7958b5..09756a835e 100644 --- a/xlators/protocol/client/src/client-rpc-fops.c +++ b/xlators/protocol/client/src/client-rpc-fops.c @@ -886,8 +886,7 @@ client3_3_flush_cbk (struct rpc_req *req, struct iovec *iov, int count, } ret = client_post_flush (this, &rsp, &xdata); - if (ret < 0) - goto out; + out: if (rsp.op_ret == -1) { gf_msg (this->name, fop_log_level (GF_FOP_FLUSH, |