diff options
| author | Ravishankar N <root@ravi3.(none)> | 2014-06-19 17:41:25 +0000 |
|---|---|---|
| committer | Vijay Bellur <vbellur@redhat.com> | 2014-06-23 00:48:17 -0700 |
| commit | 1e4a046828ea11cb4c7738a2a00fb715f84dc1ff (patch) | |
| tree | b60cb63e3893a402a9f2bb089573a405f3461556 | |
| parent | a6620e3840bad41b84c590116183670cb1819667 (diff) | |
| download | glusterfs-1e4a046828ea11cb4c7738a2a00fb715f84dc1ff.tar.gz glusterfs-1e4a046828ea11cb4c7738a2a00fb715f84dc1ff.tar.xz glusterfs-1e4a046828ea11cb4c7738a2a00fb715f84dc1ff.zip | |
cluster/stripe: don't treat ESTALE as failure in lookup
Problem:
In a stripe volume, symlinks are created only on the first brick via the
default_symlink() call. During gfid lookup, server sends ESTALE from the other
bricks, which is treated as error in stripe_lookup_cbk()
Fix:
Don't treat ESTALE as error in stripe_lookup_cbk()
Change-Id: Ie4ac8f0dfd3e61260161620bdc53665882e7adbd
BUG: 1111454
Signed-off-by: Ravishankar N <root@ravi3.(none)>
Reviewed-on: http://review.gluster.org/8135
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
| -rw-r--r-- | tests/bugs/bug-1111454.t | 18 | ||||
| -rw-r--r-- | xlators/cluster/stripe/src/stripe.c | 5 |
2 files changed, 21 insertions, 2 deletions
diff --git a/tests/bugs/bug-1111454.t b/tests/bugs/bug-1111454.t new file mode 100644 index 0000000000..49f080d975 --- /dev/null +++ b/tests/bugs/bug-1111454.t @@ -0,0 +1,18 @@ +#!/bin/bash + +. $(dirname $0)/../include.rc +. $(dirname $0)/../volume.rc + +#symlink resolution should succeed +cleanup; + +TEST glusterd +TEST pidof glusterd +TEST $CLI volume create $V0 stripe 2 $H0:$B0/${V0}{0,1} +TEST $CLI volume start $V0 +TEST glusterfs --volfile-id=/$V0 --volfile-server=$H0 $M0 --attribute-timeout=0 --entry-timeout=0 +TEST mkdir $M0/dir +TEST touch $M0/dir/file +TEST ln -s file $M0/dir/symlinkfile +TEST ls -lR $M0 +cleanup diff --git a/xlators/cluster/stripe/src/stripe.c b/xlators/cluster/stripe/src/stripe.c index 0ebea81684..5135eaf264 100644 --- a/xlators/cluster/stripe/src/stripe.c +++ b/xlators/cluster/stripe/src/stripe.c @@ -186,14 +186,15 @@ stripe_lookup_cbk (call_frame_t *frame, void *cookie, xlator_t *this, callcnt = --local->call_count; if (op_ret == -1) { - if (op_errno != ENOENT) + if ((op_errno != ENOENT) || (op_errno != ESTALE)) gf_log (this->name, GF_LOG_DEBUG, "%s returned error %s", prev->this->name, strerror (op_errno)); if (local->op_errno != ESTALE) local->op_errno = op_errno; - if (((op_errno != ENOENT) && (op_errno != ENOTCONN)) || + if (((op_errno != ENOENT) && (op_errno != ENOTCONN) + && (op_errno != ESTALE)) || (prev->this == FIRST_CHILD (this))) local->failed = 1; if (op_errno == ENOENT) |