diff options
| author | Barak Sason Rofman <bsasonro@redhat.com> | 2021-03-02 14:59:04 +0200 |
|---|---|---|
| committer | Xavi Hernandez <xhernandez@gmail.com> | 2021-03-05 12:58:24 +0100 |
| commit | d917bc3299f6f1b89ca61971b04c41e70bedb24b (patch) | |
| tree | e65a5f5b62c272072efc9ff0231056b2f988503e | |
| parent | 43f1a83298d068b010fca94a7f13e7cc566e1b71 (diff) | |
| download | glusterfs-d917bc3299f6f1b89ca61971b04c41e70bedb24b.tar.gz glusterfs-d917bc3299f6f1b89ca61971b04c41e70bedb24b.tar.xz glusterfs-d917bc3299f6f1b89ca61971b04c41e70bedb24b.zip | |
EC - Fixing a Coverity issue (Uninitialized lock use)
CID: 1444461
A lock is being destroyed, but in some code-flows might be used later
on, modified code-flow to make sure the destroyed lock is not being used
in all cases.
Change-Id: I9610d56d9cb8a8ab7062e9094493dba9afdd0b30
updates: #1060
Signed-off-by: Barak Sason Rofman <bsasonro@redhat.com>
| -rw-r--r-- | xlators/cluster/ec/src/ec-data.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/xlators/cluster/ec/src/ec-data.c b/xlators/cluster/ec/src/ec-data.c index 0638883354..fb0497f506 100644 --- a/xlators/cluster/ec/src/ec-data.c +++ b/xlators/cluster/ec/src/ec-data.c @@ -249,8 +249,6 @@ ec_fop_data_release(ec_fop_data_t *fop) fop->frame->local = NULL; STACK_DESTROY(fop->frame->root); - LOCK_DESTROY(&fop->lock); - if (fop->xdata != NULL) { dict_unref(fop->xdata); } @@ -280,6 +278,8 @@ ec_fop_data_release(ec_fop_data_t *fop) ec = fop->xl->private; ec_handle_last_pending_fop_completion(fop, ¬ify); ec_handle_healers_done(fop); + + LOCK_DESTROY(&fop->lock); mem_put(fop); if (notify) { ec_pending_fops_completed(ec); |