diff options
| author | Pranith Kumar K <pranith.karampuri@phonepe.com> | 2021-03-17 18:04:00 +0530 |
|---|---|---|
| committer | Xavi Hernandez <xhernandez@gmail.com> | 2021-03-19 10:19:04 +0100 |
| commit | bb0130d3df0a1f32e23eabca0bf559f4de1bbb55 (patch) | |
| tree | e765d3dac1b1e76bcbd690fd5116e405e8f9f9a4 | |
| parent | d84292de5706424e60d230f71ccfffe29ba9c48b (diff) | |
| download | glusterfs-bb0130d3df0a1f32e23eabca0bf559f4de1bbb55.tar.gz glusterfs-bb0130d3df0a1f32e23eabca0bf559f4de1bbb55.tar.xz glusterfs-bb0130d3df0a1f32e23eabca0bf559f4de1bbb55.zip | |
afr, dht: Add ramifications of disabling ensure-durability
Also moved options to NO_DOC
Change-Id: I86623f4139d156812e622a87655483c9d2491052
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
| -rw-r--r-- | xlators/cluster/afr/src/afr.c | 5 | ||||
| -rw-r--r-- | xlators/cluster/dht/src/dht-shared.c | 4 | ||||
| -rw-r--r-- | xlators/mgmt/glusterd/src/glusterd-volume-set.c | 2 |
3 files changed, 9 insertions, 2 deletions
diff --git a/xlators/cluster/afr/src/afr.c b/xlators/cluster/afr/src/afr.c index 8eccaf1711..8c49492e63 100644 --- a/xlators/cluster/afr/src/afr.c +++ b/xlators/cluster/afr/src/afr.c @@ -1184,7 +1184,10 @@ struct volume_options options[] = { .tags = {"replicate"}, .description = "Afr performs fsyncs for transactions if this " "option is on to make sure the changelogs/data is " - "written to the disk", + "written to the disk. Please note that disabling this " + "option can lead to bad data if the data couldn't be " + "synced by the brick machine's kernel, because of " + "hardware failure etc.", .default_value = "on", }, { diff --git a/xlators/cluster/dht/src/dht-shared.c b/xlators/cluster/dht/src/dht-shared.c index 4c1f17abf5..13ffe06db4 100644 --- a/xlators/cluster/dht/src/dht-shared.c +++ b/xlators/cluster/dht/src/dht-shared.c @@ -1107,7 +1107,9 @@ struct volume_options dht_options[] = { .type = GF_OPTION_TYPE_BOOL, .default_value = "on", .description = "If disabled, rebalance will not fsync files after " - "migration", + "migration. Please note that this can lead to bad data if " + "the data couldn't be synced by the brick machine's " + "kernel, because of hardware failure etc.", .op_version = {GD_OP_VERSION_10_0}, .level = OPT_STATUS_ADVANCED, .flags = OPT_FLAG_CLIENT_OPT | OPT_FLAG_SETTABLE | OPT_FLAG_DOC}, diff --git a/xlators/mgmt/glusterd/src/glusterd-volume-set.c b/xlators/mgmt/glusterd/src/glusterd-volume-set.c index f598f78725..61218fc475 100644 --- a/xlators/mgmt/glusterd/src/glusterd-volume-set.c +++ b/xlators/mgmt/glusterd/src/glusterd-volume-set.c @@ -1057,6 +1057,7 @@ struct volopt_map_entry glusterd_volopt_map[] = { {.key = "cluster.ensure-durability", .voltype = "cluster/replicate", .op_version = 3, + .type = NO_DOC, .flags = VOLOPT_FLAG_CLIENT_OPT}, {.key = "cluster.consistent-metadata", .voltype = "cluster/replicate", @@ -3106,6 +3107,7 @@ struct volopt_map_entry glusterd_volopt_map[] = { {.key = "rebalance.ensure-durability", .voltype = "cluster/distribute", + .type = NO_DOC, .op_version = GD_OP_VERSION_10_0, .flags = VOLOPT_FLAG_CLIENT_OPT}, {.key = NULL}}; |