summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAmit Shah <amit.shah@redhat.com>2009-11-26 20:17:43 +0530
committerAmit Shah <amit.shah@redhat.com>2009-11-26 20:17:43 +0530
commite4275d6f944a96324e2580ed3f045defe40c9035 (patch)
tree2ac2af979dc136d3f239e4097dccc8c244b0c628
parentf116a63eef78afec990b6d4a33fb62e745d15b4e (diff)
downloadtest-virtserial-e4275d6f944a96324e2580ed3f045defe40c9035.tar.gz
test-virtserial-e4275d6f944a96324e2580ed3f045defe40c9035.tar.xz
test-virtserial-e4275d6f944a96324e2580ed3f045defe40c9035.zip
auto-test: Fix return check for open
The return value from guest open should be >= 0, make sure we test for that instead of being = 0. Signed-off-by: Amit Shah <amit.shah@redhat.com>
-rw-r--r--auto-virtserial.c16
1 files changed, 8 insertions, 8 deletions
diff --git a/auto-virtserial.c b/auto-virtserial.c
index 90bdb04..b2664df 100644
--- a/auto-virtserial.c
+++ b/auto-virtserial.c
@@ -325,7 +325,7 @@ static int test_open(int nr)
int ret;
ret = guest_open_port(nr);
- return result(__func__, true, "open", ret, 0, 0, OP_EQ, true);
+ return result(__func__, true, "open", ret, -1, -1, OP_GT, true);
}
static int test_multiple_open(int nr)
@@ -333,7 +333,7 @@ static int test_multiple_open(int nr)
int err, ret;
ret = guest_open_port(nr);
- err = result(__func__, true, "single", ret, 0, 0, OP_EQ, false);
+ err = result(__func__, true, "single", ret, -1, -1, OP_GT, false);
if (err)
return err;
@@ -380,7 +380,7 @@ static int test_read_without_host(int nr)
int err, ret;
ret = guest_open_port(nr);
- err = result(__func__, true, "open", ret, 0, 0, OP_EQ, false);
+ err = result(__func__, true, "open", ret, -1, -1, OP_GT, false);
if (err)
return err;
@@ -398,7 +398,7 @@ static int test_blocking_read(int nr)
int err, ret;
ret = guest_open_port(nr);
- err = result(__func__, true, "open", ret, 0, 0, OP_EQ, false);
+ err = result(__func__, true, "open", ret, -1, -1, OP_GT, false);
if (err)
return err;
@@ -447,7 +447,7 @@ static int test_nonblocking_read(int nr)
int err, ret;
ret = guest_open_port(nr);
- err = result(__func__, true, "open", ret, 0, 0, OP_EQ, false);
+ err = result(__func__, true, "open", ret, -1, -1, OP_GT, false);
if (err)
return err;
@@ -535,7 +535,7 @@ static int test_guest_throttle(int nr)
/* Open guest */
ret = guest_open_port(nr);
err = result(__func__, chardevs[nr].throttled, "open",
- ret, 0, 0, OP_EQ, false);
+ ret, -1, -1, OP_GT, false);
if (err)
return err;
@@ -585,7 +585,7 @@ static int test_host_throttle(int nr)
ret = guest_open_port(nr);
err = result(__func__, chardevs[nr].throttled, "open",
- ret, 0, 0, OP_EQ, false);
+ ret, -1, -1, OP_GT, false);
if (err)
return err;
@@ -612,7 +612,7 @@ static int test_guest_caching(int nr)
ret = guest_open_port(nr);
err = result(__func__, chardevs[nr].caching, "open",
- ret, 0, 0, OP_EQ, false);
+ ret, -1, -1, OP_GT, false);
if (err)
return err;