diff options
| author | Jan Pazdziora <jpazdziora@redhat.com> | 2013-08-13 09:30:10 +0200 |
|---|---|---|
| committer | Jan Pazdziora <jpazdziora@redhat.com> | 2013-08-13 10:52:52 +0200 |
| commit | b8787968689c15fa13b6d605342a465edb00293c (patch) | |
| tree | 5518a56e091201598c0fbefa62eab695601b583a | |
| parent | 7f8642d956f365d391cd225140b622c709bd19b0 (diff) | |
| download | mod_lookup_identity-b8787968689c15fa13b6d605342a465edb00293c.tar.gz mod_lookup_identity-b8787968689c15fa13b6d605342a465edb00293c.tar.xz mod_lookup_identity-b8787968689c15fa13b6d605342a465edb00293c.zip | |
Use apr_strdup instead of the manual strcpy.
| -rw-r--r-- | mod_lookup_identity.c | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/mod_lookup_identity.c b/mod_lookup_identity.c index e39acf0..c7418d5 100644 --- a/mod_lookup_identity.c +++ b/mod_lookup_identity.c @@ -142,8 +142,7 @@ const char * set_output_gecos(cmd_parms * cmd, void * conf_void, const char * ar if (!strcmp(arg, "default")) { cfg->output_gecos = LOOKUP_IDENTITY_OUTPUT_GECOS; } else { - cfg->output_gecos = apr_palloc(cmd->pool, strlen(arg) + 1); - strcpy(cfg->output_gecos, arg); + cfg->output_gecos = apr_pstrdup(cmd->pool, arg); } } return NULL; @@ -155,8 +154,7 @@ const char * set_output_groups(cmd_parms * cmd, void * conf_void, const char * a if (!strcmp(arg, "default")) { cfg->output_groups = LOOKUP_IDENTITY_OUTPUT_GROUPS; } else { - cfg->output_groups = apr_palloc(cmd->pool, strlen(arg) + 1); - strcpy(cfg->output_groups, arg); + cfg->output_groups = apr_pstrdup(cmd->pool, arg); } } return NULL; @@ -168,8 +166,7 @@ const char * set_output_groups_separator(cmd_parms * cmd, void * conf_void, cons if (!strcmp(arg, "default")) { cfg->output_groups_sep = LOOKUP_IDENTITY_OUTPUT_GROUPS_SEP; } else { - cfg->output_groups_sep = apr_palloc(cmd->pool, strlen(arg) + 1); - strcpy(cfg->output_groups_sep, arg); + cfg->output_groups_sep = apr_pstrdup(cmd->pool, arg); } } return NULL; @@ -194,8 +191,7 @@ void * create_dir_conf(apr_pool_t * pool, char * context) { lookup_identity_config * cfg = create_common_conf(pool); if (cfg) { context = context ? context : "(no directory context)"; - cfg->context = apr_palloc(pool, strlen(context) + 1); - strcpy(cfg->context, context); + cfg->context = apr_pstrdup(pool, context); } return cfg; } |