First PyLint pass

8 files changed, 20 insertions, 3 deletions

diff --git a/kittystore/scrub.py b/kittystore/scrub.py
index caeda54..5d6dd0f 100644
--- a/kittystore/scrub.py
+++ b/kittystore/scrub.py
@@ -23,8 +23,8 @@ import binascii
 from types import IntType
 from mimetypes import guess_all_extensions
 
-from email.Utils import unquote
-from email.Charset import Charset
+from email.utils import unquote
+from email.charset import Charset
 
 from mailman.utilities.string import websafe, oneline
 # TODO: don't do translations here, the system locale has no meaning to the
diff --git a/kittystore/storm/hack_datetime.py b/kittystore/storm/hack_datetime.py
index 78df935..6fe817b 100644
--- a/kittystore/storm/hack_datetime.py
+++ b/kittystore/storm/hack_datetime.py
@@ -66,6 +66,8 @@ class DateTimeVariableHack(DateTime.variable_class):
 
 
 class DateTime(DateTime):
+    # Overwrite DateTime in Storm's locals
+    # pylint: disable-msg=E0102
     variable_class = DateTimeVariableHack
 
 
diff --git a/kittystore/storm/model.py b/kittystore/storm/model.py
index fc89e93..7b231e1 100644
--- a/kittystore/storm/model.py
+++ b/kittystore/storm/model.py
@@ -21,11 +21,18 @@ from mailman.interfaces.messages import IMessage
 from kittystore.utils import get_message_id_hash
 from .hack_datetime import DateTime
 
+# pylint: disable-msg=R0902,R0913,R0903
+# R0902: Too many instance attributes (X/7)
+# R0913: Too many arguments (X/5)
+# R0903: Too few public methods (X/2)
+
 
 __all__ = ("List", "Email", "Attachment")
 
 
 class List(object):
+    # The 'List' name is part of storm's locals
+    # pylint: disable-msg=E0102
     """
     An archived mailing-list.
 
diff --git a/kittystore/storm/schema/patch_1.py b/kittystore/storm/schema/patch_1.py
index 8497968..9cc9895 100644
--- a/kittystore/storm/schema/patch_1.py
+++ b/kittystore/storm/schema/patch_1.py
@@ -1,4 +1,7 @@
 # -*- coding: utf-8 -*-
+# pylint: disable=W0622,W0613
+# W0622: Redefining built-in 'apply'
+# W0613: Unused argument 'store'
 
 
 def apply(store):
diff --git a/kittystore/test/test_scrub.py b/kittystore/test/test_scrub.py
index 0504122..35e7d76 100644
--- a/kittystore/test/test_scrub.py
+++ b/kittystore/test/test_scrub.py
@@ -1,4 +1,7 @@
 # -*- coding: utf-8 -*-
+# pylint: disable=R0904,C0103
+# R0904: Too many public methods (X/20)
+# C0103: Invalid name "xX" (should match [a-z_][a-z0-9_]{2,30}$)
 
 import unittest
 import email
diff --git a/kittystore/test/test_storm_store.py b/kittystore/test/test_storm_store.py
index 863928b..b00d3ba 100644
--- a/kittystore/test/test_storm_store.py
+++ b/kittystore/test/test_storm_store.py
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# pylint: disable=R0904
 
 import unittest
 import email
diff --git a/kittystore/test/test_utils.py b/kittystore/test/test_utils.py
index abea07f..f52f999 100644
--- a/kittystore/test/test_utils.py
+++ b/kittystore/test/test_utils.py
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# pylint: disable=R0904
 
 import unittest
 import email
diff --git a/kittystore/utils.py b/kittystore/utils.py
index 90b9d15..4146694 100644
--- a/kittystore/utils.py
+++ b/kittystore/utils.py
@@ -20,7 +20,7 @@ import re
 from email.header import decode_header
 from datetime import datetime, tzinfo, timedelta
 from base64 import b32encode
-from hashlib import sha1
+from hashlib import sha1 # pylint: disable-msg=E0611
 
 import dateutil.parser, dateutil.tz