summaryrefslogtreecommitdiffstats
path: root/hyperkitty/views
diff options
context:
space:
mode:
authorAurélien Bompard <aurelien@bompard.org>2013-05-24 11:34:12 +0200
committerAurélien Bompard <aurelien@bompard.org>2013-05-24 12:32:52 +0200
commit127944f9c2b3d1c07324d6a5dd3bec965f1d7f0a (patch)
treef5b6982e1621181069f328fcbba5f4a2262bce9c /hyperkitty/views
parentd7960dd61479b254506fc7869144ff91f3481e9a (diff)
downloadhyperkitty-127944f9c2b3d1c07324d6a5dd3bec965f1d7f0a.tar.gz
hyperkitty-127944f9c2b3d1c07324d6a5dd3bec965f1d7f0a.tar.xz
hyperkitty-127944f9c2b3d1c07324d6a5dd3bec965f1d7f0a.zip
Cleanups
Diffstat (limited to 'hyperkitty/views')
-rw-r--r--hyperkitty/views/accounts.py3
-rw-r--r--hyperkitty/views/list.py42
-rw-r--r--hyperkitty/views/message.py3
-rw-r--r--hyperkitty/views/thread.py4
4 files changed, 4 insertions, 48 deletions
diff --git a/hyperkitty/views/accounts.py b/hyperkitty/views/accounts.py
index e35b6eb..42edd49 100644
--- a/hyperkitty/views/accounts.py
+++ b/hyperkitty/views/accounts.py
@@ -31,8 +31,7 @@ from django.contrib.auth.models import User
from django.contrib.auth.views import login as django_login_view
from django.shortcuts import render, redirect
from django.utils.http import is_safe_url
-from django.utils.translation import gettext as _
-from django.template import RequestContext, loader
+#from django.utils.translation import gettext as _
from social_auth.backends import SocialAuthBackend
from hyperkitty.models import UserProfile, Rating, Favorite, LastView
diff --git a/hyperkitty/views/list.py b/hyperkitty/views/list.py
index ef01b65..f4f75dd 100644
--- a/hyperkitty/views/list.py
+++ b/hyperkitty/views/list.py
@@ -142,7 +142,6 @@ def _thread_list(request, mlist, threads, template_name='thread_list.html', extr
if thread.date_active > last_view_obj.view_date:
thread.unread = True
- all_threads = threads
paginator = Paginator(threads, 10)
page_num = request.GET.get('page')
try:
@@ -260,46 +259,6 @@ def overview(request, mlist_fqdn=None):
return render(request, "recent_activities.html", context)
-def search(request, mlist_fqdn):
- keyword = request.GET.get('keyword')
- target = request.GET.get('target')
- page = request.GET.get('page')
- if keyword and target:
- url = reverse('search_keyword',
- kwargs={'mlist_fqdn': mlist_fqdn,
- 'target': target,
- 'keyword': keyword})
- if page:
- url += '%s/' % page
- else:
- url = reverse('search_list', kwargs={"mlist_fqdn": mlist_fqdn})
- return redirect(url)
-
-
-def search_keyword(request, mlist_fqdn, target, keyword, page=1):
- store = get_store(request)
- ## Should we remove the code below?
- ## If urls.py does it job we should never need it
- if not keyword:
- keyword = request.GET.get('keyword')
- if not target:
- target = request.GET.get('target')
- if not target:
- target = 'Subject'
- regex = '%%%s%%' % keyword
- list_name = mlist_fqdn.split('@')[0]
- if target.lower() == 'subjectcontent':
- threads = store.search_content_subject(mlist_fqdn, keyword)
- elif target.lower() == 'subject':
- threads = store.search_subject(mlist_fqdn, keyword)
- elif target.lower() == 'content':
- threads = store.search_content(mlist_fqdn, keyword)
- elif target.lower() == 'from':
- threads = store.search_sender(mlist_fqdn, keyword)
-
- return _search_results_page(request, mlist_fqdn, threads, 'Search', page)
-
-
def search_tag(request, mlist_fqdn, tag):
'''Returns threads having a particular tag'''
store = get_store(request)
@@ -320,4 +279,3 @@ def search_tag(request, mlist_fqdn, tag):
"no_results_text": "for this tag",
}
return _thread_list(request, mlist, threads, extra_context=extra_context)
-
diff --git a/hyperkitty/views/message.py b/hyperkitty/views/message.py
index 2cf2f29..1e48eba 100644
--- a/hyperkitty/views/message.py
+++ b/hyperkitty/views/message.py
@@ -35,7 +35,7 @@ from django.contrib.auth.decorators import login_required
from hyperkitty.lib import get_store, get_months, post_to_list, PostingFailed
from hyperkitty.lib.voting import set_message_votes
from hyperkitty.models import Rating
-from forms import SearchForm, ReplyForm, PostForm
+from forms import ReplyForm, PostForm
def index(request, mlist_fqdn, message_id_hash):
@@ -43,7 +43,6 @@ def index(request, mlist_fqdn, message_id_hash):
Displays a single message identified by its message_id_hash (derived from
message_id)
'''
- search_form = SearchForm(auto_id=False)
store = get_store(request)
message = store.get_message_by_hash_from_list(mlist_fqdn, message_id_hash)
if message is None:
diff --git a/hyperkitty/views/thread.py b/hyperkitty/views/thread.py
index cc4e23a..22710d7 100644
--- a/hyperkitty/views/thread.py
+++ b/hyperkitty/views/thread.py
@@ -216,8 +216,8 @@ def add_tag(request, mlist_fqdn, threadid):
# Now refresh the tag list
tags = Tag.objects.filter(threadid=threadid, list_address=mlist_fqdn)
FakeMList = namedtuple("MailingList", ["name"])
- t = loader.get_template('threads/tags.html')
- html = t.render(RequestContext(request, {
+ tpl = loader.get_template('threads/tags.html')
+ html = tpl.render(RequestContext(request, {
"tags": tags,
"mlist": FakeMList(name=mlist_fqdn)}))