summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlexander Bokovoy <abokovoy@redhat.com>2013-09-02 16:39:30 +0300
committerNalin Dahyabhai <nalin@dahyabhai.net>2013-11-15 15:13:03 -0500
commit929a68b13defe46c0f8913440ba28f0476dcbdab (patch)
tree08aaedaa3c87e0798110bdf9ca0392b9b2ce50ea
parent41b540bc76068355e076ba95e60780bd95905d77 (diff)
downloadslapi-nis-929a68b13defe46c0f8913440ba28f0476dcbdab.tar.gz
slapi-nis-929a68b13defe46c0f8913440ba28f0476dcbdab.tar.xz
slapi-nis-929a68b13defe46c0f8913440ba28f0476dcbdab.zip
Coverity#11940: do not leak memory in the pam wrapper test
-rw-r--r--tests/wrap-pam.c8
1 files changed, 5 insertions, 3 deletions
diff --git a/tests/wrap-pam.c b/tests/wrap-pam.c
index dc92287..45fa0fc 100644
--- a/tests/wrap-pam.c
+++ b/tests/wrap-pam.c
@@ -111,14 +111,16 @@ pam_start(const char *service_name, const char *user,
char buf[LINE_MAX], *p, *q;
pam_handle_t *ret;
+ if (getenv("WRAPPERS_PAM_CREDS") == NULL) {
+ return PAM_ABORT;
+ }
+
ret = calloc(1, sizeof(*ret));
if (ret == NULL) {
return PAM_BUF_ERR;
}
ret->conv = *pam_conversation;
- if (getenv("WRAPPERS_PAM_CREDS") == NULL) {
- return PAM_ABORT;
- }
+
fp = fopen(getenv("WRAPPERS_PAM_CREDS"), "r");
if (fp == NULL) {
free(ret);