summaryrefslogtreecommitdiffstats
path: root/makeapi
blob: 5f59a976699d02bbe8cac0818c7e914192a48869 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
#!/usr/bin/python
# Authors:
#   Rob Crittenden <rcritten@redhat.com>
#
# Copyright (C) 2011  Red Hat
# see file 'COPYING' for use and warranty information
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program.  If not, see <http://www.gnu.org/licenses/>.

# Test the API against a known-good API to ensure that changes aren't made
# lightly.

import sys
import os
import re
from ipalib import *
from ipalib.text import Gettext

API_FILE='API.txt'

API_FILE_DIFFERENCE = 1
API_NEW_COMMAND = 2
API_NO_FILE = 4

def parse_options():
    from optparse import OptionParser

    parser = OptionParser()
    parser.add_option("--validate", dest="validate", action="store_true",
        default=False, help="Validate the API vs the stored API")

    options, args = parser.parse_args()
    return options, args

def strip_doc(line):
    """
    Remove the doc= part from the repr() of a Parameter.
    """

    # this pattern allows up to 2 nested parentheses in doc part
    newline = re.sub(r', doc=([^(,]+)(\([^()]*(\([^()]+\)[^()]*)?\))?', '', line)

    return newline

def make_api():
    """
    Write a new API file from the current tree.
    """
    fd = open(API_FILE, 'w')
    for cmd in api.Command():
        fd.write('command: %s\n' % cmd.name)
        fd.write('args: %d,%d,%d\n' % (len(cmd.args), len(cmd.options), len(cmd.output)))
        for a in cmd.args():
            fd.write('arg: %s\n' % strip_doc(repr(a)))
        for o in cmd.options():
            fd.write('option: %s\n' % strip_doc(repr(o)))
        for o in cmd.output():
            fd.write('output: %s\n' % strip_doc(repr(o)))
    fd.close()

    return 0

def find_name(line):
    """
    Break apart a Param line and pull out the name. It would be nice if we
    could just eval() the line but we wouldn't have defined any validators
    or normalizers it may be using.
    """
    m = re.match('^[a-zA-Z0-9]+\(\'([a-z][_a-z0-9?\*\+]*)\'.*', line)
    if m:
        name = m.group(1)
    else:
        print "Couldn't find name in: %s" % line
        name = ''
    return name

def _finalize_command_validation(cmd, found_args, expected_args,
                                      found_options, expected_options,
                                      found_output, expected_output):
    passed = True
    # Check the args of the previous command.
    if len(found_args) != expected_args:
        print 'Argument count in %s of %d doesn\'t match expected: %d' % (
            cmd.name, len(found_args), expected_args)
        passed = False
    if len(found_options) != expected_options:
        print 'Options count in %s of %d doesn\'t match expected: %d' % (
            cmd.name, len(found_options), expected_options)
        passed = False
    if len(found_output) != expected_output:
        print 'Output count in %s of %d doesn\'t match expected: %d' % (
            cmd.name, len(found_output), expected_output)
        passed = False

    # Check if there is not a new arg/opt/output in previous command
    for a in cmd.args():
        if a.param_spec not in found_args:
            print 'Argument %s of command %s in ipalib, not in API file:\n%s' % (
                a.param_spec, cmd.name, strip_doc(repr(a)))
            passed = False
    for o in cmd.options():
        if o.param_spec not in found_options:
            print 'Option %s of command %s in ipalib, not in API file:\n%s' % (
                o.param_spec, cmd.name, strip_doc(repr(o)))
            passed = False
    for o in cmd.output():
        if o.name not in found_output:
            print 'Output %s of command %s in ipalib, not in API file:\n%s' % (
                o.name, cmd.name, strip_doc(repr(o)))
            passed = False

    return passed

def validate_api():
    """
    Compare the API in the file to the one in ipalib.

    Return a bitwise return code to identify the types of errors found, if
    any.
    """
    fd = open(API_FILE, 'r')
    lines = fd.readlines()
    fd.close()

    rval = 0

    expected_args = 0
    expected_options = 0
    expected_output = 0
    found_args = []
    found_options = []
    found_output = []

    # First run through the file and compare it to the API
    existing_cmds = []
    cmd = None
    for line in lines:
        line = line.strip()
        if line.startswith('command:'):
            if cmd:
                if not _finalize_command_validation(cmd, found_args, expected_args,
                                      found_options, expected_options,
                                      found_output, expected_output):
                    rval |= API_FILE_DIFFERENCE

            (arg, name) = line.split(': ', 1)
            if name not in api.Command:
                print "Command %s in API file, not in ipalib" % name
                rval |= API_FILE_DIFFERENCE
                cmd = None
            else:
                existing_cmds.append(name)
                cmd = api.Command[name]
            found_args = []
            found_options = []
            found_output = []
        if line.startswith('args:') and cmd:
            line = line.replace('args: ', '')
            (expected_args, expected_options, expected_output) = line.split(',')
            expected_args = int(expected_args)
            expected_options = int(expected_options)
            expected_output = int(expected_output)
        if line.startswith('arg:') and cmd:
            line = line.replace('arg: ', '')
            found = False
            arg = find_name(line)
            for a in cmd.args():
                if strip_doc(repr(a)) == line:
                    found = True
                else:
                    if a.name == arg:
                        found = True
                        print 'Arg in %s doesn\'t match.\nGot      %s\nExpected %s' % (
                            name, strip_doc(repr(a)), line)
                        rval |= API_FILE_DIFFERENCE
            if found:
                found_args.append(arg)
            else:
                arg = find_name(line)
                print "Argument '%s' in command '%s' in API file not found" % (arg, name)
                rval |= API_FILE_DIFFERENCE
        if line.startswith('option:') and cmd:
            line = line.replace('option: ', '')
            found = False
            option = find_name(line)
            for o in cmd.options():
                if strip_doc(repr(o)) == line:
                    found = True
                else:
                    if o.name == option:
                        found = True
                        print 'Option in %s doesn\'t match. Got %s Expected %s' % (name, o, line)
                        rval |= API_FILE_DIFFERENCE
            if found:
                found_options.append(option)
            else:
                option = find_name(line)
                print "Option '%s' in command '%s' in API file not found" % (option, name)
                rval |= API_FILE_DIFFERENCE
        if line.startswith('output:') and cmd:
            line = line.replace('output: ', '')
            found = False
            output = find_name(line)
            for o in cmd.output():
                if strip_doc(repr(o)) == line:
                    found = True
                else:
                    if o.name == output:
                        found = True
                        print 'Output in %s doesn\'t match. Got %s Expected %s' % (name, o, line)
                        rval |= API_FILE_DIFFERENCE
            if found:
                found_output.append(output)
            else:
                output = find_name(line)
                print "Option '%s' in command '%s' in API file not found" % (output, name)
                rval |= API_FILE_DIFFERENCE

    if cmd:
        if not _finalize_command_validation(cmd, found_args, expected_args,
                              found_options, expected_options,
                              found_output, expected_output):
            rval |= API_FILE_DIFFERENCE

    # Now look for new commands not in the current API
    for cmd in api.Command():
        if cmd.name not in existing_cmds:
            print "Command %s in ipalib, not in API" % cmd.name
            rval |= API_NEW_COMMAND

    return rval

def main():
    options, args = parse_options()

    cfg = dict(
        context='cli',
        in_server=False,
        debug=False,
        verbose=0,
        validate_api=True,
        enable_ra=True,
        mode='developer',
    )

    api.bootstrap(**cfg)
    api.finalize()

    if options.validate:
        if not os.path.exists(API_FILE):
            print 'No %s to validate' % API_FILE
            rval = API_NO_FILE
        else:
            rval = validate_api()
    else:
        print "Writing API to API.txt"
        rval = make_api()

    if rval & API_FILE_DIFFERENCE:
        print ''
        print 'There are one or more changes to the API.\nEither undo the API changes or update API.txt and increment the major version in VERSION.'

    if rval & API_NEW_COMMAND:
        print ''
        print 'There are one or more new commands defined.\nUpdate API.txt and increment the minor version in VERSION.'

    return rval

sys.exit(main())