diff options
author | Adam Misnyovszki <amisnyov@redhat.com> | 2014-04-23 17:41:45 +0200 |
---|---|---|
committer | Petr Vobornik <pvoborni@redhat.com> | 2014-04-29 14:49:51 +0200 |
commit | 6aeb138e46044f6d2f124dfc3988391cf4906242 (patch) | |
tree | 0651977e9a959aa3eac16aa0d152905ea6dc6554 | |
parent | 5d832c342608fd567ea258c1d506cae28f6b0abf (diff) | |
download | freeipa-6aeb138e46044f6d2f124dfc3988391cf4906242.tar.gz freeipa-6aeb138e46044f6d2f124dfc3988391cf4906242.tar.xz freeipa-6aeb138e46044f6d2f124dfc3988391cf4906242.zip |
webui: select all checkbox remains selected after operation
The select all checkbox remained selected after bulk
operation. This patch fixes it, after any bulk modify
or delete operation, unselect_all function is called.
https://fedorahosted.org/freeipa/ticket/4245
Reviewed-By: Petr Vobornik <pvoborni@redhat.com>
-rw-r--r-- | install/ui/src/freeipa/association.js | 2 | ||||
-rw-r--r-- | install/ui/src/freeipa/dialog.js | 6 | ||||
-rw-r--r-- | install/ui/src/freeipa/search.js | 2 |
3 files changed, 9 insertions, 1 deletions
diff --git a/install/ui/src/freeipa/association.js b/install/ui/src/freeipa/association.js index bf11de005..aee95f184 100644 --- a/install/ui/src/freeipa/association.js +++ b/install/ui/src/freeipa/association.js @@ -1203,6 +1203,7 @@ exp.association_facet = IPA.association_facet = function (spec, no_init) { method: that.remove_method, on_success: function(data) { that.refresh(); + that.table.unselect_all(); var succeeded = IPA.get_succeeded(data); var msg = text.get('@i18n:association.removed').replace('${count}', succeeded); @@ -1473,6 +1474,7 @@ exp.attribute_facet = IPA.attribute_facet = function(spec, no_init) { function(data) { that.load(data); that.show_content(); + that.table.unselect_all(); var succeeded = IPA.get_succeeded(data); var msg = text.get('@i18n:association.removed').replace('${count}', succeeded); diff --git a/install/ui/src/freeipa/dialog.js b/install/ui/src/freeipa/dialog.js index 4c6c37f88..6fdfbc62d 100644 --- a/install/ui/src/freeipa/dialog.js +++ b/install/ui/src/freeipa/dialog.js @@ -885,6 +885,8 @@ IPA.adder_dialog = function(spec) { that.add = function() { var rows = that.available_table.remove_selected_rows(); that.selected_table.add_rows(rows); + that.available_table.unselect_all(); + that.selected_table.unselect_all(); }; /** @@ -893,6 +895,8 @@ IPA.adder_dialog = function(spec) { that.remove = function() { var rows = that.selected_table.remove_selected_rows(); that.available_table.add_rows(rows); + that.available_table.unselect_all(); + that.selected_table.unselect_all(); }; /** @@ -1357,4 +1361,4 @@ dialog_builder.factory = IPA.dialog; reg.set('dialog', dialog_builder.registry); return {}; -});
\ No newline at end of file +}); diff --git a/install/ui/src/freeipa/search.js b/install/ui/src/freeipa/search.js index 9400b6aec..8701c33c3 100644 --- a/install/ui/src/freeipa/search.js +++ b/install/ui/src/freeipa/search.js @@ -353,6 +353,7 @@ IPA.search_deleter_dialog = function(spec) { batch.on_success = function(data, text_status, xhr) { that.facet.refresh(); that.facet.on_update.notify([],that.facet); + that.facet.table.unselect_all(); var succeeded = batch.commands.length - batch.errors.errors.length; var msg = text.get('@i18n:search.deleted').replace('${count}', succeeded); IPA.notify_success(msg); @@ -505,6 +506,7 @@ IPA.batch_items_action = function(spec) { that.on_success = function(facet, data, text_status, xhr) { facet.on_update.notify(); facet.refresh(); + facet.table.unselect_all(); if (that.success_msg) { var succeeded = that.batch.commands.length - that.batch.errors.errors.length; |