summaryrefslogtreecommitdiffstats
path: root/common
diff options
context:
space:
mode:
authorAlexandru Gagniuc <mr.nuke.me@gmail.com>2021-05-24 14:28:56 -0500
committerHeinrich Schuchardt <xypron.glpk@gmx.de>2021-05-28 16:17:01 +0200
commitec0512b173bfe45bc6dc03dfcff40fec419239bb (patch)
treef9c235916c76879cb052cf85749a76425d63ef7d /common
parent38de680e582b36d4605b05d3b2c67a3c0c458bfb (diff)
downloadu-boot-ec0512b173bfe45bc6dc03dfcff40fec419239bb.tar.gz
u-boot-ec0512b173bfe45bc6dc03dfcff40fec419239bb.tar.xz
u-boot-ec0512b173bfe45bc6dc03dfcff40fec419239bb.zip
Revert "lib: introduce HASH_CALCULATE option"
When we think of Kconfig, we usually think of features that we like to enable or not. Ideally, we wouldn't use Kconfig to fix a build issue, although sometimes it might make sense. With Kconfig it's hard to guarantee that the fix is universal. We can only say that it works for the set of tested configurations. In the majority of cases, it's preferable to let the linker figure things out for us. The reverted commit attempted to fix a build issue by adding an invisible Kconfig option. This is wrong in several ways: It invents a new Kconfig variable when CONFIG_HASH already exists for the same purpose. Second, hash-checksum.c makes use of the hash_progressive_lookup_algo() symbol, which is only provided with CONFIG_HASH, but this dependency was not expressed in the reverted patch. It feels like Kconfig is turning into a listing of all available source files, and a buffet to 'select' which ones to compile. The purpose of this revert is to enable the next change to make use of CONFIG_HASH instead of adding to Kconfig. This reverts commit 87316da05f2fd49d3709275e64ef0c5980366ade. Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com> Acked-by: Masahisa Kojima <masahisa.kojima@linaro.org>
Diffstat (limited to 'common')
-rw-r--r--common/Kconfig.boot1
1 files changed, 0 insertions, 1 deletions
diff --git a/common/Kconfig.boot b/common/Kconfig.boot
index 3c6e77d099..89a3161f1f 100644
--- a/common/Kconfig.boot
+++ b/common/Kconfig.boot
@@ -80,7 +80,6 @@ config FIT_SIGNATURE
select RSA_VERIFY
select IMAGE_SIGN_INFO
select FIT_FULL_CHECK
- select HASH_CALCULATE
help
This option enables signature verification of FIT uImages,
using a hash signed and verified using RSA. If