+ exec + rm -rf /rpmbuild + mkdir -p /rpmbuild + su -c 'rpmbuild -ba /builddir/build/SPECS/simh.spec --define "debug_package %{nil}" --undefine _annotated_build --define "_missing_doc_files_terminate_build %{nil}" --define "_emacs_sitestartdir /usr/share/emacs/site-lisp/site-start.d" --define "_emacs_sitelispdir /usr/share/emacs/site-lisp" --nocheck ' mockbuild Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.Dd2YS1 + umask 022 + cd /builddir/build/BUILD + cd /builddir/build/BUILD + rm -rf simh-3.9.0 + /usr/bin/gzip -dc /builddir/build/SOURCES/simh-3.9.0-noroms.tar.gz + /usr/bin/tar -xof - + STATUS=0 + '[' 0 -ne 0 ']' + cd simh-3.9.0 + /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w . + exit 0 Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.rysOo7 + umask 022 + cd /builddir/build/BUILD + cd simh-3.9.0 + mkdir -p BIN + make -j4 -e 'ROMS_OPT=-O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 ' USE_NETWORK=1 lib paths are: /lib/ /lib64/lp64d/ /usr/lib64//bind9-export/ using libm: /lib64/lp64d//libm.so using librt: /lib64/lp64d//librt.so using libpthread: /lib64/lp64d//libpthread.so /usr/include/pthread.h using libdl: /lib64/lp64d//libdl.so /usr/include/dlfcn.h using libpcap: /lib64/lp64d//libpcap.so /usr/include/pcap.h *** *** all Simulators being built with: *** - compiler optimizations and no debugging support. GCC Version: 7.3.1. *** - static networking support using Linux provided libpcap components. *** gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 PDP1/pdp1_lp.c PDP1/pdp1_cpu.c PDP1/pdp1_stddev.c PDP1/pdp1_sys.c PDP1/pdp1_dt.c PDP1/pdp1_drm.c PDP1/pdp1_clk.c PDP1/pdp1_dcs.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I PDP1 -o BIN/pdp1 -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 PDP18B/pdp18b_dt.c PDP18B/pdp18b_drm.c PDP18B/pdp18b_cpu.c PDP18B/pdp18b_lp.c PDP18B/pdp18b_mt.c PDP18B/pdp18b_rf.c PDP18B/pdp18b_rp.c PDP18B/pdp18b_stddev.c PDP18B/pdp18b_sys.c PDP18B/pdp18b_rb.c PDP18B/pdp18b_tt1.c PDP18B/pdp18b_fpp.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -DPDP4 -I PDP18B -o BIN/pdp4 -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 PDP18B/pdp18b_dt.c PDP18B/pdp18b_drm.c PDP18B/pdp18b_cpu.c PDP18B/pdp18b_lp.c PDP18B/pdp18b_mt.c PDP18B/pdp18b_rf.c PDP18B/pdp18b_rp.c PDP18B/pdp18b_stddev.c PDP18B/pdp18b_sys.c PDP18B/pdp18b_rb.c PDP18B/pdp18b_tt1.c PDP18B/pdp18b_fpp.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -DPDP7 -I PDP18B -o BIN/pdp7 -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 PDP8/pdp8_cpu.c PDP8/pdp8_clk.c PDP8/pdp8_df.c PDP8/pdp8_dt.c PDP8/pdp8_lp.c PDP8/pdp8_mt.c PDP8/pdp8_pt.c PDP8/pdp8_rf.c PDP8/pdp8_rk.c PDP8/pdp8_rx.c PDP8/pdp8_sys.c PDP8/pdp8_tt.c PDP8/pdp8_ttx.c PDP8/pdp8_rl.c PDP8/pdp8_tsc.c PDP8/pdp8_td.c PDP8/pdp8_ct.c PDP8/pdp8_fpp.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I PDP8 -o BIN/pdp8 -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program PDP8/pdp8_cpu.c: In function 'sim_instr': PDP8/pdp8_cpu.c:347:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = sim_process_event ()) ^~~~~~ PDP18B/pdp18b_dt.c: In function 'dt_svc': PDP18B/pdp18b_dt.c:1150:57: warning: "/*" within comment [-Wcomment] /* /* ignore hdr */ PDP18B/pdp18b_dt.c: In function 'dt_svc': PDP18B/pdp18b_dt.c:1150:57: warning: "/*" within comment [-Wcomment] /* /* ignore hdr */ PDP1/pdp1_cpu.c: In function 'sim_instr': PDP1/pdp1_cpu.c:549:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = sim_process_event ()) ^~~~~~ PDP1/pdp1_cpu.c:613:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Ea (IR)) /* MA <- eff addr */ ^~~~~~ PDP1/pdp1_cpu.c:615:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Read ()) /* MB <- data */ ^~~~~~ PDP1/pdp1_cpu.c:621:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Ea (IR)) /* MA <- eff addr */ ^~~~~~ PDP1/pdp1_cpu.c:623:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Read ()) /* MB <- data */ ^~~~~~ PDP1/pdp1_cpu.c:629:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Ea (IR)) /* MA <- eff addr */ ^~~~~~ PDP1/pdp1_cpu.c:631:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Read ()) /* MB <- data */ ^~~~~~ PDP1/pdp1_cpu.c:641:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Ea (IR)) /* MA <- eff addr */ ^~~~~~ PDP1/pdp1_cpu.c:643:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Read ()) /* MB <- data */ ^~~~~~ PDP1/pdp1_cpu.c:651:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Ea_ch (IR, &byno)) /* MA <- eff addr */ ^~~~~~ PDP1/pdp1_cpu.c:653:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Read ()) /* MB <- data */ ^~~~~~ PDP1/pdp1_cpu.c:662:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Ea_ch (IR, &byno)) /* MA <- eff addr */ ^~~~~~ PDP1/pdp1_cpu.c:664:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Read ()) /* MB <- data */ ^~~~~~ PDP1/pdp1_cpu.c:686:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Ea (IR)) /* MA <- eff addr */ ^~~~~~ PDP1/pdp1_cpu.c:688:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Read ()) /* MB <- data */ ^~~~~~ PDP1/pdp1_cpu.c:694:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Ea (IR)) /* MA <- eff addr */ ^~~~~~ PDP1/pdp1_cpu.c:696:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Read ()) /* MB <- data */ ^~~~~~ PDP1/pdp1_cpu.c:702:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Ea (IR)) /* MA <- eff addr */ ^~~~~~ PDP1/pdp1_cpu.c:709:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Ea (IR)) /* MA <- eff addr */ ^~~~~~ PDP1/pdp1_cpu.c:711:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Read ()) /* MB <- data */ ^~~~~~ PDP1/pdp1_cpu.c:718:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Ea (IR)) /* MA <- eff addr */ ^~~~~~ PDP1/pdp1_cpu.c:720:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Read ()) /* MB <- data */ ^~~~~~ PDP1/pdp1_cpu.c:727:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Ea (IR)) /* MA <- eff addr */ ^~~~~~ PDP1/pdp1_cpu.c:734:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Ea (IR)) /* MA <- eff addr */ ^~~~~~ PDP1/pdp1_cpu.c:758:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Ea (IR)) /* MA <- eff addr */ ^~~~~~ PDP1/pdp1_cpu.c:760:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Read ()) /* MB <- data */ ^~~~~~ PDP1/pdp1_cpu.c:772:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Ea (IR)) /* MA <- eff addr */ ^~~~~~ PDP1/pdp1_cpu.c:774:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Read ()) /* MB <- data */ ^~~~~~ PDP1/pdp1_cpu.c:787:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Ea (IR)) /* MA <- eff addr */ ^~~~~~ PDP1/pdp1_cpu.c:789:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Read ()) /* MB <- data */ ^~~~~~ PDP1/pdp1_cpu.c:801:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Ea (IR)) /* MA <- eff addr */ ^~~~~~ PDP1/pdp1_cpu.c:803:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Read ()) /* MB <- data */ ^~~~~~ PDP1/pdp1_cpu.c:813:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Ea (IR)) /* MA <- eff addr */ ^~~~~~ PDP1/pdp1_cpu.c:815:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Read ()) /* MB <- data */ ^~~~~~ PDP1/pdp1_cpu.c:827:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Ea (IR)) /* MA <- eff addr */ ^~~~~~ PDP1/pdp1_cpu.c:829:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Read ()) /* MB <- data */ ^~~~~~ PDP1/pdp1_cpu.c:836:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Ea (IR)) /* MA <- eff addr */ ^~~~~~ PDP1/pdp1_cpu.c:838:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Read ()) /* MB <- data */ ^~~~~~ PDP1/pdp1_cpu.c:866:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Ea (IR)) /* MA <- eff addr */ ^~~~~~ PDP1/pdp1_cpu.c:874:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Ea (IR)) /* MA <- eff addr */ ^~~~~~ PDP1/pdp1_cpu.c:892:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Ea (IR)) /* MA <- eff addr */ ^~~~~~ PDP1/pdp1_cpu.c:894:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Read ()) /* MB <- data */ ^~~~~~ PDP1/pdp1_cpu.c:922:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Ea (IR)) /* MA <- eff addr */ ^~~~~~ PDP1/pdp1_cpu.c:924:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Read ()) /* MB <- data */ ^~~~~~ PDP1/pdp1_cpu.c: In function 'Ea': PDP1/pdp1_cpu.c:1365:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Read ()) /* read; err? */ ^ PDP1/pdp1_cpu.c:1371:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Read ()) /* get ind word */ ^ PDP1/pdp1_cpu.c: In function 'Ea_ch': PDP1/pdp1_cpu.c:1395:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Read ()) /* read; err? */ ^ PDP1/pdp1_cpu.c:1400:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Read ()) /* get ind word */ ^ PDP18B/pdp18b_cpu.c: In function 'sim_instr': PDP18B/pdp18b_cpu.c:607:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = sim_process_event ()) ^~~~~~ PDP18B/pdp18b_cpu.c: In function 'sim_instr': PDP18B/pdp18b_cpu.c:607:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = sim_process_event ()) ^~~~~~ PDP18B/pdp18b_cpu.c:582:7: warning: variable 'api_int' set but not used [-Wunused-but-set-variable] int32 api_int, api_usmd, skp; ^~~~~~~ PDP18B/pdp18b_cpu.c:582:7: warning: variable 'api_int' set but not used [-Wunused-but-set-variable] int32 api_int, api_usmd, skp; ^~~~~~~ At top level: PDP18B/pdp18b_cpu.c:443:20: warning: 'api_vec' defined but not used [-Wunused-const-variable=] static const int32 api_vec[API_HLVL][32] = { ^~~~~~~ At top level: PDP18B/pdp18b_cpu.c:443:20: warning: 'api_vec' defined but not used [-Wunused-const-variable=] static const int32 api_vec[API_HLVL][32] = { ^~~~~~~ PDP8/pdp8_dt.c: In function 'dt_svc': PDP8/pdp8_dt.c:967:57: warning: "/*" within comment [-Wcomment] /* /* ignore hdr */ PDP8/pdp8_dt.c:971:13: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (((dtsa & DTA_MODE) == 0) || (M[DT_WC] == 0)) ^~ PDP8/pdp8_dt.c:973:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' break; ^~~~~ PDP1/pdp1_sys.c: In function 'parse_sym': PDP1/pdp1_sys.c:443:37: warning: array subscript has type 'char' [-Wchar-subscripts] #define ASCTOSIX(x) (ascii_to_fiodec[x] & 077) ^ PDP1/pdp1_sys.c:598:16: note: in expansion of macro 'ASCTOSIX' val[0] = ((ASCTOSIX (cptr[0]) & 077) << 12) | ^~~~~~~~ PDP1/pdp1_sys.c:443:37: warning: array subscript has type 'char' [-Wchar-subscripts] #define ASCTOSIX(x) (ascii_to_fiodec[x] & 077) ^ PDP1/pdp1_sys.c:599:16: note: in expansion of macro 'ASCTOSIX' ((ASCTOSIX (cptr[1]) & 077) << 6) | ^~~~~~~~ PDP1/pdp1_sys.c:443:37: warning: array subscript has type 'char' [-Wchar-subscripts] #define ASCTOSIX(x) (ascii_to_fiodec[x] & 077) ^ PDP1/pdp1_sys.c:600:16: note: in expansion of macro 'ASCTOSIX' (ASCTOSIX (cptr[2]) & 077); ^~~~~~~~ PDP18B/pdp18b_mt.c: In function 'mt_svc': PDP18B/pdp18b_mt.c:356:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrrecf (uptr, mtxb, tbc)) /* write rec, err? */ ^~ PDP18B/pdp18b_mt.c:366:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ ^~ PDP18B/pdp18b_mt.c:375:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ ^~ PDP18B/pdp18b_mt.c:385:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ ^~ PDP18B/pdp18b_mt.c: In function 'mt_svc': PDP18B/pdp18b_mt.c:356:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrrecf (uptr, mtxb, tbc)) /* write rec, err? */ ^~ PDP18B/pdp18b_mt.c:366:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ ^~ PDP18B/pdp18b_mt.c:375:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ ^~ PDP18B/pdp18b_mt.c:385:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ ^~ PDP8/pdp8_mt.c:123:57: warning: "/*" within comment [-Wcomment] /* #define STA_BAD 00020 /* bad tape?? */ PDP8/pdp8_mt.c: In function 'mt_svc': PDP8/pdp8_mt.c:456:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrrecf (uptr, mtxb, tbc)) { /* write rec, err? */ ^~ PDP8/pdp8_mt.c:464:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ ^~ PDP8/pdp8_mt.c:471:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ ^~ PDP8/pdp8_mt.c:481:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ ^~ PDP18B/pdp18b_stddev.c: In function 'ptr_svc': PDP18B/pdp18b_stddev.c:597:16: warning: suggest parentheses around assignment used as truth value [-Wparentheses] while (temp = temp & (temp - 1)) ^~~~ PDP18B/pdp18b_stddev.c: In function 'tti': PDP18B/pdp18b_stddev.c:997:30: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] dat = dat | tti_unit.buf & TTI_MASK; /* return buffer */ ^ PDP18B/pdp18b_stddev.c: In function 'ptr_svc': PDP18B/pdp18b_stddev.c:597:16: warning: suggest parentheses around assignment used as truth value [-Wparentheses] while (temp = temp & (temp - 1)) ^~~~ PDP18B/pdp18b_stddev.c: In function 'tti': PDP18B/pdp18b_stddev.c:997:30: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] dat = dat | tti_unit.buf & TTI_MASK; /* return buffer */ ^ PDP1/pdp1_dcs.c: In function 'dcsi_svc': PDP1/pdp1_dcs.c:254:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (c = tmxr_getc_ln (&dcs_ldsc[ln])) { /* get char */ ^ PDP18B/pdp18b_sys.c: In function 'fprint_sym': PDP18B/pdp18b_sys.c:1012:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sp = (inst & 03730)) ^~ In file included from scp.c:189:0: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] /* V3.8 revision history sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] /* V3.7 revision history sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] /* V3.6 revision history sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] /* V3.5 revision history sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] /* V3.4 revision history sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] /* V3.3 revision history sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] /* V3.2 revision history sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] /* V3.1 revision history sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] /* V3.0 revision history sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] /* V2.10 revision history sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] /* V2.9 revision history PDP18B/pdp18b_sys.c: In function 'fprint_sym': PDP18B/pdp18b_sys.c:1012:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sp = (inst & 03730)) ^~ scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (np = match_ext (nbuf, "EXE")) /* remove .exe */ ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) /* lookup command */ ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { /* lookup command */ ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (shtb, gbuf)) /* global match? */ ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (aptr = strchr (cptr, ';')) { /* ;action? */ ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (portp = strchr (gbuf, ':')) /* x:y? split */ ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (cptr)) { /* exact match? */ ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sptr = strchr (logstr, c)) { /* check for mask */ ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ ^~ PDP18B/pdp18b_tt1.c: In function 'ttix_svc': PDP18B/pdp18b_tt1.c:225:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (temp = tmxr_getc_ln (&ttx_ldsc[ln])) { /* get char */ ^~~~ PDP18B/pdp18b_tt1.c: In function 'ttix_svc': PDP18B/pdp18b_tt1.c:225:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (temp = tmxr_getc_ln (&ttx_ldsc[ln])) { /* get char */ ^~~~ PDP18B/pdp18b_fpp.c: In function 'fp15': PDP18B/pdp18b_fpp.c:256:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ ^~~ PDP18B/pdp18b_fpp.c:265:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ ^~~ PDP18B/pdp18b_fpp.c:273:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ ^~~ PDP18B/pdp18b_fpp.c:281:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ ^~~ PDP18B/pdp18b_fpp.c:283:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fmb)) break; /* fetch op to FMB */ ^~~ PDP18B/pdp18b_fpp.c:291:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ ^~~ PDP18B/pdp18b_fpp.c:299:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ ^~~ PDP18B/pdp18b_fpp.c:312:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ ^~~ PDP18B/pdp18b_fpp.c:320:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ ^~~ PDP18B/pdp18b_fpp.c:326:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ ^~~ PDP18B/pdp18b_fpp.c:340:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = Read (ar, &dat, RD)) ^~~ PDP18B/pdp18b_fpp.c:348:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ ^~~ PDP18B/pdp18b_fpp.c: In function 'fp15_store': PDP18B/pdp18b_fpp.c:432:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_norm (ir, a, NULL, 0)) /* normalize */ ^~~ PDP8/pdp8_ttx.c: In function 'ttix_svc': PDP8/pdp8_ttx.c:236:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (temp = tmxr_getc_ln (&ttx_ldsc[ln])) { /* get char */ ^~~~ PDP18B/pdp18b_fpp.c: In function 'fp15': PDP18B/pdp18b_fpp.c:256:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ ^~~ PDP18B/pdp18b_fpp.c:265:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ ^~~ PDP18B/pdp18b_fpp.c:273:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ ^~~ PDP18B/pdp18b_fpp.c:281:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ ^~~ PDP18B/pdp18b_fpp.c:283:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fmb)) break; /* fetch op to FMB */ ^~~ PDP18B/pdp18b_fpp.c:291:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ ^~~ PDP18B/pdp18b_fpp.c:299:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ ^~~ PDP18B/pdp18b_fpp.c:312:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ ^~~ PDP18B/pdp18b_fpp.c:320:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ ^~~ PDP18B/pdp18b_fpp.c:326:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ ^~~ PDP18B/pdp18b_fpp.c:340:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = Read (ar, &dat, RD)) ^~~ PDP18B/pdp18b_fpp.c:348:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ ^~~ PDP18B/pdp18b_fpp.c: In function 'fp15_store': PDP18B/pdp18b_fpp.c:432:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_norm (ir, a, NULL, 0)) /* normalize */ ^~~ In file included from scp.c:189:0: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] /* V3.8 revision history sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] /* V3.7 revision history sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] /* V3.6 revision history sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] /* V3.5 revision history sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] /* V3.4 revision history sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] /* V3.3 revision history sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] /* V3.2 revision history sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] /* V3.1 revision history sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] /* V3.0 revision history sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] /* V2.10 revision history sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] /* V2.9 revision history sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_con_tab, gbuf)) ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ ^ scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (np = match_ext (nbuf, "EXE")) /* remove .exe */ ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) /* lookup command */ ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { /* lookup command */ ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (shtb, gbuf)) /* global match? */ ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (aptr = strchr (cptr, ';')) { /* ;action? */ ^~~~ In file included from scp.c:189:0: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] /* V3.8 revision history sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] /* V3.7 revision history sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] /* V3.6 revision history sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] /* V3.5 revision history sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] /* V3.4 revision history sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] /* V3.3 revision history sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] /* V3.2 revision history sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] /* V3.1 revision history sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] /* V3.0 revision history sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] /* V2.10 revision history sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] /* V2.9 revision history scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (np = match_ext (nbuf, "EXE")) /* remove .exe */ ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) /* lookup command */ ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { /* lookup command */ ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (portp = strchr (gbuf, ':')) /* x:y? split */ ^~~~~ scp.c: In function 'show_cmd_fi': scp.c: In function 'find_unit': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (cptr)) { /* exact match? */ ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (shtb, gbuf)) /* global match? */ ^~~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sptr = strchr (logstr, c)) { /* check for mask */ ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ ^~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (aptr = strchr (cptr, ';')) { /* ;action? */ ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ ^~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (portp = strchr (gbuf, ':')) /* x:y? split */ ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (cptr)) { /* exact match? */ ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sptr = strchr (logstr, c)) { /* check for mask */ ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ ^~ PDP8/pdp8_ct.c: In function 'ct70': PDP8/pdp8_ct.c:273:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = ct_busy ()) /* op in progress? */ ^~~~ PDP8/pdp8_ct.c: In function 'ct_svc': PDP8/pdp8_ct.c:436:16: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrrecf (uptr, ct_xb, ct_bptr)) /* write, err? */ ^~ PDP8/pdp8_ct.c:455:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ ^~ PDP8/pdp8_ct.c:465:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_sprecr (uptr, &tbc)) /* space rev, err? */ ^~ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_con_tab, gbuf)) ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ ^ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (lp->conn == 0) /* skip if !conn */ ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ ^~~~~~ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_con_tab, gbuf)) ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ ^ In file included from scp.c:189:0: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] /* V3.8 revision history sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] /* V3.7 revision history sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] /* V3.6 revision history sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] /* V3.5 revision history sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] /* V3.4 revision history sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] /* V3.3 revision history sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] /* V3.2 revision history sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] /* V3.1 revision history sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] /* V3.0 revision history sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] /* V2.10 revision history sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] /* V2.9 revision history scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (np = match_ext (nbuf, "EXE")) /* remove .exe */ ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) /* lookup command */ ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { /* lookup command */ ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (shtb, gbuf)) /* global match? */ ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (aptr = strchr (cptr, ';')) { /* ;action? */ ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (portp = strchr (gbuf, ':')) /* x:y? split */ ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (cptr)) { /* exact match? */ ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sptr = strchr (logstr, c)) { /* check for mask */ ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ ^~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ ^~ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (lp->conn == 0) /* skip if !conn */ ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ ^~~~~~ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_con_tab, gbuf)) ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ ^ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (lp->conn == 0) /* skip if !conn */ ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ ^~~~~~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ ^~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ ^~ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (lp->conn == 0) /* skip if !conn */ ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ ^~~~~~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ ^~ gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 PDP18B/pdp18b_dt.c PDP18B/pdp18b_drm.c PDP18B/pdp18b_cpu.c PDP18B/pdp18b_lp.c PDP18B/pdp18b_mt.c PDP18B/pdp18b_rf.c PDP18B/pdp18b_rp.c PDP18B/pdp18b_stddev.c PDP18B/pdp18b_sys.c PDP18B/pdp18b_rb.c PDP18B/pdp18b_tt1.c PDP18B/pdp18b_fpp.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -DPDP9 -I PDP18B -o BIN/pdp9 -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program PDP18B/pdp18b_dt.c: In function 'dt_svc': PDP18B/pdp18b_dt.c:1150:57: warning: "/*" within comment [-Wcomment] /* /* ignore hdr */ At top level: PDP18B/pdp18b_dt.c:342:20: warning: 'map_unit' defined but not used [-Wunused-const-variable=] static const int32 map_unit[16] = { /* Type 550 unit map */ ^~~~~~~~ gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 PDP18B/pdp18b_dt.c PDP18B/pdp18b_drm.c PDP18B/pdp18b_cpu.c PDP18B/pdp18b_lp.c PDP18B/pdp18b_mt.c PDP18B/pdp18b_rf.c PDP18B/pdp18b_rp.c PDP18B/pdp18b_stddev.c PDP18B/pdp18b_sys.c PDP18B/pdp18b_rb.c PDP18B/pdp18b_tt1.c PDP18B/pdp18b_fpp.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -DPDP15 -I PDP18B -o BIN/pdp15 -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 PDP11/pdp11_fp.c PDP11/pdp11_cpu.c PDP11/pdp11_dz.c PDP11/pdp11_cis.c PDP11/pdp11_lp.c PDP11/pdp11_rk.c PDP11/pdp11_rl.c PDP11/pdp11_rp.c PDP11/pdp11_rx.c PDP11/pdp11_stddev.c PDP11/pdp11_sys.c PDP11/pdp11_tc.c PDP11/pdp11_tm.c PDP11/pdp11_ts.c PDP11/pdp11_io.c PDP11/pdp11_rq.c PDP11/pdp11_tq.c PDP11/pdp11_pclk.c PDP11/pdp11_ry.c PDP11/pdp11_pt.c PDP11/pdp11_hk.c PDP11/pdp11_xq.c PDP11/pdp11_xu.c PDP11/pdp11_vh.c PDP11/pdp11_rh.c PDP11/pdp11_tu.c PDP11/pdp11_cpumod.c PDP11/pdp11_cr.c PDP11/pdp11_rf.c PDP11/pdp11_dl.c PDP11/pdp11_ta.c PDP11/pdp11_rc.c PDP11/pdp11_kg.c PDP11/pdp11_ke.c PDP11/pdp11_dc.c PDP11/pdp11_io_lib.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -DVM_PDP11 -I PDP11 -DUSE_NETWORK -I/usr/include/ -DUSE_TAP_NETWORK -o BIN/pdp11 -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program PDP18B/pdp18b_dt.c: In function 'dt_svc': PDP18B/pdp18b_dt.c:1150:57: warning: "/*" within comment [-Wcomment] /* /* ignore hdr */ At top level: PDP18B/pdp18b_dt.c:342:20: warning: 'map_unit' defined but not used [-Wunused-const-variable=] static const int32 map_unit[16] = { /* Type 550 unit map */ ^~~~~~~~ PDP11/pdp11_fp.c: In function 'fp11': PDP11/pdp11_fp.c:441:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sign = GET_SIGN_L (fac.l)) ^~~~ PDP18B/pdp18b_cpu.c: In function 'sim_instr': PDP18B/pdp18b_cpu.c:607:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = sim_process_event ()) ^~~~~~ PDP11/pdp11_cpu.c: In function 'sim_instr': PDP11/pdp11_cpu.c:735:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (t = trap_req & TRAP_ALL) { /* if a trap */ ^ PDP18B/pdp18b_cpu.c: In function 'sim_instr': PDP18B/pdp18b_cpu.c:607:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = sim_process_event ()) ^~~~~~ PDP18B/pdp18b_cpu.c:933:11: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if ((api_act & (API_ML0|API_ML1|API_ML2|API_ML3)) == 0) ^~ PDP18B/pdp18b_cpu.c:936:13: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' api_int = api_eval (&int_pend); ^~~~~~~ PDP18B/pdp18b_mt.c: In function 'mt_svc': PDP18B/pdp18b_mt.c:356:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrrecf (uptr, mtxb, tbc)) /* write rec, err? */ ^~ PDP18B/pdp18b_mt.c:366:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ ^~ PDP18B/pdp18b_mt.c:375:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ ^~ PDP18B/pdp18b_mt.c:385:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ ^~ PDP18B/pdp18b_lp.c: In function 'lp15_svc': PDP18B/pdp18b_lp.c:821:34: warning: array subscript has type 'char' [-Wchar-subscripts] if ((c[i] <= 037) && ctrl[c[i]]) { /* control char? */ ^ PDP18B/pdp18b_lp.c:824:24: warning: array subscript has type 'char' [-Wchar-subscripts] fputs (ctrl[c[i]], uptr->fileref); /* space */ ^ PDP18B/pdp18b_mt.c: In function 'mt_svc': PDP18B/pdp18b_mt.c:356:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrrecf (uptr, mtxb, tbc)) /* write rec, err? */ ^~ PDP18B/pdp18b_mt.c:366:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ ^~ PDP18B/pdp18b_mt.c:375:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ ^~ PDP18B/pdp18b_mt.c:385:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ ^~ PDP11/pdp11_cis.c:173:21: warning: missing braces around initializer [-Wmissing-braces] static DSTR Dstr0 = { 0, 0, 0, 0, 0 }; ^ { } PDP11/pdp11_cis.c:207:36: warning: missing braces around initializer [-Wmissing-braces] static int32 opntab[128][MAXOPN] = { ^ PDP11/pdp11_cis.c:323:31: warning: missing braces around initializer [-Wmissing-braces] static int32 binover[2][16] = { ^ '{', 'A', 'B', 'C', 'D', 'E', 'F', 'G', 'H', 'I', { '0', '0', '0', '0', '0', '0', } '}', 'J', 'K', 'L', 'M', 'N', 'O', 'P', 'Q', 'R', { PDP11/pdp11_cis.c:328:5: }; } PDP11/pdp11_cis.c: In function 'cis11': PDP11/pdp11_cis.c:345:21: warning: missing braces around initializer [-Wmissing-braces] static DSTR Dstr1 = { 0, 0x10, 0, 0, 0 }; ^ { } PDP11/pdp11_cis.c:1137:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dst.sign = GET_SIGN_L (result)) ^~~ PDP11/pdp11_cis.c: In function 'WriteDstr': PDP11/pdp11_cis.c:1270:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dst->val[i] = dst->val[i] & ~mask) /* test nz */ ^~~ PDP11/pdp11_cis.c: In function 'NibbleRshift': PDP11/pdp11_cis.c:1526:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (s = sc * 4) { ^ PDP11/pdp11_cis.c: In function 'NibbleLshift': PDP11/pdp11_cis.c:1551:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (s = sc * 4) { ^ At top level: PDP11/pdp11_cis.c:330:22: warning: 'movbuf' defined but not used [-Wunused-variable] static unsigned char movbuf[65536]; ^~~~~~ PDP18B/pdp18b_stddev.c: In function 'ptr_svc': PDP18B/pdp18b_stddev.c:597:16: warning: suggest parentheses around assignment used as truth value [-Wparentheses] while (temp = temp & (temp - 1)) ^~~~ PDP18B/pdp18b_stddev.c: In function 'tti': PDP18B/pdp18b_stddev.c:997:30: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] dat = dat | tti_unit.buf & TTI_MASK; /* return buffer */ ^ PDP18B/pdp18b_sys.c: In function 'fprint_sym': PDP18B/pdp18b_sys.c:1012:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sp = (inst & 03730)) ^~ At top level: PDP18B/pdp18b_sys.c:900:14: warning: 'rar' defined but not used [-Wunused-function] static int32 rar (int32 c) ^~~ PDP11/pdp11_rk.c: In function 'rk_svc': PDP11/pdp11_rk.c:548:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (t = Map_WriteW (ma, 2, &rkxb[wc - 1])) { /* store last */ ^ PDP11/pdp11_rk.c:554:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (t = Map_WriteW (ma, wc << 1, rkxb)) { /* store buf */ ^ PDP11/pdp11_rk.c:563:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (t = Map_ReadW (ma, 2, &comp)) { /* get 1st word */ ^ PDP11/pdp11_rk.c:571:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (t = Map_ReadW (ma, wc << 1, rkxb)) { /* get buf */ ^ PDP11/pdp11_rk.c:587:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (err = ferror (uptr->fileref)) { /* read error? */ ^~~ PDP18B/pdp18b_stddev.c: In function 'clk_task_upd': PDP18B/pdp18b_stddev.c:456:8: warning: unused variable 'old' [-Wunused-variable] uint32 old = clk_task_timer; ^~~ PDP18B/pdp18b_stddev.c: In function 'ptr_svc': PDP18B/pdp18b_stddev.c:597:16: warning: suggest parentheses around assignment used as truth value [-Wparentheses] while (temp = temp & (temp - 1)) ^~~~ PDP18B/pdp18b_stddev.c: In function 'tti': PDP18B/pdp18b_stddev.c:997:30: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] dat = dat | tti_unit.buf & TTI_MASK; /* return buffer */ ^ PDP11/pdp11_rl.c: In function 'rl_svc': PDP11/pdp11_rl.c:859:1: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (DEBUG_PRS (rl_dev)) ^~ PDP11/pdp11_rl.c:863:5: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' if ((uptr->FNC >= RLCS_READ) && (err == 0)) { /* read (no hdr)? */ ^~ PDP18B/pdp18b_sys.c: In function 'fprint_sym': PDP18B/pdp18b_sys.c:1012:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sp = (inst & 03730)) ^~ At top level: PDP18B/pdp18b_sys.c:900:14: warning: 'rar' defined but not used [-Wunused-function] static int32 rar (int32 c) ^~~ PDP18B/pdp18b_tt1.c: In function 'ttix_svc': PDP18B/pdp18b_tt1.c:225:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (temp = tmxr_getc_ln (&ttx_ldsc[ln])) { /* get char */ ^~~~ PDP18B/pdp18b_fpp.c: In function 'fp15': PDP18B/pdp18b_fpp.c:256:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ ^~~ PDP18B/pdp18b_fpp.c:265:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ ^~~ PDP18B/pdp18b_fpp.c:273:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ ^~~ PDP18B/pdp18b_fpp.c:281:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ ^~~ PDP18B/pdp18b_fpp.c:283:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fmb)) break; /* fetch op to FMB */ ^~~ PDP18B/pdp18b_fpp.c:291:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ ^~~ PDP18B/pdp18b_fpp.c:299:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ ^~~ PDP18B/pdp18b_fpp.c:312:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ ^~~ PDP18B/pdp18b_fpp.c:320:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ ^~~ PDP18B/pdp18b_fpp.c:326:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ ^~~ PDP18B/pdp18b_fpp.c:340:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = Read (ar, &dat, RD)) ^~~ PDP18B/pdp18b_fpp.c:348:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ ^~~ PDP18B/pdp18b_fpp.c: In function 'fp15_store': PDP18B/pdp18b_fpp.c:432:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_norm (ir, a, NULL, 0)) /* normalize */ ^~~ PDP18B/pdp18b_tt1.c: In function 'ttix_svc': PDP18B/pdp18b_tt1.c:225:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (temp = tmxr_getc_ln (&ttx_ldsc[ln])) { /* get char */ ^~~~ In file included from scp.c:189:0: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] /* V3.8 revision history sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] /* V3.7 revision history sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] /* V3.6 revision history sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] /* V3.5 revision history sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] /* V3.4 revision history sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] /* V3.3 revision history sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] /* V3.2 revision history sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] /* V3.1 revision history sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] /* V3.0 revision history sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] /* V2.10 revision history sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] /* V2.9 revision history scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (np = match_ext (nbuf, "EXE")) /* remove .exe */ ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) /* lookup command */ ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { /* lookup command */ ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (shtb, gbuf)) /* global match? */ ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (aptr = strchr (cptr, ';')) { /* ;action? */ ^~~~ PDP18B/pdp18b_fpp.c: In function 'fp15': PDP18B/pdp18b_fpp.c:256:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ ^~~ PDP18B/pdp18b_fpp.c:265:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ ^~~ PDP18B/pdp18b_fpp.c:273:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ ^~~ PDP18B/pdp18b_fpp.c:281:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ ^~~ PDP18B/pdp18b_fpp.c:283:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fmb)) break; /* fetch op to FMB */ ^~~ PDP18B/pdp18b_fpp.c:291:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ ^~~ PDP18B/pdp18b_fpp.c:299:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ ^~~ PDP18B/pdp18b_fpp.c:312:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ ^~~ PDP18B/pdp18b_fpp.c:320:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ ^~~ PDP18B/pdp18b_fpp.c:326:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ ^~~ PDP18B/pdp18b_fpp.c:340:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = Read (ar, &dat, RD)) ^~~ PDP18B/pdp18b_fpp.c:348:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ ^~~ PDP18B/pdp18b_fpp.c: In function 'fp15_store': PDP18B/pdp18b_fpp.c:432:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sta = fp15_norm (ir, a, NULL, 0)) /* normalize */ ^~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (portp = strchr (gbuf, ':')) /* x:y? split */ ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (cptr)) { /* exact match? */ ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sptr = strchr (logstr, c)) { /* check for mask */ ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ ^~ PDP11/pdp11_sys.c: In function 'parse_sym': PDP11/pdp11_sys.c:1073:13: warning: this 'for' clause does not guard... [-Wmisleading-indentation] for (i = 0; (opcode[i] != NULL) && ^~~ PDP11/pdp11_sys.c:1075:14: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'for' if ((((opc_val[i] >> I_V_CL) & I_M_CL) != j) || ^~ In file included from scp.c:189:0: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] /* V3.8 revision history sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] /* V3.7 revision history sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] /* V3.6 revision history sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] /* V3.5 revision history sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] /* V3.4 revision history sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] /* V3.3 revision history sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] /* V3.2 revision history sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] /* V3.1 revision history sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] /* V3.0 revision history sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] /* V2.10 revision history sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] /* V2.9 revision history scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (np = match_ext (nbuf, "EXE")) /* remove .exe */ ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) /* lookup command */ ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { /* lookup command */ ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (shtb, gbuf)) /* global match? */ ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (aptr = strchr (cptr, ';')) { /* ;action? */ ^~~~ PDP11/pdp11_tc.c: In function 'dt_svc': PDP11/pdp11_tc.c:995:57: warning: "/*" within comment [-Wcomment] /* else /* ignore hdr */ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (portp = strchr (gbuf, ':')) /* x:y? split */ ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (cptr)) { /* exact match? */ ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sptr = strchr (logstr, c)) { /* check for mask */ ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ ^~ PDP11/pdp11_tm.c: In function 'tm_go': PDP11/pdp11_tm.c:380:9: warning: "/*" within comment [-Wcomment] /* else /* uncomment this else if rewind/unload don't set done */ PDP11/pdp11_tm.c: In function 'tm_svc': PDP11/pdp11_tm.c:442:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (t = Map_WriteB (xma, cbc, tmxb)) { /* copy buf to mem */ ^ PDP11/pdp11_tm.c:452:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (t = Map_ReadB (xma, cbc, tmxb)) { /* copy mem to buf */ ^ PDP11/pdp11_tm.c:458:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrrecf (uptr, tmxb, cbc)) /* write rec, err? */ ^~ PDP11/pdp11_tm.c:467:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ ^~ PDP11/pdp11_tm.c:474:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_sprecf (uptr, &tbc)) { /* spc rec fwd, err? */ ^~ PDP11/pdp11_tm.c:484:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_sprecr (uptr, &tbc)) { /* spc rec rev, err? */ ^~ PDP11/pdp11_ts.c: In function 'ts_spacef': PDP11/pdp11_ts.c:493:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_sprecf (uptr, &tbc)) /* space rec fwd, err? */ ^~ PDP11/pdp11_ts.c: In function 'ts_spacer': PDP11/pdp11_ts.c:536:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_sprecr (uptr, &tbc)) /* space rec rev, err? */ ^~ PDP11/pdp11_ts.c: In function 'ts_readf': PDP11/pdp11_ts.c:572:7: warning: variable 'wa' set but not used [-Wunused-but-set-variable] int32 wa; ^~ PDP11/pdp11_ts.c: In function 'ts_readr': PDP11/pdp11_ts.c:622:32: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] tsba = (cmdadh << 16) | cmdadl + fc; /* buf addr */ ^ PDP11/pdp11_ts.c: In function 'ts_write': PDP11/pdp11_ts.c:669:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrrecf (uptr, tsxb, fc)) /* write rec, err? */ ^~ PDP11/pdp11_ts.c: In function 'ts_wtmk': PDP11/pdp11_ts.c:682:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ ^~ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_con_tab, gbuf)) ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ ^ PDP11/pdp11_io.c: In function 'build_dib_tab': PDP11/pdp11_io.c:376:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = cpu_build_dib ()) /* build CPU entries */ ^ PDP11/pdp11_io.c:382:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = build_mbus_tab (dptr, dibp)) /* add to Mbus tab */ ^ PDP11/pdp11_io.c:386:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = build_ubus_tab (dptr, dibp)) /* add to Unibus tab */ ^ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_con_tab, gbuf)) ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ ^ In file included from PDP11/pdp11_rq.c:99:0: PDP11/pdp11_mscp.h:213:57: warning: "/*" within comment [-Wcomment] /* 5 /* reserved */ PDP11/pdp11_mscp.h:258:57: warning: "/*" within comment [-Wcomment] /* 8 - 15 /* reserved */ PDP11/pdp11_mscp.h:265:57: warning: "/*" within comment [-Wcomment] /* 8 - 15 /* reserved */ PDP11/pdp11_mscp.h:401:57: warning: "/*" within comment [-Wcomment] /* 14 /* reserved */ PDP11/pdp11_mscp.h:402:57: warning: "/*" within comment [-Wcomment] /* 15 /* reserved */ PDP11/pdp11_rq.c: In function 'rq_abo': PDP11/pdp11_rq.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = rq_getucb (cp, lu)) { /* get unit */ ^~~~ PDP11/pdp11_rq.c:1368:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (prv = uptr->pktq) { /* srch pkt q */ ^~~ PDP11/pdp11_rq.c:1369:16: warning: suggest parentheses around assignment used as truth value [-Wparentheses] while (tpkt = cp->pak[prv].link) { /* walk list */ ^~~~ PDP11/pdp11_rq.c: In function 'rq_avl': PDP11/pdp11_rq.c:1396:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ ^~~~ PDP11/pdp11_rq.c: In function 'rq_gus': PDP11/pdp11_rq.c:1450:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ ^~~~ PDP11/pdp11_rq.c: In function 'rq_onl': PDP11/pdp11_rq.c:1485:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ ^~~~ PDP11/pdp11_rq.c: In function 'rq_scc': PDP11/pdp11_rq.c:1523:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cp->htmo = cp->pak[pkt].d[SCC_TMO]) /* set timeout */ ^~ PDP11/pdp11_rq.c: In function 'rq_suc': PDP11/pdp11_rq.c:1550:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ ^~~~ PDP11/pdp11_rq.c: In function 'rq_fmt': PDP11/pdp11_rq.c:1579:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ ^~~~ PDP11/pdp11_rq.c: In function 'rq_rw': PDP11/pdp11_rq.c:1613:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ ^~~~ PDP11/pdp11_rq.c: In function 'rq_rw_valid': PDP11/pdp11_rq.c:1657:57: warning: "/*" within comment [-Wcomment] /* if (lbn & 0xF0000000) return (ST_CMD | I_LBN); /* 'reasonable' lbn? */ PDP11/pdp11_rq.c: In function 'rq_svc': PDP11/pdp11_rq.c:1728:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (abc = tbc - t) { /* any xfer? */ ^~~ PDP11/pdp11_rq.c:1755:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (t = Map_WriteW (ba, tbc, rqxb)) { /* store, nxm? */ ^ PDP11/pdp11_rq.c: In function 'rq_show_unitq': PDP11/pdp11_rq.c:2589:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (pkt = uptr->pktq) { ^~~ PDP11/pdp11_rq.c:2593:22: warning: suggest parentheses around assignment used as truth value [-Wparentheses] } while (pkt = cp->pak[pkt].link); ^~~ PDP11/pdp11_rq.c: In function 'rq_show_ctrl': PDP11/pdp11_rq.c:2620:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (pkt = cp->freq) { ^~~ PDP11/pdp11_rq.c:2633:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (pkt = cp->rspq) { ^~~ PDP11/pdp11_rq.c:2637:22: warning: suggest parentheses around assignment used as truth value [-Wparentheses] } while (pkt = cp->pak[pkt].link); ^~~ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (lp->conn == 0) /* skip if !conn */ ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ ^~~~~~ In file included from PDP11/pdp11_tq.c:85:0: PDP11/pdp11_mscp.h:213:57: warning: "/*" within comment [-Wcomment] /* 5 /* reserved */ PDP11/pdp11_mscp.h:258:57: warning: "/*" within comment [-Wcomment] /* 8 - 15 /* reserved */ PDP11/pdp11_mscp.h:265:57: warning: "/*" within comment [-Wcomment] /* 8 - 15 /* reserved */ PDP11/pdp11_mscp.h:401:57: warning: "/*" within comment [-Wcomment] /* 14 /* reserved */ PDP11/pdp11_mscp.h:402:57: warning: "/*" within comment [-Wcomment] /* 15 /* reserved */ PDP11/pdp11_tq.c: In function 'tq_mscp': PDP11/pdp11_tq.c:783:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = tq_getucb (lu)) { /* valid unit? */ ^~~~ PDP11/pdp11_tq.c:789:57: warning: "/*" within comment [-Wcomment] /* if (tq_cmf[cmd] & MD_CDL) /* clr cch lost? */ PDP11/pdp11_tq.c: In function 'tq_abo': PDP11/pdp11_tq.c:861:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = tq_getucb (lu)) { /* get unit */ ^~~~ PDP11/pdp11_tq.c:874:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (prv = uptr->pktq) { /* srch pkt q */ ^~~ PDP11/pdp11_tq.c:875:16: warning: suggest parentheses around assignment used as truth value [-Wparentheses] while (tpkt = tq_pkt[prv].link) { /* walk list */ ^~~~ PDP11/pdp11_tq.c: In function 'tq_avl': PDP11/pdp11_tq.c:903:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = tq_getucb (lu)) { /* unit exist? */ ^~~~ PDP11/pdp11_tq.c: In function 'tq_gus': PDP11/pdp11_tq.c:958:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = tq_getucb (lu)) { /* unit exist? */ ^~~~ PDP11/pdp11_tq.c: In function 'tq_onl': PDP11/pdp11_tq.c:983:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = tq_getucb (lu)) { /* unit exist? */ ^~~~ PDP11/pdp11_tq.c: In function 'tq_scc': PDP11/pdp11_tq.c:1012:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (tq_htmo = tq_pkt[pkt].d[SCC_TMO]) /* set timeout */ ^~~~~~~ PDP11/pdp11_tq.c: In function 'tq_suc': PDP11/pdp11_tq.c:1036:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = tq_getucb (lu)) { /* unit exist? */ ^~~~ PDP11/pdp11_tq.c: In function 'tq_flu': PDP11/pdp11_tq.c:1058:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = tq_getucb (lu)) /* unit exist? */ ^~~~ PDP11/pdp11_tq.c: In function 'tq_erase': PDP11/pdp11_tq.c:1074:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = tq_getucb (lu)) { /* unit exist? */ ^~~~ PDP11/pdp11_tq.c: In function 'tq_wtm': PDP11/pdp11_tq.c:1095:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = tq_getucb (lu)) { /* unit exist? */ ^~~~ PDP11/pdp11_tq.c: In function 'tq_pos': PDP11/pdp11_tq.c:1118:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = tq_getucb (lu)) { /* unit exist? */ ^~~~ PDP11/pdp11_tq.c: In function 'tq_rw': PDP11/pdp11_tq.c:1150:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = tq_getucb (lu)) { /* unit exist? */ ^~~~ PDP11/pdp11_tq.c: In function 'tq_svc': PDP11/pdp11_tq.c:1254:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (t = Map_WriteB (ba, wbc, tqxb)) { /* store, nxm? */ ^ PDP11/pdp11_tq.c:1291:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (t = Map_ReadB (ba, bc, tqxb)) { /* fetch buf, nxm? */ ^ PDP11/pdp11_tq.c: In function 'tq_show_unitq': PDP11/pdp11_tq.c:2236:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (pkt = uptr->pktq) { ^~~ PDP11/pdp11_tq.c:2240:22: warning: suggest parentheses around assignment used as truth value [-Wparentheses] } while (pkt = tq_pkt[pkt].link); ^~~ PDP11/pdp11_tq.c: In function 'tq_show_ctrl': PDP11/pdp11_tq.c:2265:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (pkt = tq_freq) { ^~~ PDP11/pdp11_tq.c:2278:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (pkt = tq_rspq) { ^~~ PDP11/pdp11_tq.c:2282:22: warning: suggest parentheses around assignment used as truth value [-Wparentheses] } while (pkt = tq_pkt[pkt].link); ^~~ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (lp->conn == 0) /* skip if !conn */ ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ ^~~~~~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ ^~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ ^~ PDP11/pdp11_hk.c: In function 'hk_svc': PDP11/pdp11_hk.c:890:21: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (t = Map_ReadW (ba, 2, &comp)) { /* get 1st wd */ ^ PDP11/pdp11_hk.c:898:21: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (t = Map_ReadW (ba, wc << 1, hkxb)) { /* get buf */ ^ PDP11/pdp11_hk.c:918:21: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (t = Map_WriteW (ba, 2, &hkxb[wc - 1])) { ^ PDP11/pdp11_hk.c:924:21: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (t = Map_WriteW (ba, wc << 1, hkxb)) { /* put buf */ ^ PDP11/pdp11_xq.c: In function 'xq_process_mop': PDP11/pdp11_xq.c:1086:28: warning: '<<' in boolean context, did you mean '<' ? [-Wint-in-bool-context] address = (meb->add_hi << 16) || (meb->add_mi << 8) || meb->add_lo; ~~~~~~~~~~~~~^~~~~~ PDP11/pdp11_xq.c:1086:51: warning: '<<' in boolean context, did you mean '<' ? [-Wint-in-bool-context] address = (meb->add_hi << 16) || (meb->add_mi << 8) || meb->add_lo; ~~~~~~~~~~~~~^~~~~ PDP11/pdp11_xq.c:1087:28: warning: '<<' in boolean context, did you mean '<' ? [-Wint-in-bool-context] size = (meb->siz_hi << 8) || meb->siz_lo; ~~~~~~~~~~~~~^~~~~ PDP11/pdp11_xq.c:1075:10: warning: variable 'size' set but not used [-Wunused-but-set-variable] uint16 size; ^~~~ PDP11/pdp11_xq.c: In function 'xq_process_setup': PDP11/pdp11_xq.c:1190:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (led = (len & XQ_SETUP_LD) >> 2) { ^~~ PDP11/pdp11_xq.c: In function 'xq_process_bootrom': PDP11/pdp11_xq.c:2046:3: warning: enumeration value 'XQ_T_DELQA' not handled in switch [-Wswitch] switch (xq->var->type) { ^~~~~~ PDP11/pdp11_xq.c:2046:3: warning: enumeration value 'XQ_T_DELQA_PLUS' not handled in switch [-Wswitch] PDP11/pdp11_xq.c: In function 'xq_tmrsvc': PDP11/pdp11_xq.c:2534:8: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] if (--xq->var->sanity.timer <= 0) ^ gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 PDP10/pdp10_fe.c PDP11/pdp11_dz.c PDP10/pdp10_cpu.c PDP10/pdp10_ksio.c PDP10/pdp10_lp20.c PDP10/pdp10_mdfp.c PDP10/pdp10_pag.c PDP10/pdp10_rp.c PDP10/pdp10_sys.c PDP10/pdp10_tim.c PDP10/pdp10_tu.c PDP10/pdp10_xtnd.c PDP11/pdp11_pt.c PDP11/pdp11_ry.c PDP11/pdp11_cr.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -DVM_PDP10 -DUSE_INT64 -I PDP10 -I PDP11 -o BIN/pdp10 -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program In file included from PDP10/pdp10_fe.c:41:0: PDP10/pdp10_defs.h:590:57: warning: "/*" within comment [-Wcomment] /* #define READC 1 /* console read */ PDP10/pdp10_defs.h:592:57: warning: "/*" within comment [-Wcomment] /* #define WRITEC 3 /* console write */ PDP11/pdp11_xu.c: In function 'xu_process_receive': PDP11/pdp11_xu.c:1044:24: warning: "/*" within comment [-Wcomment] /* xu_dump_rxring(xu); /* debug receive ring */ PDP11/pdp11_xu.c: In function 'xu_process_transmit': PDP11/pdp11_xu.c:1216:24: warning: "/*" within comment [-Wcomment] /* xu_dump_txring(xu); /* debug receive ring */ In file included from PDP11/pdp11_dz.c:62:0: PDP10/pdp10_defs.h:590:57: warning: "/*" within comment [-Wcomment] /* #define READC 1 /* console read */ PDP10/pdp10_defs.h:592:57: warning: "/*" within comment [-Wcomment] /* #define WRITEC 3 /* console write */ PDP11/pdp11_xu.c: In function 'xu_dump_rxring': PDP11/pdp11_xu.c:1683:12: warning: unused variable 'rstatus' [-Wunused-variable] t_stat rstatus = Map_ReadW (ba, 8, rxhdr); /* get rxring entry[i] */ ^~~~~~~ PDP11/pdp11_xu.c: In function 'xu_dump_txring': PDP11/pdp11_xu.c:1699:12: warning: unused variable 'tstatus' [-Wunused-variable] t_stat tstatus = Map_ReadW (ba, 8, txhdr); /* get rxring entry[i] */ ^~~~~~~ In file included from PDP10/pdp10_cpu.c:136:0: PDP10/pdp10_defs.h:590:57: warning: "/*" within comment [-Wcomment] /* #define READC 1 /* console read */ PDP10/pdp10_defs.h:592:57: warning: "/*" within comment [-Wcomment] /* #define WRITEC 3 /* console write */ PDP10/pdp10_cpu.c: In function 'sim_instr': PDP10/pdp10_cpu.c:708:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (i = sim_process_event ()) /* error? stop sim */ ^ PDP10/pdp10_cpu.c:722:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (vec = pi_ub_vec (qintr, &uba)) { /* Unibus interrupt? */ ^~~ PDP10/pdp10_cpu.c:868:57: warning: "/*" within comment [-Wcomment] /* case 0100: MUUO /* UJEN */ PDP10/pdp10_cpu.c:869:57: warning: "/*" within comment [-Wcomment] /* case 0101: MUUO /* unassigned */ PDP10/pdp10_cpu.c:882:57: warning: "/*" within comment [-Wcomment] /* case 0104: MUUO /* JSYS (T20) */ PDP10/pdp10_cpu.c:884:57: warning: "/*" within comment [-Wcomment] /* case 0106: MUUO /* GFMP (KL)*/ PDP10/pdp10_cpu.c:885:57: warning: "/*" within comment [-Wcomment] /* case 0107: MUUO /* GFDV (KL) */ PDP10/pdp10_cpu.c:912:57: warning: "/*" within comment [-Wcomment] /* case 0130: MUUO /* UFA */ PDP10/pdp10_cpu.c:913:57: warning: "/*" within comment [-Wcomment] /* case 0131: MUUO /* DFN */ PDP10/pdp10_cpu.c:917:13: warning: this 'else' clause does not guard... [-Wmisleading-indentation] else adjbp (ac, ea, pflgs); break; ^~~~ PDP10/pdp10_cpu.c:917:41: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'else' else adjbp (ac, ea, pflgs); break; ^~~~~ PDP10/pdp10_cpu.c:923:57: warning: "/*" within comment [-Wcomment] /* case 0141: MUUO /* FADL */ PDP10/pdp10_cpu.c:931:57: warning: "/*" within comment [-Wcomment] /* case 0151: MUUO /* FSBL */ PDP10/pdp10_cpu.c:939:57: warning: "/*" within comment [-Wcomment] /* case 0161: MUUO /* FMPL */ PDP10/pdp10_cpu.c:947:57: warning: "/*" within comment [-Wcomment] /* case 0171: MUUO /* FDVL */ PDP10/pdp10_cpu.c:1011:17: warning: "/*" within comment [-Wcomment] /* case 0254: /* shown later /* JRST */ PDP10/pdp10_cpu.c:1011:57: warning: "/*" within comment [-Wcomment] PDP11/pdp11_vh.c:296:60: warning: "/*" within comment [-Wcomment] /* #define DBG_XMT TMXR_DBG_XMT /* display Transmitted Data */ PDP11/pdp11_vh.c:297:60: warning: "/*" within comment [-Wcomment] /* #define DBG_RCV TMXR_DBG_RCV /* display Received Data */ PDP10/pdp10_cpu.c: In function 'test_int': PDP10/pdp10_cpu.c:2022:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (t = sim_process_event ()) /* IO event? */ ^ PDP11/pdp11_tu.c: In function 'tu_svc': PDP11/pdp11_tu.c:650:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ ^~ PDP11/pdp11_tu.c:663:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ ^~ PDP11/pdp11_tu.c:674:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ ^~ PDP11/pdp11_tu.c:690:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdrecf (uptr, xbuf, &tbc, MT_MAXFR)) { /* read fwd */ ^~ PDP11/pdp11_tu.c:742:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrrecf (uptr, xbuf, tbc)) /* write rec, err? */ ^~ PDP11/pdp11_tu.c:754:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdrecr (uptr, xbuf + 4, &tbc, MT_MAXFR)) { /* read rev */ ^~ PDP11/pdp11_tu.c:621:12: warning: variable 'r' set but not used [-Wunused-but-set-variable] t_stat st, r = SCPE_OK; ^ In file included from PDP10/pdp10_ksio.c:72:0: PDP10/pdp10_defs.h:590:57: warning: "/*" within comment [-Wcomment] /* #define READC 1 /* console read */ PDP10/pdp10_defs.h:592:57: warning: "/*" within comment [-Wcomment] /* #define WRITEC 3 /* console write */ PDP10/pdp10_ksio.c: In function 'ReadIO': PDP10/pdp10_ksio.c:404:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] for (i = 0; dibp = dib_tab[i]; i++ ) { ^~~~ PDP10/pdp10_ksio.c: In function 'WriteIO': PDP10/pdp10_ksio.c:421:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] for (i = 0; dibp = dib_tab[i]; i++ ) { ^~~~ PDP11/pdp11_cpumod.c: In function 'cpu_build_dib': PDP11/pdp11_cpumod.c:1078:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = build_ubus_tab (&cpu_dev, cnf_tab[i].dib)) /* add to dispatch tab */ ^ In file included from PDP10/pdp10_lp20.c:42:0: PDP10/pdp10_defs.h:590:57: warning: "/*" within comment [-Wcomment] /* #define READC 1 /* console read */ PDP10/pdp10_defs.h:592:57: warning: "/*" within comment [-Wcomment] /* #define WRITEC 3 /* console write */ PDP10/pdp10_lp20.c:61:57: warning: "/*" within comment [-Wcomment] /* define TX_INTR 04000 /* interrupt */ PDP10/pdp10_lp20.c:63:57: warning: "/*" within comment [-Wcomment] /* define TX_XLAT 01000 /* translate */ PDP10/pdp10_lp20.c:64:57: warning: "/*" within comment [-Wcomment] /* define TX_DVFU 00400 /* DAVFU */ PDP10/pdp10_lp20.c: In function 'lp20_adv': PDP10/pdp10_lp20.c:566:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (lppagc = (lppagc - 1) & PAGC_MASK) { /* decr page cntr */ ^~~~~~ PDP10/pdp10_lp20.c: In function 'lp20_davfu': PDP10/pdp10_lp20.c:595:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (lppagc = (lppagc - 1) & PAGC_MASK) { /* decr page cntr */ ^~~~~~ In file included from PDP10/pdp10_mdfp.c:101:0: PDP10/pdp10_defs.h:590:57: warning: "/*" within comment [-Wcomment] /* #define READC 1 /* console read */ PDP10/pdp10_defs.h:592:57: warning: "/*" within comment [-Wcomment] /* #define WRITEC 3 /* console write */ PDP10/pdp10_mdfp.c: In function 'fdv': PDP10/pdp10_mdfp.c:496:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (savhi = a.fhi) { /* dvd = 0? quo = 0 */ ^~~~~ In file included from PDP10/pdp10_pag.c:79:0: PDP10/pdp10_defs.h:590:57: warning: "/*" within comment [-Wcomment] /* #define READC 1 /* console read */ PDP10/pdp10_defs.h:592:57: warning: "/*" within comment [-Wcomment] /* #define WRITEC 3 /* console write */ PDP11/pdp11_rf.c:145:14: warning: missing braces around initializer [-Wmissing-braces] DIB rf_dib = { ^ In file included from PDP10/pdp10_rp.c:71:0: PDP10/pdp10_defs.h:590:57: warning: "/*" within comment [-Wcomment] /* #define READC 1 /* console read */ PDP10/pdp10_defs.h:592:57: warning: "/*" within comment [-Wcomment] /* #define WRITEC 3 /* console write */ PDP11/pdp11_dl.c: In function 'dli_svc': PDP11/pdp11_dl.c:349:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (temp = tmxr_getc_ln (&dlx_ldsc[ln])) { /* get char */ ^~~~ PDP10/pdp10_rp.c: In function 'rp_wr': PDP10/pdp10_rp.c:612:18: warning: variable 'dtype' set but not used [-Wunused-but-set-variable] int32 cs1f, drv, dtype, i, j; ^~~~~ PDP10/pdp10_rp.c: In function 'rp_svc': PDP10/pdp10_rp.c:954:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (fc10 = twc10 & (RP_NUMWD - 1)) { /* fill? */ ^~~~ PDP10/pdp10_rp.c: At top level: PDP10/pdp10_rp.c:1194:33: warning: suggest parentheses around '+' in operand of '&' [-Wparentheses] 0713001000000+(IOBA_UBMAP+1 & RMASK), /* wrio 0,763001(1); set ubmap */ ^ PDP10/pdp10_rp.c:1241:33: warning: suggest parentheses around '+' in operand of '&' [-Wparentheses] 0715000000000+(IOBA_UBMAP+1 & RMASK), /* iowrq 0,763001 ; set ubmap */ ^ PDP11/pdp11_ta.c: In function 'ta_svc': PDP11/pdp11_ta.c:400:16: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrrecf (uptr, ta_xb, ta_bptr)) /* write, err? */ ^~ PDP11/pdp11_ta.c:406:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ ^~ PDP11/pdp11_ta.c:416:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_sprecr (uptr, &tbc)) /* space rev, err? */ ^~ PDP11/pdp11_ta.c:428:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_sprecf (uptr, &tbc)) /* space rev, err? */ ^~ In file included from PDP10/pdp10_sys.c:42:0: PDP10/pdp10_defs.h:590:57: warning: "/*" within comment [-Wcomment] /* #define READC 1 /* console read */ PDP10/pdp10_defs.h:592:57: warning: "/*" within comment [-Wcomment] /* #define WRITEC 3 /* console write */ PDP10/pdp10_sys.c:123:1: warning: "/*" within comment [-Wcomment] /* RIM10 loader PDP10/pdp10_sys.c: In function 'fprint_sym': PDP10/pdp10_sys.c:696:16: warning: variable 'cflag' set but not used [-Wunused-but-set-variable] int32 i, j, c, cflag, ac, xr, y, dev; ^~~~~ PDP10/pdp10_sys.c: In function 'parse_sym': PDP10/pdp10_sys.c:823:7: warning: variable 'cflag' set but not used [-Wunused-but-set-variable] int32 cflag, i, j; ^~~~~ In file included from PDP10/pdp10_tim.c:41:0: PDP10/pdp10_defs.h:590:57: warning: "/*" within comment [-Wcomment] /* #define READC 1 /* console read */ PDP10/pdp10_defs.h:592:57: warning: "/*" within comment [-Wcomment] /* #define WRITEC 3 /* console write */ In file included from PDP10/pdp10_tu.c:93:0: PDP10/pdp10_defs.h:590:57: warning: "/*" within comment [-Wcomment] /* #define READC 1 /* console read */ PDP10/pdp10_defs.h:592:57: warning: "/*" within comment [-Wcomment] /* #define WRITEC 3 /* console write */ PDP10/pdp10_tu.c: In function 'tu_svc': PDP10/pdp10_tu.c:836:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ ^~ PDP10/pdp10_tu.c:850:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ ^~ PDP10/pdp10_tu.c:862:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ ^~ PDP10/pdp10_tu.c:892:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdrecf (uptr, xbuf, &tbc, MT_MAXFR)) { /* read fwd */ ^~ PDP10/pdp10_tu.c:939:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrrecf (uptr, xbuf, fc)) /* write rec, err? */ ^~ PDP10/pdp10_tu.c:954:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdrecr (uptr, xbuf + 4, &tbc, MT_MAXFR)) { /* read rev */ ^~ PDP10/pdp10_tu.c:809:12: warning: variable 'r' set but not used [-Wunused-but-set-variable] t_stat st, r = SCPE_OK; ^ PDP10/pdp10_tu.c: At top level: PDP10/pdp10_tu.c:1201:33: warning: suggest parentheses around '+' in operand of '&' [-Wparentheses] 0713001000000+(IOBA_UBMAP+1 & RMASK), /* wrio 0,763001(1); set ubmap */ ^ PDP10/pdp10_tu.c:1239:33: warning: suggest parentheses around '+' in operand of '&' [-Wparentheses] 0714000000000+(IOBA_UBMAP+1 & RMASK), /* iowri 0,763001 ; set ubmap */ ^ PDP11/pdp11_ke.c: In function 'ke_wr': PDP11/pdp11_ke.c:255:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sign = GET_SIGN_W (ke_AC)) /* sext operand */ ^~~~ PDP11/pdp11_ke.c:285:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sign = GET_SIGN_W (ke_AC)) /* sext operand */ ^~~~ In file included from PDP10/pdp10_xtnd.c:66:0: PDP10/pdp10_defs.h:590:57: warning: "/*" within comment [-Wcomment] /* #define READC 1 /* console read */ PDP10/pdp10_defs.h:592:57: warning: "/*" within comment [-Wcomment] /* #define WRITEC 3 /* console write */ PDP10/pdp10_xtnd.c:157:34: warning: missing braces around initializer [-Wmissing-braces] static const d10 pwrs10[23][2] = { ^ 0, 0, { } 0, 1, { } 0, 10, { } 0, 100, { } 0, 1000, { } 0, 10000, { } 0, 100000, { } 0, 1000000, { } 0, 10000000, { } 0, 100000000, { } 0, 1000000000, { } 0, 10000000000, { } 2, 31280523264, { } 29, 3567587328, { } 291, 1316134912, { } 2910, 13161349120, { } 29103, 28534276096, { } 291038, 10464854016, { } 2910383, 1569325056, { } 29103830, 15693250560, { } 291038304, 19493552128, { } 2910383045, 23136829440, { } 29103830456, 25209864192 { }; } In file included from PDP11/pdp11_pt.c:36:0: PDP10/pdp10_defs.h:590:57: warning: "/*" within comment [-Wcomment] /* #define READC 1 /* console read */ PDP10/pdp10_defs.h:592:57: warning: "/*" within comment [-Wcomment] /* #define WRITEC 3 /* console write */ In file included from PDP11/pdp11_ry.c:45:0: PDP10/pdp10_defs.h:590:57: warning: "/*" within comment [-Wcomment] /* #define READC 1 /* console read */ PDP10/pdp10_defs.h:592:57: warning: "/*" within comment [-Wcomment] /* #define WRITEC 3 /* console write */ In file included from PDP11/pdp11_cr.c:168:0: PDP10/pdp10_defs.h:590:57: warning: "/*" within comment [-Wcomment] /* #define READC 1 /* console read */ PDP10/pdp10_defs.h:592:57: warning: "/*" within comment [-Wcomment] /* #define WRITEC 3 /* console write */ In file included from scp.c:189:0: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] /* V3.8 revision history sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] /* V3.7 revision history sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] /* V3.6 revision history sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] /* V3.5 revision history sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] /* V3.4 revision history sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] /* V3.3 revision history sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] /* V3.2 revision history sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] /* V3.1 revision history sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] /* V3.0 revision history sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] /* V2.10 revision history sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] /* V2.9 revision history scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (np = match_ext (nbuf, "EXE")) /* remove .exe */ ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) /* lookup command */ ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { /* lookup command */ ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (shtb, gbuf)) /* global match? */ ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (aptr = strchr (cptr, ';')) { /* ;action? */ ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (portp = strchr (gbuf, ':')) /* x:y? split */ ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (cptr)) { /* exact match? */ ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sptr = strchr (logstr, c)) { /* check for mask */ ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ ^~ In file included from scp.c:189:0: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] /* V3.8 revision history sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] /* V3.7 revision history sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] /* V3.6 revision history sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] /* V3.5 revision history sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] /* V3.4 revision history sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] /* V3.3 revision history sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] /* V3.2 revision history sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] /* V3.1 revision history sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] /* V3.0 revision history sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] /* V2.10 revision history sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] /* V2.9 revision history scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (np = match_ext (nbuf, "EXE")) /* remove .exe */ ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) /* lookup command */ ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { /* lookup command */ ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (shtb, gbuf)) /* global match? */ ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (aptr = strchr (cptr, ';')) { /* ;action? */ ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (portp = strchr (gbuf, ':')) /* x:y? split */ ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (cptr)) { /* exact match? */ ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sptr = strchr (logstr, c)) { /* check for mask */ ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ ^~ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_con_tab, gbuf)) ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ ^ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_con_tab, gbuf)) ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ ^ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (lp->conn == 0) /* skip if !conn */ ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ ^~~~~~ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (lp->conn == 0) /* skip if !conn */ ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ ^~~~~~ sim_ether.c: In function 'eth_get_nic_hw_addr': sim_ether.c:1336:11: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (f = fopen("NIC.hwaddr", "r")) { ^ sim_ether.c: In function '_eth_writer': sim_ether.c:1522:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] while (request = dev->write_requests) { ^~~~~~~ sim_ether.c: In function 'eth_open': sim_ether.c:1621:8: warning: unused variable 'dev_name' [-Wunused-variable] char dev_name[64] = ""; ^~~~~~~~ sim_ether.c: In function 'eth_close': sim_ether.c:1830:11: warning: suggest parentheses around assignment used as truth value [-Wparentheses] while (buffer = dev->write_buffers) { ^~~~~~ sim_ether.c:1834:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] while (buffer = dev->write_requests) { ^~~~~~ sim_ether.c: In function 'eth_write': sim_ether.c:2087:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (request = dev->write_buffers) ^~~~~~~ At top level: sim_ether.c:2178:1: warning: '_eth_test_multicast_hash' defined but not used [-Wunused-function] _eth_test_multicast_hash() ^~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ ^~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ ^~ gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 VAX/vax_cpu.c VAX/vax_cpu1.c VAX/vax_fpa.c VAX/vax_io.c VAX/vax_cis.c VAX/vax_octa.c VAX/vax_cmode.c VAX/vax_mmu.c VAX/vax_stddev.c VAX/vax_sysdev.c VAX/vax_sys.c VAX/vax_syscm.c VAX/vax_syslist.c PDP11/pdp11_rl.c PDP11/pdp11_rq.c PDP11/pdp11_ts.c PDP11/pdp11_dz.c PDP11/pdp11_lp.c PDP11/pdp11_tq.c PDP11/pdp11_xq.c PDP11/pdp11_ry.c PDP11/pdp11_vh.c PDP11/pdp11_cr.c PDP11/pdp11_io_lib.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -DVM_VAX -DUSE_INT64 -DUSE_ADDR64 -I VAX -I PDP11 -DUSE_NETWORK -I/usr/include/ -DUSE_TAP_NETWORK -o BIN/vax -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program In file included from VAX/vax_cpu.c:182:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ In file included from VAX/vax_defs.h:726:0, from VAX/vax_cpu.c:182: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] /* #define CMCTLSIZE (18 << 2) /* 18 registers */ VAX/vax_cpu.c: In function 'sim_instr': VAX/vax_cpu.c:645:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (temp = GET_TRAP (trpirq)) { /* trap? */ ^~~~ VAX/vax_cpu.c:653:18: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (temp = GET_IRQL (trpirq)) { /* interrupt? */ ^~~~ In file included from VAX/vax_cpu1.c:72:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ In file included from VAX/vax_defs.h:726:0, from VAX/vax_cpu1.c:72: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] /* #define CMCTLSIZE (18 << 2) /* 18 registers */ In file included from VAX/vax_fpa.c:59:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ In file included from VAX/vax_defs.h:726:0, from VAX/vax_fpa.c:59: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] /* #define CMCTLSIZE (18 << 2) /* 18 registers */ In file included from VAX/vax_io.c:52:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ In file included from VAX/vax_defs.h:726:0, from VAX/vax_io.c:52: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] /* #define CMCTLSIZE (18 << 2) /* 18 registers */ VAX/vax_io.c: In function 'build_dib_tab': VAX/vax_io.c:795:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = build_ubus_tab (dptr, dibp)) /* add to bus tab */ ^ gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 VAX/vax_cpu.c VAX/vax_cpu1.c VAX/vax_fpa.c VAX/vax_cis.c VAX/vax_octa.c VAX/vax_cmode.c VAX/vax_mmu.c VAX/vax_sys.c VAX/vax_syscm.c VAX/vax780_stddev.c VAX/vax780_sbi.c VAX/vax780_mem.c VAX/vax780_uba.c VAX/vax780_mba.c VAX/vax780_fload.c VAX/vax780_syslist.c PDP11/pdp11_rl.c PDP11/pdp11_rq.c PDP11/pdp11_ts.c PDP11/pdp11_dz.c PDP11/pdp11_lp.c PDP11/pdp11_tq.c PDP11/pdp11_xu.c PDP11/pdp11_ry.c PDP11/pdp11_cr.c PDP11/pdp11_rp.c PDP11/pdp11_tu.c PDP11/pdp11_hk.c PDP11/pdp11_io_lib.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -DVM_VAX -DVAX_780 -DUSE_INT64 -DUSE_ADDR64 -I VAX -I PDP11 -DUSE_NETWORK -I/usr/include/ -DUSE_TAP_NETWORK -o BIN/vax780 -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program In file included from VAX/vax_cis.c:53:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ In file included from VAX/vax_defs.h:726:0, from VAX/vax_cis.c:53: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] /* #define CMCTLSIZE (18 << 2) /* 18 registers */ VAX/vax_cis.c:1228:59: warning: "/*" within comment [-Wcomment] /* if (((c & 0xF0) > 0x90) || /* check hi digit */ VAX/vax_cis.c:1229:59: warning: "/*" within comment [-Wcomment] /* ((c & 0x0F) > 0x09)) /* check lo digit */ In file included from VAX/vax_cpu.c:182:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ VAX/vax_cpu.c: In function 'sim_instr': VAX/vax_cpu.c:645:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (temp = GET_TRAP (trpirq)) { /* trap? */ ^~~~ VAX/vax_cpu.c:653:18: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (temp = GET_IRQL (trpirq)) { /* interrupt? */ ^~~~ In file included from VAX/vax_octa.c:47:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ In file included from VAX/vax_defs.h:726:0, from VAX/vax_octa.c:47: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] /* #define CMCTLSIZE (18 << 2) /* 18 registers */ In file included from VAX/vax_cmode.c:40:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ In file included from VAX/vax_defs.h:726:0, from VAX/vax_cmode.c:40: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] /* #define CMCTLSIZE (18 << 2) /* 18 registers */ In file included from VAX/vax_mmu.c:50:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ In file included from VAX/vax_defs.h:726:0, from VAX/vax_mmu.c:50: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] /* #define CMCTLSIZE (18 << 2) /* 18 registers */ In file included from VAX/vax_stddev.c:48:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ In file included from VAX/vax_defs.h:726:0, from VAX/vax_stddev.c:48: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] /* #define CMCTLSIZE (18 << 2) /* 18 registers */ In file included from VAX/vax_sysdev.c:55:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ In file included from VAX/vax_defs.h:726:0, from VAX/vax_sysdev.c:55: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] /* #define CMCTLSIZE (18 << 2) /* 18 registers */ VAX/vax_sysdev.c:407:18: warning: missing braces around initializer [-Wmissing-braces] DIB sysd_dib[] = { ^ 0, 0, NULL, NULL, { VAX/vax_sysdev.c:407:18: warning: missing braces around initializer [-Wmissing-braces] DIB sysd_dib[] = { ^ 0, 0, NULL, NULL, { VAX/vax_sysdev.c:410:5: }; } In file included from VAX/vax_cpu1.c:72:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ In file included from VAX/vax_sys.c:47:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ In file included from VAX/vax_defs.h:726:0, from VAX/vax_sys.c:47: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] /* #define CMCTLSIZE (18 << 2) /* 18 registers */ VAX/vax_sys.c:117:45: warning: missing braces around initializer [-Wmissing-braces] const uint16 drom[NUM_INST][MAX_SPEC + 1] = { ^ VAX/vax_sys.c: In function 'parse_spec': VAX/vax_sys.c:1176:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (tptr = parse_rnum (cptr, &rn)) { /* look for Rn */ ^~~~ In file included from VAX/vax_fpa.c:59:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ In file included from VAX/vax_syscm.c:34:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ In file included from VAX/vax_defs.h:726:0, from VAX/vax_syscm.c:34: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] /* #define CMCTLSIZE (18 << 2) /* 18 registers */ In file included from VAX/vax_cis.c:53:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ VAX/vax_cis.c:74:25: warning: missing braces around initializer [-Wmissing-braces] static DSTR Dstr_zero = { 0, 0, 0, 0, 0 }; ^ { } VAX/vax_cis.c:75:24: warning: missing braces around initializer [-Wmissing-braces] static DSTR Dstr_one = { 0, 0x10, 0, 0, 0 }; ^ { } VAX/vax_cis.c: In function 'op_cis': VAX/vax_cis.c:334:21: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = sim_process_event ()) { /* presumably WRU */ ^ VAX/vax_cis.c: In function 'ReadDstr': VAX/vax_cis.c:1228:59: warning: "/*" within comment [-Wcomment] /* if (((c & 0xF0) > 0x90) || /* check hi digit */ VAX/vax_cis.c:1229:59: warning: "/*" within comment [-Wcomment] /* ((c & 0x0F) > 0x09)) /* check lo digit */ VAX/vax_cis.c: In function 'NibbleRshift': VAX/vax_cis.c:1553:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (s = sc * 4) { ^ VAX/vax_cis.c: In function 'NibbleLshift': VAX/vax_cis.c:1577:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (s = sc * 4) { ^ In file included from VAX/vax_syslist.c:31:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ In file included from VAX/vax_defs.h:726:0, from VAX/vax_syslist.c:31: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] /* #define CMCTLSIZE (18 << 2) /* 18 registers */ In file included from PDP11/pdp11_rl.c:93:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ In file included from VAX/vax_defs.h:726:0, from PDP11/pdp11_rl.c:93: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] /* #define CMCTLSIZE (18 << 2) /* 18 registers */ PDP11/pdp11_rl.c: In function 'rl_svc': PDP11/pdp11_rl.c:859:1: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (DEBUG_PRS (rl_dev)) ^~ PDP11/pdp11_rl.c:863:5: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' if ((uptr->FNC >= RLCS_READ) && (err == 0)) { /* read (no hdr)? */ ^~ In file included from VAX/vax_octa.c:47:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ VAX/vax_octa.c: In function 'op_octa': VAX/vax_octa.c:190:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = op_tsth (opnd[0])) { /* test for 0 */ ^ VAX/vax_octa.c:201:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = op_tsth (opnd[0])) { /* test for 0 */ ^ In file included from PDP11/pdp11_rq.c:77:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ In file included from VAX/vax_defs.h:726:0, from PDP11/pdp11_rq.c:77: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] /* #define CMCTLSIZE (18 << 2) /* 18 registers */ In file included from PDP11/pdp11_rq.c:99:0: PDP11/pdp11_mscp.h:213:57: warning: "/*" within comment [-Wcomment] /* 5 /* reserved */ PDP11/pdp11_mscp.h:258:57: warning: "/*" within comment [-Wcomment] /* 8 - 15 /* reserved */ PDP11/pdp11_mscp.h:265:57: warning: "/*" within comment [-Wcomment] /* 8 - 15 /* reserved */ PDP11/pdp11_mscp.h:401:57: warning: "/*" within comment [-Wcomment] /* 14 /* reserved */ PDP11/pdp11_mscp.h:402:57: warning: "/*" within comment [-Wcomment] /* 15 /* reserved */ PDP11/pdp11_rq.c: In function 'rq_abo': PDP11/pdp11_rq.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = rq_getucb (cp, lu)) { /* get unit */ ^~~~ PDP11/pdp11_rq.c:1368:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (prv = uptr->pktq) { /* srch pkt q */ ^~~ PDP11/pdp11_rq.c:1369:16: warning: suggest parentheses around assignment used as truth value [-Wparentheses] while (tpkt = cp->pak[prv].link) { /* walk list */ ^~~~ PDP11/pdp11_rq.c: In function 'rq_avl': PDP11/pdp11_rq.c:1396:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ ^~~~ PDP11/pdp11_rq.c: In function 'rq_gus': PDP11/pdp11_rq.c:1450:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ ^~~~ PDP11/pdp11_rq.c: In function 'rq_onl': PDP11/pdp11_rq.c:1485:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ ^~~~ PDP11/pdp11_rq.c: In function 'rq_scc': PDP11/pdp11_rq.c:1523:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cp->htmo = cp->pak[pkt].d[SCC_TMO]) /* set timeout */ ^~ PDP11/pdp11_rq.c: In function 'rq_suc': PDP11/pdp11_rq.c:1550:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ ^~~~ PDP11/pdp11_rq.c: In function 'rq_fmt': PDP11/pdp11_rq.c:1579:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ ^~~~ PDP11/pdp11_rq.c: In function 'rq_rw': PDP11/pdp11_rq.c:1613:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ ^~~~ PDP11/pdp11_rq.c: In function 'rq_rw_valid': PDP11/pdp11_rq.c:1657:57: warning: "/*" within comment [-Wcomment] /* if (lbn & 0xF0000000) return (ST_CMD | I_LBN); /* 'reasonable' lbn? */ PDP11/pdp11_rq.c: In function 'rq_svc': PDP11/pdp11_rq.c:1728:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (abc = tbc - t) { /* any xfer? */ ^~~ PDP11/pdp11_rq.c:1755:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (t = Map_WriteW (ba, tbc, rqxb)) { /* store, nxm? */ ^ PDP11/pdp11_rq.c: In function 'rq_show_unitq': PDP11/pdp11_rq.c:2589:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (pkt = uptr->pktq) { ^~~ PDP11/pdp11_rq.c:2593:22: warning: suggest parentheses around assignment used as truth value [-Wparentheses] } while (pkt = cp->pak[pkt].link); ^~~ PDP11/pdp11_rq.c: In function 'rq_show_ctrl': PDP11/pdp11_rq.c:2620:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (pkt = cp->freq) { ^~~ PDP11/pdp11_rq.c:2633:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (pkt = cp->rspq) { ^~~ PDP11/pdp11_rq.c:2637:22: warning: suggest parentheses around assignment used as truth value [-Wparentheses] } while (pkt = cp->pak[pkt].link); ^~~ In file included from VAX/vax_cmode.c:40:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ VAX/vax_cmode.c: In function 'op_cmode': VAX/vax_cmode.c:624:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sign = ((src & WSIGN)? 1: 0)) ^~~~ In file included from PDP11/pdp11_ts.c:93:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ In file included from VAX/vax_defs.h:726:0, from PDP11/pdp11_ts.c:93: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] /* #define CMCTLSIZE (18 << 2) /* 18 registers */ PDP11/pdp11_ts.c: In function 'ts_spacef': PDP11/pdp11_ts.c:493:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_sprecf (uptr, &tbc)) /* space rec fwd, err? */ ^~ PDP11/pdp11_ts.c: In function 'ts_spacer': PDP11/pdp11_ts.c:536:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_sprecr (uptr, &tbc)) /* space rec rev, err? */ ^~ PDP11/pdp11_ts.c: In function 'ts_readf': PDP11/pdp11_ts.c:572:7: warning: variable 'wa' set but not used [-Wunused-but-set-variable] int32 wa; ^~ In file included from VAX/vax_mmu.c:50:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ PDP11/pdp11_ts.c: In function 'ts_readr': PDP11/pdp11_ts.c:622:32: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] tsba = (cmdadh << 16) | cmdadl + fc; /* buf addr */ ^ PDP11/pdp11_ts.c: In function 'ts_write': PDP11/pdp11_ts.c:669:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrrecf (uptr, tsxb, fc)) /* write rec, err? */ ^~ PDP11/pdp11_ts.c: In function 'ts_wtmk': PDP11/pdp11_ts.c:682:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ ^~ In file included from VAX/vax_sys.c:47:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ In file included from PDP11/pdp11_dz.c:68:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ In file included from VAX/vax_defs.h:726:0, from PDP11/pdp11_dz.c:68: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] /* #define CMCTLSIZE (18 << 2) /* 18 registers */ VAX/vax_sys.c:117:45: warning: missing braces around initializer [-Wmissing-braces] const uint16 drom[NUM_INST][MAX_SPEC + 1] = { ^ VAX/vax_sys.c: In function 'parse_spec': VAX/vax_sys.c:1176:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (tptr = parse_rnum (cptr, &rn)) { /* look for Rn */ ^~~~ In file included from VAX/vax_syscm.c:34:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ In file included from PDP11/pdp11_lp.c:45:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ In file included from VAX/vax_defs.h:726:0, from PDP11/pdp11_lp.c:45: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] /* #define CMCTLSIZE (18 << 2) /* 18 registers */ In file included from PDP11/pdp11_tq.c:68:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ In file included from VAX/vax_defs.h:726:0, from PDP11/pdp11_tq.c:68: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] /* #define CMCTLSIZE (18 << 2) /* 18 registers */ In file included from PDP11/pdp11_tq.c:85:0: PDP11/pdp11_mscp.h:213:57: warning: "/*" within comment [-Wcomment] /* 5 /* reserved */ PDP11/pdp11_mscp.h:258:57: warning: "/*" within comment [-Wcomment] /* 8 - 15 /* reserved */ PDP11/pdp11_mscp.h:265:57: warning: "/*" within comment [-Wcomment] /* 8 - 15 /* reserved */ PDP11/pdp11_mscp.h:401:57: warning: "/*" within comment [-Wcomment] /* 14 /* reserved */ PDP11/pdp11_mscp.h:402:57: warning: "/*" within comment [-Wcomment] /* 15 /* reserved */ PDP11/pdp11_tq.c: In function 'tq_mscp': PDP11/pdp11_tq.c:783:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = tq_getucb (lu)) { /* valid unit? */ ^~~~ PDP11/pdp11_tq.c:789:57: warning: "/*" within comment [-Wcomment] /* if (tq_cmf[cmd] & MD_CDL) /* clr cch lost? */ PDP11/pdp11_tq.c: In function 'tq_abo': PDP11/pdp11_tq.c:861:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = tq_getucb (lu)) { /* get unit */ ^~~~ PDP11/pdp11_tq.c:874:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (prv = uptr->pktq) { /* srch pkt q */ ^~~ PDP11/pdp11_tq.c:875:16: warning: suggest parentheses around assignment used as truth value [-Wparentheses] while (tpkt = tq_pkt[prv].link) { /* walk list */ ^~~~ PDP11/pdp11_tq.c: In function 'tq_avl': PDP11/pdp11_tq.c:903:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = tq_getucb (lu)) { /* unit exist? */ ^~~~ PDP11/pdp11_tq.c: In function 'tq_gus': PDP11/pdp11_tq.c:958:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = tq_getucb (lu)) { /* unit exist? */ ^~~~ PDP11/pdp11_tq.c: In function 'tq_onl': PDP11/pdp11_tq.c:983:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = tq_getucb (lu)) { /* unit exist? */ ^~~~ PDP11/pdp11_tq.c: In function 'tq_scc': PDP11/pdp11_tq.c:1012:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (tq_htmo = tq_pkt[pkt].d[SCC_TMO]) /* set timeout */ ^~~~~~~ PDP11/pdp11_tq.c: In function 'tq_suc': PDP11/pdp11_tq.c:1036:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = tq_getucb (lu)) { /* unit exist? */ ^~~~ PDP11/pdp11_tq.c: In function 'tq_flu': PDP11/pdp11_tq.c:1058:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = tq_getucb (lu)) /* unit exist? */ ^~~~ PDP11/pdp11_tq.c: In function 'tq_erase': PDP11/pdp11_tq.c:1074:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = tq_getucb (lu)) { /* unit exist? */ ^~~~ PDP11/pdp11_tq.c: In function 'tq_wtm': PDP11/pdp11_tq.c:1095:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = tq_getucb (lu)) { /* unit exist? */ ^~~~ PDP11/pdp11_tq.c: In function 'tq_pos': PDP11/pdp11_tq.c:1118:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = tq_getucb (lu)) { /* unit exist? */ ^~~~ PDP11/pdp11_tq.c: In function 'tq_rw': PDP11/pdp11_tq.c:1150:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = tq_getucb (lu)) { /* unit exist? */ ^~~~ PDP11/pdp11_tq.c: In function 'tq_svc': PDP11/pdp11_tq.c:1254:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (t = Map_WriteB (ba, wbc, tqxb)) { /* store, nxm? */ ^ PDP11/pdp11_tq.c:1291:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (t = Map_ReadB (ba, bc, tqxb)) { /* fetch buf, nxm? */ ^ In file included from VAX/vax780_stddev.c:59:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ PDP11/pdp11_tq.c: In function 'tq_show_unitq': PDP11/pdp11_tq.c:2236:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (pkt = uptr->pktq) { ^~~ PDP11/pdp11_tq.c:2240:22: warning: suggest parentheses around assignment used as truth value [-Wparentheses] } while (pkt = tq_pkt[pkt].link); ^~~ PDP11/pdp11_tq.c: In function 'tq_show_ctrl': PDP11/pdp11_tq.c:2265:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (pkt = tq_freq) { ^~~ PDP11/pdp11_tq.c:2278:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (pkt = tq_rspq) { ^~~ PDP11/pdp11_tq.c:2282:22: warning: suggest parentheses around assignment used as truth value [-Wparentheses] } while (pkt = tq_pkt[pkt].link); ^~~ In file included from VAX/vax780_sbi.c:36:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ VAX/vax780_sbi.c:220:1: warning: "/*" within comment [-Wcomment] /* Find highest priority vectorable interrupt */ VAX/vax780_sbi.c: In function 'vax780_boot_parse': VAX/vax780_sbi.c:641:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (slptr = strchr (gbuf, '/')) { /* found slash? */ ^~~~~ VAX/vax780_sbi.c: In function 'build_dib_tab': VAX/vax780_sbi.c:787:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = build_nexus_tab (dptr, dibp)) /* add to dispatch table */ ^ VAX/vax780_sbi.c:791:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = build_mbus_tab (dptr, dibp)) ^ VAX/vax780_sbi.c:795:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = build_ubus_tab (dptr, dibp)) /* add to dispatch tab */ ^ In file included from PDP11/pdp11_xq.h:72:0, from PDP11/pdp11_xq.c:252: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ In file included from VAX/vax_defs.h:726:0, from PDP11/pdp11_xq.h:72, from PDP11/pdp11_xq.c:252: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] /* #define CMCTLSIZE (18 << 2) /* 18 registers */ PDP11/pdp11_xq.c: In function 'xq_process_mop': PDP11/pdp11_xq.c:1086:28: warning: '<<' in boolean context, did you mean '<' ? [-Wint-in-bool-context] address = (meb->add_hi << 16) || (meb->add_mi << 8) || meb->add_lo; ~~~~~~~~~~~~~^~~~~~ PDP11/pdp11_xq.c:1086:51: warning: '<<' in boolean context, did you mean '<' ? [-Wint-in-bool-context] address = (meb->add_hi << 16) || (meb->add_mi << 8) || meb->add_lo; ~~~~~~~~~~~~~^~~~~ PDP11/pdp11_xq.c:1087:28: warning: '<<' in boolean context, did you mean '<' ? [-Wint-in-bool-context] size = (meb->siz_hi << 8) || meb->siz_lo; ~~~~~~~~~~~~~^~~~~ PDP11/pdp11_xq.c:1075:10: warning: variable 'size' set but not used [-Wunused-but-set-variable] uint16 size; ^~~~ PDP11/pdp11_xq.c: In function 'xq_process_setup': PDP11/pdp11_xq.c:1190:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (led = (len & XQ_SETUP_LD) >> 2) { ^~~ In file included from VAX/vax780_mem.c:31:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ VAX/vax780_mem.c:101:19: warning: missing braces around initializer [-Wmissing-braces] DIB mctl0_dib[] = { TR_MCTL0, 0, &mctl_rdreg, &mctl_wrreg, 0 }; ^ VAX/vax780_mem.c:120:19: warning: missing braces around initializer [-Wmissing-braces] DIB mctl1_dib[] = { TR_MCTL1, 0, &mctl_rdreg, &mctl_wrreg, 0 }; ^ PDP11/pdp11_xq.c: In function 'xq_tmrsvc': PDP11/pdp11_xq.c:2534:8: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] if (--xq->var->sanity.timer <= 0) ^ In file included from VAX/vax780_uba.c:34:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ In file included from VAX/vax780_mba.c:31:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ In file included from PDP11/pdp11_ry.c:50:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ In file included from VAX/vax_defs.h:726:0, from PDP11/pdp11_ry.c:50: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] /* #define CMCTLSIZE (18 << 2) /* 18 registers */ In file included from VAX/vax780_fload.c:44:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ In file included from PDP11/pdp11_vh.c:75:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ In file included from VAX/vax_defs.h:726:0, from PDP11/pdp11_vh.c:75: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] /* #define CMCTLSIZE (18 << 2) /* 18 registers */ PDP11/pdp11_vh.c:296:60: warning: "/*" within comment [-Wcomment] /* #define DBG_XMT TMXR_DBG_XMT /* display Transmitted Data */ PDP11/pdp11_vh.c:297:60: warning: "/*" within comment [-Wcomment] /* #define DBG_RCV TMXR_DBG_RCV /* display Received Data */ In file included from VAX/vax780_syslist.c:30:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ In file included from PDP11/pdp11_rl.c:93:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ PDP11/pdp11_rl.c: In function 'rl_svc': PDP11/pdp11_rl.c:859:1: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (DEBUG_PRS (rl_dev)) ^~ PDP11/pdp11_rl.c:863:5: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' if ((uptr->FNC >= RLCS_READ) && (err == 0)) { /* read (no hdr)? */ ^~ In file included from PDP11/pdp11_cr.c:175:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ In file included from VAX/vax_defs.h:726:0, from PDP11/pdp11_cr.c:175: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] /* #define CMCTLSIZE (18 << 2) /* 18 registers */ In file included from PDP11/pdp11_rq.c:77:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ In file included from PDP11/pdp11_rq.c:99:0: PDP11/pdp11_mscp.h:213:57: warning: "/*" within comment [-Wcomment] /* 5 /* reserved */ PDP11/pdp11_mscp.h:258:57: warning: "/*" within comment [-Wcomment] /* 8 - 15 /* reserved */ PDP11/pdp11_mscp.h:265:57: warning: "/*" within comment [-Wcomment] /* 8 - 15 /* reserved */ PDP11/pdp11_mscp.h:401:57: warning: "/*" within comment [-Wcomment] /* 14 /* reserved */ PDP11/pdp11_mscp.h:402:57: warning: "/*" within comment [-Wcomment] /* 15 /* reserved */ PDP11/pdp11_rq.c: In function 'rq_abo': PDP11/pdp11_rq.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = rq_getucb (cp, lu)) { /* get unit */ ^~~~ PDP11/pdp11_rq.c:1368:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (prv = uptr->pktq) { /* srch pkt q */ ^~~ PDP11/pdp11_rq.c:1369:16: warning: suggest parentheses around assignment used as truth value [-Wparentheses] while (tpkt = cp->pak[prv].link) { /* walk list */ ^~~~ PDP11/pdp11_rq.c: In function 'rq_avl': PDP11/pdp11_rq.c:1396:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ ^~~~ PDP11/pdp11_rq.c: In function 'rq_gus': PDP11/pdp11_rq.c:1450:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ ^~~~ PDP11/pdp11_rq.c: In function 'rq_onl': PDP11/pdp11_rq.c:1485:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ ^~~~ PDP11/pdp11_rq.c: In function 'rq_scc': PDP11/pdp11_rq.c:1523:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cp->htmo = cp->pak[pkt].d[SCC_TMO]) /* set timeout */ ^~ PDP11/pdp11_rq.c: In function 'rq_suc': PDP11/pdp11_rq.c:1550:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ ^~~~ PDP11/pdp11_rq.c: In function 'rq_fmt': PDP11/pdp11_rq.c:1579:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ ^~~~ PDP11/pdp11_rq.c: In function 'rq_rw': PDP11/pdp11_rq.c:1613:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ ^~~~ PDP11/pdp11_rq.c: In function 'rq_rw_valid': PDP11/pdp11_rq.c:1657:57: warning: "/*" within comment [-Wcomment] /* if (lbn & 0xF0000000) return (ST_CMD | I_LBN); /* 'reasonable' lbn? */ PDP11/pdp11_rq.c: In function 'rq_svc': PDP11/pdp11_rq.c:1728:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (abc = tbc - t) { /* any xfer? */ ^~~ PDP11/pdp11_rq.c:1755:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (t = Map_WriteW (ba, tbc, rqxb)) { /* store, nxm? */ ^ PDP11/pdp11_rq.c: In function 'rq_show_unitq': PDP11/pdp11_rq.c:2589:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (pkt = uptr->pktq) { ^~~ PDP11/pdp11_rq.c:2593:22: warning: suggest parentheses around assignment used as truth value [-Wparentheses] } while (pkt = cp->pak[pkt].link); ^~~ PDP11/pdp11_rq.c: In function 'rq_show_ctrl': PDP11/pdp11_rq.c:2620:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (pkt = cp->freq) { ^~~ PDP11/pdp11_rq.c:2633:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (pkt = cp->rspq) { ^~~ PDP11/pdp11_rq.c:2637:22: warning: suggest parentheses around assignment used as truth value [-Wparentheses] } while (pkt = cp->pak[pkt].link); ^~~ In file included from PDP11/pdp11_io_lib.c:31:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ In file included from VAX/vax_defs.h:726:0, from PDP11/pdp11_io_lib.c:31: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] /* #define CMCTLSIZE (18 << 2) /* 18 registers */ In file included from scp.c:189:0: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] /* V3.8 revision history sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] /* V3.7 revision history sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] /* V3.6 revision history sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] /* V3.5 revision history sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] /* V3.4 revision history sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] /* V3.3 revision history sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] /* V3.2 revision history sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] /* V3.1 revision history sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] /* V3.0 revision history sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] /* V2.10 revision history sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] /* V2.9 revision history In file included from PDP11/pdp11_ts.c:93:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (np = match_ext (nbuf, "EXE")) /* remove .exe */ ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) /* lookup command */ ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { /* lookup command */ ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ PDP11/pdp11_ts.c: In function 'ts_spacef': PDP11/pdp11_ts.c:493:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_sprecf (uptr, &tbc)) /* space rec fwd, err? */ ^~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) ^~~~~ PDP11/pdp11_ts.c: In function 'ts_spacer': scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ ^~~~ PDP11/pdp11_ts.c:536:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_sprecr (uptr, &tbc)) /* space rec rev, err? */ ^~ PDP11/pdp11_ts.c: In function 'ts_readf': PDP11/pdp11_ts.c:572:7: warning: variable 'wa' set but not used [-Wunused-but-set-variable] int32 wa; ^~ PDP11/pdp11_ts.c: In function 'ts_readr': PDP11/pdp11_ts.c:622:32: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] tsba = (cmdadh << 16) | cmdadl + fc; /* buf addr */ ^ PDP11/pdp11_ts.c: In function 'ts_write': PDP11/pdp11_ts.c:669:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrrecf (uptr, tsxb, fc)) /* write rec, err? */ ^~ scp.c: In function 'show_cmd_fi': PDP11/pdp11_ts.c: In function 'ts_wtmk': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ ^~~~~ PDP11/pdp11_ts.c:682:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ ^~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (shtb, gbuf)) /* global match? */ ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (aptr = strchr (cptr, ';')) { /* ;action? */ ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (portp = strchr (gbuf, ':')) /* x:y? split */ ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (cptr)) { /* exact match? */ ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sptr = strchr (logstr, c)) { /* check for mask */ ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ ^~ In file included from PDP11/pdp11_dz.c:68:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ In file included from PDP11/pdp11_lp.c:45:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ In file included from PDP11/pdp11_tq.c:68:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ In file included from PDP11/pdp11_tq.c:85:0: PDP11/pdp11_mscp.h:213:57: warning: "/*" within comment [-Wcomment] /* 5 /* reserved */ PDP11/pdp11_mscp.h:258:57: warning: "/*" within comment [-Wcomment] /* 8 - 15 /* reserved */ PDP11/pdp11_mscp.h:265:57: warning: "/*" within comment [-Wcomment] /* 8 - 15 /* reserved */ PDP11/pdp11_mscp.h:401:57: warning: "/*" within comment [-Wcomment] /* 14 /* reserved */ PDP11/pdp11_mscp.h:402:57: warning: "/*" within comment [-Wcomment] /* 15 /* reserved */ PDP11/pdp11_tq.c: In function 'tq_mscp': PDP11/pdp11_tq.c:783:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = tq_getucb (lu)) { /* valid unit? */ ^~~~ PDP11/pdp11_tq.c:789:57: warning: "/*" within comment [-Wcomment] /* if (tq_cmf[cmd] & MD_CDL) /* clr cch lost? */ PDP11/pdp11_tq.c: In function 'tq_abo': PDP11/pdp11_tq.c:861:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = tq_getucb (lu)) { /* get unit */ ^~~~ PDP11/pdp11_tq.c:874:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (prv = uptr->pktq) { /* srch pkt q */ ^~~ PDP11/pdp11_tq.c:875:16: warning: suggest parentheses around assignment used as truth value [-Wparentheses] while (tpkt = tq_pkt[prv].link) { /* walk list */ ^~~~ PDP11/pdp11_tq.c: In function 'tq_avl': PDP11/pdp11_tq.c:903:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = tq_getucb (lu)) { /* unit exist? */ ^~~~ PDP11/pdp11_tq.c: In function 'tq_gus': PDP11/pdp11_tq.c:958:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = tq_getucb (lu)) { /* unit exist? */ ^~~~ PDP11/pdp11_tq.c: In function 'tq_onl': PDP11/pdp11_tq.c:983:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = tq_getucb (lu)) { /* unit exist? */ ^~~~ PDP11/pdp11_tq.c: In function 'tq_scc': PDP11/pdp11_tq.c:1012:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (tq_htmo = tq_pkt[pkt].d[SCC_TMO]) /* set timeout */ ^~~~~~~ PDP11/pdp11_tq.c: In function 'tq_suc': PDP11/pdp11_tq.c:1036:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = tq_getucb (lu)) { /* unit exist? */ ^~~~ PDP11/pdp11_tq.c: In function 'tq_flu': PDP11/pdp11_tq.c:1058:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = tq_getucb (lu)) /* unit exist? */ ^~~~ PDP11/pdp11_tq.c: In function 'tq_erase': PDP11/pdp11_tq.c:1074:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = tq_getucb (lu)) { /* unit exist? */ ^~~~ PDP11/pdp11_tq.c: In function 'tq_wtm': PDP11/pdp11_tq.c:1095:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = tq_getucb (lu)) { /* unit exist? */ ^~~~ PDP11/pdp11_tq.c: In function 'tq_pos': PDP11/pdp11_tq.c:1118:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = tq_getucb (lu)) { /* unit exist? */ ^~~~ PDP11/pdp11_tq.c: In function 'tq_rw': PDP11/pdp11_tq.c:1150:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = tq_getucb (lu)) { /* unit exist? */ ^~~~ PDP11/pdp11_tq.c: In function 'tq_svc': PDP11/pdp11_tq.c:1254:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (t = Map_WriteB (ba, wbc, tqxb)) { /* store, nxm? */ ^ PDP11/pdp11_tq.c:1291:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (t = Map_ReadB (ba, bc, tqxb)) { /* fetch buf, nxm? */ ^ PDP11/pdp11_tq.c: In function 'tq_show_unitq': PDP11/pdp11_tq.c:2236:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (pkt = uptr->pktq) { ^~~ PDP11/pdp11_tq.c:2240:22: warning: suggest parentheses around assignment used as truth value [-Wparentheses] } while (pkt = tq_pkt[pkt].link); ^~~ PDP11/pdp11_tq.c: In function 'tq_show_ctrl': PDP11/pdp11_tq.c:2265:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (pkt = tq_freq) { ^~~ PDP11/pdp11_tq.c:2278:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (pkt = tq_rspq) { ^~~ PDP11/pdp11_tq.c:2282:22: warning: suggest parentheses around assignment used as truth value [-Wparentheses] } while (pkt = tq_pkt[pkt].link); ^~~ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_con_tab, gbuf)) ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ ^ In file included from PDP11/pdp11_xu.h:55:0, from PDP11/pdp11_xu.c:100: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ PDP11/pdp11_xu.c: In function 'xu_process_receive': PDP11/pdp11_xu.c:1044:24: warning: "/*" within comment [-Wcomment] /* xu_dump_rxring(xu); /* debug receive ring */ PDP11/pdp11_xu.c: In function 'xu_process_transmit': PDP11/pdp11_xu.c:1216:24: warning: "/*" within comment [-Wcomment] /* xu_dump_txring(xu); /* debug receive ring */ PDP11/pdp11_xu.c: In function 'xu_dump_rxring': PDP11/pdp11_xu.c:1683:12: warning: unused variable 'rstatus' [-Wunused-variable] t_stat rstatus = Map_ReadW (ba, 8, rxhdr); /* get rxring entry[i] */ ^~~~~~~ PDP11/pdp11_xu.c: In function 'xu_dump_txring': PDP11/pdp11_xu.c:1699:12: warning: unused variable 'tstatus' [-Wunused-variable] t_stat tstatus = Map_ReadW (ba, 8, txhdr); /* get rxring entry[i] */ ^~~~~~~ In file included from PDP11/pdp11_ry.c:50:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ In file included from PDP11/pdp11_cr.c:175:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (lp->conn == 0) /* skip if !conn */ ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ ^~~~~~ In file included from PDP11/pdp11_rp.c:58:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ sim_ether.c: In function 'eth_get_nic_hw_addr': sim_ether.c:1336:11: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (f = fopen("NIC.hwaddr", "r")) { ^ sim_ether.c: In function '_eth_writer': sim_ether.c:1522:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] while (request = dev->write_requests) { ^~~~~~~ sim_ether.c: In function 'eth_open': sim_ether.c:1621:8: warning: unused variable 'dev_name' [-Wunused-variable] char dev_name[64] = ""; ^~~~~~~~ sim_ether.c: In function 'eth_close': sim_ether.c:1830:11: warning: suggest parentheses around assignment used as truth value [-Wparentheses] while (buffer = dev->write_buffers) { ^~~~~~ sim_ether.c:1834:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] while (buffer = dev->write_requests) { ^~~~~~ sim_ether.c: In function 'eth_write': sim_ether.c:2087:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (request = dev->write_buffers) ^~~~~~~ At top level: sim_ether.c:2178:1: warning: '_eth_test_multicast_hash' defined but not used [-Wunused-function] _eth_test_multicast_hash() ^~~~~~~~~~~~~~~~~~~~~~~~ In file included from PDP11/pdp11_tu.c:63:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ PDP11/pdp11_tu.c: In function 'tu_svc': PDP11/pdp11_tu.c:650:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ ^~ PDP11/pdp11_tu.c:663:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ ^~ PDP11/pdp11_tu.c:674:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ ^~ PDP11/pdp11_tu.c:690:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdrecf (uptr, xbuf, &tbc, MT_MAXFR)) { /* read fwd */ ^~ PDP11/pdp11_tu.c:742:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrrecf (uptr, xbuf, tbc)) /* write rec, err? */ ^~ PDP11/pdp11_tu.c:754:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdrecr (uptr, xbuf + 4, &tbc, MT_MAXFR)) { /* read rev */ ^~ PDP11/pdp11_tu.c:621:12: warning: variable 'r' set but not used [-Wunused-but-set-variable] t_stat st, r = SCPE_OK; ^ In file included from PDP11/pdp11_hk.c:60:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ PDP11/pdp11_hk.c: In function 'hk_svc': PDP11/pdp11_hk.c:890:21: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (t = Map_ReadW (ba, 2, &comp)) { /* get 1st wd */ ^ PDP11/pdp11_hk.c:898:21: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (t = Map_ReadW (ba, wc << 1, hkxb)) { /* get buf */ ^ PDP11/pdp11_hk.c:918:21: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (t = Map_WriteW (ba, 2, &hkxb[wc - 1])) { ^ PDP11/pdp11_hk.c:924:21: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (t = Map_WriteW (ba, wc << 1, hkxb)) { /* put buf */ ^ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ ^~ In file included from PDP11/pdp11_io_lib.c:31:0: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] /* #define PR_TB 5 /* impossible */ In file included from scp.c:189:0: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] /* V3.8 revision history sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] /* V3.7 revision history sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] /* V3.6 revision history sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] /* V3.5 revision history sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] /* V3.4 revision history sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] /* V3.3 revision history sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] /* V3.2 revision history sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] /* V3.1 revision history sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] /* V3.0 revision history sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] /* V2.10 revision history sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] /* V2.9 revision history scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (np = match_ext (nbuf, "EXE")) /* remove .exe */ ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) /* lookup command */ ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { /* lookup command */ ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (shtb, gbuf)) /* global match? */ ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (aptr = strchr (cptr, ';')) { /* ;action? */ ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (portp = strchr (gbuf, ':')) /* x:y? split */ ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (cptr)) { /* exact match? */ ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sptr = strchr (logstr, c)) { /* check for mask */ ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ ^~ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_con_tab, gbuf)) ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ ^ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (lp->conn == 0) /* skip if !conn */ ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ ^~~~~~ sim_ether.c: In function 'eth_get_nic_hw_addr': sim_ether.c:1336:11: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (f = fopen("NIC.hwaddr", "r")) { ^ sim_ether.c: In function '_eth_writer': sim_ether.c:1522:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] while (request = dev->write_requests) { ^~~~~~~ sim_ether.c: In function 'eth_open': sim_ether.c:1621:8: warning: unused variable 'dev_name' [-Wunused-variable] char dev_name[64] = ""; ^~~~~~~~ sim_ether.c: In function 'eth_close': sim_ether.c:1830:11: warning: suggest parentheses around assignment used as truth value [-Wparentheses] while (buffer = dev->write_buffers) { ^~~~~~ sim_ether.c:1834:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] while (buffer = dev->write_requests) { ^~~~~~ sim_ether.c: In function 'eth_write': sim_ether.c:2087:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (request = dev->write_buffers) ^~~~~~~ At top level: sim_ether.c:2178:1: warning: '_eth_test_multicast_hash' defined but not used [-Wunused-function] _eth_test_multicast_hash() ^~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ ^~ gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 NOVA/nova_sys.c NOVA/nova_cpu.c NOVA/nova_dkp.c NOVA/nova_dsk.c NOVA/nova_lp.c NOVA/nova_mta.c NOVA/nova_plt.c NOVA/nova_pt.c NOVA/nova_clk.c NOVA/nova_tt.c NOVA/nova_tt1.c NOVA/nova_qty.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I NOVA -o BIN/nova -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program NOVA/nova_cpu.c: In function 'sim_instr': NOVA/nova_cpu.c:246:28: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] if ( ((x) <= AUTO_TOP) && ((x) >= AUTO_INC) ) \ ^ NOVA/nova_cpu.c:463:16: note: in expansion of macro 'IND_STEP' indf = IND_STEP (MA); ^~~~~~~~ NOVA/nova_cpu.c:246:28: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] if ( ((x) <= AUTO_TOP) && ((x) >= AUTO_INC) ) \ ^ NOVA/nova_cpu.c:468:20: note: in expansion of macro 'IND_STEP' indf = IND_STEP (MA); /* indirect loop */ ^~~~~~~~ NOVA/nova_cpu.c:246:28: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] if ( ((x) <= AUTO_TOP) && ((x) >= AUTO_INC) ) \ ^ NOVA/nova_cpu.c:625:24: note: in expansion of macro 'IND_STEP' indf = IND_STEP (MA); ^~~~~~~~ NOVA/nova_cpu.c:246:28: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] if ( ((x) <= AUTO_TOP) && ((x) >= AUTO_INC) ) \ ^ NOVA/nova_cpu.c:630:28: note: in expansion of macro 'IND_STEP' indf = IND_STEP (MA); /* resolve indirect */ ^~~~~~~~ NOVA/nova_cpu.c:983:13: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if ( pulse == iopP ) ^~ NOVA/nova_cpu.c:992:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' break ; ^~~~~ NOVA/nova_dkp.c: In function 'dkp_svc': NOVA/nova_dkp.c:912:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (err = ferror (uptr->fileref)) ^~~ NOVA/nova_dkp.c:928:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (err = ferror (uptr->fileref)) ^~~ NOVA/nova_mta.c: In function 'mta_svc': NOVA/nova_mta.c:415:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrrecf (uptr, mtxb, tbc)) { /* write rec, err? */ ^~ NOVA/nova_mta.c:424:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ ^~ NOVA/nova_mta.c:438:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ ^~ NOVA/nova_mta.c:450:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ ^~ NOVA/nova_mta.c: In function 'mta_upddsta': NOVA/nova_mta.c:496:57: warning: "/*" within comment [-Wcomment] /* if (mta_ep) { /* if polling */ NOVA/nova_mta.c:497:57: warning: "/*" within comment [-Wcomment] /* u = uptr - mta_dev.units; /* unit num */ NOVA/nova_mta.c:499:1: warning: "/*" within comment [-Wcomment] /* set polling interupt... NOVA/nova_mta.c:500:1: warning: "/*" within comment [-Wcomment] /* } */ NOVA/nova_tt1.c: In function 'tti1_svc': NOVA/nova_tt1.c:187:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (temp = tmxr_getc_ln (&tt1_ldsc)) { /* get char */ ^~~~ NOVA/nova_qty.c: In function 'qty_update_status': NOVA/nova_qty.c:225:58: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define QTY_LINE_BITS( line, bits ) qty_status[ (line) ] & bits ^ NOVA/nova_qty.c:441:26: note: in expansion of macro 'QTY_LINE_BITS' status = QTY_LINE_BITS( line, QTY_S_DMASK ) | QTY_S_RI ; ^~~~~~~~~~~~~ NOVA/nova_qty.c: In function 'qty_common_svc': NOVA/nova_qty.c:606:8: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] if ( (newln >= 0) && qty_mdm ) ^ NOVA/nova_qty.c: In function 'alm': NOVA/nova_qty.c:994:12: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] if ( alm_line < qty_max ) ^ In file included from scp.c:189:0: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] /* V3.8 revision history sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] /* V3.7 revision history sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] /* V3.6 revision history sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] /* V3.5 revision history sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] /* V3.4 revision history sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] /* V3.3 revision history sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] /* V3.2 revision history sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] /* V3.1 revision history sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] /* V3.0 revision history sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] /* V2.10 revision history sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] /* V2.9 revision history scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (np = match_ext (nbuf, "EXE")) /* remove .exe */ ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) /* lookup command */ ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { /* lookup command */ ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (shtb, gbuf)) /* global match? */ ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (aptr = strchr (cptr, ';')) { /* ;action? */ ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (portp = strchr (gbuf, ':')) /* x:y? split */ ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (cptr)) { /* exact match? */ ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sptr = strchr (logstr, c)) { /* check for mask */ ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ ^~ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_con_tab, gbuf)) ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ ^ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (lp->conn == 0) /* skip if !conn */ ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ ^~~~~~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ ^~ gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 NOVA/eclipse_cpu.c NOVA/eclipse_tt.c NOVA/nova_sys.c NOVA/nova_dkp.c NOVA/nova_dsk.c NOVA/nova_lp.c NOVA/nova_mta.c NOVA/nova_plt.c NOVA/nova_pt.c NOVA/nova_clk.c NOVA/nova_tt1.c NOVA/nova_qty.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I NOVA -DECLIPSE -o BIN/eclipse -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program NOVA/eclipse_cpu.c: In function 'sim_instr': NOVA/eclipse_cpu.c:747:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = sim_process_event ()) ^~~~~~ gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 HP2100/hp2100_stddev.c HP2100/hp2100_dp.c HP2100/hp2100_dq.c HP2100/hp2100_dr.c HP2100/hp2100_lps.c HP2100/hp2100_ms.c HP2100/hp2100_mt.c HP2100/hp2100_mux.c HP2100/hp2100_cpu.c HP2100/hp2100_fp.c HP2100/hp2100_sys.c HP2100/hp2100_lpt.c HP2100/hp2100_ipl.c HP2100/hp2100_ds.c HP2100/hp2100_cpu0.c HP2100/hp2100_cpu1.c HP2100/hp2100_cpu2.c HP2100/hp2100_cpu3.c HP2100/hp2100_cpu4.c HP2100/hp2100_cpu5.c HP2100/hp2100_cpu6.c HP2100/hp2100_cpu7.c HP2100/hp2100_fp1.c HP2100/hp2100_baci.c HP2100/hp2100_mpx.c HP2100/hp2100_pif.c HP2100/hp2100_di.c HP2100/hp2100_di_da.c HP2100/hp_disclib.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -DHAVE_INT64 -I HP2100 -o BIN/hp2100 -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program NOVA/nova_dkp.c: In function 'dkp_svc': NOVA/nova_dkp.c:912:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (err = ferror (uptr->fileref)) ^~~ NOVA/nova_dkp.c:928:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (err = ferror (uptr->fileref)) ^~~ In file included from HP2100/hp2100_stddev.c:113:0: HP2100/hp2100_stddev.c: In function 'ptrio': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_stddev.c:434:13: note: in expansion of macro 'setstdSKF' setstdSKF (ptr); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_stddev.c:434:13: note: in expansion of macro 'setstdSKF' setstdSKF (ptr); ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_stddev.c:439:13: note: in expansion of macro 'setstdSKF' setstdSKF (ptr); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_stddev.c:439:13: note: in expansion of macro 'setstdSKF' setstdSKF (ptr); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_stddev.c:444:25: note: in expansion of macro 'IORETURN' stat_data = IORETURN (SCPE_OK, ptr_unit.buf); /* merge in return status */ ^~~~~~~~ HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); ^~~~~~ HP2100/hp2100_stddev.c:466:13: note: in expansion of macro 'setstdPRL' setstdPRL (ptr); /* set standard PRL signal */ ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); ^~~~~~ HP2100/hp2100_stddev.c:467:13: note: in expansion of macro 'setstdIRQ' setstdIRQ (ptr); /* set standard IRQ signal */ ^~~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:436:25: note: in expansion of macro 'setSRQ' #define setstdSRQ(N) setSRQ (dibptr->select_code, N.flag); ^~~~~~ HP2100/hp2100_stddev.c:468:13: note: in expansion of macro 'setstdSRQ' setstdSRQ (ptr); /* set standard SRQ signal */ ^~~~~~~~~ HP2100/hp2100_stddev.c: In function 'ptpio': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_stddev.c:651:13: note: in expansion of macro 'setstdSKF' setstdSKF (ptp); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_stddev.c:651:13: note: in expansion of macro 'setstdSKF' setstdSKF (ptp); ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_stddev.c:656:13: note: in expansion of macro 'setstdSKF' setstdSKF (ptp); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_stddev.c:656:13: note: in expansion of macro 'setstdSKF' setstdSKF (ptp); ^~~~~~~~~ HP2100/hp2100_defs.h:360:46: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_stddev.c:662:29: note: in expansion of macro 'IORETURN' stat_data = IORETURN (SCPE_OK, PTP_LOW); /* report as out of tape */ ^~~~~~~~ HP2100/hp2100_defs.h:360:46: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_stddev.c:664:29: note: in expansion of macro 'IORETURN' stat_data = IORETURN (SCPE_OK, 0); ^~~~~~~~ HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); ^~~~~~ HP2100/hp2100_stddev.c:692:13: note: in expansion of macro 'setstdPRL' setstdPRL (ptp); /* set standard PRL signal */ ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); ^~~~~~ HP2100/hp2100_stddev.c:693:13: note: in expansion of macro 'setstdIRQ' setstdIRQ (ptp); /* set standard IRQ signal */ ^~~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:436:25: note: in expansion of macro 'setSRQ' #define setstdSRQ(N) setSRQ (dibptr->select_code, N.flag); ^~~~~~ HP2100/hp2100_stddev.c:694:13: note: in expansion of macro 'setstdSRQ' setstdSRQ (ptp); /* set standard SRQ signal */ ^~~~~~~~~ HP2100/hp2100_stddev.c: In function 'ttyio': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_stddev.c:767:13: note: in expansion of macro 'setstdSKF' setstdSKF (tty); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_stddev.c:767:13: note: in expansion of macro 'setstdSKF' setstdSKF (tty); ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_stddev.c:772:13: note: in expansion of macro 'setstdSKF' setstdSKF (tty); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_stddev.c:772:13: note: in expansion of macro 'setstdSKF' setstdSKF (tty); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_stddev.c:782:25: note: in expansion of macro 'IORETURN' stat_data = IORETURN (SCPE_OK, data); /* merge in return status */ ^~~~~~~~ HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); ^~~~~~ HP2100/hp2100_stddev.c:819:13: note: in expansion of macro 'setstdPRL' setstdPRL (tty); /* set standard PRL signal */ ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); ^~~~~~ HP2100/hp2100_stddev.c:820:13: note: in expansion of macro 'setstdIRQ' setstdIRQ (tty); /* set standard IRQ signal */ ^~~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:436:25: note: in expansion of macro 'setSRQ' #define setstdSRQ(N) setSRQ (dibptr->select_code, N.flag); ^~~~~~ HP2100/hp2100_stddev.c:821:13: note: in expansion of macro 'setstdSRQ' setstdSRQ (tty); /* set standard SRQ signal */ ^~~~~~~~~ HP2100/hp2100_stddev.c: In function 'tto_out': HP2100/hp2100_stddev.c:945:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = sim_putchar_s (c)) return r; /* output char */ ^ In file included from HP2100/hp2100_stddev.c:113:0: HP2100/hp2100_stddev.c: In function 'clkio': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_stddev.c:1071:13: note: in expansion of macro 'setstdSKF' setstdSKF (clk); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_stddev.c:1071:13: note: in expansion of macro 'setstdSKF' setstdSKF (clk); ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_stddev.c:1076:13: note: in expansion of macro 'setstdSKF' setstdSKF (clk); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_stddev.c:1076:13: note: in expansion of macro 'setstdSKF' setstdSKF (clk); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_stddev.c:1081:25: note: in expansion of macro 'IORETURN' stat_data = IORETURN (SCPE_OK, clk_error); /* merge in return status */ ^~~~~~~~ HP2100/hp2100_stddev.c:1115:20: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] if ((clk_unit.flags & UNIT_DIAG) == 0) /* calibrated? */ ^ In file included from HP2100/hp2100_stddev.c:113:0: HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); ^~~~~~ HP2100/hp2100_stddev.c:1129:13: note: in expansion of macro 'setstdPRL' setstdPRL (clk); /* set standard PRL signal */ ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); ^~~~~~ HP2100/hp2100_stddev.c:1130:13: note: in expansion of macro 'setstdIRQ' setstdIRQ (clk); /* set standard IRQ signal */ ^~~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:436:25: note: in expansion of macro 'setSRQ' #define setstdSRQ(N) setSRQ (dibptr->select_code, N.flag); ^~~~~~ HP2100/hp2100_stddev.c:1131:13: note: in expansion of macro 'setstdSRQ' setstdSRQ (clk); /* set standard SRQ signal */ ^~~~~~~~~ HP2100/hp2100_dp.c:193:57: warning: "/*" within comment [-Wcomment] /* 0000200 /* unused */ In file included from HP2100/hp2100_dp.c:122:0: HP2100/hp2100_dp.c: In function 'dpdio': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_dp.c:433:13: note: in expansion of macro 'setstdSKF' setstdSKF (dpd); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_dp.c:433:13: note: in expansion of macro 'setstdSKF' setstdSKF (dpd); ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_dp.c:438:13: note: in expansion of macro 'setstdSKF' setstdSKF (dpd); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_dp.c:438:13: note: in expansion of macro 'setstdSKF' setstdSKF (dpd); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_dp.c:443:25: note: in expansion of macro 'IORETURN' stat_data = IORETURN (SCPE_OK, dpd_ibuf); /* merge in return status */ ^~~~~~~~ HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); ^~~~~~ HP2100/hp2100_dp.c:497:17: note: in expansion of macro 'setstdPRL' setstdPRL (dpd); /* set standard PRL signal */ ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); ^~~~~~ HP2100/hp2100_dp.c:498:17: note: in expansion of macro 'setstdIRQ' setstdIRQ (dpd); /* set standard IRQ signal */ ^~~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:436:25: note: in expansion of macro 'setSRQ' #define setstdSRQ(N) setSRQ (dibptr->select_code, N.flag); ^~~~~~ HP2100/hp2100_dp.c:501:13: note: in expansion of macro 'setstdSRQ' setstdSRQ (dpd); /* set standard SRQ signal */ ^~~~~~~~~ HP2100/hp2100_dp.c: In function 'dpcio': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_dp.c:563:13: note: in expansion of macro 'setstdSKF' setstdSKF (dpc); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_dp.c:563:13: note: in expansion of macro 'setstdSKF' setstdSKF (dpc); ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_dp.c:568:13: note: in expansion of macro 'setstdSKF' setstdSKF (dpc); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_dp.c:568:13: note: in expansion of macro 'setstdSKF' setstdSKF (dpc); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_dp.c:578:25: note: in expansion of macro 'IORETURN' stat_data = IORETURN (SCPE_OK, data); /* merge in return status */ ^~~~~~~~ HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); ^~~~~~ HP2100/hp2100_dp.c:658:13: note: in expansion of macro 'setstdPRL' setstdPRL (dpc); /* set standard PRL signal */ ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); ^~~~~~ HP2100/hp2100_dp.c:659:13: note: in expansion of macro 'setstdIRQ' setstdIRQ (dpc); /* set standard IRQ signal */ ^~~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:436:25: note: in expansion of macro 'setSRQ' #define setstdSRQ(N) setSRQ (dibptr->select_code, N.flag); ^~~~~~ HP2100/hp2100_dp.c:660:13: note: in expansion of macro 'setstdSRQ' setstdSRQ (dpc); /* set standard SRQ signal */ ^~~~~~~~~ HP2100/hp2100_dp.c: In function 'dp_goc': HP2100/hp2100_dp.c:697:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (t = sim_is_active (&dpc_unit[drv])) { /* still seeking? */ ^ HP2100/hp2100_dp.c: In function 'dpc_svc': HP2100/hp2100_dp.c:909:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (err = fseek (uptr->fileref, da * sizeof (int16), ^~~ HP2100/hp2100_dp.c:912:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (err = ferror (uptr->fileref)) break; ^~~ HP2100/hp2100_dp.c:956:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (err = fseek (uptr->fileref, da * sizeof (int16), ^~~ HP2100/hp2100_dp.c:959:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (err = ferror (uptr->fileref)) break; /* error? */ ^~~ HP2100/hp2100_dq.c:103:57: warning: "/*" within comment [-Wcomment] /* 000 /* unused */ In file included from HP2100/hp2100_dq.c:80:0: HP2100/hp2100_dq.c: In function 'dqdio': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_dq.c:329:13: note: in expansion of macro 'setstdSKF' setstdSKF (dqd); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_dq.c:329:13: note: in expansion of macro 'setstdSKF' setstdSKF (dqd); ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_dq.c:334:13: note: in expansion of macro 'setstdSKF' setstdSKF (dqd); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_dq.c:334:13: note: in expansion of macro 'setstdSKF' setstdSKF (dqd); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_dq.c:339:25: note: in expansion of macro 'IORETURN' stat_data = IORETURN (SCPE_OK, dqd_ibuf); /* merge in return status */ ^~~~~~~~ HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); ^~~~~~ HP2100/hp2100_dq.c:377:13: note: in expansion of macro 'setstdPRL' setstdPRL (dqd); /* set standard PRL signal */ ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); ^~~~~~ HP2100/hp2100_dq.c:378:13: note: in expansion of macro 'setstdIRQ' setstdIRQ (dqd); /* set standard IRQ signal */ ^~~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:436:25: note: in expansion of macro 'setSRQ' #define setstdSRQ(N) setSRQ (dibptr->select_code, N.flag); ^~~~~~ HP2100/hp2100_dq.c:379:13: note: in expansion of macro 'setstdSRQ' setstdSRQ (dqd); /* set standard SRQ signal */ ^~~~~~~~~ HP2100/hp2100_dq.c: In function 'dqcio': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_dq.c:431:13: note: in expansion of macro 'setstdSKF' setstdSKF (dqc); ^~~~~~~~~ NOVA/nova_mta.c: In function 'mta_svc': NOVA/nova_mta.c:415:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrrecf (uptr, mtxb, tbc)) { /* write rec, err? */ ^~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_dq.c:431:13: note: in expansion of macro 'setstdSKF' setstdSKF (dqc); ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_dq.c:436:13: note: in expansion of macro 'setstdSKF' setstdSKF (dqc); ^~~~~~~~~ NOVA/nova_mta.c:424:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ ^~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_dq.c:436:13: note: in expansion of macro 'setstdSKF' setstdSKF (dqc); ^~~~~~~~~ HP2100/hp2100_defs.h:360:46: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_dq.c:441:25: note: in expansion of macro 'IORETURN' stat_data = IORETURN (SCPE_OK, 0); /* no data */ ^~~~~~~~ NOVA/nova_mta.c:438:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ ^~ NOVA/nova_mta.c:450:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ ^~ HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); ^~~~~~ HP2100/hp2100_dq.c:496:13: note: in expansion of macro 'setstdPRL' setstdPRL (dqc); /* set standard PRL signal */ ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); ^~~~~~ HP2100/hp2100_dq.c:497:13: note: in expansion of macro 'setstdIRQ' setstdIRQ (dqc); /* set standard IRQ signal */ ^~~~~~~~~ NOVA/nova_mta.c: In function 'mta_upddsta': NOVA/nova_mta.c:496:57: warning: "/*" within comment [-Wcomment] /* if (mta_ep) { /* if polling */ NOVA/nova_mta.c:497:57: warning: "/*" within comment [-Wcomment] /* u = uptr - mta_dev.units; /* unit num */ NOVA/nova_mta.c:499:1: warning: "/*" within comment [-Wcomment] /* set polling interupt... HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:436:25: note: in expansion of macro 'setSRQ' #define setstdSRQ(N) setSRQ (dibptr->select_code, N.flag); ^~~~~~ HP2100/hp2100_dq.c:498:13: note: in expansion of macro 'setstdSRQ' setstdSRQ (dqc); /* set standard SRQ signal */ ^~~~~~~~~ NOVA/nova_mta.c:500:1: warning: "/*" within comment [-Wcomment] /* } */ HP2100/hp2100_dq.c: In function 'dq_goc': HP2100/hp2100_dq.c:533:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (t = sim_is_active (&dqc_unit[drv])) { /* still seeking? */ ^ HP2100/hp2100_dq.c: In function 'dqc_svc': HP2100/hp2100_dq.c:743:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (err = fseek (uptr->fileref, da * sizeof (int16), ^~~ HP2100/hp2100_dq.c:746:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (err = ferror (uptr->fileref)) break; ^~~ HP2100/hp2100_dq.c:789:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (err = fseek (uptr->fileref, da * sizeof (int16), ^~~ HP2100/hp2100_dq.c:792:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (err = ferror (uptr->fileref)) break; ^~~ In file included from HP2100/hp2100_dr.c:107:0: HP2100/hp2100_dr.c: In function 'drdio': HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_dr.c:360:25: note: in expansion of macro 'IORETURN' stat_data = IORETURN (SCPE_OK, drd_ibuf); /* merge in return status */ ^~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:436:25: note: in expansion of macro 'setSRQ' #define setstdSRQ(N) setSRQ (dibptr->select_code, N.flag); ^~~~~~ HP2100/hp2100_dr.c:400:13: note: in expansion of macro 'setstdSRQ' setstdSRQ (drd); /* set SRQ signal */ ^~~~~~~~~ HP2100/hp2100_dr.c: In function 'drcio': HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_dr.c:458:17: note: in expansion of macro 'setSKF' setSKF (!(CALC_SCP (sim_gtime()))); /* skip if nearing end of sector */ ^~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_dr.c:464:17: note: in expansion of macro 'setSKF' setSKF (!sim_is_active (&drd_unit[TMR_ORG])); /* skip if origin seen */ ^~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_dr.c:486:25: note: in expansion of macro 'IORETURN' stat_data = IORETURN (SCPE_OK, data); /* merge in return status */ ^~~~~~~~ In file included from HP2100/hp2100_lps.c:135:0: HP2100/hp2100_lps.c: In function 'lpsio': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_lps.c:313:13: note: in expansion of macro 'setstdSKF' setstdSKF (lps); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_lps.c:313:13: note: in expansion of macro 'setstdSKF' setstdSKF (lps); ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_lps.c:318:13: note: in expansion of macro 'setstdSKF' setstdSKF (lps); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_lps.c:318:13: note: in expansion of macro 'setstdSKF' setstdSKF (lps); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_lps.c:337:25: note: in expansion of macro 'IORETURN' stat_data = IORETURN (SCPE_OK, lps_sta); /* diag, rtn status */ ^~~~~~~~ HP2100/hp2100_lps.c:375:20: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] if (!(signal_set & ioCLC)) /* CLC not asserted simultaneously? */ ^ In file included from HP2100/hp2100_lps.c:135:0: HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); ^~~~~~ HP2100/hp2100_lps.c:430:13: note: in expansion of macro 'setstdPRL' setstdPRL (lps); /* set standard PRL signal */ ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); ^~~~~~ HP2100/hp2100_lps.c:431:13: note: in expansion of macro 'setstdIRQ' setstdIRQ (lps); /* set standard IRQ signal */ ^~~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:436:25: note: in expansion of macro 'setSRQ' #define setstdSRQ(N) setSRQ (dibptr->select_code, N.flag); ^~~~~~ HP2100/hp2100_lps.c:432:13: note: in expansion of macro 'setstdSRQ' setstdSRQ (lps); /* set standard SRQ signal */ ^~~~~~~~~ In file included from HP2100/hp2100_ms.c:79:0: HP2100/hp2100_ms.c: In function 'msdio': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_ms.c:403:13: note: in expansion of macro 'setstdSKF' setstdSKF (msd); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_ms.c:403:13: note: in expansion of macro 'setstdSKF' setstdSKF (msd); ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_ms.c:407:13: note: in expansion of macro 'setstdSKF' setstdSKF (msd); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_ms.c:407:13: note: in expansion of macro 'setstdSKF' setstdSKF (msd); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_ms.c:411:25: note: in expansion of macro 'IORETURN' stat_data = IORETURN (SCPE_OK, msd_buf); /* merge in return status */ ^~~~~~~~ HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); ^~~~~~ HP2100/hp2100_ms.c:438:13: note: in expansion of macro 'setstdPRL' setstdPRL (msd); /* set standard PRL signal */ ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); ^~~~~~ HP2100/hp2100_ms.c:439:13: note: in expansion of macro 'setstdIRQ' setstdIRQ (msd); /* set standard IRQ signal */ ^~~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:436:25: note: in expansion of macro 'setSRQ' #define setstdSRQ(N) setSRQ (dibptr->select_code, N.flag); ^~~~~~ HP2100/hp2100_ms.c:440:13: note: in expansion of macro 'setstdSRQ' setstdSRQ (msd); /* set standard SRQ signal */ ^~~~~~~~~ HP2100/hp2100_ms.c: In function 'mscio': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_ms.c:507:13: note: in expansion of macro 'setstdSKF' setstdSKF (msc); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_ms.c:507:13: note: in expansion of macro 'setstdSKF' setstdSKF (msc); ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_ms.c:512:13: note: in expansion of macro 'setstdSKF' setstdSKF (msc); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_ms.c:512:13: note: in expansion of macro 'setstdSKF' setstdSKF (msc); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_ms.c:545:25: note: in expansion of macro 'IORETURN' stat_data = IORETURN (SCPE_OK, data); /* merge in return status */ ^~~~~~~~ HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); ^~~~~~ HP2100/hp2100_ms.c:649:13: note: in expansion of macro 'setstdPRL' setstdPRL (msc); /* set standard PRL signal */ ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); ^~~~~~ HP2100/hp2100_ms.c:650:13: note: in expansion of macro 'setstdIRQ' setstdIRQ (msc); /* set standard IRQ signal */ ^~~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:436:25: note: in expansion of macro 'setSRQ' #define setstdSRQ(N) setSRQ (dibptr->select_code, N.flag); ^~~~~~ HP2100/hp2100_ms.c:651:13: note: in expansion of macro 'setstdSRQ' setstdSRQ (msc); /* set standard SRQ signal */ ^~~~~~~~~ HP2100/hp2100_ms.c: In function 'msc_svc': HP2100/hp2100_ms.c:740:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = ms_write_gap (uptr)) { /* write initial gap; error? */ ^~ HP2100/hp2100_ms.c:750:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ ^~ HP2100/hp2100_ms.c:756:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_sprecf (uptr, &tbc)) /* space rec fwd, err? */ ^~ HP2100/hp2100_ms.c:764:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_sprecr (uptr, &tbc)) /* space rec rev, err? */ ^~ HP2100/hp2100_ms.c:834:21: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = ms_write_gap (uptr)) { /* write initial gap; error? */ ^~ HP2100/hp2100_ms.c:858:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrrecf (uptr, msxb, ms_ptr)) { /* write, err? */ ^~ HP2100/hp2100_ms.c: In function 'ms_write_gap': HP2100/hp2100_ms.c:897:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrgap (uptr, gap_len, tape_bpi)) /* write gap */ ^~ HP2100/hp2100_ms.c: In function 'ms_clear': HP2100/hp2100_ms.c:977:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrrecf (uptr, msxb, ms_ptr | MTR_ERF)) ^~ NOVA/nova_tt1.c: In function 'tti1_svc': NOVA/nova_tt1.c:187:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (temp = tmxr_getc_ln (&tt1_ldsc)) { /* get char */ ^~~~ In file included from HP2100/hp2100_mt.c:83:0: HP2100/hp2100_mt.c: In function 'mtdio': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_mt.c:277:13: note: in expansion of macro 'setstdSKF' setstdSKF (mtd); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_mt.c:277:13: note: in expansion of macro 'setstdSKF' setstdSKF (mtd); ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_mt.c:281:13: note: in expansion of macro 'setstdSKF' setstdSKF (mtd); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_mt.c:281:13: note: in expansion of macro 'setstdSKF' setstdSKF (mtd); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_mt.c:285:25: note: in expansion of macro 'IORETURN' stat_data = IORETURN (SCPE_OK, mtc_unit.buf); /* merge in return status */ ^~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:436:25: note: in expansion of macro 'setSRQ' #define setstdSRQ(N) setSRQ (dibptr->select_code, N.flag); ^~~~~~ HP2100/hp2100_mt.c:303:13: note: in expansion of macro 'setstdSRQ' setstdSRQ (mtd); /* set standard SRQ signal */ ^~~~~~~~~ HP2100/hp2100_mt.c: In function 'mtcio': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_mt.c:364:13: note: in expansion of macro 'setstdSKF' setstdSKF (mtc); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_mt.c:364:13: note: in expansion of macro 'setstdSKF' setstdSKF (mtc); ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_mt.c:369:13: note: in expansion of macro 'setstdSKF' setstdSKF (mtc); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_mt.c:369:13: note: in expansion of macro 'setstdSKF' setstdSKF (mtc); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_mt.c:386:25: note: in expansion of macro 'IORETURN' stat_data = IORETURN (SCPE_OK, data); /* merge in return status */ ^~~~~~~~ HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); ^~~~~~ HP2100/hp2100_mt.c:446:13: note: in expansion of macro 'setstdPRL' setstdPRL (mtc); /* set standard PRL signal */ ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); ^~~~~~ HP2100/hp2100_mt.c:447:13: note: in expansion of macro 'setstdIRQ' setstdIRQ (mtc); /* set standard IRQ signal */ ^~~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:436:25: note: in expansion of macro 'setSRQ' #define setstdSRQ(N) setSRQ (dibptr->select_code, N.flag); ^~~~~~ HP2100/hp2100_mt.c:448:13: note: in expansion of macro 'setstdSRQ' setstdSRQ (mtc); /* set standard SRQ signal */ ^~~~~~~~~ HP2100/hp2100_mt.c: In function 'mtc_svc': HP2100/hp2100_mt.c:498:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ ^~ HP2100/hp2100_mt.c:507:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_sprecf (uptr, &tbc)) /* space rec fwd, err? */ ^~ HP2100/hp2100_mt.c:512:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_sprecr (uptr, &tbc)) /* space rec rev, err? */ ^~ HP2100/hp2100_mt.c:561:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrrecf (uptr, mtxb, mt_ptr)) { /* write, err? */ ^~ NOVA/nova_qty.c: In function 'qty_update_status': HP2100/hp2100_mt.c: In function 'mt_clear': NOVA/nova_qty.c:225:58: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define QTY_LINE_BITS( line, bits ) qty_status[ (line) ] & bits ^ NOVA/nova_qty.c:441:26: note: in expansion of macro 'QTY_LINE_BITS' status = QTY_LINE_BITS( line, QTY_S_DMASK ) | QTY_S_RI ; ^~~~~~~~~~~~~ HP2100/hp2100_mt.c:630:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrrecf (&mtc_unit, mtxb, mt_ptr | MTR_ERF)) ^~ NOVA/nova_qty.c: In function 'qty_common_svc': NOVA/nova_qty.c:606:8: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] if ( (newln >= 0) && qty_mdm ) ^ NOVA/nova_qty.c: In function 'alm': NOVA/nova_qty.c:994:12: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] if ( alm_line < qty_max ) ^ In file included from scp.c:189:0: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] /* V3.8 revision history sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] /* V3.7 revision history sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] /* V3.6 revision history sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] /* V3.5 revision history sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] /* V3.4 revision history sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] /* V3.3 revision history sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] /* V3.2 revision history sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] /* V3.1 revision history sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] /* V3.0 revision history sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] /* V2.10 revision history sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] /* V2.9 revision history scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (np = match_ext (nbuf, "EXE")) /* remove .exe */ ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) /* lookup command */ ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { /* lookup command */ ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (shtb, gbuf)) /* global match? */ ^~~~~ In file included from HP2100/hp2100_mux.c:137:0: HP2100/hp2100_mux.c: In function 'muxlio': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_mux.c:633:13: note: in expansion of macro 'setstdSKF' setstdSKF (muxl); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_mux.c:633:13: note: in expansion of macro 'setstdSKF' setstdSKF (muxl); ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_mux.c:638:13: note: in expansion of macro 'setstdSKF' setstdSKF (muxl); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_mux.c:638:13: note: in expansion of macro 'setstdSKF' setstdSKF (muxl); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_mux.c:643:25: note: in expansion of macro 'IORETURN' stat_data = IORETURN (SCPE_OK, muxl_ibuf); /* merge in return status */ ^~~~~~~~ HP2100/hp2100_mux.c:653:16: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] if (DEBUG_PRI (muxu_dev, DEB_CPU)) ^ HP2100/hp2100_mux.c:711:43: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] muxl_obuf & ~OTL_PAR | ^ In file included from HP2100/hp2100_mux.c:137:0: HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); ^~~~~~ HP2100/hp2100_mux.c:757:13: note: in expansion of macro 'setstdPRL' setstdPRL (muxl); /* set standard PRL signal */ ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); ^~~~~~ HP2100/hp2100_mux.c:758:13: note: in expansion of macro 'setstdIRQ' setstdIRQ (muxl); /* set standard IRQ signal */ ^~~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:436:25: note: in expansion of macro 'setSRQ' #define setstdSRQ(N) setSRQ (dibptr->select_code, N.flag); ^~~~~~ HP2100/hp2100_mux.c:759:13: note: in expansion of macro 'setstdSRQ' setstdSRQ (muxl); /* set standard SRQ signal */ ^~~~~~~~~ HP2100/hp2100_mux.c: In function 'muxuio': HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_mux.c:803:25: note: in expansion of macro 'IORETURN' stat_data = IORETURN (SCPE_OK, muxu_ibuf); /* merge in return status */ ^~~~~~~~ HP2100/hp2100_mux.c: In function 'muxcio': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_mux.c:870:13: note: in expansion of macro 'setstdSKF' setstdSKF (muxc); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_mux.c:870:13: note: in expansion of macro 'setstdSKF' setstdSKF (muxc); ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_mux.c:875:13: note: in expansion of macro 'setstdSKF' setstdSKF (muxc); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_mux.c:875:13: note: in expansion of macro 'setstdSKF' setstdSKF (muxc); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_mux.c:890:25: note: in expansion of macro 'IORETURN' stat_data = IORETURN (SCPE_OK, data); /* merge in return status */ ^~~~~~~~ HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); ^~~~~~ HP2100/hp2100_mux.c:954:13: note: in expansion of macro 'setstdPRL' setstdPRL (muxc); /* set standard PRL signal */ ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); ^~~~~~ HP2100/hp2100_mux.c:955:13: note: in expansion of macro 'setstdIRQ' setstdIRQ (muxc); /* set standard IRQ signal */ ^~~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:436:25: note: in expansion of macro 'setSRQ' #define setstdSRQ(N) setSRQ (dibptr->select_code, N.flag); ^~~~~~ HP2100/hp2100_mux.c:956:13: note: in expansion of macro 'setstdSRQ' setstdSRQ (muxc); /* set standard SRQ signal */ ^~~~~~~~~ HP2100/hp2100_mux.c: In function 'mux_receive': HP2100/hp2100_mux.c:1110:12: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] if (DEBUG_PRI (muxu_dev, DEB_XFER)) ^ scp.c: In function 'ssh_break': HP2100/hp2100_mux.c: In function 'mux_data_int': HP2100/hp2100_mux.c:1163:25: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] mux_rbuf[i] & LIL_CHAR | ^ scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (aptr = strchr (cptr, ';')) { /* ;action? */ ^~~~ HP2100/hp2100_mux.c:1179:25: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] mux_rbuf[i] & LIL_CHAR | ^ HP2100/hp2100_mux.c:1195:25: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] mux_rbuf[i] & LIL_CHAR | ^ HP2100/hp2100_mux.c: In function 'mux_ctrl_int': HP2100/hp2100_mux.c:241:26: warning: '<<' in boolean context, did you mean '<' ? [-Wint-in-bool-context] #define LIC_TSTI(ch) (((muxc_lia[ch] ^ muxc_ota[ch]) & \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ((muxc_ota[ch] & (OTC_ES2|OTC_ES1)) >> OTC_V_ES)) \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ << LIC_V_I) ^~~~~~~~~~~ HP2100/hp2100_mux.c:1230:9: note: in expansion of macro 'LIC_TSTI' if (LIC_TSTI (muxc_chan)) { /* status change? */ ^~~~~~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (portp = strchr (gbuf, ':')) /* x:y? split */ ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (cptr)) { /* exact match? */ ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sptr = strchr (logstr, c)) { /* check for mask */ ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ ^~ HP2100/hp2100_cpu.c: In function 'sim_instr': HP2100/hp2100_cpu.c:1057:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] for (i = 0; dptr = sim_devices [i]; i++) { /* loop thru dev */ ^~~~ HP2100/hp2100_cpu.c:1470:56: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if (((PC == err_PC) || /* RTE through RTE-IVB */ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ((PC == (err_PC - 1)) && /* RTE-6/VM */ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ((ReadW (PC) & I_MRG) == I_ISZ))) && /* RTE jump target */ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ (mp_fence == CLEAR) && (M [xeqt] == 0) && /* RTE idle indications */ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ (M [tbg] == clk_dib.select_code) || /* RTE verification */ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from HP2100/hp2100_cpu.c:444:0: HP2100/hp2100_cpu.c: In function 'iogrp': HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_cpu.c:1984:38: note: in expansion of macro 'IORETURN' ioreturn = devdisp (dev, signal_set, IORETURN (SCPE_OK, iodata)); /* dispatch I/O signal */ ^~~~~~~~ HP2100/hp2100_cpu.c: In function 'devdisp': HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_cpu.c:2018:40: note: in expansion of macro 'IORETURN' IORETURN (SCPE_OK, data)); ^~~~~~~~ HP2100/hp2100_cpu.c: In function 'calc_int': HP2100/hp2100_cpu.c:2156:9: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] else if (req_grant [1]) /* device in upper half */ ^ In file included from HP2100/hp2100_cpu.c:444:0: HP2100/hp2100_cpu.c: In function 'cpuio': HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_cpu.c:2750:13: note: in expansion of macro 'setSKF' setSKF (!ion); /* skip if interrupt system is off */ ^~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_cpu.c:2754:13: note: in expansion of macro 'setSKF' setSKF (ion); /* skip if interupt system is on */ ^~~~~~ HP2100/hp2100_defs.h:360:46: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_cpu.c:2758:25: note: in expansion of macro 'IORETURN' stat_data = IORETURN (SCPE_OK, 0); /* returns 0 */ ^~~~~~~~ HP2100/hp2100_cpu.c: In function 'ovflio': HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_cpu.c:2840:13: note: in expansion of macro 'setSKF' setSKF (!O); /* skip if overflow is clear */ ^~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_cpu.c:2844:13: note: in expansion of macro 'setSKF' setSKF (O); /* skip if overflow is set */ ^~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_cpu.c:2848:25: note: in expansion of macro 'IORETURN' stat_data = IORETURN (SCPE_OK, SR); /* read switch register value */ ^~~~~~~~ HP2100/hp2100_cpu.c: In function 'pwrfio': HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_cpu.c:2899:25: note: in expansion of macro 'IORETURN' stat_data = IORETURN (SCPE_OK, intaddr); /* input CIR value */ ^~~~~~~~ HP2100/hp2100_cpu.c: In function 'protio': HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_cpu.c:2992:13: note: in expansion of macro 'setSKF' setSKF (!mp_mevff); /* skip if MP interrupt */ ^~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_cpu.c:2996:13: note: in expansion of macro 'setSKF' setSKF (mp_mevff); /* skip if DMS interrupt */ ^~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_cpu.c:3000:25: note: in expansion of macro 'IORETURN' stat_data = IORETURN (SCPE_OK, mp_viol); /* read MP violation register */ ^~~~~~~~ HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_cpu.c:3024:13: note: in expansion of macro 'setPRL' setPRL (PRO, !mp_flag); /* set PRL signal */ ^~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_cpu.c:3025:13: note: in expansion of macro 'setIRQ' setIRQ (PRO, mp_flag); /* set IRQ signal */ ^~~~~~ HP2100/hp2100_cpu.c: In function 'dmasio': HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_cpu.c:3098:25: note: in expansion of macro 'IORETURN' stat_data = IORETURN (SCPE_OK, data); /* merge status and remaining word count */ ^~~~~~~~ HP2100/hp2100_cpu.c: In function 'dmapio': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_cpu.c:3183:13: note: in expansion of macro 'setstdSKF' setstdSKF (dma [ch]); /* skip if transfer in progress */ ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_cpu.c:3183:13: note: in expansion of macro 'setstdSKF' setstdSKF (dma [ch]); /* skip if transfer in progress */ ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_cpu.c:3187:13: note: in expansion of macro 'setstdSKF' setstdSKF (dma [ch]); /* skip if transfer is complete */ ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_cpu.c:3187:13: note: in expansion of macro 'setstdSKF' setstdSKF (dma [ch]); /* skip if transfer is complete */ ^~~~~~~~~ HP2100/hp2100_defs.h:360:46: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_cpu.c:3192:29: note: in expansion of macro 'IORETURN' stat_data = IORETURN (SCPE_OK, DMASK); /* return all ones */ ^~~~~~~~ HP2100/hp2100_defs.h:360:46: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_cpu.c:3194:29: note: in expansion of macro 'IORETURN' stat_data = IORETURN (SCPE_OK, 0); /* return all zeros */ ^~~~~~~~ HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); ^~~~~~ HP2100/hp2100_cpu.c:3227:13: note: in expansion of macro 'setstdPRL' setstdPRL (dma [ch]); ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); ^~~~~~ HP2100/hp2100_cpu.c:3228:13: note: in expansion of macro 'setstdIRQ' setstdIRQ (dma [ch]); ^~~~~~~~~ HP2100/hp2100_cpu.c: In function 'nullio': HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_cpu.c:3292:8: note: in expansion of macro 'IORETURN' return IORETURN (stop_dev, data); /* flag missing device */ ^~~~~~~~ HP2100/hp2100_cpu.c: In function 'dma_cycle': HP2100/hp2100_cpu.c:3354:11: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if (bytes && !even || dma [ch].cw3 != DMASK) { /* normal cycle? */ ~~~~~~^~~~~~~~ In file included from HP2100/hp2100_cpu.c:444:0: HP2100/hp2100_defs.h:360:46: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_cpu.c:3380:25: note: in expansion of macro 'IORETURN' IORETURN (SCPE_OK, 0)); ^~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_cpu.c:3419:25: note: in expansion of macro 'IORETURN' IORETURN (SCPE_OK, data)); ^~~~~~~~ HP2100/hp2100_cpu.c:3425:47: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] dma [ch].cw2 = input | (dma [ch].cw2 + 1) & VAMASK; /* increment address */ HP2100/hp2100_cpu.c: In function 'dev_conflict': HP2100/hp2100_cpu.c:3614:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] for (i = 0; dptr = sim_devices[i]; i++) { ^~~~ HP2100/hp2100_cpu.c:3632:25: warning: suggest parentheses around assignment used as truth value [-Wparentheses] for (j = 0; dptr = sim_devices[j]; j++) { ^~~~ HP2100/hp2100_cpu.c: In function 'cpu_set_model': HP2100/hp2100_cpu.c:3733:33: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] cpu_unit.flags = cpu_unit.flags & ~UNIT_OPTS | /* set typical features */ HP2100/hp2100_cpu.c:3794:4: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] if (result == SCPE_OK) /* memory change OK? */ ^ HP2100/hp2100_cpu.c: In function 'cpu_show_model': HP2100/hp2100_cpu.c:3813:4: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] if (UNIT_CPU_FAMILY == UNIT_FAMILY_21XX) /* valid only for 21xx */ ^ HP2100/hp2100_cpu.c: In function 'cpu_set_opt': HP2100/hp2100_cpu.c:3849:9: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] else if (UNIT_CPU_MODEL == UNIT_1000_F) ^ HP2100/hp2100_sys.c: In function 'parse_sym': HP2100/hp2100_sys.c:611:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (k = (strcmp (gbuf, "C") == 0)) { /* C specified? */ ^ HP2100/hp2100_sys.c:615:18: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (k = (strcmp (gbuf, "Z") == 0)) { /* Z specified? */ ^ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_con_tab, gbuf)) ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ ^ In file included from HP2100/hp2100_lpt.c:76:0: HP2100/hp2100_lpt.c: In function 'lptio': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_lpt.c:190:13: note: in expansion of macro 'setstdSKF' setstdSKF (lpt); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_lpt.c:190:13: note: in expansion of macro 'setstdSKF' setstdSKF (lpt); ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_lpt.c:195:13: note: in expansion of macro 'setstdSKF' setstdSKF (lpt); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_lpt.c:195:13: note: in expansion of macro 'setstdSKF' setstdSKF (lpt); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_lpt.c:216:25: note: in expansion of macro 'IORETURN' stat_data = IORETURN (SCPE_OK, data); /* merge in return status */ ^~~~~~~~ HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); ^~~~~~ HP2100/hp2100_lpt.c:244:13: note: in expansion of macro 'setstdPRL' setstdPRL (lpt); /* set standard PRL signal */ ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); ^~~~~~ HP2100/hp2100_lpt.c:245:13: note: in expansion of macro 'setstdIRQ' setstdIRQ (lpt); /* set standard IRQ signal */ ^~~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:436:25: note: in expansion of macro 'setSRQ' #define setstdSRQ(N) setSRQ (dibptr->select_code, N.flag); ^~~~~~ HP2100/hp2100_lpt.c:246:13: note: in expansion of macro 'setstdSRQ' setstdSRQ (lpt); /* set standard SRQ signal */ ^~~~~~~~~ In file included from HP2100/hp2100_ipl.c:67:0: HP2100/hp2100_ipl.c: In function 'iplio': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_ipl.c:332:13: note: in expansion of macro 'setstdSKF' setstdSKF (ipl [card]); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_ipl.c:332:13: note: in expansion of macro 'setstdSKF' setstdSKF (ipl [card]); ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_ipl.c:337:13: note: in expansion of macro 'setstdSKF' setstdSKF (ipl [card]); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_ipl.c:337:13: note: in expansion of macro 'setstdSKF' setstdSKF (ipl [card]); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_ipl.c:342:25: note: in expansion of macro 'IORETURN' stat_data = IORETURN (SCPE_OK, uptr->IBUF); /* get return data */ ^~~~~~~~ HP2100/hp2100_defs.h:360:46: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_ipl.c:385:28: note: in expansion of macro 'IORETURN' return IORETURN (STOP_NOCONN, 0); /* lose */ ^~~~~~~~ HP2100/hp2100_defs.h:360:46: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_ipl.c:398:28: note: in expansion of macro 'IORETURN' return IORETURN (SCPE_IOERR, 0); ^~~~~~~~ HP2100/hp2100_defs.h:360:46: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_ipl.c:413:24: note: in expansion of macro 'IORETURN' return IORETURN (SCPE_UNATT, 0); /* lose */ ^~~~~~~~ HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); ^~~~~~ HP2100/hp2100_ipl.c:433:13: note: in expansion of macro 'setstdPRL' setstdPRL (ipl [card]); ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); ^~~~~~ HP2100/hp2100_ipl.c:434:13: note: in expansion of macro 'setstdIRQ' setstdIRQ (ipl [card]); ^~~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:436:25: note: in expansion of macro 'setSRQ' #define setstdSRQ(N) setSRQ (dibptr->select_code, N.flag); ^~~~~~ HP2100/hp2100_ipl.c:435:13: note: in expansion of macro 'setstdSRQ' setstdSRQ (ipl [card]); ^~~~~~~~~ HP2100/hp2100_ipl.c: In function 'ipl_attach': HP2100/hp2100_ipl.c:626:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (t = ipl_check_conn (uptr)) /* established? */ ^ In file included from HP2100/hp2100_ds.c:118:0: HP2100/hp2100_ds.c: In function 'ds_io': HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_ds.c:459:13: note: in expansion of macro 'setSKF' setSKF (mac_cntlr.state != cntlr_busy); /* skip if the controller is not busy */ ^~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_ds.c:464:13: note: in expansion of macro 'setstdSKF' setstdSKF (ds); /* assert SKF if the flag is set */ ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_ds.c:464:13: note: in expansion of macro 'setstdSKF' setstdSKF (ds); /* assert SKF if the flag is set */ ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_ds.c:470:25: note: in expansion of macro 'IORETURN' stat_data = IORETURN (SCPE_OK, data); /* merge in the return status */ ^~~~~~~~ HP2100/hp2100_defs.h:360:46: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_ds.c:543:29: note: in expansion of macro 'IORETURN' stat_data = IORETURN (status, 0); /* return the status from the controller */ ^~~~~~~~ HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); ^~~~~~ HP2100/hp2100_ds.c:580:13: note: in expansion of macro 'setstdPRL' setstdPRL (ds); /* set the standard PRL signal */ ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); ^~~~~~ HP2100/hp2100_ds.c:581:13: note: in expansion of macro 'setstdIRQ' setstdIRQ (ds); /* set the standard IRQ signal */ ^~~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_ds.c:582:13: note: in expansion of macro 'setSRQ' setSRQ (dibptr->select_code, ds.srq); /* set the SRQ signal */ ^~~~~~ HP2100/hp2100_ds.c: In function 'ds_boot': HP2100/hp2100_ds.c:1172:9: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] SR = SR & (IBL_OPT | IBL_DS_HEAD) /* set S to a reasonable value */ ~~~^~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_cpu0.c: In function 'cpu_ds': HP2100/hp2100_cpu0.c:133:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = cpu_ops (op_ds[entry], op, intrq)) /* get instruction operands */ ^~~~~~ HP2100/hp2100_cpu0.c: In function 'cpu_user': HP2100/hp2100_cpu0.c:194:57: warning: "/*" within comment [-Wcomment] /* case 000: /* 105000-105017 */ HP2100/hp2100_cpu0.c:195:57: warning: "/*" within comment [-Wcomment] /* return cpu_user_00 (IR, intrq); /* uncomment to handle instruction */ HP2100/hp2100_cpu0.c:197:57: warning: "/*" within comment [-Wcomment] /* case 001: /* 105020-105037 */ HP2100/hp2100_cpu0.c:198:57: warning: "/*" within comment [-Wcomment] /* return cpu_user_01 (IR, intrq); /* uncomment to handle instruction */ HP2100/hp2100_cpu0.c:200:57: warning: "/*" within comment [-Wcomment] /* case 0nn: /* other cases as needed */ HP2100/hp2100_cpu0.c:201:57: warning: "/*" within comment [-Wcomment] /* return cpu_user_nn (IR, intrq); /* uncomment to handle instruction */ HP2100/hp2100_cpu0.c:206:57: warning: "/*" within comment [-Wcomment] /* case 021: /* 10x420-10x437 */ HP2100/hp2100_cpu0.c:207:57: warning: "/*" within comment [-Wcomment] /* return cpu_user_21 (IR, intrq); /* uncomment to handle instruction */ HP2100/hp2100_cpu0.c:209:57: warning: "/*" within comment [-Wcomment] /* case 0nn: /* other cases as needed */ HP2100/hp2100_cpu0.c:210:57: warning: "/*" within comment [-Wcomment] /* return cpu_user_nn (IR, intrq); /* uncomment to handle instruction */ HP2100/hp2100_cpu0.c: In function 'cpu_user_20': HP2100/hp2100_cpu0.c:247:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = cpu_ops (op_user_20 [entry], op, intrq)) /* get instruction operands */ ^~~~~~ HP2100/hp2100_cpu0.c:253:57: warning: "/*" within comment [-Wcomment] /* break; /* uncomment to handle instruction */ HP2100/hp2100_cpu0.c:256:57: warning: "/*" within comment [-Wcomment] /* break; /* uncomment to handle instruction */ HP2100/hp2100_cpu0.c:258:57: warning: "/*" within comment [-Wcomment] /* case 0nn: /* other cases as needed */ HP2100/hp2100_cpu0.c:259:57: warning: "/*" within comment [-Wcomment] /* break; /* uncomment to handle instruction */ HP2100/hp2100_cpu1.c: In function 'cpu_eau': HP2100/hp2100_cpu1.c:196:4: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] if ((cpu_unit.flags & UNIT_EAU) == 0) /* option installed? */ ^ HP2100/hp2100_cpu1.c:248:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = cpu_ops (OP_K, op, intrq)) /* get operand */ ^~~~~~ HP2100/hp2100_cpu1.c:265:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = cpu_ops (OP_K, op, intrq)) /* get operand */ ^~~~~~ HP2100/hp2100_cpu1.c:267:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (rs = qs = BR & SIGN) { /* save divd sign, neg? */ ^~ HP2100/hp2100_cpu1.c:320:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = cpu_ops (OP_D, op, intrq)) /* get operand */ ^~~~~~ HP2100/hp2100_cpu1.c:327:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = cpu_ops (OP_A, op, intrq)) /* get operand */ ^~~~~~ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (lp->conn == 0) /* skip if !conn */ ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ ^~~~~~ HP2100/hp2100_cpu1.c: In function 'cpu_ops': HP2100/hp2100_cpu1.c:737:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = resolve (ReadW (PC), &MA, irq)) /* resolve indirects */ ^~~~~~ HP2100/hp2100_cpu2.c: In function 'cpu_dms': HP2100/hp2100_cpu2.c:247:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = cpu_ops (op_dms[entry], op, intrq)) /* get instruction operands */ ^~~~~~ HP2100/hp2100_cpu2.c: In function 'cpu_eig': HP2100/hp2100_cpu2.c:613:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = cpu_ops (op_eig[entry], op, intrq)) /* get instruction operands */ ^~~~~~ HP2100/hp2100_cpu2.c: In function 'cpu_iop': HP2100/hp2100_cpu2.c:992:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = cpu_ops (op_iop[entry], op, intrq)) /* get instruction operands */ ^~~~~~ HP2100/hp2100_cpu3.c: In function 'cpu_ffp': HP2100/hp2100_cpu3.c:189:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = cpu_ops (op_ffp_e[entry], op, intrq)) /* get instruction operands */ ^~~~~~ HP2100/hp2100_cpu3.c:197:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = cpu_ops (op_ffp_f[entry], op, intrq)) /* get instruction operands */ ^~~~~~ HP2100/hp2100_cpu3.c:420:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = resolve (da, &MA, intrq)) { /* resolve indirects */ ^~~~~~ HP2100/hp2100_cpu3.c:438:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = cpu_ops (OP_KK, op2, intrq)) { /* get 1st, 2nd ranges */ ^~~~~~ HP2100/hp2100_cpu3.c:464:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = resolve (MA, &MA, intrq)) { /* resolve indirect */ ^~~~~~ HP2100/hp2100_cpu3.c: In function 'cpu_dbi': HP2100/hp2100_cpu3.c:647:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = cpu_ops (op_dbi[entry], op, intrq)) /* get instruction operands */ ^~~~~~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ ^~ HP2100/hp2100_cpu4.c: In function 'cpu_fpp': HP2100/hp2100_cpu4.c:264:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = cpu_ops (op_fpp[entry], op, intrq)) /* get instruction operands */ ^~~~~~ HP2100/hp2100_cpu4.c: In function 'cpu_sis': HP2100/hp2100_cpu4.c:603:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = cpu_ops (op_sis[entry], op, intrq)) /* get instruction operands */ ^~~~~~ HP2100/hp2100_cpu5.c: In function 'cpu_rte_vma': HP2100/hp2100_cpu5.c:653:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = cpu_ops (pattern, op, intrq)) /* get instruction operands */ ^~~~~~ HP2100/hp2100_cpu5.c: In function 'cpu_rte_ema': HP2100/hp2100_cpu5.c:1364:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = cpu_ops (pattern, op, intrq)) /* get instruction operands */ ^~~~~~ HP2100/hp2100_cpu6.c: In function 'cpu_save_regs': HP2100/hp2100_cpu6.c:251:34: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] WriteW (save_area + 3, (E << 15) & SIGN | O & 1); /* save E and O */ HP2100/hp2100_cpu6.c: In function 'cpu_rte_os': HP2100/hp2100_cpu6.c:397:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = cpu_ops (pattern, op, intrq)) /* get instruction operands */ ^~~~~~ HP2100/hp2100_cpu6.c:400:40: warning: suggest parentheses around '&&' within '||' [-Wparentheses] tbg_tick = tbg_tick || (IR == 0105357) && iotrap; /* set TBG interrupting flag */ ~~~~~~~~~~~~~~~~^~~~~~~~~ HP2100/hp2100_cpu6.c:547:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = resolve (ma, &ma, intrq)) { /* resolve indirect */ ^~~~~~ HP2100/hp2100_cpu6.c:552:36: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] WriteW (ma, ReadW (ma) & ~I_DEVMASK | AR); /* set SC into instruction */ HP2100/hp2100_cpu6.c:623:26: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((E == 0) && (key == op[0].word) || /* for E = 0, key = arg? */ ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_cpu6.c:713:21: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = resolve (ma, &ma, intrq)) { /* resolve indirect */ ^~~~~~ HP2100/hp2100_cpu7.c: In function 'cpu_vis': HP2100/hp2100_cpu7.c:388:1: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (pattern != OP_N) ^~ HP2100/hp2100_cpu7.c:394:5: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' if (reason = cpu_ops (pattern, op, intrq)) /* get instruction operands */ ^~ HP2100/hp2100_cpu7.c:394:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = cpu_ops (pattern, op, intrq)) /* get instruction operands */ ^~~~~~ HP2100/hp2100_cpu7.c: In function 'cpu_signal': HP2100/hp2100_cpu7.c:656:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = cpu_ops (op_signal[entry], op, intrq)) /* get instruction operands */ ^~~~~~ HP2100/hp2100_fp1.c: In function 'fp_prec': HP2100/hp2100_fp1.c:1148:4: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] if (result) /* want result precision? */ ^ In file included from HP2100/hp2100_baci.c:156:0: HP2100/hp2100_baci.c: In function 'baci_io': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_baci.c:579:13: note: in expansion of macro 'setstdSKF' setstdSKF (baci); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_baci.c:579:13: note: in expansion of macro 'setstdSKF' setstdSKF (baci); ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_baci.c:584:13: note: in expansion of macro 'setstdSKF' setstdSKF (baci); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_baci.c:584:13: note: in expansion of macro 'setstdSKF' setstdSKF (baci); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_baci.c:608:25: note: in expansion of macro 'IORETURN' stat_data = IORETURN (SCPE_OK, data); /* merge in return status */ ^~~~~~~~ HP2100/hp2100_baci.c:673:28: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] if (baci_term.flags & UNIT_DIAG) /* diagnostic mode? */ ^ In file included from HP2100/hp2100_baci.c:156:0: HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); ^~~~~~ HP2100/hp2100_baci.c:745:13: note: in expansion of macro 'setstdPRL' setstdPRL (baci); /* set standard PRL signal */ ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); ^~~~~~ HP2100/hp2100_baci.c:746:13: note: in expansion of macro 'setstdIRQ' setstdIRQ (baci); /* set standard IRQ signal */ ^~~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_baci.c:747:13: note: in expansion of macro 'setSRQ' setSRQ (dibptr->select_code, baci.srq); /* set SRQ signal */ ^~~~~~ HP2100/hp2100_baci.c: In function 'master_reset': HP2100/hp2100_baci.c:1110:31: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] baci_status = baci_status & ~IN_MODEM | IN_SPARE; /* clear loopback status, set BA */ ^ HP2100/hp2100_baci.c: In function 'update_status': HP2100/hp2100_baci.c:1160:28: warning: suggest parentheses around '&&' within '||' [-Wparentheses] !(baci_icw & OUT_DCPC) && /* or under program control */ ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ (baci_status & IN_FIFOIRQ) || /* and FIFO interrupt? */ ~~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_baci.c:1163:30: warning: suggest parentheses around '&&' within '||' [-Wparentheses] (IO_MODE == RECV) && /* or receiving */ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ (baci_edsiw & OUT_ENCM) && /* and char mode */ ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ (baci_fget != baci_fput)) { /* and FIFO not empty? */ ~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_baci.c:1188:24: warning: suggest parentheses around '&&' within '||' [-Wparentheses] ((IO_MODE == XMIT) && (baci_fcount < 128) || /* and xmit and room in FIFO */ ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_baci.c: In function 'fifo_put': HP2100/hp2100_baci.c:1384:4: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] if (DEBUG_PRI (baci_dev, DEB_BUF)) ^ HP2100/hp2100_baci.c: In function 'clock_uart': HP2100/hp2100_baci.c:1450:8: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] if ((baci_uart_clk & 017) == 0) /* end of a bit? */ ^ HP2100/hp2100_baci.c:1476:35: warning: suggest parentheses around '&&' within '||' [-Wparentheses] (baci_uart_clk == 8) && /* or last stop bit */ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ (baci_cfcw & OUT_STBITS) && /* and extra stop bit requested */ ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ((baci_cfcw & OUT_CHARSIZE) == 0))) { /* and 1.5 stop bits used? */ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from HP2100/hp2100_mpx.c:141:0: HP2100/hp2100_mpx.c: In function 'mpx_io': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_mpx.c:839:13: note: in expansion of macro 'setstdSKF' setstdSKF (mpx); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_mpx.c:839:13: note: in expansion of macro 'setstdSKF' setstdSKF (mpx); ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_mpx.c:844:13: note: in expansion of macro 'setstdSKF' setstdSKF (mpx); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_mpx.c:844:13: note: in expansion of macro 'setstdSKF' setstdSKF (mpx); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_mpx.c:849:25: note: in expansion of macro 'IORETURN' stat_data = IORETURN (SCPE_OK, mpx_ibuf); /* return info */ ^~~~~~~~ HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); ^~~~~~ HP2100/hp2100_mpx.c:935:13: note: in expansion of macro 'setstdPRL' setstdPRL (mpx); /* set standard PRL signal */ ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); ^~~~~~ HP2100/hp2100_mpx.c:936:13: note: in expansion of macro 'setstdIRQ' setstdIRQ (mpx); /* set standard IRQ signal */ ^~~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:436:25: note: in expansion of macro 'setSRQ' #define setstdSRQ(N) setSRQ (dibptr->select_code, N.flag); ^~~~~~ HP2100/hp2100_mpx.c:937:13: note: in expansion of macro 'setstdSRQ' setstdSRQ (mpx); /* set standard SRQ signal */ ^~~~~~~~~ HP2100/hp2100_mpx.c: In function 'exec_command': HP2100/hp2100_mpx.c:1120:9: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (port >= 0) /* port defined? */ ^~ HP2100/hp2100_mpx.c:1123:13: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' if ((buf_avail (ioread, port) == 1) && /* one buffer remaining? */ ^~ HP2100/hp2100_mpx.c:1156:12: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] if (port >= 0) /* port defined? */ ^ HP2100/hp2100_mpx.c:1211:9: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (port >= 0) /* port defined? */ ^~ HP2100/hp2100_mpx.c:1214:13: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' if (mpx_param & FC_FORCE_XON) /* force XON? */ ^~ HP2100/hp2100_mpx.c:1254:12: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] if (port >= 0) /* port defined? */ ^ HP2100/hp2100_mpx.c: In function 'mpx_cntl_svc': HP2100/hp2100_mpx.c:1379:39: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] mpx_ibuf = mpx_uicode & UI_REASON | mpx_portkey; /* report UI reason and port key */ ^ HP2100/hp2100_mpx.c: In function 'mpx_line_svc': HP2100/hp2100_mpx.c:1787:12: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] if (rt & RT_ENAB_EDIT) /* editing enabled? */ ^ HP2100/hp2100_mpx.c:1929:41: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((buf_avail (iowrite, port) < 2) && /* more to transmit? */ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ !(mpx_flags [port] & (FL_WAITACK | FL_XOFF)) || /* and transmission not suspended */ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_mpx.c: In function 'buf_get': HP2100/hp2100_mpx.c:2476:4: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] if (DEBUG_PRI (mpx_dev, DEB_BUF)) ^ At top level: HP2100/hp2100_mpx.c:447:11: warning: 'FL_DO_ENQACK_V' defined but not used [-Wunused-const-variable=] BITFIELD (FL_DO_ENQACK, 0, 1) /* Port flags: do ENQ/ACK handshake */ ^ HP2100/hp2100_mpx.c:167:25: note: in definition of macro 'BITFIELD' static const uint32 NAME ## _V = STARTBIT; \ ^~~~ HP2100/hp2100_mpx.c:446:11: warning: 'FL_WAITACK_V' defined but not used [-Wunused-const-variable=] BITFIELD (FL_WAITACK, 1, 1) /* Port flags: ENQ sent, waiting for ACK */ ^ HP2100/hp2100_mpx.c:167:25: note: in definition of macro 'BITFIELD' static const uint32 NAME ## _V = STARTBIT; \ ^~~~ HP2100/hp2100_mpx.c:445:11: warning: 'FL_WREMPT_V' defined but not used [-Wunused-const-variable=] BITFIELD (FL_WREMPT, 2, 1) /* Port flags: write buffer is emptying */ ^ HP2100/hp2100_mpx.c:167:25: note: in definition of macro 'BITFIELD' static const uint32 NAME ## _V = STARTBIT; \ ^~~~ HP2100/hp2100_mpx.c:444:11: warning: 'FL_WRFILL_V' defined but not used [-Wunused-const-variable=] BITFIELD (FL_WRFILL, 3, 1) /* Port flags: write buffer is filling */ ^ HP2100/hp2100_mpx.c:167:25: note: in definition of macro 'BITFIELD' static const uint32 NAME ## _V = STARTBIT; \ ^~~~ HP2100/hp2100_mpx.c:443:11: warning: 'FL_RDEMPT_V' defined but not used [-Wunused-const-variable=] BITFIELD (FL_RDEMPT, 4, 1) /* Port flags: read buffer is emptying */ ^ HP2100/hp2100_mpx.c:167:25: note: in definition of macro 'BITFIELD' static const uint32 NAME ## _V = STARTBIT; \ ^~~~ HP2100/hp2100_mpx.c:442:11: warning: 'FL_RDFILL_V' defined but not used [-Wunused-const-variable=] BITFIELD (FL_RDFILL, 5, 1) /* Port flags: read buffer is filling */ ^ HP2100/hp2100_mpx.c:167:25: note: in definition of macro 'BITFIELD' static const uint32 NAME ## _V = STARTBIT; \ ^~~~ HP2100/hp2100_mpx.c:441:11: warning: 'FL_RDOVFLOW_V' defined but not used [-Wunused-const-variable=] BITFIELD (FL_RDOVFLOW, 6, 1) /* Port flags: read buffers overflowed */ ^ HP2100/hp2100_mpx.c:167:25: note: in definition of macro 'BITFIELD' static const uint32 NAME ## _V = STARTBIT; \ ^~~~ HP2100/hp2100_mpx.c:440:11: warning: 'FL_WANTBUF_V' defined but not used [-Wunused-const-variable=] BITFIELD (FL_WANTBUF, 7, 1) /* Port flags: UI / write buffer available */ ^ HP2100/hp2100_mpx.c:167:25: note: in definition of macro 'BITFIELD' static const uint32 NAME ## _V = STARTBIT; \ ^~~~ HP2100/hp2100_mpx.c:439:11: warning: 'FL_HAVEBUF_V' defined but not used [-Wunused-const-variable=] BITFIELD (FL_HAVEBUF, 8, 1) /* Port flags: UI / read buffer available */ ^ HP2100/hp2100_mpx.c:167:25: note: in definition of macro 'BITFIELD' static const uint32 NAME ## _V = STARTBIT; \ ^~~~ HP2100/hp2100_mpx.c:438:11: warning: 'FL_BREAK_V' defined but not used [-Wunused-const-variable=] BITFIELD (FL_BREAK, 9, 1) /* Port flags: UI / break detected */ ^ HP2100/hp2100_mpx.c:167:25: note: in definition of macro 'BITFIELD' static const uint32 NAME ## _V = STARTBIT; \ ^~~~ HP2100/hp2100_mpx.c:437:11: warning: 'FL_XOFF_V' defined but not used [-Wunused-const-variable=] BITFIELD (FL_XOFF, 10, 1) /* Port flags: XOFF stopped transmission */ ^ HP2100/hp2100_mpx.c:167:25: note: in definition of macro 'BITFIELD' static const uint32 NAME ## _V = STARTBIT; \ ^~~~ HP2100/hp2100_mpx.c:436:11: warning: 'FL_ALERT_V' defined but not used [-Wunused-const-variable=] BITFIELD (FL_ALERT, 11, 1) /* Port flags: alert for terminate recv buffer */ ^ HP2100/hp2100_mpx.c:167:25: note: in definition of macro 'BITFIELD' static const uint32 NAME ## _V = STARTBIT; \ ^~~~ HP2100/hp2100_mpx.c:432:11: warning: 'SK_ENQACK_V' defined but not used [-Wunused-const-variable=] BITFIELD (SK_ENQACK, 7, 1) /* Set key: disable or enable ENQ/ACK */ ^ HP2100/hp2100_mpx.c:167:25: note: in definition of macro 'BITFIELD' static const uint32 NAME ## _V = STARTBIT; \ ^~~~ HP2100/hp2100_mpx.c:431:11: warning: 'SK_PARITY' defined but not used [-Wunused-const-variable=] BITFIELD (SK_PARITY, 8, 2) /* Set key: parity select */ ^ HP2100/hp2100_mpx.c:168:25: note: in definition of macro 'BITFIELD' static const uint32 NAME = ((1 << (BITWIDTH)) - 1) << (STARTBIT); ^~~~ HP2100/hp2100_mpx.c:431:11: warning: 'SK_PARITY_V' defined but not used [-Wunused-const-variable=] BITFIELD (SK_PARITY, 8, 2) /* Set key: parity select */ ^ HP2100/hp2100_mpx.c:167:25: note: in definition of macro 'BITFIELD' static const uint32 NAME ## _V = STARTBIT; \ ^~~~ HP2100/hp2100_mpx.c:430:11: warning: 'SK_STOPBITS' defined but not used [-Wunused-const-variable=] BITFIELD (SK_STOPBITS, 10, 2) /* Set key: stop bits */ ^ HP2100/hp2100_mpx.c:168:25: note: in definition of macro 'BITFIELD' static const uint32 NAME = ((1 << (BITWIDTH)) - 1) << (STARTBIT); ^~~~ HP2100/hp2100_mpx.c:429:11: warning: 'SK_BRG_V' defined but not used [-Wunused-const-variable=] BITFIELD (SK_BRG, 12, 1) /* Set key: baud rate generator 0/1 */ ^ HP2100/hp2100_mpx.c:167:25: note: in definition of macro 'BITFIELD' static const uint32 NAME ## _V = STARTBIT; \ ^~~~ HP2100/hp2100_mpx.c:428:11: warning: 'SK_MODEM' defined but not used [-Wunused-const-variable=] BITFIELD (SK_MODEM, 13, 1) /* Set key: hardwired or modem */ ^ HP2100/hp2100_mpx.c:168:25: note: in definition of macro 'BITFIELD' static const uint32 NAME = ((1 << (BITWIDTH)) - 1) << (STARTBIT); ^~~~ HP2100/hp2100_mpx.c:428:11: warning: 'SK_MODEM_V' defined but not used [-Wunused-const-variable=] BITFIELD (SK_MODEM, 13, 1) /* Set key: hardwired or modem */ ^ HP2100/hp2100_mpx.c:167:25: note: in definition of macro 'BITFIELD' static const uint32 NAME ## _V = STARTBIT; \ ^~~~ In file included from HP2100/hp2100_pif.c:97:0: HP2100/hp2100_pif.c: In function 'pif_io': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_pif.c:251:17: note: in expansion of macro 'setstdSKF' setstdSKF (pif); /* card responds to SFC */ ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_pif.c:251:17: note: in expansion of macro 'setstdSKF' setstdSKF (pif); /* card responds to SFC */ ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_pif.c:257:17: note: in expansion of macro 'setstdSKF' setstdSKF (pif); /* card responds to SFS */ ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_pif.c:257:17: note: in expansion of macro 'setstdSKF' setstdSKF (pif); /* card responds to SFS */ ^~~~~~~~~ HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); ^~~~~~ HP2100/hp2100_pif.c:302:17: note: in expansion of macro 'setstdPRL' setstdPRL (pif); /* set standard PRL signal */ ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); ^~~~~~ HP2100/hp2100_pif.c:303:17: note: in expansion of macro 'setstdIRQ' setstdIRQ (pif); /* set standard IRQ signal */ ^~~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:436:25: note: in expansion of macro 'setSRQ' #define setstdSRQ(N) setSRQ (dibptr->select_code, N.flag); ^~~~~~ HP2100/hp2100_pif.c:304:17: note: in expansion of macro 'setstdSRQ' setstdSRQ (pif); /* set standard SRQ signal */ ^~~~~~~~~ HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_pif.c:308:17: note: in expansion of macro 'setPRL' setPRL (dibptr->select_code, !(pif.control | pif.flag)); ^~~~~~ HP2100/hp2100_pif.c:309:46: warning: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~' [-Wparentheses] setIRQ (dibptr->select_code, !pif.control & pif.flag & pif.flagbuf); ^~~~~~ HP2100/hp2100_defs.h:424:77: note: in definition of macro 'setIRQ' #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_pif.c:309:17: note: in expansion of macro 'setIRQ' setIRQ (dibptr->select_code, !pif.control & pif.flag & pif.flagbuf); ^~~~~~ In file included from HP2100/hp2100_di.c:100:0: HP2100/hp2100_di.c: In function 'di_io': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_di.c:474:13: note: in expansion of macro 'setstdSKF' setstdSKF (di [card]); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_di.c:474:13: note: in expansion of macro 'setstdSKF' setstdSKF (di [card]); ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_di.c:479:13: note: in expansion of macro 'setstdSKF' setstdSKF (di [card]); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ ^~~~~~ HP2100/hp2100_di.c:479:13: note: in expansion of macro 'setstdSKF' setstdSKF (di [card]); ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ ^ HP2100/hp2100_di.c:530:25: note: in expansion of macro 'IORETURN' stat_data = IORETURN (SCPE_OK, data); /* merge in the return status */ ^~~~~~~~ HP2100/hp2100_di.c:610:20: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] if (FIFO_FULL) /* is the FIFO full? */ ^ HP2100/hp2100_di.c:629:27: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] di_card->status_register ~~~~~~~~~~~~~~~~~~~~~~~~~ & ~(STAT_LSTN | STAT_TALK) /* clear listen and talk status */ ^~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from HP2100/hp2100_di.c:100:0: HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); ^~~~~~ HP2100/hp2100_di.c:720:13: note: in expansion of macro 'setstdPRL' setstdPRL (di [card]); /* set the standard PRL signal */ ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); ^~~~~~ HP2100/hp2100_di.c:721:13: note: in expansion of macro 'setstdIRQ' setstdIRQ (di [card]); /* set the standard IRQ signal */ ^~~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) ^ HP2100/hp2100_di.c:723:13: note: in expansion of macro 'setSRQ' setSRQ (dibptr->select_code, /* set the SRQ signal if control and SRQ are set */ ^~~~~~ HP2100/hp2100_di.c: In function 'di_set_address': HP2100/hp2100_di.c:838:35: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] dptr->flags = dptr->flags & ~DEV_BUSADR /* store the new address in the device flags */ HP2100/hp2100_di.c:853:35: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] uptr->flags = uptr->flags & ~UNIT_BUSADR /* the address is valid; change it */ HP2100/hp2100_di.c: In function 'di_bus_control': HP2100/hp2100_di.c:1117:32: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] new_state = di [card].bus_cntl & ~deny | assert; /* set up the new control state */ ~~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_di.c: In function 'update_state': HP2100/hp2100_di.c:1455:4: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] if (di_card->cntl_register & CNTL_LSTN) /* is the card a listener? */ ^ HP2100/hp2100_di.c:1470:3: warning: suggest parentheses around '&&' within '||' [-Wparentheses] && di_card->status_register & STAT_IRL /* and the input register is loaded, */ ^ HP2100/hp2100_di.c:1485:5: warning: suggest parentheses around '&&' within '||' [-Wparentheses] && di_card->cntl_register & CNTL_IRL /* and notification is wanted? */ ^ HP2100/hp2100_di.c:1489:5: warning: suggest parentheses around '&&' within '||' [-Wparentheses] || di_card->eor == SET /* or was the end of record seen */ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ && !(di_card->status_register & STAT_IRL) /* and the input register was unloaded? */ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_di.c:1492:5: warning: suggest parentheses around '&&' within '||' [-Wparentheses] && di_card->cntl_register & CNTL_CIC /* and the card is not controller? */ ^ HP2100/hp2100_di.c:1495:5: warning: suggest parentheses around '&&' within '||' [-Wparentheses] && di_card->cntl_register & CNTL_REN /* and notification is wanted? */ ^ HP2100/hp2100_di.c:1498:5: warning: suggest parentheses around '&&' within '||' [-Wparentheses] && di_card->cntl_register & CNTL_IFC) { /* and notification is wanted? */ ^ HP2100/hp2100_di.c: In function 'fifo_unload': HP2100/hp2100_di.c:1816:21: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] data = data & ~(DATA_ATN | DATA_EOI) /* substitute the ATN/EOI tag values */ ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_di.c:1870:33: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] di_card->bus_cntl & ~BUS_ATN /* from the ATN tag value */ HP2100/hp2100_di.c:1874:29: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] di_card->bus_cntl & ~BUS_EOI /* from the EOI tag value */ HP2100/hp2100_di.c:1859:4: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] if (di_card->cntl_register & CNTL_TALK) /* is the card talking? */ ^ HP2100/hp2100_di_da.c: In function 'da_boot': HP2100/hp2100_di_da.c:1218:9: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] SR = SR & (IBL_OPT | IBL_DS_HEAD) /* set S to a reasonable value */ ~~~^~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_di_da.c: In function 'da_bus_accept': HP2100/hp2100_di_da.c:1598:19: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if (if_state [unit] == read_wait /* if we're waiting for a send data secondary */ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ && message_address != 0x00 /* but it's not there */ ^~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_di_da.c:1741:16: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] if (icd_cntlr [unit].length == 0) /* is this the last parameter? */ ^ HP2100/hp2100_di_da.c:1790:4: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] if (initiated && DEBUG_PRI (da_dev, DEB_RWSC)) ^ HP2100/hp_disclib.c: In function 'dl_start_command': HP2100/hp_disclib.c:764:23: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if (props->unit_check && !uptr /* if the unit number is checked and is invalid */ ~~~~~~~~~~~~~~~~~~^~~~~~~~ HP2100/hp_disclib.c: In function 'dl_load_unload': HP2100/hp_disclib.c:1566:9: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] else if (!(sim_switches & SIM_SW_REST)) /* modify the flags only if not restoring */ ^ HP2100/hp_disclib.c: In function 'start_write': HP2100/hp_disclib.c:1900:14: warning: suggest parentheses around '&&' within '||' [-Wparentheses] || !verify && !(uptr->flags & UNIT_FMT)) /* or is formatting required but not enabled? */ ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp_disclib.c: In function 'position_sector': HP2100/hp_disclib.c:2044:12: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] if (uptr->STAT & DL_S2SC) /* did a seek check occur? */ ^ HP2100/hp_disclib.c: In function 'set_timer': HP2100/hp_disclib.c:2294:4: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] if (cvptr->type == MAC) /* is this a MAC controller? */ ^ In file included from scp.c:189:0: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] /* V3.8 revision history sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] /* V3.7 revision history sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] /* V3.6 revision history sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] /* V3.5 revision history sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] /* V3.4 revision history sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] /* V3.3 revision history sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] /* V3.2 revision history sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] /* V3.1 revision history sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] /* V3.0 revision history sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] /* V2.10 revision history sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] /* V2.9 revision history scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (np = match_ext (nbuf, "EXE")) /* remove .exe */ ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) /* lookup command */ ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { /* lookup command */ ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (shtb, gbuf)) /* global match? */ ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (aptr = strchr (cptr, ';')) { /* ;action? */ ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (portp = strchr (gbuf, ':')) /* x:y? split */ ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (cptr)) { /* exact match? */ ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sptr = strchr (logstr, c)) { /* check for mask */ ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ ^~ gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 I1401/i1401_lp.c I1401/i1401_cpu.c I1401/i1401_iq.c I1401/i1401_cd.c I1401/i1401_mt.c I1401/i1401_dp.c I1401/i1401_sys.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I I1401 -o BIN/i1401 -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program I1401/i1401_cpu.c: In function 'sim_instr': I1401/i1401_cpu.c:550:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = sim_process_event ()) ^~~~~~ I1401/i1401_cpu.c:1042:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = iomod (ilnt, D, r_mod)) /* valid modifier? */ ^~~~~~ I1401/i1401_cpu.c:1052:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = iomod (ilnt, D, w_mod)) /* valid modifier? */ ^~~~~~ I1401/i1401_cpu.c:1062:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = iomod (ilnt, D, p_mod)) /* valid modifier? */ ^~~~~~ I1401/i1401_cpu.c:1072:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = iomod (ilnt, D, w_mod)) /* valid modifier? */ ^~~~~~ I1401/i1401_cpu.c:1085:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = iomod (ilnt, D, w_mod)) /* valid modifier? */ ^~~~~~ I1401/i1401_cpu.c:1098:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = iomod (ilnt, D, NULL)) /* valid modifier? */ ^~~~~~ I1401/i1401_cpu.c:1111:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = iomod (ilnt, D, w_mod)) /* valid modifier? */ ^~~~~~ I1401/i1401_cpu.c:1125:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = iomod (ilnt, D, ss_mod)) /* valid modifier? */ ^~~~~~ I1401/i1401_cpu.c:1127:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = select_stack (D)) /* sel stack, error? */ ^~~~~~ I1401/i1401_cpu.c:1135:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = carriage_control (D)) /* car ctrl, error? */ ^~~~~~ I1401/i1401_cpu.c:1157:18: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (reason = iomod (ilnt, D, mtf_mod)) /* valid modifier? */ ^~~~~~ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_con_tab, gbuf)) ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ ^ I1401/i1401_iq.c: In function 'inq_io': I1401/i1401_iq.c:97:1: warning: "/*" within comment [-Wcomment] /* return SCPE_OK; /* return if no req */ I1401/i1401_iq.c:97:57: warning: "/*" within comment [-Wcomment] I1401/i1401_cd.c: In function 'read_card': I1401/i1401_cd.c:187:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = cdr_svc (&cdr_unit)) /* process */ ^ I1401/i1401_mt.c: In function 'mt_reset': I1401/i1401_mt.c:454:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (uptr = mt_sel_unit (i)) { ^~~~ I1401/i1401_dp.c: In function 'dp_io': I1401/i1401_dp.c:272:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = dp_rdsec (uptr, psec, flg, qwc)) /* read sector */ ^ I1401/i1401_dp.c:281:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = dp_nexsec (uptr, psec, dcf)) /* find next */ ^ I1401/i1401_dp.c:292:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = dp_rdadr (uptr, psec, flg, qwc)) /* read addr */ ^ I1401/i1401_dp.c:294:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = dp_rdsec (uptr, psec, flg, qwc)) /* read data */ ^ I1401/i1401_dp.c:315:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = dp_wrsec (uptr, psec, flg)) /* write data */ ^ I1401/i1401_dp.c:321:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = dp_nexsec (uptr, psec, dcf)) /* find next */ ^ I1401/i1401_dp.c:334:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = dp_wradr (uptr, psec, flg)) /* write addr */ ^ I1401/i1401_dp.c:336:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = dp_wrsec (uptr, psec, flg)) /* write data */ ^ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (lp->conn == 0) /* skip if !conn */ ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ ^~~~~~ In file included from scp.c:189:0: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] /* V3.8 revision history sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] /* V3.7 revision history sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] /* V3.6 revision history sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] /* V3.5 revision history sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] /* V3.4 revision history sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] /* V3.3 revision history sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] /* V3.2 revision history sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] /* V3.1 revision history sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] /* V3.0 revision history sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] /* V2.10 revision history sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] /* V2.9 revision history scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (np = match_ext (nbuf, "EXE")) /* remove .exe */ ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) /* lookup command */ ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { /* lookup command */ ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (shtb, gbuf)) /* global match? */ ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (aptr = strchr (cptr, ';')) { /* ;action? */ ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (portp = strchr (gbuf, ':')) /* x:y? split */ ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (cptr)) { /* exact match? */ ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sptr = strchr (logstr, c)) { /* check for mask */ ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ ^~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ ^~ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_con_tab, gbuf)) ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ ^ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (lp->conn == 0) /* skip if !conn */ ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ ^~~~~~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ ^~ gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 I1620/i1620_cd.c I1620/i1620_dp.c I1620/i1620_pt.c I1620/i1620_tty.c I1620/i1620_cpu.c I1620/i1620_lp.c I1620/i1620_fp.c I1620/i1620_sys.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I I1620 -o BIN/i1620 -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program I1620/i1620_cd.c:113:1: warning: "/*" within comment [-Wcomment] /* Card reader (ASCII) to numeric (one digit) */ I1620/i1620_cd.c: In function 'cdr': I1620/i1620_cd.c:245:29: warning: array subscript has type 'char' [-Wchar-subscripts] cdc = cdr_to_num[cdr_buf[i]]; /* translate */ ^ I1620/i1620_cd.c:262:29: warning: array subscript has type 'char' [-Wchar-subscripts] cdc = cdr_to_alp[cdr_buf[i]]; /* translate */ ^ I1620/i1620_dp.c: In function 'dp': I1620/i1620_dp.c:209:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = dp_rdsec (uptr, psec, qnr, qwc)) /* read sector */ ^ I1620/i1620_dp.c:219:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = dp_rdadr (uptr, psec, qnr, qwc)) /* read addr */ ^ I1620/i1620_dp.c:221:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = dp_rdsec (uptr, psec, qnr, qwc)) /* read data */ ^ I1620/i1620_dp.c:234:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = dp_tstgm (M[dp_ba], qnr)) /* start with gm? */ ^ I1620/i1620_dp.c:236:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = dp_wrsec (uptr, psec, qnr)) /* write data */ ^ I1620/i1620_dp.c:248:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = dp_tstgm (M[dp_ba], qnr)) /* start with gm? */ ^ I1620/i1620_dp.c:250:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = dp_wradr (uptr, psec, qnr)) /* write addr */ ^ I1620/i1620_dp.c:252:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = dp_wrsec (uptr, psec, qnr)) /* write data */ ^ I1620/i1620_tty.c: In function 'tti_rnum': I1620/i1620_tty.c:263:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (cp = strchr (tti_to_num, raw)) /* legal? */ ^~ I1620/i1620_cpu.c: In function 'sim_instr': I1620/i1620_cpu.c:479:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = sim_process_event ()) ^~~~~~ I1620/i1620_sys.c: In function 'parse_sym': I1620/i1620_sys.c:487:23: warning: array subscript has type 'char' [-Wchar-subscripts] t = cdr_to_alp[t]; /* convert */ ^ I1620/i1620_sys.c:505:23: warning: array subscript has type 'char' [-Wchar-subscripts] t = cdr_to_alp[t]; /* convert */ ^ I1620/i1620_sys.c:555:8: warning: suggest parentheses around assignment used as truth value [-Wparentheses] while (t = *fptr++) { /* loop through */ ^ I1620/i1620_sys.c:569:8: warning: array subscript has type 'char' [-Wchar-subscripts] val[t] = val[t] | FLAG; /* set flag */ ^ I1620/i1620_sys.c:569:17: warning: array subscript has type 'char' [-Wchar-subscripts] val[t] = val[t] | FLAG; /* set flag */ ^ In file included from scp.c:189:0: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] /* V3.8 revision history sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] /* V3.7 revision history sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] /* V3.6 revision history sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] /* V3.5 revision history sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] /* V3.4 revision history sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] /* V3.3 revision history sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] /* V3.2 revision history sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] /* V3.1 revision history sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] /* V3.0 revision history sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] /* V2.10 revision history sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] /* V2.9 revision history scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (np = match_ext (nbuf, "EXE")) /* remove .exe */ ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) /* lookup command */ ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { /* lookup command */ ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (shtb, gbuf)) /* global match? */ ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (aptr = strchr (cptr, ';')) { /* ;action? */ ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (portp = strchr (gbuf, ':')) /* x:y? split */ ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (cptr)) { /* exact match? */ ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sptr = strchr (logstr, c)) { /* check for mask */ ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ ^~ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_con_tab, gbuf)) ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ ^ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (lp->conn == 0) /* skip if !conn */ ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ ^~~~~~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ ^~ gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 S3/s3_cd.c S3/s3_cpu.c S3/s3_disk.c S3/s3_lp.c S3/s3_pkb.c S3/s3_sys.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I S3 -o BIN/s3 -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program S3/s3_cd.c: In function 'read_card': S3/s3_cd.c:283:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = cdr_svc (&cdr_unit)) return r; /* process */ ^ S3/s3_cd.c:328:34: warning: array subscript has type 'char' [-Wchar-subscripts] rbuf[i] = ascii_to_ebcdic[rbuf[i]]; /* convert to EBCDIC */ ^ S3/s3_cd.c: In function 'cdr_svc': S3/s3_cd.c:349:58: warning: array subscript has type 'char' [-Wchar-subscripts] for (i = 0; i < CDR_WIDTH; i++) rbuf[i] = ebcdic_to_ascii[rbuf[i]]; ^ S3/s3_cpu.c: In function 'sim_instr': S3/s3_cpu.c:530:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = sim_process_event ()) break; ^~~~~~ I1401/i1401_cpu.c:225:15: warning: type of 'select_stack' does not match original declaration [-Wlto-type-mismatch] extern t_stat select_stack (int32 mod); ^ I1401/i1401_cd.c:359:8: note: type mismatch in parameter 2 t_stat select_stack (int32 ilnt, int32 mod) ^ ./sim_defs.h:123:25: note: type 'int32' should match type 'void' typedef signed int int32; ^ I1401/i1401_cd.c:359:8: note: 'select_stack' was previously declared here t_stat select_stack (int32 ilnt, int32 mod) ^ gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 ALTAIR/altair_sio.c ALTAIR/altair_cpu.c ALTAIR/altair_dsk.c ALTAIR/altair_sys.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I ALTAIR -o BIN/altair -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program S3/s3_disk.c: In function 'dsk': S3/s3_disk.c:203:11: warning: variable 'F' set but not used [-Wunused-but-set-variable] int32 F, C, S, N, usave; ^ ALTAIR/altair_cpu.c: In function 'sim_instr': ALTAIR/altair_cpu.c:316:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = sim_process_event ()) break; ^~~~~~ ALTAIR/altair_cpu.c:369:37: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] DAR = DAR | (M[PC] <<8) & 0xFF00;; ~~~~~~~~~~~~^~~~~~~~ ALTAIR/altair_dsk.c: In function 'dsk12': ALTAIR/altair_dsk.c:313:18: warning: variable 'rtn' set but not used [-Wunused-but-set-variable] static int32 rtn, i; ^~~ ALTAIR/altair_dsk.c: In function 'writebuf': ALTAIR/altair_dsk.c:353:11: warning: variable 'rtn' set but not used [-Wunused-but-set-variable] int32 rtn, i; ^~~ ALTAIR/altair_sys.c: In function 'fprint_sym': ALTAIR/altair_sys.c:186:7: warning: variable 'cflag' set but not used [-Wunused-but-set-variable] int32 cflag, c1, c2, inst, adr; ^~~~~ ALTAIR/altair_sys.c: In function 'parse_sym': ALTAIR/altair_sys.c:234:7: warning: variable 'cflag' set but not used [-Wunused-but-set-variable] int32 cflag, i = 0, j, r; ^~~~~ S3/s3_sys.c:124:27: warning: missing braces around initializer [-Wmissing-braces] struct opdef opcode[75] = { ^ "HPL", 0x00,0,0,0, /* Halt Program Level */ { } "A", 0x06,0,1,3, /* Add to Register: A R,AADD */ { } "ST", 0x04,0,1,3, /* Store Register */ { } "L", 0x05,0,1,3, /* Load Register */ { } "LA", 0x02,0,1,1, /* Load Address */ { } "ZAZ", 0x04,0,2,2, /* Zero and Add Zoned */ { } "AZ", 0x06,0,2,2, /* Add Zoned Decimal */ { } "SZ", 0x07,0,2,2, /* Subtract Zoned Decimal */ { } "ALC", 0x0E,0,2,2, /* Add Logical: ALC BADD,AADD,LEN */ { } "SLC", 0x0F,0,2,2, /* Sub Logical: SLC BADD,AADD,LEN */ { } "MVC", 0x0C,0,2,2, /* Move Chars MVX BADD,AADD,LEN */ { } "ED", 0x0A,0,2,2, /* Edit: ED BADD,AADD,LEN */ { } "ITC", 0x0B,0,2,2, /* Insert Chars: ITC BADD,AADD,LEN */ { } "CLC", 0x0D,0,2,2, /* Compare Logical: CLC BADD,AADD,LEN */ { } "MVI", 0x0C,0,3,3, /* Move Immediate */ { } "SBN", 0x0A,0,3,3, /* Set Bits On */ { } "SBF", 0x0B,0,3,3, /* Set Bits Off */ { } "CLI", 0x0D,0,3,3, /* Compare Immediate */ { } "TBN", 0x08,0,3,3, /* Test Bits On */ { } "TBF", 0x09,0,3,3, /* Test Bits Off */ { } "APL", 0x01,0,4,0, /* Advance Program Level */ { } "SIO", 0x03,0,5,0, /* Start I/O */ { } "SNS", 0x00,0,6,3, /* Sense I/O */ { } "LIO", 0x01,0,6,3, /* Load I/O */ { } "TIO", 0x01,0,6,1, /* Test I/O */ { } "J", 0x02,0,7,0, /* Jump Unconditional */ { } "J", 0x02,0x87,7,0, /* Alternate J */ { } "JH", 0x02,132,7,0, /* Jump if High */ { } "JL", 0x02,130,7,0, /* Jump if Low */ { } "JE", 0x02,129,7,0, /* Jump if Equal */ { } "JNH", 0x02,4,7,0, /* Jump if Not High */ { } "JNL", 0x02,2,7,0, /* Jump if Not Low */ { } "JNE", 0x02,1,7,0, /* Jump if Not Equal */ { } "JOZ", 0x02,136,7,0, /* Jump if Overflow Zoned */ { } "JOL", 0x02,160,7,0, /* Jump if Overflow Logical */ { } "JNOZ", 0x02,8,7,0, /* Jump if No Overflow Zoned */ { } "JNOL", 0x02,32,7,0, /* Jump if No Overflow Logical */ { } "JT", 0x02,16,7,0, /* Jump if True */ { } "JF", 0x02,144,7,0, /* Jump if False */ { } "JP", 0x02,132,7,0, /* Jump if Plus */ { } "JM", 0x02,130,7,0, /* Jump if Minus */ { } "JZ", 0x02,129,7,0, /* Jump if Zero */ { } "JNP", 0x02,4,7,0, /* Jump if Not Plus */ { } "JNM", 0x02,2,7,0, /* Jump if Not Minus */ { } "JNZ", 0x02,1,7,0, /* Jump if Not Zero */ { } "NOPJ", 0x02,0x80,7,0, /* Never Jump - NOP */ { } "B", 0x00,0x00,8,1, /* Branch Unconditional */ { } "B", 0x00,0x87,8,1, /* Alternate B */ { } "BH", 0x00,0x84,8,1, /* Branch if High */ { } "BL", 0x00,0x82,8,1, /* Branch if Low */ { } "BE", 0x00,0x81,8,1, /* Branch if Equal */ { } "BNH", 0x00,0x04,8,1, /* Branch if Not High */ { } "BNL", 0x00,0x02,8,1, /* Branch if Not Low */ { } "BNE", 0x00,0x01,8,1, /* Branch if Not Equal */ { } "BOZ", 0x00,0x88,8,1, /* Branch if Overflow Zoned */ { } "BOL", 0x00,0xA0,8,1, /* Branch if Overflow Logical */ { } "BNOZ", 0x00,0x08,8,1, /* Branch if No Overflow Zoned */ { } "BNOL", 0x00,0x20,8,1, /* Branch if No Overflow Logical */ { } "BT", 0x00,0x10,8,1, /* Branch if True */ { } "BF", 0x00,0x90,8,1, /* Branch if False */ { } "BP", 0x00,0x84,8,1, /* Branch if Plus */ { } "BM", 0x00,0x82,8,1, /* Branch if Minus */ { } "BZ", 0x00,0x81,8,1, /* Branch if Zero */ { } "BNP", 0x00,0x04,8,1, /* Branch if Not Plus */ { } "BNM", 0x00,0x02,8,1, /* Branch if Not Minus */ { } "BNZ", 0x00,0x01,8,1, /* Branch if Not Zero */ { } "NOPB", 0x00,0x80,8,1, /* Never Branch - NOP */ { } "MZZ", 0x08,0,9,2, /* Move Zone to Zone */ { } "MNZ", 0x08,1,9,2, /* Move Numeric to Zone */ { } "MZN", 0x08,2,9,2, /* Move Zone to Numeric */ { } "MNN", 0x08,3,9,2, /* Move Numeric to Numeric */ { } "MVX", 0x08,0,2,2, /* Move Hex: MVX BADD,AADD,CODE */ { } "JC", 0x02,0,3,0, /* Jump on Specified Condition bits */ { } "BC", 0x00,0,3,1, /* Branch on Specified Condition */ { } "***", 0x00,0,0,0 { }; } S3/s3_sys.c: In function 'printf_sym': S3/s3_sys.c:273:7: warning: variable 'cflag' set but not used [-Wunused-but-set-variable] int32 cflag, c1, c2, group, len1, len2, inst, aaddr, baddr; ^~~~~ S3/s3_sys.c: In function 'parse_sym': S3/s3_sys.c:507:7: warning: variable 'cflag' set but not used [-Wunused-but-set-variable] int32 cflag, i = 0, j, r, oplen, addtyp, saveaddr, vptr; ^~~~~ In file included from scp.c:189:0: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] /* V3.8 revision history sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] /* V3.7 revision history sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] /* V3.6 revision history sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] /* V3.5 revision history sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] /* V3.4 revision history sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] /* V3.3 revision history sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] /* V3.2 revision history sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] /* V3.1 revision history sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] /* V3.0 revision history sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] /* V2.10 revision history sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] /* V2.9 revision history scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (np = match_ext (nbuf, "EXE")) /* remove .exe */ ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) /* lookup command */ ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { /* lookup command */ ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (shtb, gbuf)) /* global match? */ ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (aptr = strchr (cptr, ';')) { /* ;action? */ ^~~~ In file included from scp.c:189:0: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] /* V3.8 revision history sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] /* V3.7 revision history sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] /* V3.6 revision history sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] /* V3.5 revision history sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] /* V3.4 revision history sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] /* V3.3 revision history sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] /* V3.2 revision history sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] /* V3.1 revision history sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] /* V3.0 revision history sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] /* V2.10 revision history sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] /* V2.9 revision history scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (portp = strchr (gbuf, ':')) /* x:y? split */ ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (cptr)) { /* exact match? */ ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sptr = strchr (logstr, c)) { /* check for mask */ ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ ^~~~ scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (np = match_ext (nbuf, "EXE")) /* remove .exe */ ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) /* lookup command */ ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { /* lookup command */ ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c: In function 'sim_brk_getact': scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ ^~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (shtb, gbuf)) /* global match? */ ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (aptr = strchr (cptr, ';')) { /* ;action? */ ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (portp = strchr (gbuf, ':')) /* x:y? split */ ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (cptr)) { /* exact match? */ ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sptr = strchr (logstr, c)) { /* check for mask */ ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ ^~ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_con_tab, gbuf)) ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ ^ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_con_tab, gbuf)) ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ ^ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (lp->conn == 0) /* skip if !conn */ ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ ^~~~~~ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (lp->conn == 0) /* skip if !conn */ ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ ^~~~~~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ ^~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ ^~ gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 AltairZ80/altairz80_cpu.c AltairZ80/altairz80_cpu_nommu.c AltairZ80/altairz80_dsk.c AltairZ80/disasm.c AltairZ80/altairz80_sio.c AltairZ80/altairz80_sys.c AltairZ80/altairz80_hdsk.c AltairZ80/altairz80_net.c AltairZ80/flashwriter2.c AltairZ80/i86_decode.c AltairZ80/i86_ops.c AltairZ80/i86_prim_ops.c AltairZ80/i8272.c AltairZ80/insnsd.c AltairZ80/mfdc.c AltairZ80/n8vem.c AltairZ80/vfdhd.c AltairZ80/s100_disk1a.c AltairZ80/s100_disk2.c AltairZ80/s100_disk3.c AltairZ80/s100_fif.c AltairZ80/s100_mdriveh.c AltairZ80/s100_mdsad.c AltairZ80/s100_selchan.c AltairZ80/s100_ss1.c AltairZ80/s100_64fdc.c AltairZ80/s100_scp300f.c AltairZ80/sim_imd.c AltairZ80/wd179x.c AltairZ80/s100_hdc1001.c AltairZ80/s100_if3.c AltairZ80/s100_adcs6.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I AltairZ80 -o BIN/altairz80 -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program AltairZ80/altairz80_cpu.c: In function 'sim_instr_mmu': AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1975:17: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' CHECK_BREAK_TWO_BYTES_EXTENDED(SP - 2, SP - 1, (timerInterrupt = TRUE, IFF_S |= 1)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1991:17: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' CHECK_BREAK_TWO_BYTES_EXTENDED(SP - 2, SP - 1, (keyboardInterrupt = TRUE, IFF_S |= 1)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:2281:17: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(temp); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:2369:17: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(temp); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:3467:21: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(SP); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:3476:17: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(SP); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:118:9: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(SP - 2); \ ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:3491:17: note: in expansion of macro 'CALLC' CALLC(!TSTFLAG(Z)); /* also updates tStates */ ^~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:3496:17: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(SP - 2); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:3512:17: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(SP - 2); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:3520:21: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(SP); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:3533:17: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(SP); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:118:9: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(SP - 2); \ ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:3712:17: note: in expansion of macro 'CALLC' CALLC(TSTFLAG(Z)); /* also updates tStates */ ^~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:118:9: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(SP - 2); \ ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:3716:17: note: in expansion of macro 'CALLC' CALLC(1); /* also updates tStates */ ^~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:3731:17: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(SP - 2); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:3743:21: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(SP); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:3752:17: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(SP); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:118:9: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(SP - 2); \ ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:3768:17: note: in expansion of macro 'CALLC' CALLC(!TSTFLAG(C)); /* also updates tStates */ ^~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:3773:17: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(SP - 2); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:3789:17: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(SP - 2); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:3797:21: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(SP); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:118:9: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(SP - 2); \ ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:3835:17: note: in expansion of macro 'CALLC' CALLC(TSTFLAG(C)); /* also updates tStates */ ^~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:3872:25: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(temp); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:3915:25: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(temp); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:4575:25: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(SP); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:4581:25: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(SP); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:4589:25: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(SP - 2); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:4625:17: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(SP - 2); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:4637:21: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(SP); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:4646:17: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(SP); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:4657:17: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(SP); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:118:9: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(SP - 2); \ ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:4664:17: note: in expansion of macro 'CALLC' CALLC(!TSTFLAG(P)); /* also updates tStates */ ^~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:4669:17: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(SP - 2); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:4681:17: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(SP - 2); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:4689:21: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(SP); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:118:9: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(SP - 2); \ ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:4721:17: note: in expansion of macro 'CALLC' CALLC(TSTFLAG(P)); /* also updates tStates */ ^~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:4756:25: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(temp); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:4798:25: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(SP); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:4843:25: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(temp); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:4851:25: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(SP); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:4890:25: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(temp); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:4935:25: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(temp); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:4980:25: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(temp); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:5021:25: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(temp); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:5063:25: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(temp); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:5096:25: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(temp); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:5103:25: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' CHECK_BREAK_TWO_BYTES(HL, DE); ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:5165:25: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' CHECK_BREAK_TWO_BYTES(HL, DE); ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:5224:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' CHECK_BREAK_TWO_BYTES(HL, DE); ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:5295:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' CHECK_BREAK_TWO_BYTES(HL, DE); ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:5373:17: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(SP - 2); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:5385:21: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(SP); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:5394:17: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(SP); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:118:9: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(SP - 2); \ ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:5410:17: note: in expansion of macro 'CALLC' CALLC(!TSTFLAG(S)); /* also updates tStates */ ^~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:5415:17: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(SP - 2); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:5427:17: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(SP - 2); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:5435:21: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(SP); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:118:9: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(SP - 2); \ ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:5464:17: note: in expansion of macro 'CALLC' CALLC(TSTFLAG(S)); /* also updates tStates */ ^~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:5501:25: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(temp); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:5544:25: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(temp); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:6204:25: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(SP); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:6210:25: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(SP); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:6218:25: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(SP - 2); ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ & 0xffff, SWMASK('M')) == TRUE)) { \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:6256:13: note: in expansion of macro 'CHECK_BREAK_WORD' CHECK_BREAK_WORD(SP - 2); ^~~~~~~~~~~~~~~~ gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 GRI/gri_cpu.c GRI/gri_stddev.c GRI/gri_sys.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I GRI -o BIN/gri -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program GRI/gri_cpu.c: In function 'sim_instr': GRI/gri_cpu.c:424:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = sim_process_event ()) ^~~~~~ In file included from scp.c:189:0: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] /* V3.8 revision history sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] /* V3.7 revision history sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] /* V3.6 revision history sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] /* V3.5 revision history sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] /* V3.4 revision history sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] /* V3.3 revision history sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] /* V3.2 revision history sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] /* V3.1 revision history sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] /* V3.0 revision history sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] /* V2.10 revision history sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] /* V2.9 revision history scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (np = match_ext (nbuf, "EXE")) /* remove .exe */ ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) /* lookup command */ ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { /* lookup command */ ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (shtb, gbuf)) /* global match? */ ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (aptr = strchr (cptr, ';')) { /* ;action? */ ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (portp = strchr (gbuf, ':')) /* x:y? split */ ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (cptr)) { /* exact match? */ ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sptr = strchr (logstr, c)) { /* check for mask */ ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ ^~ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_con_tab, gbuf)) ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ ^ gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 I7094/i7094_cpu.c I7094/i7094_cpu1.c I7094/i7094_io.c I7094/i7094_cd.c I7094/i7094_clk.c I7094/i7094_com.c I7094/i7094_drm.c I7094/i7094_dsk.c I7094/i7094_sys.c I7094/i7094_lp.c I7094/i7094_mt.c I7094/i7094_binloader.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -DUSE_INT64 -I I7094 -o BIN/i7094 -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 Interdata/id16_cpu.c Interdata/id16_sys.c Interdata/id_dp.c Interdata/id_fd.c Interdata/id_fp.c Interdata/id_idc.c Interdata/id_io.c Interdata/id_lp.c Interdata/id_mt.c Interdata/id_pas.c Interdata/id_pt.c Interdata/id_tt.c Interdata/id_uvc.c Interdata/id16_dboot.c Interdata/id_ttp.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I Interdata -o BIN/id16 -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program I7094/i7094_cpu.c: In function 'sim_instr': I7094/i7094_cpu.c:667:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = sim_process_event ()) /* process events */ ^~~~~~ I7094/i7094_cpu.c:674:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = ch_proc (i)) ^~~~~~ I7094/i7094_cpu.c:1976:21: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = sim_process_event ()) /* process events */ ^ I7094/i7094_cpu.c:1982:33: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = ch_proc (j)) ^ I7094/i7094_cpu.c: In function 'cpu_fprint_one_inst': I7094/i7094_cpu.c:2441:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (ch = HIST_CH (pc)) { /* channel? */ ^~ Interdata/id16_cpu.c: In function 'sim_instr': Interdata/id16_cpu.c:607:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = sim_process_event ()) ^~~~~~ Interdata/id16_sys.c: In function 'fprint_sym_m': Interdata/id16_sys.c:355:32: warning: variable 'vp' set but not used [-Wunused-but-set-variable] uint32 i, j, inst, r1, r2, ea, vp; ^~ Interdata/id16_sys.c: In function 'parse_sym_m': Interdata/id16_sys.c:573:7: warning: variable 'st' set but not used [-Wunused-but-set-variable] int32 st, r1, r2; ^~ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (lp->conn == 0) /* skip if !conn */ ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ ^~~~~~ I7094/i7094_io.c: In function 'ch_op_start': I7094/i7094_io.c:798:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = ch9_wr (ch, ir, 0)) /* write to dev */ ^ I7094/i7094_io.c: In function 'ch_proc': I7094/i7094_io.c:1006:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = ch9_sel (ch, CHSL_SNS)) /* send sense to dev */ ^ I7094/i7094_io.c:1022:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = ch9_sel (ch, CHSL_RDS)) /* send read sel */ ^ I7094/i7094_io.c:1028:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = ch9_sel (ch, CHSL_WRS)) /* end write sel */ ^ I7094/i7094_io.c:1038:21: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = ch9_wr (ch, 0, CH9DF_STOP)) /* send stop */ ^ I7094/i7094_io.c:1058:18: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (r = ch9_wr_getw (ch)) /* no, write */ ^ I7094/i7094_io.c:1167:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = ch6_wr_getw (ch, TRUE)) /* send wd to dev; err? */ ^ I7094/i7094_io.c:1177:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = ch6_wr_getw (ch, FALSE)) /* send wd to dev; err? */ ^ I7094/i7094_io.c:1187:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = ch6_wr_getw (ch, FALSE)) /* send wd to dev; err? */ ^ I7094/i7094_io.c:1196:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = ch6_wr_getw (ch, TRUE)) /* send wd to dev; err? */ ^ I7094/i7094_io.c:1206:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = ch6_wr_getw (ch, TRUE)) /* send wd to dev; err? */ ^ Interdata/id_dp.c: In function 'dp_svc': Interdata/id_dp.c:422:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = dp_rds (uptr)) /* read sec, err? */ ^ Interdata/id_dp.c:441:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = dp_wds (uptr)) /* write sec, err? */ ^ Interdata/id_dp.c:396:8: warning: variable 't' set but not used [-Wunused-but-set-variable] uint32 t; ^ I7094/i7094_cd.c: In function 'cdr_svc': I7094/i7094_cd.c:242:40: warning: array subscript has type 'char' [-Wchar-subscripts] else colbin = bcd_to_colbin[cdr_cbuf[col]]; /* cvt to col binary */ ^ I7094/i7094_cd.c: In function 'cdp_card_end': I7094/i7094_cd.c:450:28: warning: array subscript has type 'char' [-Wchar-subscripts] cdp_cbuf[col] = pch[bcd]; /* -> ASCII */ ^ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ ^~ Interdata/id_idc.c:99:57: warning: "/*" within comment [-Wcomment] /* 0x40 /* unused */ Interdata/id_idc.c: In function 'idc_svc': Interdata/id_idc.c:579:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = idc_rds (uptr)) /* read sec, err? */ ^ Interdata/id_idc.c:598:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = idc_wds (uptr)) /* write sec, err? */ ^ Interdata/id_idc.c:506:8: warning: variable 't' set but not used [-Wunused-but-set-variable] uint32 t; ^ I7094/i7094_com.c: In function 'com_show_oneq': I7094/i7094_com.c:1178:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (entc = com_show_qsumm (st, lh, name)) { ^~~~ Interdata/id_io.c: In function 'sch_set_nchan': Interdata/id_io.c:361:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] for (i = 0; dptr = sim_devices[i]; i++) { /* loop thru dev */ ^~~~ Interdata/id_io.c: In function 'int_getdev': Interdata/id_io.c:442:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = int_req[i] & int_enb[i]) { /* find nz int wd */ ^ Interdata/id_io.c: In function 'devtab_init': Interdata/id_io.c:633:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] for (i = 0; dptr = sim_devices[i]; i++) { /* loop thru devices */ ^~~~ Interdata/id_mt.c: In function 'mt_svc': Interdata/id_mt.c:371:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrrecf (uptr, mtxb, mt_bptr)) /* write, err? */ ^~ Interdata/id_mt.c:377:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ ^~ Interdata/id_mt.c:405:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_sprecr (uptr, &tbc)) /* skip rec rev, err? */ ^~ I7094/i7094_dsk.c: In function 'dsk_svc': I7094/i7094_dsk.c:696:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = dsk_init_trk (udptr, trk)) { /* read track, err? */ ^ I7094/i7094_dsk.c:703:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = dsk_xfer_done (uaptr, dtyp)) { /* transfer done? */ ^ I7094/i7094_dsk.c:724:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = dsk_init_trk (udptr, trk)) { /* read track, err? */ ^ I7094/i7094_dsk.c:745:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = dsk_xfer_done (uaptr, dtyp)) { /* transfer done? */ ^ I7094/i7094_dsk.c:758:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = dsk_wr_trk (udptr, trk)) /* write track; err? */ ^ I7094/i7094_dsk.c:849:25: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = dsk_wr_trk (udptr, trk + i)) /* wr track; err? */ ^ Interdata/id_pas.c: In function 'pasi_svc': Interdata/id_pas.c:337:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (c = tmxr_getc_ln (&pas_ldsc[ln])) { /* any char? */ ^ I7094/i7094_lp.c: In function 'lpt_end_line': I7094/i7094_lp.c:333:24: warning: array subscript has type 'char' [-Wchar-subscripts] lpt_cbuf[col] = pch[bcd]; /* -> ASCII */ ^ I7094/i7094_mt.c: In function 'mt_svc': I7094/i7094_mt.c:567:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = mt_map_err (uptr, r)) /* map status */ ^ I7094/i7094_mt.c: In function 'mt_rec_end': I7094/i7094_mt.c:739:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = mt_map_err (uptr, r)) /* map error */ ^ In file included from scp.c:189:0: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] /* V3.8 revision history sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] /* V3.7 revision history sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] /* V3.6 revision history sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] /* V3.5 revision history sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] /* V3.4 revision history sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] /* V3.3 revision history sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] /* V3.2 revision history sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] /* V3.1 revision history sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] /* V3.0 revision history sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] /* V2.10 revision history sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] /* V2.9 revision history scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (np = match_ext (nbuf, "EXE")) /* remove .exe */ ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) /* lookup command */ ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { /* lookup command */ ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (shtb, gbuf)) /* global match? */ ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (aptr = strchr (cptr, ';')) { /* ;action? */ ^~~~ Interdata/id_ttp.c: In function 'ttp': Interdata/id_ttp.c:133:10: warning: variable 'old_cmd' set but not used [-Wunused-but-set-variable] int32 t, old_cmd; ^~~~~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (portp = strchr (gbuf, ':')) /* x:y? split */ ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (cptr)) { /* exact match? */ ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sptr = strchr (logstr, c)) { /* check for mask */ ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ ^~ In file included from scp.c:189:0: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] /* V3.8 revision history sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] /* V3.7 revision history sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] /* V3.6 revision history sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] /* V3.5 revision history sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] /* V3.4 revision history sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] /* V3.3 revision history sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] /* V3.2 revision history sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] /* V3.1 revision history sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] /* V3.0 revision history sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] /* V2.10 revision history sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] /* V2.9 revision history scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (np = match_ext (nbuf, "EXE")) /* remove .exe */ ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) /* lookup command */ ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { /* lookup command */ ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (shtb, gbuf)) /* global match? */ ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (aptr = strchr (cptr, ';')) { /* ;action? */ ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (portp = strchr (gbuf, ':')) /* x:y? split */ ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (cptr)) { /* exact match? */ ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sptr = strchr (logstr, c)) { /* check for mask */ ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ ^~ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_con_tab, gbuf)) ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ ^ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_con_tab, gbuf)) ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ ^ In file included from scp.c:189:0: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] /* V3.8 revision history sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] /* V3.7 revision history sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] /* V3.6 revision history sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] /* V3.5 revision history sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] /* V3.4 revision history sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] /* V3.3 revision history sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] /* V3.2 revision history sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] /* V3.1 revision history sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] /* V3.0 revision history sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] /* V2.10 revision history sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] /* V2.9 revision history scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (np = match_ext (nbuf, "EXE")) /* remove .exe */ ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) /* lookup command */ ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { /* lookup command */ ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ ^~~~ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (lp->conn == 0) /* skip if !conn */ ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ ^~~~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (shtb, gbuf)) /* global match? */ ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (aptr = strchr (cptr, ';')) { /* ;action? */ ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (portp = strchr (gbuf, ':')) /* x:y? split */ ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (cptr)) { /* exact match? */ ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sptr = strchr (logstr, c)) { /* check for mask */ ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ ^~ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (lp->conn == 0) /* skip if !conn */ ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ ^~~~~~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ ^~ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_con_tab, gbuf)) ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ ^ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ ^~ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (lp->conn == 0) /* skip if !conn */ ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ ^~~~~~ GRI/gri_cpu.c:252:15: warning: type of 'tty_rd' does not match original declaration [-Wlto-type-mismatch] extern uint32 tty_rd (uint32 src); ^ GRI/gri_stddev.c:212:8: note: type mismatch in parameter 1 uint32 tty_rd (int32 src, int32 ea) ^ ./sim_defs.h:123:25: note: type 'int32' should match type 'uint32' typedef signed int int32; ^ ./sim_defs.h:126:25: note: the incompatible type is defined here typedef unsigned int uint32; ^ GRI/gri_stddev.c:212:8: note: 'tty_rd' was previously declared here uint32 tty_rd (int32 src, int32 ea) ^ GRI/gri_cpu.c:248:15: warning: type of 'hsrp_rd' does not match original declaration [-Wlto-type-mismatch] extern uint32 hsrp_rd (uint32 src); ^ GRI/gri_stddev.c:303:8: note: type mismatch in parameter 1 uint32 hsrp_rd (int32 src, int32 ea) ^ ./sim_defs.h:123:25: note: type 'int32' should match type 'uint32' typedef signed int int32; ^ ./sim_defs.h:126:25: note: the incompatible type is defined here typedef unsigned int uint32; ^ GRI/gri_stddev.c:303:8: note: 'hsrp_rd' was previously declared here uint32 hsrp_rd (int32 src, int32 ea) ^ gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 Interdata/id32_cpu.c Interdata/id32_sys.c Interdata/id_dp.c Interdata/id_fd.c Interdata/id_fp.c Interdata/id_idc.c Interdata/id_io.c Interdata/id_lp.c Interdata/id_mt.c Interdata/id_pas.c Interdata/id_pt.c Interdata/id_tt.c Interdata/id_uvc.c Interdata/id32_dboot.c Interdata/id_ttp.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I Interdata -o BIN/id32 -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program Interdata/id32_cpu.c: In function 'sim_instr': Interdata/id32_cpu.c:667:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = sim_process_event ()) ^~~~~~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ ^~ Interdata/id32_sys.c: In function 'parse_sym_m': Interdata/id32_sys.c:672:31: warning: variable 'vp' set but not used [-Wunused-but-set-variable] uint32 i, j, df, db, t, inst, vp; ^~ Interdata/id_dp.c: In function 'dp_svc': Interdata/id_dp.c:422:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = dp_rds (uptr)) /* read sec, err? */ ^ Interdata/id_dp.c:441:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = dp_wds (uptr)) /* write sec, err? */ ^ Interdata/id_dp.c:396:8: warning: variable 't' set but not used [-Wunused-but-set-variable] uint32 t; ^ Interdata/id_idc.c:99:57: warning: "/*" within comment [-Wcomment] /* 0x40 /* unused */ Interdata/id_idc.c: In function 'idc_svc': Interdata/id_idc.c:579:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = idc_rds (uptr)) /* read sec, err? */ ^ Interdata/id_idc.c:598:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = idc_wds (uptr)) /* write sec, err? */ ^ Interdata/id_idc.c:506:8: warning: variable 't' set but not used [-Wunused-but-set-variable] uint32 t; ^ Interdata/id_io.c: In function 'sch_set_nchan': Interdata/id_io.c:361:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] for (i = 0; dptr = sim_devices[i]; i++) { /* loop thru dev */ ^~~~ Interdata/id_io.c: In function 'int_getdev': Interdata/id_io.c:442:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = int_req[i] & int_enb[i]) { /* find nz int wd */ ^ Interdata/id_io.c: In function 'devtab_init': Interdata/id_io.c:633:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] for (i = 0; dptr = sim_devices[i]; i++) { /* loop thru devices */ ^~~~ Interdata/id_mt.c: In function 'mt_svc': Interdata/id_mt.c:371:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrrecf (uptr, mtxb, mt_bptr)) /* write, err? */ ^~ Interdata/id_mt.c:377:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ ^~ Interdata/id_mt.c:405:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_sprecr (uptr, &tbc)) /* skip rec rev, err? */ ^~ Interdata/id_pas.c: In function 'pasi_svc': Interdata/id_pas.c:337:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (c = tmxr_getc_ln (&pas_ldsc[ln])) { /* any char? */ ^ Interdata/id_ttp.c: In function 'ttp': Interdata/id_ttp.c:133:10: warning: variable 'old_cmd' set but not used [-Wunused-but-set-variable] int32 t, old_cmd; ^~~~~~~ In file included from scp.c:189:0: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] /* V3.8 revision history sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] /* V3.7 revision history sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] /* V3.6 revision history sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] /* V3.5 revision history sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] /* V3.4 revision history sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] /* V3.3 revision history sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] /* V3.2 revision history sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] /* V3.1 revision history sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] /* V3.0 revision history sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] /* V2.10 revision history sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] /* V2.9 revision history scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (np = match_ext (nbuf, "EXE")) /* remove .exe */ ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) /* lookup command */ ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { /* lookup command */ ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (shtb, gbuf)) /* global match? */ ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (aptr = strchr (cptr, ';')) { /* ;action? */ ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (portp = strchr (gbuf, ':')) /* x:y? split */ ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (cptr)) { /* exact match? */ ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sptr = strchr (logstr, c)) { /* check for mask */ ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ ^~ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_con_tab, gbuf)) ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ ^ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (lp->conn == 0) /* skip if !conn */ ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ ^~~~~~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ ^~ gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 SDS/sds_cpu.c SDS/sds_drm.c SDS/sds_dsk.c SDS/sds_io.c SDS/sds_lp.c SDS/sds_mt.c SDS/sds_mux.c SDS/sds_rad.c SDS/sds_stddev.c SDS/sds_sys.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I SDS -o BIN/sds -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program SDS/sds_cpu.c: In function 'sim_instr': SDS/sds_cpu.c:388:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = sim_process_event ()) /* process */ ^~~~~~ SDS/sds_cpu.c:395:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = chan_process ()) /* process */ ^~~~~~ SDS/sds_cpu.c: In function 'one_inst': SDS/sds_cpu.c:509:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Write (0, dat)) ^ SDS/sds_cpu.c:528:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Ea (inst, &va)) /* decode eff addr */ ^ SDS/sds_cpu.c:530:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Read (va, &A)) /* get operand */ ^ SDS/sds_cpu.c:535:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Ea (inst, &va)) /* decode eff addr */ ^ SDS/sds_cpu.c:537:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Read (va, &B)) /* get operand */ ^ SDS/sds_cpu.c:542:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Ea (inst, &va)) /* decode eff addr */ ^ SDS/sds_cpu.c:544:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Read (va, &X)) /* get operand */ ^ SDS/sds_cpu.c:549:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Ea (inst, &va)) /* decode eff addr */ ^ SDS/sds_cpu.c:551:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Write (va, A)) /* write operand */ ^ SDS/sds_cpu.c:556:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Ea (inst, &va)) /* decode eff addr */ ^ SDS/sds_cpu.c:558:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Write (va, B)) /* write operand */ ^ SDS/sds_cpu.c:563:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Ea (inst, &va)) /* decode eff addr */ ^ SDS/sds_cpu.c:565:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Write (va, X)) /* write operand */ ^ SDS/sds_cpu.c:570:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Ea (inst, &va)) /* decode eff addr */ ^ SDS/sds_cpu.c:578:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Ea (inst, &va)) /* decode eff addr */ ^ SDS/sds_cpu.c:580:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Read (va, &dat)) /* get operand */ ^ SDS/sds_cpu.c:582:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Write (va, A)) /* write A */ ^ SDS/sds_cpu.c:590:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Ea (inst, &va)) /* decode eff addr */ ^ SDS/sds_cpu.c:592:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Read (va, &dat)) /* get operand */ ^ SDS/sds_cpu.c:598:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Ea (inst, &va)) /* decode eff addr */ ^ SDS/sds_cpu.c:600:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Read (va, &dat)) /* get operand */ ^ SDS/sds_cpu.c:607:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Ea (inst, &va)) /* decode eff addr */ ^ SDS/sds_cpu.c:609:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Read (va, &dat)) /* get operand */ ^ SDS/sds_cpu.c:615:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Ea (inst, &va)) /* decode eff addr */ ^ SDS/sds_cpu.c:617:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Read (va, &dat)) /* get operand */ ^ SDS/sds_cpu.c:624:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Ea (inst, &va)) /* decode eff addr */ ^ SDS/sds_cpu.c:626:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Read (va, &dat)) /* get operand */ ^ SDS/sds_cpu.c:629:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Write (va, dat)) /* rewrite */ ^ SDS/sds_cpu.c:634:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Ea (inst, &va)) /* decode eff addr */ ^ SDS/sds_cpu.c:636:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Read (va, &dat)) /* get operand */ ^ SDS/sds_cpu.c:639:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Write (va, dat)) /* rewrite */ ^ SDS/sds_cpu.c:644:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Ea (inst, &va)) /* decode eff addr */ ^ SDS/sds_cpu.c:646:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Read (va, &dat)) /* get operand */ ^ SDS/sds_cpu.c:652:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Ea (inst, &va)) /* decode eff addr */ ^ SDS/sds_cpu.c:654:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Read (va, &dat)) /* get operand */ ^ SDS/sds_cpu.c:660:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Ea (inst, &va)) /* decode eff addr */ ^ SDS/sds_cpu.c:662:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Read (va, &dat)) /* get operand */ ^ SDS/sds_cpu.c:668:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Ea (inst, &va)) /* decode eff addr */ ^ SDS/sds_cpu.c:670:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Read (va, &dat)) /* get operand */ ^ SDS/sds_cpu.c:676:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Ea (inst, &va)) /* decode eff addr */ ^ SDS/sds_cpu.c:678:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Read (va, &dat)) /* get operand */ ^ SDS/sds_cpu.c:686:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Ea (inst, &va)) /* decode eff addr */ ^ SDS/sds_cpu.c:688:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Read (va, &dat)) /* get operand */ ^ SDS/sds_cpu.c:695:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Ea (inst, &va)) /* decode eff addr */ ^ SDS/sds_cpu.c:697:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Read (va, &dat)) /* get operand */ ^ SDS/sds_cpu.c:704:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Ea (inst, &va)) /* decode eff addr */ ^ SDS/sds_cpu.c:706:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Read (va, &dat)) /* get operand */ ^ SDS/sds_cpu.c:713:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Ea (inst, &va)) /* decode eff addr */ ^ SDS/sds_cpu.c:715:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Read (va, &dat)) /* get operand */ ^ SDS/sds_cpu.c:722:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Ea (inst, &va)) /* decode eff addr */ ^ SDS/sds_cpu.c:724:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Read (va, &dat)) /* get operand */ ^ SDS/sds_cpu.c:731:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Ea (inst, &va)) /* decode eff addr */ ^ SDS/sds_cpu.c:733:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Read (va, &dat)) /* get operand */ ^ SDS/sds_cpu.c:740:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Ea (inst, &va)) /* decode eff addr */ ^ SDS/sds_cpu.c:742:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Read (va, &dat)) /* get operand */ ^ SDS/sds_cpu.c:745:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Write (va, dat)) /* rewrite */ ^ SDS/sds_cpu.c:752:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Ea (inst, &va)) /* decode eff addr */ ^ SDS/sds_cpu.c:754:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Read (va, &dat)) /* get operand */ ^ SDS/sds_cpu.c:777:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Ea (inst, &va)) /* decode eff addr */ ^ SDS/sds_cpu.c:779:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Read (va, &dat)) /* get operand */ ^ SDS/sds_cpu.c:786:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Ea (inst, &va)) /* decode eff addr */ ^ SDS/sds_cpu.c:788:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Read (va, &dat)) /* get operand */ ^ SDS/sds_cpu.c:795:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Ea (inst, &va)) /* decode eff addr */ ^ SDS/sds_cpu.c:799:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Read (va, &dat)) /* test dest access */ ^ SDS/sds_cpu.c:807:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Ea (inst, &va)) /* decode eff addr */ ^ SDS/sds_cpu.c:813:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Write (va, dat)) /* write ret word */ ^ SDS/sds_cpu.c:820:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Ea (inst, &va)) /* decode eff addr */ ^ SDS/sds_cpu.c:822:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Read (va, &dat)) /* get operand */ ^ SDS/sds_cpu.c:840:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Ea (inst, &va)) /* decode eff addr */ ^ SDS/sds_cpu.c:842:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Read (va, &dat)) /* get operand */ ^ SDS/sds_cpu.c:912:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = EaSh (inst, &va)) /* decode eff addr */ ^ SDS/sds_cpu.c:937:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = EaSh (inst, &va)) /* decode eff addr */ ^ SDS/sds_cpu.c:992:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Ea (inst, &va)) /* decode eff addr */ ^ SDS/sds_cpu.c:994:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Read (va, &dat)) /* get operand */ ^ SDS/sds_cpu.c:996:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = op_miwy (inst, dat)) /* process inst */ ^ SDS/sds_cpu.c:1005:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Ea (inst, &va)) /* decode eff addr */ ^ SDS/sds_cpu.c:1007:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = op_wyim (inst, &dat)) /* process inst */ ^ SDS/sds_cpu.c:1009:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Write (va, dat)) ^ SDS/sds_cpu.c:1018:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = op_eomd (inst)) /* process inst */ ^ SDS/sds_cpu.c:1028:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Ea (inst, &va)) /* decode eff addr */ ^ SDS/sds_cpu.c:1030:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Read (va, &dat)) /* get operand */ ^ SDS/sds_cpu.c:1032:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = op_pot (dat)) /* process inst */ ^ SDS/sds_cpu.c:1041:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Ea (inst, &va)) /* decode eff addr */ ^ SDS/sds_cpu.c:1043:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = op_pin (&dat)) /* process inst */ ^ SDS/sds_cpu.c:1045:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Write (va, dat)) /* write result */ ^ SDS/sds_cpu.c:1054:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = op_sks (inst, &dat)) /* process inst */ ^ SDS/sds_cpu.c: In function 'Ea': SDS/sds_cpu.c:1088:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Read (va, &wd)) /* read ind; fails? */ ^ SDS/sds_cpu.c: In function 'EaSh': SDS/sds_cpu.c:1115:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Read (va, &wd)) /* read ind; fails? */ ^ SDS/sds_cpu.c: In function 'ShfR48': SDS/sds_cpu.c:1344:39: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] B = ((B >> sc) | (A << (24 - sc)) & DMASK); SDS/sds_cpu.c: In function 'rtc_inst': SDS/sds_cpu.c:1572:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Ea (inst, &va)) /* decode eff addr */ ^ SDS/sds_cpu.c:1574:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Read (va, &dat)) /* get operand */ ^ SDS/sds_cpu.c:1577:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = Write (va, dat)) /* rewrite */ ^ SDS/sds_dsk.c: In function 'dsk': SDS/sds_dsk.c:207:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = dsk_read_buf (inst)) /* read sector */ ^ SDS/sds_dsk.c:222:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = dsk_write_buf (inst)) /* write sector */ ^ SDS/sds_io.c: In function 'op_eomd': SDS/sds_io.c:339:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = dev_dsp[dev][ch] (IO_CONN, inst, NULL)) /* connect */ ^ SDS/sds_io.c: In function 'io_init': SDS/sds_io.c:961:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] for (i = 0; dptr = sim_devices[i]; i++) { /* loop thru devices */ ^~~~ gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 LGP/lgp_cpu.c LGP/lgp_stddev.c LGP/lgp_sys.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I LGP -o BIN/lgp -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program SDS/sds_lp.c: In function 'lpt': SDS/sds_lp.c:180:24: warning: suggest parentheses around '&&' within '||' [-Wparentheses] (t == 004) && !lpt_err) /* 11062: !err */ ~~~~~~~~~~~^~~~~~~~~~~ LGP/lgp_cpu.c: In function 'sim_instr': LGP/lgp_cpu.c:291:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = sim_process_event ()) ^ LGP/lgp_cpu.c:311:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = cpu_one_inst (oPC, IR)) { /* one instr; error? */ ^ LGP/lgp_cpu.c: In function 'cpu_set_exec': LGP/lgp_cpu.c:747:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = sim_process_event ()) ^ SDS/sds_mt.c: In function 'mt': SDS/sds_mt.c:238:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = mt_wrend (inst)) /* end record */ ^ SDS/sds_mt.c:245:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = mt_wrend (inst)) /* end record */ ^ LGP/lgp_stddev.c: In function 'ttr_svc': LGP/lgp_stddev.c:397:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = read_reader (uptr, ttr_stopioe, (int32 *) &tti_buf)) ^ LGP/lgp_stddev.c: In function 'ptr_svc': LGP/lgp_stddev.c:418:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = read_reader (uptr, ptr_stopioe, &uptr->buf)) ^ LGP/lgp_stddev.c: In function 'write_tto': LGP/lgp_stddev.c:551:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = sim_putchar_s (ch)) /* write char */ ^ SDS/sds_mux.c: In function 'muxi_svc': SDS/sds_mux.c:366:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (c = tmxr_getc_ln (&mux_ldsc[ln])) { /* get char */ ^ LGP/lgp_sys.c: In function 'parse_sym': LGP/lgp_sys.c:366:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (tptr = strchr (hex_decode, c)) ^~~~ LGP/lgp_sys.c: In function 'parse_sym_m': LGP/lgp_sys.c:391:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (tptr = strchr (opcode, gbuf[0])) ^~~~ In file included from scp.c:189:0: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] /* V3.8 revision history sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] /* V3.7 revision history sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] /* V3.6 revision history sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] /* V3.5 revision history sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] /* V3.4 revision history sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] /* V3.3 revision history sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] /* V3.2 revision history sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] /* V3.1 revision history sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] /* V3.0 revision history sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] /* V2.10 revision history sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] /* V2.9 revision history scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (np = match_ext (nbuf, "EXE")) /* remove .exe */ ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) /* lookup command */ ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { /* lookup command */ ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (shtb, gbuf)) /* global match? */ ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (aptr = strchr (cptr, ';')) { /* ;action? */ ^~~~ SDS/sds_stddev.c: In function 'ptp_svc': SDS/sds_stddev.c:398:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = ptp_out (0)) ^ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (portp = strchr (gbuf, ':')) /* x:y? split */ ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (cptr)) { /* exact match? */ ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sptr = strchr (logstr, c)) { /* check for mask */ ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ ^~ In file included from scp.c:189:0: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] /* V3.8 revision history sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] /* V3.7 revision history sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] /* V3.6 revision history sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] /* V3.5 revision history sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] /* V3.4 revision history sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] /* V3.3 revision history sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] /* V3.2 revision history sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] /* V3.1 revision history sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] /* V3.0 revision history sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] /* V2.10 revision history sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] /* V2.9 revision history scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (np = match_ext (nbuf, "EXE")) /* remove .exe */ ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) /* lookup command */ ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { /* lookup command */ ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (shtb, gbuf)) /* global match? */ ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (aptr = strchr (cptr, ';')) { /* ;action? */ ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (portp = strchr (gbuf, ':')) /* x:y? split */ ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (cptr)) { /* exact match? */ ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sptr = strchr (logstr, c)) { /* check for mask */ ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ ^~ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_con_tab, gbuf)) ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ ^ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_con_tab, gbuf)) ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ ^ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (lp->conn == 0) /* skip if !conn */ ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ ^~~~~~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ ^~ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (lp->conn == 0) /* skip if !conn */ ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ ^~~~~~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ ^~ gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 H316/h316_stddev.c H316/h316_lp.c H316/h316_cpu.c H316/h316_sys.c H316/h316_mt.c H316/h316_fhd.c H316/h316_dp.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I H316 -o BIN/h316 -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program H316/h316_stddev.c: In function 'pt_attach': H316/h316_stddev.c:393:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = attach_unit (uptr, cptr)) ^ H316/h316_cpu.c: In function 'sim_instr': H316/h316_cpu.c:427:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = sim_process_event ()) ^~~~~~ H316/h316_cpu.c:461:21: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = (t >> IOT_V_REASON)) ^ H316/h316_cpu.c:531:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Ea (MB, &Y)) /* eff addr */ ^~~~~~ H316/h316_cpu.c:540:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Ea (MB, &Y)) /* eff addr */ ^~~~~~ H316/h316_cpu.c:551:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Ea (MB, &Y)) /* eff addr */ ^~~~~~ H316/h316_cpu.c:557:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Ea (MB, &Y)) /* eff addr */ ^~~~~~ H316/h316_cpu.c:567:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Ea (MB, &Y)) /* eff addr */ ^~~~~~ H316/h316_cpu.c:573:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Ea (MB, &Y)) /* eff addr */ ^~~~~~ H316/h316_cpu.c:586:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Ea (MB, &Y)) /* eff addr */ ^~~~~~ H316/h316_cpu.c:599:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Ea (MB, &Y)) /* eff addr */ ^~~~~~ H316/h316_cpu.c:608:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Ea (MB, &Y)) /* eff addr */ ^~~~~~ H316/h316_cpu.c:618:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Ea (MB, &Y)) /* eff addr */ ^~~~~~ H316/h316_cpu.c:627:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Ea (MB, &Y)) /* eff addr */ ^~~~~~ H316/h316_cpu.c:635:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Ea (MB & ~IDX, &Y)) /* eff addr */ ^~~~~~ H316/h316_cpu.c:641:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Ea (MB & ~IDX, &Y)) /* eff addr */ ^~~~~~ H316/h316_cpu.c:649:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Ea (MB, &Y)) /* eff addr */ ^~~~~~ H316/h316_cpu.c:660:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = Ea (MB, &Y)) /* eff addr */ ^~~~~~ H316/h316_cpu.c:829:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = stop_inst) /* stop on undef? */ ^~~~~~ H316/h316_cpu.c:862:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = stop_inst) /* stop on undef? */ ^~~~~~ H316/h316_cpu.c:902:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = stop_inst) /* stop on undef? */ ^~~~~~ H316/h316_cpu.c:938:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = stop_inst) /* stop on undef? */ ^~~~~~ H316/h316_cpu.c:1006:18: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (reason = stop_inst) ^~~~~~ H316/h316_cpu.c: In function 'devtab_init': H316/h316_cpu.c:1503:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] for (i = 0; dptr = sim_devices[i]; i++) { /* loop thru devices */ ^~~~ H316/h316_sys.c: In function 'parse_sym': H316/h316_sys.c:367:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (k = (strcmp (gbuf, "C") == 0)) { /* C specified? */ ^ H316/h316_sys.c:371:18: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (k = (strcmp (gbuf, "Z") == 0)) { /* Z specified? */ ^ H316/h316_mt.c: In function 'mt_svc': H316/h316_mt.c:374:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ ^~ H316/h316_mt.c:379:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_sprecf (uptr, &tbc)) /* space fwd, err? */ ^~ H316/h316_mt.c:384:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_sprecr (uptr, &tbc)) /* space rev, err? */ ^~ H316/h316_mt.c:458:21: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_wrrecf (uptr, mtxb, mt_ptr)) /* write, err? */ ^~ H316/h316_fhd.c: In function 'fhdio': H316/h316_fhd.c:222:9: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (((fnc == 000) && fhd_rdy) || /* 0 = skip if ready */ ^~ H316/h316_fhd.c:228:13: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' break; ^~~~~ H316/h316_dp.c: In function 'dp_svc': H316/h316_dp.c:620:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = dp_rdtrk (uptr, dpxb, uptr->CYL, h)) /* get track; error? */ ^ H316/h316_dp.c:725:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = dp_rdtrk (uptr, dpxb, uptr->CYL, h)) /* get track; error? */ ^ H316/h316_dp.c:753:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = dp_wrwd (uptr, dp_buf)) /* wr word, error? */ ^ H316/h316_dp.c: In function 'dp_wrwd': H316/h316_dp.c:858:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = dp_wrdone (uptr, STA_UNSER)) /* dump track */ ^ H316/h316_dp.c: In function 'dp_setformat': H316/h316_dp.c:1020:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = dp_wrtrk (uptr, tbuf, c, h)) ^ H316/h316_dp.c: In function 'dp_showformat': H316/h316_dp.c:1046:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (r = dp_rdtrk (uptr, tbuf, c, h)) ^ In file included from scp.c:189:0: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] /* V3.8 revision history sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] /* V3.7 revision history sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] /* V3.6 revision history sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] /* V3.5 revision history sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] /* V3.4 revision history sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] /* V3.3 revision history sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] /* V3.2 revision history sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] /* V3.1 revision history sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] /* V3.0 revision history sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] /* V2.10 revision history sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] /* V2.9 revision history scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (np = match_ext (nbuf, "EXE")) /* remove .exe */ ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) /* lookup command */ ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { /* lookup command */ ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (shtb, gbuf)) /* global match? */ ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (aptr = strchr (cptr, ';')) { /* ;action? */ ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (portp = strchr (gbuf, ':')) /* x:y? split */ ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (cptr)) { /* exact match? */ ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sptr = strchr (logstr, c)) { /* check for mask */ ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ ^~ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_con_tab, gbuf)) ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ ^ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (lp->conn == 0) /* skip if !conn */ ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ ^~~~~~ gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 swtp6800/common/mp-a.c swtp6800/common/m6800.c swtp6800/common/m6810.c swtp6800/common/bootrom.c swtp6800/common/dc-4.c swtp6800/common/mp-s.c swtp6800/swtp6800/mp-a_sys.c swtp6800/common/mp-b2.c swtp6800/common/mp-8m.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I swtp6800/swtp6800 -o BIN/swtp6800mp-a -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program swtp6800/common/m6800.c: In function 'sim_instr': swtp6800/common/m6800.c:319:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = sim_process_event ()) ^~~~~~ swtp6800/common/m6800.c:318:9: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (sim_interval <= 0) /* check clock queue */ ^~ swtp6800/common/m6800.c:321:13: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' if (mem_fault) { /* memory fault? */ ^~ swtp6800/common/m6800.c: In function 'condevalVa': swtp6800/common/m6800.c:1895:18: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses] (op1 & 0x80 == 0) && (op2 & 0x80 == 0))); ^ swtp6800/common/m6800.c:106:9: note: in definition of macro 'COND_SET_FLAG_V' if (COND) SET_FLAG(VF); else CLR_FLAG(VF) ^~~~ swtp6800/common/m6800.c:1895:39: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses] (op1 & 0x80 == 0) && (op2 & 0x80 == 0))); ^ swtp6800/common/m6800.c:106:9: note: in definition of macro 'COND_SET_FLAG_V' if (COND) SET_FLAG(VF); else CLR_FLAG(VF) ^~~~ swtp6800/common/m6800.c:1893:8: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] if (get_flag(CF)) ^ swtp6800/common/m6800.c: In function 'condevalVs': swtp6800/common/m6800.c:1903:47: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses] COND_SET_FLAG_V(((op1 & 0x80) && (op2 & 0x80 == 0)) || ^ swtp6800/common/m6800.c:106:9: note: in definition of macro 'COND_SET_FLAG_V' if (COND) SET_FLAG(VF); else CLR_FLAG(VF) ^~~~ swtp6800/common/m6800.c:1904:19: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses] ((op1 & 0x80 == 0) && (op2 & 0x80))); ^ swtp6800/common/m6800.c:106:9: note: in definition of macro 'COND_SET_FLAG_V' if (COND) SET_FLAG(VF); else CLR_FLAG(VF) ^~~~ swtp6800/common/m6800.c:1902:8: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] if (get_flag(CF)) ^ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ ^~ swtp6800/common/m6810.c: In function 'm6810_get_mbyte': swtp6800/common/m6810.c:114:21: warning: unused variable 'len' [-Wunused-variable] int32 val, org, len; ^~~ swtp6800/common/m6810.c:114:16: warning: unused variable 'org' [-Wunused-variable] int32 val, org, len; ^~~ swtp6800/common/bootrom.c: In function 'BOOTROM_config': swtp6800/common/bootrom.c:147:61: warning: suggest parentheses around '-' inside '<<' [-Wparentheses] BOOTROM_unit.capac = 0x200 << (val >> UNIT_V_MSIZE) - 1; /* set EPROM size */ ~~~~~~~~~~~~~~~~~~~~~~^~~ swtp6800/common/bootrom.c: In function 'BOOTROM_reset': swtp6800/common/bootrom.c:166:12: warning: unused variable 'r' [-Wunused-variable] t_stat r; ^ swtp6800/common/dc-4.c: In function 'fdcdrv': swtp6800/common/dc-4.c:371:10: warning: unused variable 'buf' [-Wunused-variable] char buf[128]; ^~~ swtp6800/common/mp-8m.c: In function 'mp_8m_put_mbyte': swtp6800/common/mp-8m.c:180:21: warning: unused variable 'type' [-Wunused-variable] int32 org, len, type; ^~~~ In file included from scp.c:189:0: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] /* V3.8 revision history sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] /* V3.7 revision history sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] /* V3.6 revision history sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] /* V3.5 revision history sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] /* V3.4 revision history sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] /* V3.3 revision history sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] /* V3.2 revision history sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] /* V3.1 revision history sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] /* V3.0 revision history sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] /* V2.10 revision history sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] /* V2.9 revision history scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (np = match_ext (nbuf, "EXE")) /* remove .exe */ ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) /* lookup command */ ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { /* lookup command */ ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (shtb, gbuf)) /* global match? */ ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (aptr = strchr (cptr, ';')) { /* ;action? */ ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (portp = strchr (gbuf, ':')) /* x:y? split */ ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (cptr)) { /* exact match? */ ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sptr = strchr (logstr, c)) { /* check for mask */ ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ ^~ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_con_tab, gbuf)) ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ ^ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (lp->conn == 0) /* skip if !conn */ ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ ^~~~~~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ ^~ gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 swtp6800/common/mp-a2.c swtp6800/common/m6800.c swtp6800/common/m6810.c swtp6800/common/bootrom.c swtp6800/common/dc-4.c swtp6800/common/mp-s.c swtp6800/swtp6800/mp-a2_sys.c swtp6800/common/mp-b2.c swtp6800/common/mp-8m.c swtp6800/common/i2716.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I swtp6800/swtp6800 -o BIN/swtp6800mp-a2 -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program swtp6800/common/m6800.c: In function 'sim_instr': swtp6800/common/m6800.c:319:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (reason = sim_process_event ()) ^~~~~~ swtp6800/common/m6800.c:318:9: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (sim_interval <= 0) /* check clock queue */ ^~ swtp6800/common/m6800.c:321:13: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' if (mem_fault) { /* memory fault? */ ^~ swtp6800/common/m6800.c: In function 'condevalVa': swtp6800/common/m6800.c:1895:18: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses] (op1 & 0x80 == 0) && (op2 & 0x80 == 0))); ^ swtp6800/common/m6800.c:106:9: note: in definition of macro 'COND_SET_FLAG_V' if (COND) SET_FLAG(VF); else CLR_FLAG(VF) ^~~~ swtp6800/common/m6800.c:1895:39: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses] (op1 & 0x80 == 0) && (op2 & 0x80 == 0))); ^ swtp6800/common/m6800.c:106:9: note: in definition of macro 'COND_SET_FLAG_V' if (COND) SET_FLAG(VF); else CLR_FLAG(VF) ^~~~ swtp6800/common/m6800.c:1893:8: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] if (get_flag(CF)) ^ swtp6800/common/m6800.c: In function 'condevalVs': swtp6800/common/m6800.c:1903:47: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses] COND_SET_FLAG_V(((op1 & 0x80) && (op2 & 0x80 == 0)) || ^ swtp6800/common/m6800.c:106:9: note: in definition of macro 'COND_SET_FLAG_V' if (COND) SET_FLAG(VF); else CLR_FLAG(VF) ^~~~ swtp6800/common/m6800.c:1904:19: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses] ((op1 & 0x80 == 0) && (op2 & 0x80))); ^ swtp6800/common/m6800.c:106:9: note: in definition of macro 'COND_SET_FLAG_V' if (COND) SET_FLAG(VF); else CLR_FLAG(VF) ^~~~ swtp6800/common/m6800.c:1902:8: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] if (get_flag(CF)) ^ swtp6800/common/m6810.c: In function 'm6810_get_mbyte': swtp6800/common/m6810.c:114:21: warning: unused variable 'len' [-Wunused-variable] int32 val, org, len; ^~~ swtp6800/common/m6810.c:114:16: warning: unused variable 'org' [-Wunused-variable] int32 val, org, len; ^~~ swtp6800/common/bootrom.c: In function 'BOOTROM_config': swtp6800/common/bootrom.c:147:61: warning: suggest parentheses around '-' inside '<<' [-Wparentheses] BOOTROM_unit.capac = 0x200 << (val >> UNIT_V_MSIZE) - 1; /* set EPROM size */ ~~~~~~~~~~~~~~~~~~~~~~^~~ swtp6800/common/bootrom.c: In function 'BOOTROM_reset': swtp6800/common/bootrom.c:166:12: warning: unused variable 'r' [-Wunused-variable] t_stat r; ^ swtp6800/common/dc-4.c: In function 'fdcdrv': swtp6800/common/dc-4.c:371:10: warning: unused variable 'buf' [-Wunused-variable] char buf[128]; ^~~ swtp6800/common/mp-8m.c: In function 'mp_8m_put_mbyte': swtp6800/common/mp-8m.c:180:21: warning: unused variable 'type' [-Wunused-variable] int32 org, len, type; ^~~~ swtp6800/common/i2716.c: In function 'i2716_attach': swtp6800/common/i2716.c:124:23: warning: format '%d' expects argument of type 'int', but argument 2 has type 'long int' [-Wformat=] printf("i2716%d: Unable to open ROM file %s\n", uptr - i2716_dev.units, uptr->filename); ~^ ~~~~~~~~~~~~~~~~~~~~~~ %ld swtp6800/common/i2716.c: In function 'i2716_reset': swtp6800/common/i2716.c:154:12: warning: unused variable 'r' [-Wunused-variable] t_stat r; ^ swtp6800/common/i2716.c:153:17: warning: unused variable 'c' [-Wunused-variable] int32 i, j, c, base; ^ swtp6800/common/i2716.c:153:14: warning: unused variable 'j' [-Wunused-variable] int32 i, j, c, base; ^ In file included from scp.c:189:0: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] /* V3.8 revision history sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] /* V3.7 revision history sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] /* V3.6 revision history sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] /* V3.5 revision history sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] /* V3.4 revision history sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] /* V3.3 revision history sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] /* V3.2 revision history sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] /* V3.1 revision history sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] /* V3.0 revision history sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] /* V2.10 revision history sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] /* V2.9 revision history scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (np = match_ext (nbuf, "EXE")) /* remove .exe */ ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) /* lookup command */ ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cmdp = find_cmd (gbuf)) { /* lookup command */ ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (gbuf)) { /* device match? */ ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (shtb, gbuf)) /* global match? */ ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (aptr = strchr (cptr, ';')) { /* ;action? */ ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (portp = strchr (gbuf, ':')) /* x:y? split */ ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (dptr = find_dev (cptr)) { /* exact match? */ ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (sptr = strchr (logstr, c)) { /* check for mask */ ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ ^~ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (cvptr = strchr (gbuf, '=')) /* = value? */ ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (shptr = find_shtab (show_con_tab, gbuf)) ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ ^ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (lp->conn == 0) /* skip if !conn */ ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ ^~~~~~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ ^~ + exit 0 Executing(%install): /bin/sh -e /var/tmp/rpm-tmp.yW4Pxt + umask 022 + cd /builddir/build/BUILD + '[' /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64 '!=' / ']' + rm -rf /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64 ++ dirname /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64 + mkdir -p /builddir/build/BUILDROOT + mkdir /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64 + cd simh-3.9.0 + rm -rf /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64 + mkdir -p /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/bin ++ ls BIN/ + for i in `ls BIN/` + install -p -m 755 BIN/altair /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/bin/simh-altair + for i in `ls BIN/` + install -p -m 755 BIN/altairz80 /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/bin/simh-altairz80 + for i in `ls BIN/` + install -p -m 755 BIN/eclipse /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/bin/simh-eclipse + for i in `ls BIN/` + install -p -m 755 BIN/gri /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/bin/simh-gri + for i in `ls BIN/` + install -p -m 755 BIN/h316 /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/bin/simh-h316 + for i in `ls BIN/` + install -p -m 755 BIN/hp2100 /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/bin/simh-hp2100 + for i in `ls BIN/` + install -p -m 755 BIN/i1401 /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/bin/simh-i1401 + for i in `ls BIN/` + install -p -m 755 BIN/i1620 /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/bin/simh-i1620 + for i in `ls BIN/` + install -p -m 755 BIN/i7094 /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/bin/simh-i7094 + for i in `ls BIN/` + install -p -m 755 BIN/id16 /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/bin/simh-id16 + for i in `ls BIN/` + install -p -m 755 BIN/id32 /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/bin/simh-id32 + for i in `ls BIN/` + install -p -m 755 BIN/lgp /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/bin/simh-lgp + for i in `ls BIN/` + install -p -m 755 BIN/nova /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/bin/simh-nova + for i in `ls BIN/` + install -p -m 755 BIN/pdp1 /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/bin/simh-pdp1 + for i in `ls BIN/` + install -p -m 755 BIN/pdp10 /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/bin/simh-pdp10 + for i in `ls BIN/` + install -p -m 755 BIN/pdp11 /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/bin/simh-pdp11 + for i in `ls BIN/` + install -p -m 755 BIN/pdp15 /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/bin/simh-pdp15 + for i in `ls BIN/` + install -p -m 755 BIN/pdp4 /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/bin/simh-pdp4 + for i in `ls BIN/` + install -p -m 755 BIN/pdp7 /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/bin/simh-pdp7 + for i in `ls BIN/` + install -p -m 755 BIN/pdp8 /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/bin/simh-pdp8 + for i in `ls BIN/` + install -p -m 755 BIN/pdp9 /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/bin/simh-pdp9 + for i in `ls BIN/` + install -p -m 755 BIN/s3 /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/bin/simh-s3 + for i in `ls BIN/` + install -p -m 755 BIN/sds /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/bin/simh-sds + for i in `ls BIN/` + install -p -m 755 BIN/swtp6800mp-a /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/bin/simh-swtp6800mp-a + for i in `ls BIN/` + install -p -m 755 BIN/swtp6800mp-a2 /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/bin/simh-swtp6800mp-a2 + for i in `ls BIN/` + install -p -m 755 BIN/vax /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/bin/simh-vax + for i in `ls BIN/` + install -p -m 755 BIN/vax780 /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/bin/simh-vax780 + mkdir -p /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/share/doc/simh ++ find -iname '*.txt' + for i in `find -iname "*.txt"` + dos2unix -k ./SDS/sds_diag.txt dos2unix: converting file ./SDS/sds_diag.txt to Unix format... + for i in `find -iname "*.txt"` + dos2unix -k ./PDP10/pdp10_bug_history.txt dos2unix: converting file ./PDP10/pdp10_bug_history.txt to Unix format... + for i in `find -iname "*.txt"` + dos2unix -k ./PDP18B/pdp18b_diag.txt dos2unix: converting file ./PDP18B/pdp18b_diag.txt to Unix format... + for i in `find -iname "*.txt"` + dos2unix -k ./S3/readme_s3.txt dos2unix: converting file ./S3/readme_s3.txt to Unix format... + for i in `find -iname "*.txt"` + dos2unix -k ./S3/system3.txt dos2unix: converting file ./S3/system3.txt to Unix format... + for i in `find -iname "*.txt"` + dos2unix -k ./S3/haltguide.txt dos2unix: converting file ./S3/haltguide.txt to Unix format... + for i in `find -iname "*.txt"` + dos2unix -k ./0readme_39.txt dos2unix: converting file ./0readme_39.txt to Unix format... + for i in `find -iname "*.txt"` + dos2unix -k ./ALTAIR/altair.txt dos2unix: converting file ./ALTAIR/altair.txt to Unix format... + for i in `find -iname "*.txt"` + dos2unix -k ./VAX/vax780_bug_history.txt dos2unix: converting file ./VAX/vax780_bug_history.txt to Unix format... + for i in `find -iname "*.txt"` + dos2unix -k ./0readme_ethernet.txt dos2unix: converting file ./0readme_ethernet.txt to Unix format... + for i in `find -iname "*.txt"` + dos2unix -k ./NOVA/eclipse.txt dos2unix: converting file ./NOVA/eclipse.txt to Unix format... + for i in `find -iname "*.txt"` + dos2unix -k ./HP2100/hp2100_diag.txt dos2unix: converting file ./HP2100/hp2100_diag.txt to Unix format... + for i in `find -iname "*.txt"` + dos2unix -k ./HP2100/hp2100_bugfixes.txt dos2unix: converting file ./HP2100/hp2100_bugfixes.txt to Unix format... + for i in `find -iname "*.txt"` + dos2unix -k ./Interdata/id_diag.txt dos2unix: converting file ./Interdata/id_diag.txt to Unix format... + for i in `find -iname "*.txt"` + dos2unix -k ./PDP1/pdp1_diag.txt dos2unix: converting file ./PDP1/pdp1_diag.txt to Unix format... + for i in `find -iname "*.txt"` + dos2unix -k ./I7094/i7094_bug_history.txt dos2unix: converting file ./I7094/i7094_bug_history.txt to Unix format... + /usr/lib/rpm/check-buildroot + /usr/lib/rpm/redhat/brp-ldconfig /sbin/ldconfig: Warning: ignoring configuration file that cannot be opened: /etc/ld.so.conf: No such file or directory + /usr/lib/rpm/brp-compress + /usr/lib/rpm/brp-strip /usr/bin/strip + /usr/lib/rpm/brp-strip-comment-note /usr/bin/strip /usr/bin/objdump + /usr/lib/rpm/brp-strip-static-archive /usr/bin/strip + /usr/lib/rpm/brp-python-bytecompile /usr/bin/python 1 + /usr/lib/rpm/brp-python-hardlink + /usr/lib/rpm/redhat/brp-mangle-shebangs Processing files: simh-3.9.0-8.fc28.riscv64 Executing(%doc): /bin/sh -e /var/tmp/rpm-tmp.2KaZer + umask 022 + cd /builddir/build/BUILD + cd simh-3.9.0 + DOCDIR=/builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/share/doc/simh + export LC_ALL=C + LC_ALL=C + export DOCDIR + /usr/bin/mkdir -p /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/share/doc/simh + cp -pr ALTAIR/altair.txt /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/share/doc/simh + cp -pr NOVA/eclipse.txt /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/share/doc/simh + cp -pr 0readme_39.txt /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/share/doc/simh + cp -pr 0readme_ethernet.txt /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/share/doc/simh + cp -pr HP2100/hp2100_diag.txt /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/share/doc/simh + cp -pr I7094/i7094_bug_history.txt /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/share/doc/simh + cp -pr Interdata/id_diag.txt /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/share/doc/simh + cp -pr PDP1/pdp1_diag.txt /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/share/doc/simh + cp -pr PDP10/pdp10_bug_history.txt /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/share/doc/simh + cp -pr PDP18B/pdp18b_diag.txt /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/share/doc/simh + cp -pr S3/haltguide.txt /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/share/doc/simh + cp -pr S3/readme_s3.txt /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/share/doc/simh + cp -pr S3/system3.txt /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/share/doc/simh + cp -pr SDS/sds_diag.txt /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/share/doc/simh + cp -pr VAX/vax780_bug_history.txt /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64/usr/share/doc/simh + exit 0 Provides: simh = 3.9.0-8.fc28 simh(riscv-64) = 3.9.0-8.fc28 Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 Requires: ld-linux-riscv64-lp64d.so.1()(64bit) ld-linux-riscv64-lp64d.so.1(GLIBC_2.27)(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.27)(64bit) libdl.so.2()(64bit) libdl.so.2(GLIBC_2.27)(64bit) libm.so.6()(64bit) libm.so.6(GLIBC_2.27)(64bit) libpcap.so.1()(64bit) libpthread.so.0()(64bit) libpthread.so.0(GLIBC_2.27)(64bit) librt.so.1()(64bit) rtld(GNU_HASH) Checking for unpackaged file(s): /usr/lib/rpm/check-files /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64 Wrote: /builddir/build/SRPMS/simh-3.9.0-8.fc28.src.rpm Wrote: /builddir/build/RPMS/riscv64/simh-3.9.0-8.fc28.riscv64.rpm Executing(%clean): /bin/sh -e /var/tmp/rpm-tmp.DXJtr4 + umask 022 + cd /builddir/build/BUILD + cd simh-3.9.0 + rm -rf /builddir/build/BUILDROOT/simh-3.9.0-8.fc28.riscv64 + exit 0 + touch /buildok + cleanup + set +e + sync + sleep 5 + sync + poweroff Terminated ++ cleanup ++ set +e ++ sync Terminated +++ cleanup +++ set +e +++ sync +++ sleep 5 +++ sync +++ poweroff