Example task here https://bitbucket.org/fedoraqa/task-exampleartifacts
Details
Details
Diff Detail
Diff Detail
- Repository
- rLTRN libtaskotron
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
The question is whether we want to create artifacts dir even for tasks that don't need it and are ran locally (therefore we end up with bunch of empty directories).
Comment Actions
I would say probably not but how would we know if the directory was created? do we leave creation up to the task unless there is a directive that creates artifacts?
Comment Actions
Looks good to me. We probably want to create the dir no matter what, because handling the edge cases complicates the code a lot (at least it seemed so after a short brainstorming with Martin).
| libtaskotron/runner.py | ||
|---|---|---|
| 54 | Maybe TaskotronConfigError, because the dir is not configured properly in the log? Not sure, either way is fine. | |
Maybe TaskotronConfigError, because the dir is not configured properly in the log? Not sure, either way is fine.