Listen for compose completion messages in trigger
ClosedPublic

Authored by mkrizek on Dec 15 2014, 4:03 PM.

Diff Detail

Repository
rTRGR taskotron-trigger
Branch
feature/compose_complete
Lint
No Linters Available
Unit
No Unit Test Coverage
mkrizek retitled this revision from to Listen for compose completion messages in trigger.Dec 15 2014, 4:03 PM
mkrizek updated this object.
mkrizek edited the test plan for this revision. (Show Details)
mkrizek added a reviewer: tflink.
mkrizek added inline comments.Dec 16 2014, 2:46 PM
jobtriggers/compose_complete_msg.py
34

Just realized - what do we pass as "arch" argument here? Empty string?

tflink accepted this revision.Dec 17 2014, 5:20 AM

Looks good to me. If you've been able to see a reaction to a compose completion message locally, push to develop.

It occurs to me that we'll need to add support for the 'compose' item_type in libtaskotron - filed as T381.

jobtriggers/compose_complete_msg.py
34

I guess either empty string or 'noarch'. The runner cli defaults to 'noarch' if there is no arch supplied

This revision is now accepted and ready to land.Dec 17 2014, 5:21 AM
mkrizek closed this revision.Dec 17 2014, 2:53 PM