schedule jobs for cloud atomicinst
ClosedPublic

Authored by adamwill on Sep 19 2015, 12:57 AM.

Details

Summary

D595 is a diff to run default_install test for the Cloud
'atomic installer' image. This is trivial, except that there's
an unfortunate issue with the image searching: we don't want
cloud boot images, but we can't really easily express that
without making the queries and config settings messier. That
didn't really seem like a great idea, so instead let's just
have a small hack: remove the cloud boot images from the
results after querying.

NOTE: there is a somewhat icky problem lurking here, and you can summarize it as 'separators'. Back when we set up openQA and decided what value we'd set as FLAVOR, we picked this: (payload)_(imagetype) There's a big problem with that, which is that payloads can have underscores in them. It also is not consistent with the image naming policy, which states that - is the separator *between* fields and _ can be used to separate tokens *inside* fields. But changing the flavor names could be quite disruptive, so I tried to avoid it for now. This commit works around the problem for default_install_cb() (which needs to split up the FLAVOR) by doing an rsplit with a split limit, which will work so long as we have no imagetypes with a _ character. I'll try to avoid that happening, since I define the imagetypes.

Adds a timer for the current stable post-release nightly.

Test Plan

as per D595. Result reporting won't really work for
now as there is no entry for this image in the wiki, but should
not crash.

Diff Detail

Repository
rOPENQA fedora_openqa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
adamwill retitled this revision from to schedule jobs for cloud atomicinst.Sep 19 2015, 12:57 AM
adamwill updated this object.
adamwill edited the test plan for this revision. (Show Details)
adamwill added reviewers: jskladan, garretraziel.

Further notes on the separator mess:

fedfind *could* use a separator other than _ when producing a payload from flavor and subflavor, but there are problems with that. It only solves the 'cloud atomic' case; it does nothing for any other payload with a _ in it (several of the loadout names themselves have _). It's just wrong - _ is the correct character, I believe, for the design of fedfind and the image naming policy. The regex for reading values out of the config file will actually split on any character other than a-z, A-Z, 0-9, or _, so we'd have to tweak that if we wanted to use say - or . in the payload name. And finally, openQA itself uses - as a field separator; when you go to the 'overview' page for a build, it shows the flavors as distri-flavor, and I'd guess there are other places where it uses - too. Basically, separators suck!

garretraziel accepted this revision.Sep 21 2015, 1:50 PM

Seems to work OK.

As a side-note - sadly, I don't think that there is easy and clean solution for separator problem.

This revision is now accepted and ready to land.Sep 21 2015, 1:50 PM
This revision was automatically updated to reflect the committed changes.