fix broken builds on i386 due to hard-coded x86_64 value
ClosedPublic

Authored by roshi on May 30 2014, 5:21 PM.

Details

Summary

added fixes for T191
added testcase to test_yumrepoinfo_directive.py

Test Plan

Run 'py.test /testing' on x86_64 and i386 machines

Diff Detail

Repository
rLTRN libtaskotron
Lint
Lint Skipped
Unit
Unit Tests Skipped
roshi retitled this revision from to fix and test case for T191.
roshi updated this object.
roshi edited the test plan for this revision. (Show Details)
roshi added a reviewer: tflink.
roshi updated this revision to Diff 333.May 30 2014, 5:26 PM
roshi edited the test plan for this revision. (Show Details)

Running 'arc diff' against develop instead of not providing a branch like last time

tflink accepted this revision.May 30 2014, 5:27 PM
tflink added a reviewer: kparal.

It looks good to me

This revision is now accepted and ready to land.May 30 2014, 5:29 PM
kparal accepted this revision.May 30 2014, 6:14 PM

I think it's fine, just a few cleanups and improvements are possible (only the one on line 56 seems a bit important to me).

libtaskotron/directives/yumrepoinfo_directive.py
25

TaskotronValueError doesn't need to be imported, it's not used. Not related to this patch, but can be removed while we're at it.

46–47

It seems that self.conf is also not used anywhere, can be removed.

55

I wonder if 'noarch' is a good fallback here. It will definitely make the URLs invalid (we don't have 'noarch' trees in our YUM repos). And since I see a check that arch is in input_data just a few lines above, I think the default should be removed. In some unexpected condition, it would raise an error, which is better.

Let's make it

arch = input_data['arch']
60

Just a nitpick, is is a better comparison here. But I'm not actually sure whether it's faster or something, it's just cleaner and more 'posh and proper' I think :-)

roshi updated this revision to Diff 335.May 30 2014, 6:29 PM
  • fixed issues brought up in D115 review
roshi closed this revision.May 30 2014, 6:58 PM
roshi updated this revision to Diff 336.

Closed by commit rLTRN570a0eb651a3 (authored by @roshi).

kparal retitled this revision from fix and test case for T191 to fix broken builds on i386 due to hard-coded x86_64 value.Jun 2 2014, 12:54 PM