Store used config file name
ClosedPublic

Authored by mkrizek on May 19 2015, 8:13 AM.

Details

Summary

This is needed for disposable clients work, so we know which config file to copy from a task initiator to a vm.

Test Plan

Tests amended, pass.

Diff Detail

Repository
rLTRN libtaskotron
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mkrizek retitled this revision from to Store used config file name.May 19 2015, 8:13 AM
mkrizek updated this object.
mkrizek edited the test plan for this revision. (Show Details)
mkrizek added reviewers: kparal, tflink, jskladan.
kparal added inline comments.May 19 2015, 8:38 AM
libtaskotron/config.py
95

Simple

config.config_filename = filename

should work as well :)

225–226

I don't think we need additional checking if we clearly document that this is an internal property which should not be set manually in the config file. But I'm fine with both approaches.

libtaskotron/config_defaults.py
40–41

What about:

Filename of the loaded config file. To be set after an external config file is loaded from the disk and its values merged with the default values. (If no config file is found, this is going to stay empty). Do not set this value manually in a config file itself - it is for internal use only.

42

@jskladan suggested using _filename here, to show that this just for internal use. Might be a good idea.

mkrizek updated this revision to Diff 994.May 19 2015, 11:00 AM
  • Better document the config_filename option
tflink accepted this revision.May 19 2015, 1:45 PM
This revision is now accepted and ready to land.May 19 2015, 1:45 PM
kparal accepted this revision.May 26 2015, 8:00 AM
This revision was automatically updated to reflect the committed changes.