Add support for task artifacts
ClosedPublic

Authored by mkrizek on Feb 17 2015, 9:18 AM.

Diff Detail

Repository
rLTRN libtaskotron
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mkrizek retitled this revision from to Add support for task artifacts.Feb 17 2015, 9:18 AM
mkrizek updated this object.
mkrizek edited the test plan for this revision. (Show Details)
mkrizek added reviewers: tflink, kparal, jskladan.

The question is whether we want to create artifacts dir even for tasks that don't need it and are ran locally (therefore we end up with bunch of empty directories).

In D279#4915, @mkrizek wrote:

The question is whether we want to create artifacts dir even for tasks that don't need it and are ran locally (therefore we end up with bunch of empty directories).

I would say probably not but how would we know if the directory was created? do we leave creation up to the task unless there is a directive that creates artifacts?

kparal accepted this revision.Feb 17 2015, 1:51 PM

Looks good to me. We probably want to create the dir no matter what, because handling the edge cases complicates the code a lot (at least it seemed so after a short brainstorming with Martin).

libtaskotron/runner.py
54

Maybe TaskotronConfigError, because the dir is not configured properly in the log? Not sure, either way is fine.

This revision is now accepted and ready to land.Feb 17 2015, 1:51 PM
tflink accepted this revision.Feb 18 2015, 10:58 AM

LGTM

This revision was automatically updated to reflect the committed changes.