allowing per-instance hostname to be set at construction time. Fixes T622
ClosedPublic

Authored by tflink on Sep 25 2015, 6:06 PM.

Details

Summary

testcloud side of the fix - allow hostname to be set on a per-instance basis but falls back to the config file value if that per-instance value is not set

Test Plan

unit tests pass, integration with new libtaskotron code works with setting hostname, old behavior still remains if that hostname arg isn't set

Diff Detail

Repository
rTCLOUD testcloud
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tflink retitled this revision from to allowing per-instance hostname to be set at construction time. Fixes T622.Sep 25 2015, 6:06 PM
tflink updated this object.
tflink edited the test plan for this revision. (Show Details)
tflink added a reviewer: roshi.
mkrizek accepted this revision.Sep 25 2015, 6:45 PM
mkrizek added a reviewer: mkrizek.
mkrizek added a subscriber: mkrizek.

Haven't tested the patch but looks simple enough to say LGTM *s-word avoided*

This revision is now accepted and ready to land.Sep 25 2015, 6:45 PM
roshi accepted this revision.Sep 28 2015, 8:09 PM

Seems sane to me.

This revision was automatically updated to reflect the committed changes.