runner: create workdir in run() instead of init()
ClosedPublic

Authored by kparal on Jul 3 2014, 9:16 AM.

Details

Summary

When we create the workdir in init(), we end up with a lot of empty
directories during our test suite execution. That seems a bit
unnecessary. We could avoid it by providing a fake value to every Runner
instance creation, but it seems easier to simply create workdir in the
run() phase instead of init().

Test Plan

unit tests pass and when not running the functional tests, no unneeded dirs are created

Diff Detail

Repository
rLTRN libtaskotron
Lint
Lint Skipped
Unit
Unit Tests Skipped
kparal retitled this revision from to runner: create workdir in run() instead of init().Jul 3 2014, 9:16 AM
kparal updated this object.
kparal edited the test plan for this revision. (Show Details)
kparal added reviewers: tflink, jskladan, mkrizek.
mkrizek accepted this revision.Jul 3 2014, 9:20 AM

LGTM

This revision is now accepted and ready to land.Jul 3 2014, 9:20 AM
tflink accepted this revision.Jul 3 2014, 11:18 AM
kparal closed this revision.Jul 3 2014, 11:40 AM
kparal updated this revision to Diff 515.

Closed by commit rLTRNb6ba6f663897 (authored by @kparal).