changing buildbot trigger to use change_source instead of login and force build. Fixes T231.
ClosedPublic

Authored by tflink on Jun 25 2014, 2:25 PM.

Details

Summary

this uses an alternate interface to buildbot that doesn't require
hacking in logins to force builds. It requires a
change to the buildmaster config
that will be done at the same time this is actually deployed

Test Plan

I've been running it locally for a while and in dev during load testing.

Diff Detail

Repository
rTRGR taskotron-trigger
Lint
Lint Skipped
Unit
Unit Tests Skipped
tflink retitled this revision from to changing buildbot trigger to use change_source instead of login and force build. Fixes T231..Jun 25 2014, 2:25 PM
tflink updated this object.
tflink edited the test plan for this revision. (Show Details)
tflink added a reviewer: mkrizek.
mkrizek requested changes to this revision.Jun 26 2014, 9:08 AM

Other than the config comments, it looks good to me, assuming it works :)

conf/trigger.cfg.example
1–2

Do we want to remove username and password from the config since they're no longer used in the code?

2

This should be changed in jobtriggers/config.py as well.

This revision now requires changes to proceed.Jun 26 2014, 9:08 AM
tflink added inline comments.Jun 26 2014, 12:55 PM
conf/trigger.cfg.example
1–2

I imagine that we might want to have some sort of auth on this eventually but for now, we can remove it.

2

good catch, thanks

tflink updated this revision to Diff 476.Jun 26 2014, 12:58 PM
  • fixing config per comments in review
mkrizek accepted this revision.Jun 26 2014, 1:14 PM
This revision is now accepted and ready to land.Jun 26 2014, 1:14 PM
tflink closed this revision.Jun 27 2014, 12:16 PM
tflink updated this revision to Diff 491.

Closed by commit rTRGR8816f62230da (authored by @tflink).