- Unittests amended.
- Try running a check and see if a fedmsg would or wouldn't have been sent (change fedmsg.publish to print the message). Worked in my testing.
Details
Details
- Reviewers
kparal tflink jskladan - Maniphest Tasks
- T668: add 'previous_outcome' field to fedmsgs
- Commits
- rRSDB351836e144de: Add 'previous_outcome' field to fedmsgs
Diff Detail
Diff Detail
- Repository
- rRSDB resultsdb
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| resultsdb/controllers/api_v1.py | ||
|---|---|---|
| 652 | It would seem clearer to me if this was: def create_fedmsg(result, prev_result=None) But either way works. If you change this, don't forget to also change the code where you call this :-) | |
It would seem clearer to me if this was:
But either way works.
If you change this, don't forget to also change the code where you call this :-)