.
Details
- Reviewers
mkrizek jskladan - Group Reviewers
libtaskotron - Maniphest Tasks
- T305: Create task for rpmgrill
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Created the differential review on behalf of @ralph since he's having issues logging in.
| run_rpmgrill.py | ||
|---|---|---|
| 121 | Please use . as a separator between the rpmgrill namespace, and the checkname. The checkname can then be, of course, named as you wish, but we want to make sure that the namespaces are honoured, even though the actual code to check that is not present in the libtaskotron code at the moment. | |
The task is crashing for me:
[rpmgrill:run_rpmgrill.py:126] 2016-06-28 13:22:40 INFO rpmgrill-virus-check PASSED for htop-1.0.3-6.fc23 (No issues found)
[rpmgrill:run_rpmgrill.py:126] 2016-06-28 13:22:40 INFO rpmgrill-spec-file-sanity PASSED for htop-1.0.3-6.fc23 (No issues found)
[rpmgrill:run_rpmgrill.py:126] 2016-06-28 13:22:40 INFO rpmgrill-spec-file-encoding PASSED for htop-1.0.3-6.fc23 (No issues found)
[rpmgrill:run_rpmgrill.py:126] 2016-06-28 13:22:40 INFO rpmgrill-lib-gather PASSED for htop-1.0.3-6.fc23 (No issues found)
[rpmgrill:run_rpmgrill.py:126] 2016-06-28 13:22:40 INFO rpmgrill-elf-checks PASSED for htop-1.0.3-6.fc23 (No issues found)
[rpmgrill:run_rpmgrill.py:126] 2016-06-28 13:22:40 INFO rpmgrill-patches PASSED for htop-1.0.3-6.fc23 (No issues found)
[rpmgrill:run_rpmgrill.py:126] 2016-06-28 13:22:40 INFO rpmgrill-security-policy PASSED for htop-1.0.3-6.fc23 (No issues found)
[rpmgrill:run_rpmgrill.py:126] 2016-06-28 13:22:40 INFO rpmgrill-multilib PASSED for htop-1.0.3-6.fc23 (No issues found)
[rpmgrill:run_rpmgrill.py:126] 2016-06-28 13:22:40 INFO rpmgrill-manifest PASSED for htop-1.0.3-6.fc23 (No issues found)
[rpmgrill:run_rpmgrill.py:126] 2016-06-28 13:22:40 INFO rpmgrill-man-pages PASSED for htop-1.0.3-6.fc23 (No issues found)
[rpmgrill:run_rpmgrill.py:126] 2016-06-28 13:22:40 INFO rpmgrill-rpm-scripts PASSED for htop-1.0.3-6.fc23 (No issues found)
[rpmgrill:run_rpmgrill.py:126] 2016-06-28 13:22:40 INFO rpmgrill-setxid PASSED for htop-1.0.3-6.fc23 (No issues found)
[rpmgrill:run_rpmgrill.py:126] 2016-06-28 13:22:40 INFO rpmgrill-build-log PASSED for htop-1.0.3-6.fc23 (No issues found)
[rpmgrill:run_rpmgrill.py:126] 2016-06-28 13:22:40 INFO rpmgrill-desktop-lint PASSED for htop-1.0.3-6.fc23 (No issues found)
[libtaskotron:executor.py:155] 2016-06-28 13:22:40 DEBUG Variable ${rpmgrill_output} was exported with value:
results:
- checkname: rpmgrill
item: htop-1.0.3-6.fc23
note: not all arguments converted during string formatting
outcome: CRASHED
type: koji_buildAfter adding
log.exception(e)
onto line 42 (which I'd recommend), the traceback is:
[rpmgrill:run_rpmgrill.py:42] 2016-06-28 13:30:03 ERROR not all arguments converted during string formatting
Traceback (most recent call last):
File "run_rpmgrill.py", line 40, in wrapper
return fn(**kwargs)
File "run_rpmgrill.py", line 77, in run
details = list(massage_results(rpmgrill_results, koji_build, log_path))
File "run_rpmgrill.py", line 138, in massage_results
note = "No issues found" % total_issues
TypeError: not all arguments converted during string formattingA copy paste error :)
Also, when running this, I see these warnings:
rpmgrill: WARNING: Arch 'armv7hl' not in my Is_64 table at /usr/share/perl5/vendor_perl/RPM/Grill.pm line 178.
probably for each armv7hl rpm. Does it reduce test coverage? Is this something we should configure somewhere/report a bug against rpmgrill?
Apart from these issues, it seems great! I'll have a look whether we could download build logs for you.
| readme.rst | ||
|---|---|---|
| 12–14 | This is a bit outdated :) | |
| run_rpmgrill.py | ||
| 33 | I think this is not needed (also line 48), because by default your checkname from task formula is used. | |
| 110–113 | Please note that output is not exported into ResultsYAML. You can write it into artifacts, if you wish to have it clearly displayed somewhere. | |
Oh, one more thing, could you nuke the rpmlint-related git history from the repo? It seems the repo has been forked from rpmlint including the git history, let's start with a clean slate.
I'll have a look whether we could download build logs for you.
Created T812 to track that.
Just one minor nit.
| .arcconfig | ||
|---|---|---|
| 2 | s/task-rpmlint/task-rpmgrill/ :) Which means we should create task-rpmgrill project in phab. | |
Seems no more concerns, closing.
| .arcconfig | ||
|---|---|---|
| 2 | Fixed, and done: | |
s/task-rpmlint/task-rpmgrill/ :)
Which means we should create task-rpmgrill project in phab.