resultsdb_directive: print external artifacts URL
ClosedPublic

Authored by kparal on Jan 18 2017, 3:09 PM.

Details

Summary

This should make it easier to find the artifacts storage location when
reading the debug log.

On my localhost, I now see this:

[libtaskotron:resultsdb_directive.py:294] 2017-01-18 14:56:48 INFO    Posting 1 results to ResultsDB...
[libtaskotron:resultsdb_directive.py:325] 2017-01-18 14:56:49 DEBUG   External URL for task artifacts was set to: http://localhost/artifacts/all/20170118_145642_514416

Of course that URL is not correct/configured, but in our real infrastructure the logs should contain something like this:

[libtaskotron:resultsdb_directive.py:325] 2017-01-18 14:56:49 DEBUG   External URL for task artifacts was set to: https://taskotron-dev.fedoraproject.org/artifacts/all/558374a4-dd7a-11e6-8458-525400cb0b45
Test Plan

works on my setup, prints URLs. I hope it'll also print the right URLs in our infra :)

Diff Detail

Repository
rLTRN libtaskotron
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kparal retitled this revision from to resultsdb_directive: print external artifacts URL.Jan 18 2017, 3:09 PM
kparal updated this object.
kparal edited the test plan for this revision. (Show Details)
kparal added a reviewer: libtaskotron.
mkrizek accepted this revision.Jan 18 2017, 4:08 PM
mkrizek added a reviewer: mkrizek.
mkrizek added a subscriber: mkrizek.

Didn't test but the code looks good to me.

This revision is now accepted and ready to land.Jan 18 2017, 4:08 PM
tflink accepted this revision.Jan 18 2017, 4:21 PM
tflink added a reviewer: tflink.

also didn't test but LGTM.

Closed by commit rLTRNaebd7562ae46: resultsdb_directive: print external artifacts URL (authored by Kamil Páral <kparal@redhat.com>). · Explain WhyJan 19 2017, 10:23 AM
This revision was automatically updated to reflect the committed changes.