Add 'previous_outcome' field to fedmsgs
ClosedPublic

Authored by mkrizek on Jan 19 2016, 8:16 PM.

Details

Test Plan
  1. Unittests amended.
  2. Try running a check and see if a fedmsg would or wouldn't have been sent (change fedmsg.publish to print the message). Worked in my testing.

Diff Detail

Repository
rRSDB resultsdb
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mkrizek retitled this revision from to Add 'previous_outcome' field to fedmsgs.Jan 19 2016, 8:16 PM
mkrizek updated this object.
mkrizek edited the test plan for this revision. (Show Details)
mkrizek added reviewers: tflink, kparal, jskladan.
kparal accepted this revision.Jan 20 2016, 9:16 AM
kparal added inline comments.
resultsdb/controllers/api_v1.py
652

It would seem clearer to me if this was:

def create_fedmsg(result, prev_result=None)

But either way works.

If you change this, don't forget to also change the code where you call this :-)

This revision is now accepted and ready to land.Jan 20 2016, 9:16 AM
tflink accepted this revision.Jan 20 2016, 6:13 PM

I'm curious to see what this'll do to the database performance but LGTM

This revision was automatically updated to reflect the committed changes.