implementation of 'instance list'. lists running instances by default, includes non-running instances with --all flag
Details
Details
- Reviewers
roshi - Maniphest Tasks
- T425: Implement the 'instance list' handler to list existing instances
- Commits
- rTCLOUD3fb8b924f2a4: implementing instance list. Fixes T425
unit tests adjusted, works locally
Diff Detail
Diff Detail
- Repository
- rTCLOUD testcloud
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
This looks good to me. I noticed an error, but I don't know if we care about it.
I deleted the instance from within virt-manager, and when I ask for the instance list from testCloud I get a KeyError. If I go and delete the dir that testCloud creates for the instance, then it works fine. Not a huge issue, but something we should handle gracefully in the future. I'll file another task for fixing that - I just don't think it's important for our purposes here and now.