Fixes T378
Details
Details
- Reviewers
tflink - Maniphest Tasks
- T378: listen for compose completion messages in trigger
- Commits
- rTRGR6ed532f2c7ed: Listen for compose completion messages in trigger
tests included
Diff Detail
Diff Detail
- Repository
- rTRGR taskotron-trigger
- Branch
- feature/compose_complete
- Lint
No Linters Available - Unit
No Unit Test Coverage
| jobtriggers/compose_complete_msg.py | ||
|---|---|---|
| 34 | Just realized - what do we pass as "arch" argument here? Empty string? | |
Comment Actions
Looks good to me. If you've been able to see a reaction to a compose completion message locally, push to develop.
It occurs to me that we'll need to add support for the 'compose' item_type in libtaskotron - filed as T381.
| jobtriggers/compose_complete_msg.py | ||
|---|---|---|
| 34 | I guess either empty string or 'noarch'. The runner cli defaults to 'noarch' if there is no arch supplied | |
Just realized - what do we pass as "arch" argument here? Empty string?