add an iscsi test, and a support_server test to support it
ClosedPublic

Authored by adamwill on Jun 8 2016, 7:08 AM.

Details

Summary

this is following a SUSE model for tests where we need a server
end but don't want setting up the server to constitute a real
test in itself, we want it to be stable. The 'support_server'
test just boots a pre-built (by createhdds) disk image, sets up
networking, and runs the iSCSI server.

To run the iSCSI test we need to handle networking config in
anaconda (or we would need to set the support server up as a
DHCP server, which may be worth considering), so this adds that.
We also need to be able to specify the target device for a
volume in custom partitioning, so this adds that too.

Test Plan

Build the necessary support server disk image (use
D883), then run the test and make sure it works. Also make sure
all other tests continue to work.

Diff Detail

Repository
rOPENQATESTS os-autoinst-distri-fedora
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
adamwill retitled this revision from to add an iscsi test, and a support_server test to support it.Jun 8 2016, 7:08 AM
adamwill updated this object.
adamwill edited the test plan for this revision. (Show Details)
adamwill added reviewers: garretraziel, jskladan.

On the question of whether it'd be better to make the support server a DHCP (and possibly DNS) server rather than do static IP config in anaconda - in a sense it might be simpler and less fragile, but OTOH I know how to do static IP config but I'd have to read some docs to figure out how to set up a DHCP server. :P Seriously, though, this also serves as a test of anaconda networking config, which is probably a good thing to have. If we wind up doing a lot of these tests, though, we may still want to consider it in order to avoid having to manually keep track of what IP addresses each test uses etc, and maybe just have a single specific test whose *job* is to check that static IP address config works. For now this seems to work fine, though.

One other note - storage postinstall loading is actually broken in the current code, this fixes it (seems we need to use an absolute path to check for the test's existence). The only other affected test is software_raid (we have not actually been running its postinstall test for however long this has been broken).

adamwill updated this revision to Diff 2261.Jun 8 2016, 6:50 PM

rebase, fix iscsi hash existence check

instead of checking the hashref (as a hashref is always truth-y,
even if it's a ref to an empty hash), check the hash.

garretraziel accepted this revision.Jun 9 2016, 11:39 AM

Works without problem.

This revision is now accepted and ready to land.Jun 9 2016, 11:39 AM
This revision was automatically updated to reflect the committed changes.