taskotron-client: replace vars in yumrepoinfo.conf
ClosedPublic

Authored by kparal on Tue, Jul 11, 11:27 AM.

Details

Summary
Instead of keeping modified version of the config file and merging the
changes every time (which is very error prone - I broke it in
cddf101acb9d), rather store the vanilla version and perform
modifications on top of it. These modifications will fail if the keys
change, hopefully reducing silent failures.
Test Plan

tested locally in a custom playbook

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
kparal created this revision.Tue, Jul 11, 11:27 AM
jskladan accepted this revision.Tue, Jul 11, 11:38 AM

This is fine. At least before we have a better solution - I'd go with diff applied on top of the yumrepoinfo downloaded from repos, or installed from package, so we don't even need to keep the local copy, which can get outdated, and still not fail the checks.

This revision is now accepted and ready to land.Tue, Jul 11, 11:38 AM

Ack. Adding @tflink as a reviewer for more input.

mkrizek accepted this revision.Tue, Jul 11, 1:37 PM
kparal closed this revision.Wed, Jul 12, 10:21 AM

Pushed to ansible as 3952106f493.