Import tap first for validation purposes
ClosedPublic

Authored by mkrizek on May 19 2014, 12:17 PM.

Details

Summary

It seems to me that validation of the items required for resultsdb reporting is done when importing tap results, so unless I am missing something I am proposing this: import tap first for validation purposes and after that check if reporting is enabled.

Fixes T165

Test Plan

None

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
kparal requested changes to this revision.May 19 2014, 1:48 PM

That should work. But could you please add a unit test for it?

Also, I think this behavior and the use case is worth noting in the directive (class) docstring, right?

It seems to me that validation of the items required for resultsdb reporting is done when importing tap results, so unless I am missing something I am proposing this: import tap first for validation purposes and after that check if reporting is enabled.

That makes sense to me but I'd also like to see some logging message(s) saying that the TAP was OK and list out the details that would have been reported.

mkrizek updated this revision.May 20 2014, 11:00 AM

Add docstring
List out the details that would have been reported

I didn't add unit test for this as it seems to me that the change is covered by the current tests, am I missing something?

kparal requested changes to this revision.May 20 2014, 11:34 AM

I didn't add unit test for this as it seems to me that the change is covered by the current tests, am I missing something?

I got confused by "Test Plan: None". If there's already a unit test checking for invalid TAP, everything is fine.

libtaskotron/directives/resultsdb_directive.py
122–123

As discussed in person, please use str(CheckDetail) instead. The correct method is already there.

mkrizek updated this revision.May 20 2014, 12:01 PM

Use str(CheckDetail)

tflink accepted this revision.May 20 2014, 12:35 PM

Looks good to me

jskladan accepted this revision.May 20 2014, 1:00 PM

Coolio, ship it!

kparal accepted this revision.May 20 2014, 1:55 PM
mkrizek closed this revision.May 21 2014, 11:43 AM

Closed by commit rLTRN852212274721 (authored by @mkrizek).