Import/deps fixes
ClosedPublic

Authored by mkrizek on Nov 18 2015, 9:03 PM.

Details

Summary

Couple of fixes of bugs that I found during disposable clients deployment.
Includes:

  • Don't require -disposable in -core
  • We need -core not -disposable on disposable clients
Test Plan

Ran tasks in disposable mode, worked.

Diff Detail

Repository
rLTRN libtaskotron
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mkrizek retitled this revision from to Import/deps fixes.Nov 18 2015, 9:03 PM
mkrizek updated this object.
mkrizek edited the test plan for this revision. (Show Details)
mkrizek added reviewers: tflink, kparal, jskladan, lbrabec.
tflink accepted this revision.Nov 19 2015, 1:02 AM
This revision is now accepted and ready to land.Nov 19 2015, 1:02 AM
lbrabec accepted this revision.Nov 19 2015, 8:32 AM
kparal accepted this revision.Nov 19 2015, 8:44 AM
kparal added inline comments.
libtaskotron/overlord.py
15

Maybe let's add something like this here?

# do not import anything outside of libtaskotron-core here
This revision was automatically updated to reflect the committed changes.