Fix tests
Details
Details
- Reviewers
lbrabec kparal tflink jskladan - Maniphest Tasks
- T597: ssh output from paramiko is cropped or skipped often
- Commits
- rLTRN5e3f11f9ca62: Fix ssh output being skipped often
Tried examples given by kparal in the ticket, worked.
Diff Detail
Diff Detail
- Repository
- rLTRN libtaskotron
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
apart of the nit, lgtm
| testing/test_remote_exec.py | ||
|---|---|---|
| 132 | Maybe add a comment explaining, to us lower mortals, why read=lambda: '' is important here, pls. | |
| testing/test_remote_exec.py | ||
|---|---|---|
| 132 | Because his patch added code which uses .read() method on these objects. Martin could have used Dingus for this, but Bunch works here as well for these simple use cases. PS: Bunch is so outdated, cool kids use Munch these days! | |
Maybe add a comment explaining, to us lower mortals, why read=lambda: '' is important here, pls.