implementing instance list. Fixes T425
ClosedPublic

Authored by tflink on Jun 2 2015, 7:59 PM.

Details

Summary

implementation of 'instance list'. lists running instances by default, includes non-running instances with --all flag

Test Plan

unit tests adjusted, works locally

Diff Detail

Repository
rTCLOUD testcloud
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tflink retitled this revision from to implementing instance list. Fixes T425.Jun 2 2015, 7:59 PM
tflink updated this object.
tflink edited the test plan for this revision. (Show Details)
tflink added a reviewer: roshi.
roshi accepted this revision.Jun 5 2015, 1:04 AM

This looks good to me. I noticed an error, but I don't know if we care about it.

I deleted the instance from within virt-manager, and when I ask for the instance list from testCloud I get a KeyError. If I go and delete the dir that testCloud creates for the instance, then it works fine. Not a huge issue, but something we should handle gracefully in the future. I'll file another task for fixing that - I just don't think it's important for our purposes here and now.

This revision is now accepted and ready to land.Jun 5 2015, 1:04 AM
roshi added a comment.Jun 5 2015, 1:09 AM

Created T493 to track the mentioned bug.

This revision was automatically updated to reflect the committed changes.