Don't try to modify request.args.
ClosedPublic

Authored by ralph on Sep 26 2014, 2:25 PM.

Details

Summary

This works on certain versions of Flask and werkzeug, but not others
(which is why it didn't get caught before T329). This commit retreats
from that approach and addresses the problem more directly...

reqparse was behaving strangely in the presence of arguments it didn't
know about (like 'callback' and '_'). By declaring those arguments and
then not using them, the test case added in the previous commit passes.

Sorry for the mess on this.. :/

Test Plan
The test suite.

Diff Detail

Repository
rRSDB resultsdb
Branch
fix-jsonp-with-test
Lint
No Linters Available
Unit
No Unit Test Coverage
ralph retitled this revision from to Don't try to modify request.args..Sep 26 2014, 2:25 PM
ralph updated this object.
ralph edited the test plan for this revision. (Show Details)
ralph added reviewers: mkrizek, tflink.
tflink accepted this revision.Sep 30 2014, 5:22 AM

LGTM

This revision is now accepted and ready to land.Sep 30 2014, 5:22 AM
mkrizek accepted this revision.Sep 30 2014, 7:51 AM

LGTM. Thanks for adding the test!

ralph closed this revision.Sep 30 2014, 2:09 PM