This adds a new messaging plugin to publish over STOMP.
Details
Details
- Reviewers
jskladan tflink - Group Reviewers
resultsdb - Commits
- rRSDB39f6bf46f441: A stomp messaging plugin.
Unfortunately, you have to set up a broker to really functionally test this. :(
Diff Detail
Diff Detail
- Repository
- rRSDB resultsdb
- Branch
- feature/stomp-publication (branched from develop)
- Lint
Lint OK - Unit
Unit Tests OK - Build Status
Buildable 1132 Build 1132: arc lint + arc unit
Comment Actions
I talked to @ralph on IRC and the motivation behind this is to support the upcoming "Unified Message Bus" project in Red Hat. That uses an ActiveMQ broker which speaks STOMP and they would like to have ResultsDB interface with that broker
Comment Actions
Ping. Any review feedback on this?
We would like to enable it internally but would rather not run a patch out of band.
Comment Actions
Who am I to say what works, and what does not :) I guess you tested it with your usecase, so feel free to merge!
Comment Actions
Thanks! Although, since the move to pagure.io I don't think I have rights to land changes anymore:
❯ arc land feature/stomp-publication
TARGET Landing onto "develop", selected by "arc.land.onto.default" configuration.
REMOTE Using remote "origin", the default remote under git.
FETCH Fetching origin/develop...
This commit will be landed:
- 92b3c2b A stomp messaging plugin.
Landing revision 'D1191: A stomp messaging plugin.'...
BUILDS PASSED Harbormaster builds for the active diff completed successfully.
PUSHING Pushing changes to "origin/develop".
FATAL: W any taskotron/resultsdb ralph DENIED by fallthru
(or you mis-spelled the reponame)
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
Usage Exception: Push failed! Fix the error and run "arc land" again.