updating resultsdb package to be more like other taskotron-related packages
ClosedPublic

Authored by tflink on Apr 16 2014, 8:35 PM.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

I used the more complicated version extraction method here because importing resultsdb causes the full stack of flask, sqlalchemy etc to be imported and then they'd have to be listed as buildrequires.

kparal accepted this revision.Apr 17 2014, 8:39 AM

I used the more complicated version extraction method here because importing resultsdb causes the full stack of flask, sqlalchemy etc to be imported and then they'd have to be listed as buildrequires.

Yeah, I've seen somewhere this as a reason not to perform complicated things in __init__.py. But if the regexp stuff works well, sure, why not.

The changes look ok.

tflink closed this revision.Apr 17 2014, 3:23 PM

Closed by commit rRSDBe4ce893d9dfa (authored by @tflink).