task-rpmgrill
AbandonedPublic

Authored by kparal on Jun 27 2016, 3:28 PM.

Details

Reviewers
mkrizek
jskladan
Group Reviewers
libtaskotron
Maniphest Tasks
T305: Create task for rpmgrill
Test Plan

.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
mkrizek retitled this revision from to task-rpmgrill.Jun 27 2016, 3:28 PM
mkrizek updated this object.
mkrizek edited the test plan for this revision. (Show Details)
mkrizek added a reviewer: libtaskotron.
mkrizek added subscribers: ralph, ralph2.

Created the differential review on behalf of @ralph since he's having issues logging in.

jskladan accepted this revision.Jun 28 2016, 12:51 PM
jskladan added a reviewer: jskladan.
jskladan added a subscriber: jskladan.
This comment was removed by jskladan.
This revision is now accepted and ready to land.Jun 28 2016, 12:51 PM
jskladan requested changes to this revision.Jun 28 2016, 1:15 PM
jskladan added inline comments.
run_rpmgrill.py
121

Please use . as a separator between the rpmgrill namespace, and the checkname. The checkname can then be, of course, named as you wish, but we want to make sure that the namespaces are honoured, even though the actual code to check that is not present in the libtaskotron code at the moment.

This revision now requires changes to proceed.Jun 28 2016, 1:15 PM
kparal requested changes to this revision.EditedJun 28 2016, 1:39 PM
kparal added a reviewer: kparal.
kparal added a subscriber: kparal.

The task is crashing for me:

[rpmgrill:run_rpmgrill.py:126] 2016-06-28 13:22:40 INFO    rpmgrill-virus-check PASSED for htop-1.0.3-6.fc23 (No issues found)
[rpmgrill:run_rpmgrill.py:126] 2016-06-28 13:22:40 INFO    rpmgrill-spec-file-sanity PASSED for htop-1.0.3-6.fc23 (No issues found)
[rpmgrill:run_rpmgrill.py:126] 2016-06-28 13:22:40 INFO    rpmgrill-spec-file-encoding PASSED for htop-1.0.3-6.fc23 (No issues found)
[rpmgrill:run_rpmgrill.py:126] 2016-06-28 13:22:40 INFO    rpmgrill-lib-gather PASSED for htop-1.0.3-6.fc23 (No issues found)
[rpmgrill:run_rpmgrill.py:126] 2016-06-28 13:22:40 INFO    rpmgrill-elf-checks PASSED for htop-1.0.3-6.fc23 (No issues found)
[rpmgrill:run_rpmgrill.py:126] 2016-06-28 13:22:40 INFO    rpmgrill-patches PASSED for htop-1.0.3-6.fc23 (No issues found)
[rpmgrill:run_rpmgrill.py:126] 2016-06-28 13:22:40 INFO    rpmgrill-security-policy PASSED for htop-1.0.3-6.fc23 (No issues found)
[rpmgrill:run_rpmgrill.py:126] 2016-06-28 13:22:40 INFO    rpmgrill-multilib PASSED for htop-1.0.3-6.fc23 (No issues found)
[rpmgrill:run_rpmgrill.py:126] 2016-06-28 13:22:40 INFO    rpmgrill-manifest PASSED for htop-1.0.3-6.fc23 (No issues found)
[rpmgrill:run_rpmgrill.py:126] 2016-06-28 13:22:40 INFO    rpmgrill-man-pages PASSED for htop-1.0.3-6.fc23 (No issues found)
[rpmgrill:run_rpmgrill.py:126] 2016-06-28 13:22:40 INFO    rpmgrill-rpm-scripts PASSED for htop-1.0.3-6.fc23 (No issues found)
[rpmgrill:run_rpmgrill.py:126] 2016-06-28 13:22:40 INFO    rpmgrill-setxid PASSED for htop-1.0.3-6.fc23 (No issues found)
[rpmgrill:run_rpmgrill.py:126] 2016-06-28 13:22:40 INFO    rpmgrill-build-log PASSED for htop-1.0.3-6.fc23 (No issues found)
[rpmgrill:run_rpmgrill.py:126] 2016-06-28 13:22:40 INFO    rpmgrill-desktop-lint PASSED for htop-1.0.3-6.fc23 (No issues found)
[libtaskotron:executor.py:155] 2016-06-28 13:22:40 DEBUG   Variable ${rpmgrill_output} was exported with value:
results:
- checkname: rpmgrill
  item: htop-1.0.3-6.fc23
  note: not all arguments converted during string formatting
  outcome: CRASHED
  type: koji_build

After adding

log.exception(e)

onto line 42 (which I'd recommend), the traceback is:

[rpmgrill:run_rpmgrill.py:42] 2016-06-28 13:30:03 ERROR   not all arguments converted during string formatting
Traceback (most recent call last):
  File "run_rpmgrill.py", line 40, in wrapper
    return fn(**kwargs)
  File "run_rpmgrill.py", line 77, in run
    details = list(massage_results(rpmgrill_results, koji_build, log_path))
  File "run_rpmgrill.py", line 138, in massage_results
    note = "No issues found" % total_issues
TypeError: not all arguments converted during string formatting

A copy paste error :)

Also, when running this, I see these warnings:

rpmgrill: WARNING: Arch 'armv7hl' not in my Is_64 table at /usr/share/perl5/vendor_perl/RPM/Grill.pm line 178.

probably for each armv7hl rpm. Does it reduce test coverage? Is this something we should configure somewhere/report a bug against rpmgrill?

Apart from these issues, it seems great! I'll have a look whether we could download build logs for you.

readme.rst
12–14

This is a bit outdated :)

run_rpmgrill.py
33

I think this is not needed (also line 48), because by default your checkname from task formula is used.

110–113

Please note that output is not exported into ResultsYAML. You can write it into artifacts, if you wish to have it clearly displayed somewhere.

Oh, one more thing, could you nuke the rpmlint-related git history from the repo? It seems the repo has been forked from rpmlint including the git history, let's start with a clean slate.

I'll have a look whether we could download build logs for you.

Created T812 to track that.

kparal commandeered this revision.Jun 29 2016, 7:23 AM
kparal updated this revision to Diff 2315.
kparal edited reviewers, added: mkrizek; removed: kparal.

update to latest ralph's code

kparal updated this revision to Diff 2316.Jun 29 2016, 7:40 AM

fix a bug in store_logs

kparal updated this revision to Diff 2317.Jun 29 2016, 7:47 AM

update readme

I pushed a few changes, looks good to me now :)

Just one minor nit.

.arcconfig
2

s/task-rpmlint/task-rpmgrill/ :)

Which means we should create task-rpmgrill project in phab.

kparal abandoned this revision.Jul 4 2016, 1:53 PM

Seems no more concerns, closing.

.arcconfig
2