bodhi_comment directive should report direct log link
ClosedPublic

Authored by mkrizek on Jun 5 2014, 2:26 PM.

Details

Summary

Fixes T201. In addition, this will probably need, like in autoqa, some url shortening service, any thoughts on whether to implement it as a part of this ticket or create a new ticket for that?

Test Plan

Tests altered

Diff Detail

Repository
rLTRN libtaskotron
Lint
Lint Skipped
Unit
Unit Tests Skipped
mkrizek retitled this revision from to bodhi_comment directive should report direct log link.Jun 5 2014, 2:26 PM
mkrizek updated this object.
mkrizek edited the test plan for this revision. (Show Details)
mkrizek added reviewers: tflink, jskladan, kparal.
tflink added a comment.Jun 9 2014, 4:38 AM

In addition, this will probably need, like in autoqa, some url shortening service, any thoughts on whether to implement it as a part of this ticket or create a new ticket for that?

I see what you mean but I'd prefer to avoid setting up yet another service if possible - especially one that would require MySQL (yourls) when everything else we're using is on postgres. Do you think that it would be worth setting up a yourls instance and integrating python-yourls? AFAIK, the current plan is for bodhi2 to go live after F21 is released and that'll pull directly from resultsdb instead of relying on bodhi comments.

tflink accepted this revision.Jun 9 2014, 4:40 AM

Looks good to me

This revision is now accepted and ready to land.Jun 9 2014, 4:40 AM
kparal requested changes to this revision.Jun 10 2014, 2:53 PM

The new lines are way too long. Please fix line wrapping.

libtaskotron/buildbot_utils.py
2–3

Please include a file header and a module docstring. Don't forget absolute import from future.

This revision now requires changes to proceed.Jun 10 2014, 2:53 PM
mkrizek updated this revision to Diff 384.Jun 10 2014, 3:54 PM

Address issues mentioned in the review

kparal accepted this revision.Jun 11 2014, 10:55 AM

Thanks.

testing/test_bodhi_comment_directive.py
28

Can you wrap this as well?

This revision is now accepted and ready to land.Jun 11 2014, 10:55 AM
mkrizek closed this revision.Jun 12 2014, 8:40 AM
mkrizek updated this revision to Diff 394.

Closed by commit rLTRN366a86e1fd27 (authored by @mkrizek).