spec: add missing deps to sudo, coreutils
ClosedPublic

Authored by kparal on Aug 23 2016, 11:16 AM.

Details

Summary

We started using those in runtime and in test suite. Also update readme.

Test Plan

not tested

Diff Detail

Repository
rLTRN libtaskotron
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kparal retitled this revision from to spec: add missing deps to sudo, coreutils.Aug 23 2016, 11:16 AM
kparal updated this object.
kparal edited the test plan for this revision. (Show Details)
kparal added reviewers: libtaskotron, mkrizek.

Aren't those in minimal install?

In D985#18567, @mkrizek wrote:

Aren't those in minimal install?

Yes, but I don't think that really matters, because the package deps must list everything needed. I guess coreutils dep could have some exception (it's really really basic), but I quickly searched packaging guidelines and didn't find anything about it.

mkrizek added a comment.EditedAug 23 2016, 12:18 PM

Then we need to include kernel into the spec file. On more serious note, I can't imagine use case when one would install libtaskotron on a system without dnf, sudo or coreutils. But if you think this is needed, I don't really care that much.

kparal added a comment.EditedAug 23 2016, 12:41 PM
In D985#18569, @mkrizek wrote:

Then we need to include kernel into the spec file.

Nope. We can run in a docker, without kernel.

On more serious note, I can't imagine use case when one would install libtaskotron on a system without dnf, sudo or coreutils.

Just try dnf remove sudo. No broken deps for me, just this single package removed. I can imagine there can be ultimately stripped systems without this package (or somebody being paranoid).

But if you think this is needed, I don't really care that much.

Realistically, probably it isn't. But it should be there. That's packaging.

Also, it helps folks from other distributions. It's easier to see what the "assumed dependencies" are (which might be different in different distributions).

In D985#18576, @kparal wrote:
In D985#18569, @mkrizek wrote:

Then we need to include kernel into the spec file.

Nope. We can run in a docker, without kernel.

On more serious note, I can't imagine use case when one would install libtaskotron on a system without dnf, sudo or coreutils.

Just try dnf remove sudo. No broken deps for me, just this single package removed. I can imagine there can be ultimately stripped systems without this package (or somebody being paranoid).

Just try dnf remove coreutils.

But if you think this is needed, I don't really care that much.

Realistically, probably it isn't. But it should be there. That's packaging.

Also, it helps folks from other distributions. It's easier to see what the "assumed dependencies" are (which might be different in different distributions).

Then, look at your readme.rst change, you instruct user to do:

sudo dnf install dnf
and
sudo dnf install sudo.

kparal updated this revision to Diff 2513.Aug 23 2016, 1:42 PM
  • people don't like full deps. ignore coreutils, and very common pkgs in readme
mkrizek accepted this revision.Aug 23 2016, 4:13 PM
This revision is now accepted and ready to land.Aug 23 2016, 4:13 PM
This revision was automatically updated to reflect the committed changes.