fix env in Minimal_Package_install conf_test_suites
ClosedPublic
Actions

Authored by garretraziel on Aug 22 2016, 6:49 AM.

Details

Reviewers

Commits

rOPENQAd0ece3060ed3: fix env in Minimal_Package_install conf_test_suites

Summary

I *think* that this is how it should be - reporting with previous
settings showed error for me when I tried to report it. The thing is,
reporting of this test works in production for some reason. @adamwill,
can you please check it?

Test Plan

Try to report minimal_package_install before and after applying
this patch.

Diff Detail

Repository

rOPENQA fedora_openqa

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

garretraziel retitled this revision from to fix env in Minimal_Package_install conf_test_suites.Aug 22 2016, 6:49 AM

garretraziel updated this object.

garretraziel edited the test plan for this revision. (Show Details)

garretraziel added a reviewer: adamwill.

garretraziel added a subscriber: adamwill.

Herald added a subscriber: tflink. · View Herald TranscriptAug 22 2016, 6:49 AM

Hum, well, it shouldn't really matter - as I recall the code - since if there's only one environment it doesn't bother with the setting. So it makes sense to me that it happens to work in production, it surprises me that you got an error. But yes, this is correct.

This revision is now accepted and ready to land.Sep 2 2016, 6:15 PM

Closed by commit rOPENQAd0ece3060ed3: fix env in Minimal_Package_install conf_test_suites (authored by garretraziel). · Explain WhySep 5 2016, 11:32 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

			Path	Packages
M			scheduler/fedora_openqa_schedule/conf_test_suites.py (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	2504	732a13c		Aug 22 2016, 6:49 AM	★	★
Diff 2	2530	5cb778a	rOPENQAd0ece3060ed31f5f60a617f4a4afac327a8099fb	Sep 5 2016, 11:26 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
9857b39420cd	480b25db30e0	732a13c00fb2	Jan Sedlák	fix env in Minimal_Package_install conf_test_suites (Show More…)	Aug 22 2016, 6:48 AM

Diff 2530

View Options

scheduler/fedora_openqa_schedule/conf_test_suites.py