| lbrabec |
SSIA
The workaround is no longer needed with mock 2.0.0.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| Path | Packages | |||
|---|---|---|---|---|
| M | testing/test_rpm_utils.py (4 lines) |
| Commit | Tree | Parents | Author | Summary | Date |
|---|---|---|---|---|---|
| 91d6066957a9 | a7afbb759daa | c7003650f802 | Kamil Páral | Title: tests: remove a workaround for an old mock (Show More…) | Aug 19 2016, 8:36 AM |
| Show First 20 Lines • Show All 214 Lines • ▼ Show 20 Line(s) | 210 | def test_run_twice_on_cache_fail(self): | |||
|---|---|---|---|---|---|
| 215 | 215 | | |||
| 216 | assert self.mock_check_output.call_count == 2 | 216 | assert self.mock_check_output.call_count == 2 | ||
| 217 | assert '--cacheonly' in self.mock_check_output.call_args_list[0][0][0] | 217 | assert '--cacheonly' in self.mock_check_output.call_args_list[0][0][0] | ||
| 218 | assert '--cacheonly' not in self.mock_check_output.call_args_list[1][0][0] | 218 | assert '--cacheonly' not in self.mock_check_output.call_args_list[1][0][0] | ||
| 219 | 219 | | |||
| 220 | def test_run_twice_second_ok(self): | 220 | def test_run_twice_second_ok(self): | ||
| 221 | '''If installation is tried twice and second one succeeds, the whole operation should | 221 | '''If installation is tried twice and second one succeeds, the whole operation should | ||
| 222 | succeed.''' | 222 | succeed.''' | ||
| 223 | # ideally we would use `(self.err, mock.DEFAULT)`, but there's a bug in mock: | 223 | self.mock_check_output.side_effect = (self.err, mock.DEFAULT) | ||
| 224 | # https://github.com/testing-cabal/mock/issues/190 | | |||
| 225 | self.mock_check_output.side_effect = (self.err, '') | | |||
| 226 | install(['foo']) | 224 | install(['foo']) | ||
| 227 | assert self.mock_check_output.call_count == 2 | 225 | assert self.mock_check_output.call_count == 2 | ||
| 228 | 226 | | |||
| 229 | 227 | | |||
| 230 | @pytest.mark.usefixtures('setup') | 228 | @pytest.mark.usefixtures('setup') | ||
| 231 | class TestIsInstalled(object): | 229 | class TestIsInstalled(object): | ||
| 232 | '''Test rpm_utils.is_installed()''' | 230 | '''Test rpm_utils.is_installed()''' | ||
| 233 | 231 | | |||
| ▲ Show 20 Lines • Show All 109 Lines • Show Last 20 Lines | |||||