| lbrabec |
Add more information to documentation. Always set xunit file
as artifact. Use an existing method for creating a success
rate summary. Simplify tests by reusing data. Don't mock builtin
open, override it just inside the module under test.
Bump requirements for mock to 2.0.0 to avoid bugs in older version.
test suite works
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| Path | Packages | |||
|---|---|---|---|---|
| M | docs/source/resultyaml.rst (3 lines) | |||
| M | libtaskotron.spec (2 lines) | |||
| M | libtaskotron/directives/koji_directive.py (2 lines) | |||
| M | libtaskotron/directives/xunit_directive.py (83 lines) | |||
| M | requirements.txt (2 lines) | |||
| M | testing/test_xunit_directive.py (123 lines) |
| Commit | Tree | Parents | Author | Summary | Date |
|---|---|---|---|---|---|
| 46ee390a8319 | 0473f1cd1758 | b655e28df36c | Kamil Páral | make file description more readable | Aug 18 2016, 2:17 PM |
| b655e28df36c | 6b9f89e37f0d | c7003650f802 | Kamil Páral | xunit_directive: improve docs, tests, some code (Show More…) | Aug 18 2016, 1:57 PM |
| 1 | .. _resultyaml-format: | 1 | .. _resultyaml-format: | ||
|---|---|---|---|---|---|
| 2 | 2 | | |||
| 3 | ================== | 3 | ================== | ||
| 4 | Task result format | 4 | Task result format | ||
| 5 | ================== | 5 | ================== | ||
| 6 | 6 | | |||
| 7 | The required output format of the checks in Taskotron is YAML. | 7 | The required output format for tasks in Taskotron is YAML with particular values, which we call | ||
| 8 | *ResultYAML*. | ||||
| 8 | 9 | | |||
| 9 | We recommend using the provided :py:class:`libtaskotron.check.CheckDetail` and the | 10 | We recommend using the provided :py:class:`libtaskotron.check.CheckDetail` and the | ||
| 10 | helper method :py:meth:`libtaskotron.check.export_YAML` to create the YAML output. | 11 | helper method :py:meth:`libtaskotron.check.export_YAML` to create the YAML output. | ||
| 11 | If you can not use it, then please adhere to the specification described below. | 12 | If you can not use it, then please adhere to the specification described below. | ||
| 12 | 13 | | |||
| 13 | 14 | | |||
| 14 | YAML and reporting | 15 | YAML and reporting | ||
| 15 | ================== | 16 | ================== | ||
| ▲ Show 20 Lines • Show All 106 Lines • Show Last 20 Lines | |||||
| Show All 30 Lines | |||||
| 31 | Requires: python-setuptools | 31 | Requires: python-setuptools | ||
| 32 | Requires: python-xunitparser >= 1.3.3 | 32 | Requires: python-xunitparser >= 1.3.3 | ||
| 33 | Requires: PyYAML >= 3.11 | 33 | Requires: PyYAML >= 3.11 | ||
| 34 | Requires: tar >= 1.28-6 | 34 | Requires: tar >= 1.28-6 | ||
| 35 | BuildRequires: pytest >= 2.7.3 | 35 | BuildRequires: pytest >= 2.7.3 | ||
| 36 | BuildRequires: python2-devel | 36 | BuildRequires: python2-devel | ||
| 37 | BuildRequires: python-configparser >= 3.5.0b2 | 37 | BuildRequires: python-configparser >= 3.5.0b2 | ||
| 38 | BuildRequires: python-dingus >= 0.3.4 | 38 | BuildRequires: python-dingus >= 0.3.4 | ||
| 39 | BuildRequires: python-mock >= 1.0.1 | 39 | BuildRequires: python-mock >= 2.0.0 | ||
| 40 | BuildRequires: python-progressbar >= 2.3 | 40 | BuildRequires: python-progressbar >= 2.3 | ||
| 41 | BuildRequires: python-resultsdb_api >= 1.2.2 | 41 | BuildRequires: python-resultsdb_api >= 1.2.2 | ||
| 42 | BuildRequires: python-requests >= 2.7.0 | 42 | BuildRequires: python-requests >= 2.7.0 | ||
| 43 | BuildRequires: python-setuptools | 43 | BuildRequires: python-setuptools | ||
| 44 | BuildRequires: python-xunitparser >= 1.3.3 | 44 | BuildRequires: python-xunitparser >= 1.3.3 | ||
| 45 | BuildRequires: PyYAML >= 3.11 | 45 | BuildRequires: PyYAML >= 3.11 | ||
| 46 | 46 | | |||
| 47 | %description -n libtaskotron-core | 47 | %description -n libtaskotron-core | ||
| ▲ Show 20 Lines • Show All 357 Lines • Show Last 20 Lines | |||||
| Show First 20 Lines • Show All 81 Lines • ▼ Show 20 Line(s) | |||||
| 82 | returns: | | 82 | returns: | | ||
| 83 | A dictionary containing following items: | 83 | A dictionary containing following items: | ||
| 84 | 84 | | |||
| 85 | * `downloaded_rpms`: (list of str) a list of absolute paths of the downloaded RPMs | 85 | * `downloaded_rpms`: (list of str) a list of absolute paths of the downloaded RPMs | ||
| 86 | * `downloaded_logs`: (list of str) a list of absolute paths of the downloaded build logs | 86 | * `downloaded_logs`: (list of str) a list of absolute paths of the downloaded build logs | ||
| 87 | * `log_errors`: (list of str) a list of architectures for which the ``build.log`` could not be | 87 | * `log_errors`: (list of str) a list of architectures for which the ``build.log`` could not be | ||
| 88 | downloaded | 88 | downloaded | ||
| 89 | raises: | | 89 | raises: | | ||
| 90 | * :class:`.TaskotronDirectiveError`: if mandatory parameters are missing or incorrect parameter | ||||
| 91 | values were provided | ||||
| 90 | * :class:`.TaskotronRemoteError`: if downloading failed | 92 | * :class:`.TaskotronRemoteError`: if downloading failed | ||
| 91 | version_added: 0.4 | 93 | version_added: 0.4 | ||
| 92 | """ | 94 | """ | ||
| 93 | 95 | | |||
| 94 | EXAMPLES = """ | 96 | EXAMPLES = """ | ||
| 95 | Rpmlint needs to download a specific build from Koji, all architectures | 97 | Rpmlint needs to download a specific build from Koji, all architectures | ||
| 96 | including src.rpm:: | 98 | including src.rpm:: | ||
| 97 | 99 | | |||
| ▲ Show 20 Lines • Show All 149 Lines • Show Last 20 Lines | |||||
| Show All 9 Lines | |||||
| 10 | from libtaskotron.directives import BaseDirective | 10 | from libtaskotron.directives import BaseDirective | ||
| 11 | from libtaskotron.exceptions import TaskotronDirectiveError | 11 | from libtaskotron.exceptions import TaskotronDirectiveError | ||
| 12 | from libtaskotron.check import CheckDetail, export_YAML | 12 | from libtaskotron.check import CheckDetail, export_YAML | ||
| 13 | 13 | | |||
| 14 | DOCUMENTATION = """ | 14 | DOCUMENTATION = """ | ||
| 15 | module: xunit_directive | 15 | module: xunit_directive | ||
| 16 | short_description: parse XML xUnit file | 16 | short_description: parse XML xUnit file | ||
| 17 | description: | | 17 | description: | | ||
| 18 | Parse test ouput in XML xUnit format and generate ResultYAML for further use (i.e. in resultsdb) | 18 | Parse test ouput in XML xUnit format and generate :doc:`ResultYAML </resultyaml>` for further use | ||
| 19 | (i.e. directly usable in :doc:`resultsdb directive <resultsdb_directive_module>`). | ||||
| 20 | | ||||
| 21 | .. note:: | ||||
| 22 | The input xUnit file is set as an artifact in the output ResultYAML result, therefore it's | ||||
| 23 | recommended that you place it inside ``${artifactsdir}``. | ||||
| 19 | parameters: | 24 | parameters: | ||
| 20 | file: | 25 | file: | ||
| 21 | required: true | 26 | required: true | ||
| 22 | description: xml file to be parsed, relative path is to the task formula file | 27 | description: xUnit XML file path to be parsed, either absolute or relative to task directory | ||
| 23 | type: str | 28 | type: str | ||
| 24 | aggregation: | 29 | aggregation: | ||
| 25 | required: false | 30 | required: false | ||
| 26 | description: type of result aggregation, ``none`` means no aggregation will be use and all | 31 | description: | | ||
| 27 | testcases will be reporter as separate results. ``allpass`` will agregate testcases into | 32 | type of result aggregation: ``allpass`` will aggregate testcases into a single result with | ||
| 28 | one results with outcome ``PASSED`` if all testcases passed otherwise ``FAILED`` outcome is | 33 | outcome ``PASSED`` if all testcases passed, otherwise ``FAILED``. ``none`` means no | ||
| 29 | set. | 34 | aggregation and all testcases will be reported as separate results. | ||
| 30 | If not provided ``allpass`` is default value. | | |||
| 31 | type: str | 35 | type: str | ||
| 36 | default: allpass | ||||
| 37 | choices: [allpass, none] | ||||
| 32 | returns: | | 38 | returns: | | ||
| 33 | Returns output of the check in the ResultYAML format directly usable in | 39 | check result(s) in the ResultYAML format | ||
| 34 | :ref:`resultsdb directive <resultsdb_directive>` | | |||
| 35 | | ||||
| 36 | raises: | | 40 | raises: | | ||
| 37 | * :class:`.TaskotronDirectiveError`: if ``file`` was not provided or aggregation | 41 | * :class:`.TaskotronDirectiveError`: if mandatory parameters are missing or incorrect parameter | ||
| 38 | was set to unknown type. | 42 | values were provided | ||
| 39 | version_added: 0.4.14 | 43 | version_added: 0.4.14 | ||
| 40 | """ | 44 | """ | ||
| 41 | 45 | | |||
| 42 | EXAMPLES = """ | 46 | EXAMPLES = """ | ||
| 43 | This example parses XML file located in ``artifactsdir`` generates ResultYAML with no aggregation | 47 | This example parses xUnit XML file located in ``${artifactsdir}``, generates ResultYAML from it and | ||
| 44 | and exports it to variable which is finally passed to ``resultsdb``:: | 48 | exports it to a variable which is then passed to ``resultsdb`` directive:: | ||
| 45 | 49 | | |||
| 46 | - name: parse test output | 50 | - name: parse xunit output | ||
| 47 | xunit: | 51 | xunit: | ||
| 48 | file: ${artifactsdir}/output.xml | 52 | file: ${artifactsdir}/xunit_output.xml | ||
| 49 | aggregation: none | 53 | export: resultyaml | ||
| 50 | export: test_output | | |||
| 51 | 54 | | |||
| 52 | - name: report results to resultsdb | 55 | - name: report results to resultsdb | ||
| 53 | resultsdb: | 56 | resultsdb: | ||
| 54 | results: ${test_output} | 57 | results: ${resultyaml} | ||
| 55 | """ | 58 | """ | ||
| 56 | 59 | | |||
| 57 | aggregations = ['none', 'allpass'] | | |||
| 58 | | ||||
| 59 | directive_class = 'XunitDirective' | 60 | directive_class = 'XunitDirective' | ||
| 60 | 61 | | |||
| 61 | 62 | | |||
| 62 | class XunitDirective(BaseDirective): | 63 | class XunitDirective(BaseDirective): | ||
| 64 | | ||||
| 65 | aggregations = ['none', 'allpass'] | ||||
| 66 | | ||||
| 63 | def process(self, params, arg_data): | 67 | def process(self, params, arg_data): | ||
| 64 | try: | 68 | if 'file' not in params: | ||
| 65 | artifact = params['file'] | | |||
| 66 | except KeyError: | | |||
| 67 | raise TaskotronDirectiveError('No file provided.') | 69 | raise TaskotronDirectiveError('No file provided.') | ||
| 70 | xunitfile = params['file'] | ||||
| 68 | 71 | | |||
| 69 | aggregation = params.get('aggregation', 'allpass') | 72 | aggregation = params.get('aggregation', 'allpass') | ||
| 70 | 73 | | |||
| 71 | if not arg_data['item'] or not arg_data['type']: | 74 | if not arg_data['item'] or not arg_data['type']: | ||
| 72 | raise TaskotronDirectiveError('Item and its type has to be provided.') | 75 | raise TaskotronDirectiveError('Item and its type has to be provided.') | ||
| 73 | 76 | | |||
| 74 | if aggregation not in aggregations: | 77 | if aggregation not in self.aggregations: | ||
| 75 | raise TaskotronDirectiveError( | 78 | raise TaskotronDirectiveError( | ||
| 76 | 'Aggregation must be one of %s.' % ', '.join(aggregations)) | 79 | "Aggregation '%s' is not one of: %s" % (aggregation, ', '.join(self.aggregations))) | ||
| 77 | 80 | | |||
| 78 | with open(artifact) as xmlfile: | 81 | with open(xunitfile) as xmlfile: | ||
| 79 | testsuite, testresult = xunitparser.parse(xmlfile) | 82 | testsuite, testresult = xunitparser.parse(xmlfile) | ||
| 80 | 83 | | |||
| 81 | if aggregation == 'none': | 84 | if aggregation == 'none': | ||
| 82 | details = [] | 85 | details = [] | ||
| 83 | for tc in testsuite: | 86 | for tc in testsuite: | ||
| 84 | outcome = 'PASSED' if tc.good else 'FAILED' | 87 | outcome = 'PASSED' if tc.good else 'FAILED' | ||
| 85 | details.append(CheckDetail(item=arg_data['item'], | 88 | details.append(CheckDetail(item=arg_data['item'], | ||
| 86 | checkname="%s.%s" % (arg_data['checkname'], | 89 | checkname="%s.%s" % (arg_data['checkname'], | ||
| 87 | tc.methodname), | 90 | tc.methodname), | ||
| 88 | report_type=arg_data['type'], | 91 | report_type=arg_data['type'], | ||
| 89 | outcome=outcome)) | 92 | outcome=outcome, | ||
| 90 | 93 | artifact=xunitfile)) | |||
| 91 | return export_YAML(details) | 94 | return export_YAML(details) | ||
| 95 | | ||||
| 92 | elif aggregation == 'allpass': | 96 | elif aggregation == 'allpass': | ||
| 93 | summary = "%d PASSED, %d FAILED" | 97 | passed = len([tc for tc in testsuite if tc.good]) | ||
| 94 | passed = 0 | 98 | failed = len([tc for tc in testsuite if not tc.good]) | ||
| 95 | failed = 0 | 99 | final_outcome = 'PASSED' if failed == 0 else 'FAILED' | ||
| 96 | final_outcome = 'PASSED' | 100 | note = CheckDetail.create_multi_item_summary(['PASSED'] * passed + ['FAILED'] * failed) | ||
| 97 | for tc in testsuite: | | |||
| 98 | if tc.good: | | |||
| 99 | passed += 1 | | |||
| 100 | else: | | |||
| 101 | failed += 1 | | |||
| 102 | final_outcome = 'FAILED' | | |||
| 103 | 101 | | |||
| 104 | summary = summary % (passed, failed) | | |||
| 105 | return export_YAML(CheckDetail(item=arg_data['item'], | 102 | return export_YAML(CheckDetail(item=arg_data['item'], | ||
| 106 | note=summary, | 103 | note=note, | ||
| 107 | report_type=arg_data['type'], | 104 | report_type=arg_data['type'], | ||
| 108 | outcome=final_outcome, | 105 | outcome=final_outcome, | ||
| 109 | artifact=artifact)) | 106 | artifact=xunitfile)) | ||
| 110 | 107 | | |||
| 111 | else: | 108 | else: | ||
| 112 | assert False, "This should never happen" | 109 | assert False, "This should never happen, aggregation is %r" % aggregation | ||
| 1 | # This is a list of pypi packages to be installed into virtualenv. Alternatively, | 1 | # This is a list of pypi packages to be installed into virtualenv. Alternatively, | ||
|---|---|---|---|---|---|
| 2 | # you can install these as RPMs instead of pypi packages. Use | 2 | # you can install these as RPMs instead of pypi packages. Use | ||
| 3 | # `rpmspec -q --requires libtaskotron.spec` and | 3 | # `rpmspec -q --requires libtaskotron.spec` and | ||
| 4 | # `rpmspec -q --buildrequires libtaskotron.spec` to get a list of RPM dependencies. | 4 | # `rpmspec -q --buildrequires libtaskotron.spec` to get a list of RPM dependencies. | ||
| 5 | # | 5 | # | ||
| 6 | # A note for maintainers: Please keep this list in sync with libtaskotron.spec. | 6 | # A note for maintainers: Please keep this list in sync with libtaskotron.spec. | ||
| 7 | # You should require exact versions here (in order to define an exact working | 7 | # You should require exact versions here (in order to define an exact working | ||
| 8 | # environment), and require a minimal version in the spec file (in order to allow | 8 | # environment), and require a minimal version in the spec file (in order to allow | ||
| 9 | # the libraries to have some minor version bumps during the Fedora release | 9 | # the libraries to have some minor version bumps during the Fedora release | ||
| 10 | # lifecycle). If the Fedora libraries span multiple versions across releases, | 10 | # lifecycle). If the Fedora libraries span multiple versions across releases, | ||
| 11 | # you can define a dependency range here instead of an exact version. | 11 | # you can define a dependency range here instead of an exact version. | ||
| 12 | 12 | | |||
| 13 | configparser == 3.5.0b2 | 13 | configparser == 3.5.0b2 | ||
| 14 | dingus == 0.3.4 | 14 | dingus == 0.3.4 | ||
| 15 | Jinja2 == 2.8 | 15 | Jinja2 == 2.8 | ||
| 16 | munch == 2.0.2 | 16 | munch == 2.0.2 | ||
| 17 | mock == 1.0.1 | 17 | mock == 2.0.0 | ||
| 18 | paramiko == 1.15.1 | 18 | paramiko == 1.15.1 | ||
| 19 | pytest == 2.7.3 | 19 | pytest == 2.7.3 | ||
| 20 | pytest-cov == 2.2.1 | 20 | pytest-cov == 2.2.1 | ||
| 21 | python-fedora == 0.8.0 | 21 | python-fedora == 0.8.0 | ||
| 22 | progressbar == 2.3 | 22 | progressbar == 2.3 | ||
| 23 | requests == 2.7.0 | 23 | requests == 2.7.0 | ||
| 24 | PyYAML == 3.11 | 24 | PyYAML == 3.11 | ||
| 25 | resultsdb_api == 1.2.2 | 25 | resultsdb_api == 1.2.2 | ||
| 26 | Sphinx == 1.2.3 | 26 | Sphinx == 1.2.3 | ||
| 27 | xunitparser == 1.3.3 | 27 | xunitparser == 1.3.3 | ||
| 1 | # -*- coding: utf-8 -*- | 1 | # -*- coding: utf-8 -*- | ||
|---|---|---|---|---|---|
| 2 | # Copyright 2009-2014, Red Hat, Inc. | 2 | # Copyright 2009-2014, Red Hat, Inc. | ||
| 3 | # License: GPL-2.0+ <http://spdx.org/licenses/GPL-2.0+> | 3 | # License: GPL-2.0+ <http://spdx.org/licenses/GPL-2.0+> | ||
| 4 | # See the LICENSE file for more details on Licensing | 4 | # See the LICENSE file for more details on Licensing | ||
| 5 | 5 | | |||
| 6 | from libtaskotron.directives import xunit_directive | 6 | from libtaskotron.directives import xunit_directive | ||
| 7 | from libtaskotron.exceptions import TaskotronDirectiveError | 7 | from libtaskotron.exceptions import TaskotronDirectiveError | ||
| 8 | from libtaskotron.check import import_YAML | 8 | from libtaskotron.check import import_YAML | ||
| 9 | 9 | | |||
| 10 | import mock | 10 | import mock | ||
| 11 | import pytest | 11 | import pytest | ||
| 12 | import xunitparser | 12 | import xunitparser | ||
| 13 | import io | | |||
| 14 | 13 | | |||
| 15 | OUTPUT = 'Kilo kabanosu naprudko' | 14 | OUTPUT = 'I shall not use Czech in source code' | ||
| 16 | 15 | | |||
| 17 | XML = """<?xml version="1.0"?> | 16 | XML = """<?xml version="1.0"?> | ||
| 18 | <testsuite errors="0" failures="0" name="pytest" skips="0" tests="3" time="17.131"> | 17 | <testsuite errors="0" failures="0" name="pytest" skips="0" tests="3" time="17.131"> | ||
| 19 | <testcase classname="test.TestClass" file="test.py" line="30" name="test1" time="2.76759004593"> | 18 | <testcase classname="test.TestClass" file="test.py" line="30" name="test1" time="2.76759004593"> | ||
| 20 | <system-out></system-out></testcase> | 19 | <system-out></system-out></testcase> | ||
| 21 | <testcase classname="test.TestClass" file="test.py" line="34" name="test2" time="2.67303919792"> | 20 | <testcase classname="test.TestClass" file="test.py" line="34" name="test2" time="2.67303919792"> | ||
| 22 | <system-out></system-out></testcase> | 21 | <system-out></system-out></testcase> | ||
| 23 | <testcase classname="test.TestClass" file="test.py" line="52" name="test3" time="11.6780951023"> | 22 | <testcase classname="test.TestClass" file="test.py" line="52" name="test3" time="11.6780951023"> | ||
| 24 | <system-out></system-out></testcase></testsuite>""" | 23 | <system-out></system-out></testcase></testsuite>""" | ||
| 25 | 24 | | |||
| 26 | 25 | | |||
| 27 | class TestCheckParams(object): | 26 | class TestCheckParams(object): | ||
| 28 | def test_file_present(self, monkeypatch): | | |||
| 29 | test_params = {'file': 'json.xml'} | | |||
| 30 | test_arg_data = {'item': 'starobrno', 'type': 'skopek'} | | |||
| 31 | 27 | | |||
| 32 | test_directive = xunit_directive.XunitDirective() | 28 | def setup(self): | ||
| 29 | self.params = {'file': 'json.xml'} | ||||
| 30 | self.arg_data = {'item': 'some_item', 'type': 'some_type'} | ||||
| 31 | self.directive = xunit_directive.XunitDirective() | ||||
| 33 | 32 | | |||
| 33 | @pytest.fixture | ||||
| 34 | def mock_parse(self, monkeypatch): | ||||
| 34 | stub_parse = mock.MagicMock(return_value=([], True)) | 35 | stub_parse = mock.MagicMock(return_value=([], True)) | ||
| 35 | monkeypatch.setattr(xunitparser, 'parse', stub_parse) | 36 | monkeypatch.setattr(xunitparser, 'parse', stub_parse) | ||
| 36 | 37 | | |||
| 37 | with mock.patch('__builtin__.open', mock.mock_open(), create=True): | 38 | @pytest.fixture | ||
| 38 | with mock.patch('libtaskotron.directives.xunit_directive.export_YAML', | 39 | def mock_open(self, monkeypatch, read_data=None): | ||
| 39 | mock.MagicMock(return_value=OUTPUT)): | 40 | monkeypatch.setattr(xunit_directive, 'open', mock.mock_open(read_data=read_data), | ||
| 40 | output = test_directive.process(test_params, test_arg_data) | 41 | raising=False) | ||
| 41 | 42 | | |||
| 42 | assert output == OUTPUT | 43 | def test_file_present(self, monkeypatch, mock_parse, mock_open): | ||
| 43 | 44 | monkeypatch.setattr(xunit_directive, 'export_YAML', mock.Mock(return_value=OUTPUT)) | |||
| 44 | def test_file_not_present(self, monkeypatch): | | |||
| 45 | test_params = {'fila': 'json.xml'} | | |||
| 46 | test_arg_data = {'item': 'starobrno', 'type': 'skopek'} | | |||
| 47 | test_directive = xunit_directive.XunitDirective() | | |||
| 48 | | ||||
| 49 | stub_parse = mock.MagicMock(return_value=([], True)) | | |||
| 50 | monkeypatch.setattr(xunitparser, 'parse', stub_parse) | | |||
| 51 | | ||||
| 52 | with mock.patch('__builtin__.open', mock.mock_open(), create=True): | | |||
| 53 | with pytest.raises(TaskotronDirectiveError): | | |||
| 54 | test_directive.process(test_params, test_arg_data) | | |||
| 55 | 45 | | |||
| 56 | def test_item_not_present(self, monkeypatch): | 46 | output = self.directive.process(self.params, self.arg_data) | ||
| 57 | test_params = {'file': 'json.xml'} | 47 | assert output == OUTPUT | ||
| 58 | test_arg_data = {'item': None, 'type': 'skopek'} | | |||
| 59 | test_directive = xunit_directive.XunitDirective() | | |||
| 60 | 48 | | |||
| 61 | stub_parse = mock.MagicMock(return_value=([], True)) | 49 | def test_file_not_present(self, mock_parse, mock_open): | ||
| 62 | monkeypatch.setattr(xunitparser, 'parse', stub_parse) | 50 | self.params = {'fila': 'json.xml'} | ||
| 63 | 51 | | |||
| 64 | with mock.patch('__builtin__.open', mock.mock_open(), create=True): | 52 | with pytest.raises(TaskotronDirectiveError): | ||
| 65 | with pytest.raises(TaskotronDirectiveError): | 53 | self.directive.process(self.params, self.arg_data) | ||
| 66 | test_directive.process(test_params, test_arg_data) | | |||
| 67 | 54 | | |||
| 68 | def test_type_not_present(self, monkeypatch): | 55 | def test_item_not_present(self, mock_parse, mock_open): | ||
| 69 | test_params = {'file': 'json.xml'} | 56 | self.arg_data['item'] = None | ||
| 70 | test_arg_data = {'item': 'starobrno', 'type': None} | | |||
| 71 | test_directive = xunit_directive.XunitDirective() | | |||
| 72 | 57 | | |||
| 73 | stub_parse = mock.MagicMock(return_value=([], True)) | 58 | with pytest.raises(TaskotronDirectiveError): | ||
| 74 | monkeypatch.setattr(xunitparser, 'parse', stub_parse) | 59 | self.directive.process(self.params, self.arg_data) | ||
| 75 | | ||||
| 76 | with mock.patch('__builtin__.open', mock.mock_open(), create=True): | | |||
| 77 | with pytest.raises(TaskotronDirectiveError): | | |||
| 78 | test_directive.process(test_params, test_arg_data) | | |||
| 79 | 60 | | |||
| 80 | def test_file_does_not_exist(self, monkeypatch): | 61 | def test_type_not_present(self, mock_parse, mock_open): | ||
| 81 | test_params = {'file': 'json.xml'} | 62 | self.arg_data['type'] = None | ||
| 82 | test_arg_data = {'item': 'starobrno', 'type': 'skopek'} | | |||
| 83 | test_directive = xunit_directive.XunitDirective() | | |||
| 84 | 63 | | |||
| 85 | stub_parse = mock.MagicMock(return_value=([], True)) | 64 | with pytest.raises(TaskotronDirectiveError): | ||
| 86 | monkeypatch.setattr(xunitparser, 'parse', stub_parse) | 65 | self.directive.process(self.params, self.arg_data) | ||
| 87 | 66 | | |||
| 67 | def test_file_does_not_exist(self, mock_parse): | ||||
| 88 | with pytest.raises(IOError): | 68 | with pytest.raises(IOError): | ||
| 89 | test_directive.process(test_params, test_arg_data) | 69 | self.directive.process(self.params, self.arg_data) | ||
| 90 | 70 | | |||
| 91 | def test_aggregation_unknown(self, monkeypatch): | 71 | def test_aggregation_unknown(self, mock_parse): | ||
| 92 | test_params = {'file': 'json.xml', 'aggregation': 'allfail'} | 72 | self.params['aggregation'] = 'allfail' | ||
| 93 | test_arg_data = {'item': 'starobrno', 'type': 'skopek'} | | |||
| 94 | test_directive = xunit_directive.XunitDirective() | | |||
| 95 | | ||||
| 96 | stub_parse = mock.MagicMock(return_value=([], True)) | | |||
| 97 | monkeypatch.setattr(xunitparser, 'parse', stub_parse) | | |||
| 98 | 73 | | |||
| 99 | with pytest.raises(TaskotronDirectiveError): | 74 | with pytest.raises(TaskotronDirectiveError): | ||
| 100 | test_directive.process(test_params, test_arg_data) | 75 | self.directive.process(self.params, self.arg_data) | ||
| 101 | 76 | | |||
| 102 | def test_aggregation_none(self, monkeypatch): | 77 | def test_aggregation_none(self, monkeypatch): | ||
| 103 | test_params = {'file': 'json.xml', 'aggregation': 'none'} | 78 | self.params['aggregation'] = 'none' | ||
| 104 | test_arg_data = {'item': 'starobrno', 'type': 'skopek', 'checkname': 'ochutnavka'} | 79 | self.arg_data['checkname'] = 'mycheck' | ||
| 105 | test_directive = xunit_directive.XunitDirective() | 80 | self.mock_open(monkeypatch, read_data=XML) | ||
| 106 | | ||||
| 107 | # https://bugzilla.redhat.com/show_bug.cgi?id=1244145#c18 | | |||
| 108 | # with mock.patch('__builtin__.open', mock.mock_open(read_data=XML), create=True): | | |||
| 109 | with mock.patch('__builtin__.open', mock.MagicMock(return_value=io.BytesIO(XML)), | | |||
| 110 | create=True): | | |||
| 111 | output = test_directive.process(test_params, test_arg_data) | | |||
| 112 | 81 | | |||
| 82 | output = self.directive.process(self.params, self.arg_data) | ||||
| 113 | assert len(import_YAML(output)) == 3 | 83 | assert len(import_YAML(output)) == 3 | ||
| 114 | 84 | | |||
| 115 | def test_aggregation_allpass(self, monkeypatch): | 85 | def test_aggregation_allpass(self, monkeypatch): | ||
| 116 | test_params = {'file': 'json.xml', 'aggregation': 'allpass'} | 86 | self.params['aggregation'] = 'allpass' | ||
| 117 | test_arg_data = {'item': 'starobrno', 'type': 'skopek'} | 87 | self.mock_open(monkeypatch, read_data=XML) | ||
| 118 | test_directive = xunit_directive.XunitDirective() | | |||
| 119 | | ||||
| 120 | # ditto | | |||
| 121 | with mock.patch('__builtin__.open', mock.MagicMock(return_value=io.BytesIO(XML)), | | |||
| 122 | create=True): | | |||
| 123 | output = test_directive.process(test_params, test_arg_data) | | |||
| 124 | 88 | | |||
| 89 | output = self.directive.process(self.params, self.arg_data) | ||||
| 125 | assert len(import_YAML(output)) == 1 | 90 | assert len(import_YAML(output)) == 1 | ||
| 126 | 91 | | |||
| 127 | def test_aggregation_allpass_default(self, monkeypatch): | 92 | def test_aggregation_allpass_default(self, monkeypatch): | ||
| 128 | test_params = {'file': 'json.xml'} | 93 | self.mock_open(monkeypatch, read_data=XML) | ||
| 129 | test_arg_data = {'item': 'starobrno', 'type': 'skopek'} | | |||
| 130 | test_directive = xunit_directive.XunitDirective() | | |||
| 131 | | ||||
| 132 | # ditto | | |||
| 133 | with mock.patch('__builtin__.open', mock.MagicMock(return_value=io.BytesIO(XML)), | | |||
| 134 | create=True): | | |||
| 135 | output = test_directive.process(test_params, test_arg_data) | | |||
| 136 | 94 | | |||
| 95 | output = self.directive.process(self.params, self.arg_data) | ||||
| 137 | assert len(import_YAML(output)) == 1 | 96 | assert len(import_YAML(output)) == 1 | ||