Differential D974

Default to the current milestone when proposing a blocker
ClosedPublic
Actions

Authored by mkrizek on Aug 18 2016, 10:49 AM.

Details

Reviewers
tflink
Group Reviewers
blockerbugs
Maniphest Tasks
T805: Blocker nominations should be for the 'current' milestone by default, not the first active milestone
Commits
rBLKR1196beff12fd: Default to the current milestone when proposing a blocker
Test Plan

Tested manually, worked for me.

Diff Detail

Repository
rBLKR blockerbugs
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mkrizek retitled this revision from to Default to the current milestone when proposing a blocker.Aug 18 2016, 10:49 AM
mkrizek updated this object.
mkrizek edited the test plan for this revision. (Show Details)
mkrizek added reviewers: blockerbugs, tflink.
tflink accepted this revision.Sep 12 2016, 6:31 PM
tflink added inline comments.
blockerbugs/controllers/main.py
387–389

The only concern I have is that this assumes that milestones are created in order. While that's true in practice, there's nothing in the app which enforces this.

That being said, I don't have a better idea for how to sort them :)

This revision is now accepted and ready to land.Sep 12 2016, 6:31 PM
Closed by commit rBLKR1196beff12fd: Default to the current milestone when proposing a blocker (authored by mkrizek). · Explain WhySep 13 2016, 11:22 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathPackages
Mblockerbugs/controllers/main.py (7 lines)

Diff 2553

View Options

blockerbugs/controllers/main.py

Show First 20 Lines • Show All 375 Lines • ▼ Show 20 Line(s)
376 376​
377@main.route('/propose_bug', methods=['GET', 'POST']) 377​@main.route('/propose_bug', methods=['GET', 'POST'])
378@fas_login_required 378​@fas_login_required
379def propose_bug(): 379​def propose_bug():
380 user_info = UserInfo.query.filter_by(fas_login=g.fas_user.username).first() 380​ user_info = UserInfo.query.filter_by(fas_login=g.fas_user.username).first()
381 if not user_info or not user_info.bz_user: 381​ if not user_info or not user_info.bz_user:
382 return redirect(url_for('.fas_bugzilla')) 382​ return redirect(url_for('.fas_bugzilla'))
383 383​
384​ current_milestone = get_current_milestone()
384 bugform = BugProposeForm() 385​ bugform = BugProposeForm()
385 bugform.bz_user.data = user_info.bz_user 386​ bugform.bz_user.data = user_info.bz_user
386 bugform.milestone.choices = [(m.id, m.name) for m in Milestone.query.filter_by(active=True).all()] 387​ bugform.milestone.choices = [(m.id, m.name) for m in Milestone.query.filter_by(active=True).order_by(Milestone.id).all()]
388​ bugform.milestone.default = current_milestone.id
389​ bugform.process()
tflinkUnsubmitted
Not Done

The only concern I have is that this assumes that milestones are created in order. While that's true in practice, there's nothing in the app which enforces this.

That being said, I don't have a better idea for how to sort them :)

387 390​
388 if bugform.validate_on_submit(): 391​ if bugform.validate_on_submit():
389 app.logger.debug('bugid: %i' % bugform.bugid.data) 392​ app.logger.debug('bugid: %i' % bugform.bugid.data)
390 app.logger.debug('bz_user: %s' % user_info.bz_user) 393​ app.logger.debug('bz_user: %s' % user_info.bz_user)
391 app.logger.debug('milestone: %i' % bugform.milestone.data) 394​ app.logger.debug('milestone: %i' % bugform.milestone.data)
392 app.logger.debug('blocker: %s' % unicode(bugform.blocker.data)) 395​ app.logger.debug('blocker: %s' % unicode(bugform.blocker.data))
393 app.logger.debug('freeze_exception: %s' % unicode(bugform.freeze_exception.data)) 396​ app.logger.debug('freeze_exception: %s' % unicode(bugform.freeze_exception.data))
394 app.logger.debug('justification: %s' % unicode(bugform.justification.data)) 397​ app.logger.debug('justification: %s' % unicode(bugform.justification.data))
▲ Show 20 Lines • Show All 42 Lines • ▼ Show 20 Line(s)438 except BZInterfaceError, e:
437 app.logger.info('bug proposal form errors: %s' % e.msg) 440​ app.logger.info('bug proposal form errors: %s' % e.msg)
438 else: 441​ else:
439 app.logger.info('bug proposal form errors: %s' % unicode(bugform.errors)) 442​ app.logger.info('bug proposal form errors: %s' % unicode(bugform.errors))
440 443​
441 # this assumes that the current milestone is the release against which the 444​ # this assumes that the current milestone is the release against which the
442 # blocker is being proposed. It isn't an ideal assumption but it should hold 445​ # blocker is being proposed. It isn't an ideal assumption but it should hold
443 # for most use cases. 446​ # for most use cases.
444 447​
445 current_release = get_current_milestone().release.number 448​ current_release = current_milestone.release.number
446 return render_template('propose_bug.html', title='Propose a Blocker or Freeze Exception', 449​ return render_template('propose_bug.html', title='Propose a Blocker or Freeze Exception',
447 bugform=bugform, release=current_release) 450​ bugform=bugform, release=current_release)