Differential D972

symlink testcloud images instead of copying
ClosedPublic
Actions

Authored by kparal on Aug 15 2016, 8:13 AM.

Details

Reviewers
lbrabec
mkrizek
Maniphest Tasks
T829: testcloud race condition when populating backingstores
Commits
rLTRN5feca2a43e74: symlink testcloud images instead of copying
Summary

Make use of new testcloud API allowing us to symlink images into
testcloud's backingstores/, instead of copying it there. This makes the
image management easier for the user (also saves space).

Bump requirement on testcloud to 0.1.10.

Test Plan

tested manually by removing everything in /var/lib/testcloud/backingstores/ and then running some minion tasks, symlinks created OK, tasks worked

Diff Detail

Repository
rLTRN libtaskotron
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kparal retitled this revision from to symlink testcloud images instead of copying.Aug 15 2016, 8:13 AM
kparal updated this object.
kparal edited the test plan for this revision. (Show Details)
kparal added reviewers: mkrizek, lbrabec.
lbrabec accepted this revision.Aug 15 2016, 8:15 AM
This revision is now accepted and ready to land.Aug 15 2016, 8:15 AM
mkrizek accepted this revision.Aug 15 2016, 8:16 AM
Closed by commit rLTRN5feca2a43e74: symlink testcloud images instead of copying (authored by kparal). · Explain WhyAug 15 2016, 9:46 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathPackages
Mlibtaskotron.spec (4 lines)
Mlibtaskotron/ext/disposable/vm.py (5 lines)

Diff 2488

View Options

libtaskotron.spec

Show First 20 Lines • Show All 74 Lines • ▼ Show 20 Line(s)
75%description -n libtaskotron-fedora 75​%description -n libtaskotron-fedora
76Module for libtaskotron which contains all functionality which is fedora-only 76​Module for libtaskotron which contains all functionality which is fedora-only
77 77​
78%package -n libtaskotron-disposable 78​%package -n libtaskotron-disposable
79Summary: disposable client module for libtaskotron 79​Summary: disposable client module for libtaskotron
80 80​
81Requires: libtaskotron-core = %{version}-%{release} 81​Requires: libtaskotron-core = %{version}-%{release}
82Requires: python-paramiko >= 1.15.1 82​Requires: python-paramiko >= 1.15.1
83Requires: testcloud >= 0.1.9 83​Requires: testcloud >= 0.1.10
84BuildRequires: python-paramiko >= 1.15.1 84​BuildRequires: python-paramiko >= 1.15.1
85BuildRequires: testcloud >= 0.1.9 85​BuildRequires: testcloud >= 0.1.10
86 86​
87%description -n libtaskotron-disposable 87​%description -n libtaskotron-disposable
88Module for libtaskotron which enables the use of disposable clients 88​Module for libtaskotron which enables the use of disposable clients
89 89​
90 90​
91%pre core 91​%pre core
92getent group taskotron >/dev/null || groupadd taskotron 92​getent group taskotron >/dev/null || groupadd taskotron
93 93​
▲ Show 20 Lines • Show All 306 Lines • Show Last 20 Lines
View Options

libtaskotron/ext/disposable/vm.py

Show First 20 Lines • Show All 78 Lines • ▼ Show 20 Line(s)49 def _prepare_image(self, distro=None, release=None, flavor=None, arch=None):
79 except exc.TaskotronImageNotFoundError as e: 79​ except exc.TaskotronImageNotFoundError as e:
80 log.error(e) 80​ log.error(e)
81 raise 81​ raise
82 82​
83 log.debug("Preparing image {} for task {}".format(img_url, self.uuid)) 83​ log.debug("Preparing image {} for task {}".format(img_url, self.uuid))
84 84​
85 try: 85​ try:
86 tc_image = image.Image(img_url) 86​ tc_image = image.Image(img_url)
87 tc_image.prepare() 87​ # symlink the image instead of copying it to the testcloud dir, because our user only
88​ # expects image handling in taskotron dirs, and we remove all minion instances
89​ # immediately after task execution anyway
90​ tc_image.prepare(copy=False)
88 except TestcloudImageError as e: 91​ except TestcloudImageError as e:
89 log.exception(e) 92​ log.exception(e)
90 raise exc.TaskotronImageError("There was an error while preparing the " 93​ raise exc.TaskotronImageError("There was an error while preparing the "
91 "testcloud image", e) 94​ "testcloud image", e)
92 95​
93 return tc_image 96​ return tc_image
94 97​
95 def _prepare_instance(self, tc_image): 98​ def _prepare_instance(self, tc_image):
▲ Show 20 Lines • Show All 174 Lines • Show Last 20 Lines