Taskotron init script PoC
Needs ReviewPublic
Actions

Authored by lbrabec on Aug 10 2016, 2:32 PM.

Details

Reviewers

kparal
tflink
jskladan
mkrizek

Summary

Script that inits taskotron and testcloud after installation. This is PoC to open a discussion what else we'd like to see in init script.

Test Plan

run the script

Diff Detail

Lint

Lint Skipped

Unit

Unit Tests Skipped

lbrabec retitled this revision from to Taskotron init script PoC.Aug 10 2016, 2:32 PM

lbrabec updated this object.

lbrabec edited the test plan for this revision. (Show Details)

lbrabec added reviewers: kparal, jskladan, mkrizek.

lbrabec added a project: libtaskotron.

Herald added a subscriber: tflink. · View Herald TranscriptAug 10 2016, 2:32 PM

lbrabec added a reviewer: tflink.Aug 10 2016, 2:32 PM

I thought that we were going to do this in python as part of the cli re-work, is this something different?

I imagined this would be written in Python. It could be easier for some tasks, especially if we're going to parse existing testcloud settings as suggested. Running simple command like options is not that difficult in Python, just subprocess.check_call(...). But I don't have strong objections against bash either, it's just that we'll have another executable around.

taskotron_init.sh
4–6	I wonder if we could do this idempotent? Always end up with same result, even if run several times, therefore no need to worry about overwriting something?
19	We could do something like Your testcloud config includes these ssh keys at this moment: XXX Do you want to add any new ones? [y/n]
57	Let's check the current groups first, and skip if taskotron group is already present for the user. If not, let's ask whether to run the command or skip (maybe the user wants to run it him/herself).
60	I'd say is required.

In D966#18267, @kparal wrote:

I imagined this would be written in Python. It could be easier for some tasks, especially if we're going to parse existing testcloud settings as suggested. Running simple command like options is not that difficult in Python, just subprocess.check_call(...). But I don't have strong objections against bash either, it's just that we'll have another executable around.

Bash is my go for language for stuff like this and I'd prefer one subprocess.check_call(...) over more, but not having another executable around is probably better. Python then.

Parsing existing testcloud settings means parsing cloud-init configuration (or do I miss something?). Reading the cloud-config docs, it is in yaml, so no problem I guess.

taskotron_init.sh
4–6	Sure, idempotent init is probably better. I was aiming on something like `arc` does when it is executed for the first time, it tells you to run `arc install-certificate`. I think it would be nice to have such behavior in `runtask` (or `taskotron run`).

In D966#18273, @lbrabec wrote:

Parsing existing testcloud settings means parsing cloud-init configuration (or do I miss something?).

I meant the file in ~/.config/testcloud/settings.py (in order to be able to append ssh keys and not overwrite the existing ones). But that was just an idea, we don't have to support this use case.

mkrizek resigned from this revision.Thu, Jul 13, 9:03 AM

Revision Contents

			Path
A	M		taskotron_init.sh (63 lines)

Diff 2466

View Options

taskotron_init.sh

This file was added.

Property	Old Value	New Value
File Mode	null	100755

1		#!/usr/bin/env bash
2
3
4		# check if init was done already
5		if [ -f $HOME/.config/taskotron/init_done ]; then
6		echo -n "Taskotron and testcloud already initialized, do you want to redo the init? "
	kparalUnsubmitted Not Done I wonder if we could do this idempotent? Always end up with same result, even if run several times, therefore no need to worry about overwriting something?
	lbrabecAuthorUnsubmitted Not Done Sure, idempotent init is probably better. I was aiming on something like `arc` does when it is executed for the first time, it tells you to run `arc install-certificate`. I think it would be nice to have such behavior in `runtask` (or `taskotron run`).
7		read -r -p "[y/N] " response
8		response=${response,,} #to lower
9		if [[ $response =~ ^(yes\|y)$ ]]; then
10		rm -f /var/lib/taskotron/init_done
11		else
12		exit 1
13		fi
14		fi
15
16		# get the path to pubkey
17		PUBKEY_PATH=
18		if [ -f ~/.ssh/id_rsa.pub ]; then
19		echo -n "Enter path to ssh pubkey (leave empty to use ~/.ssh/id_rsa.pub):"
	kparalUnsubmitted Not Done We could do something like Your testcloud config includes these ssh keys at this moment: XXX Do you want to add any new ones? [y/n]
20		read PUBKEY_PATH
21		if [ -z "$PUBKEY_PATH" ]; then
22		PUBKEY_PATH="$HOME/.ssh/id_rsa.pub"
23		fi
24		else
25		echo -n "Enter path to ssh pubkey:"
26		read PUBKEY_PATH
27		if [ -z "$PUBKEY_PATH" ]; then
28		echo "No pubkey specified, exiting."
29		exit 1
30		fi
31		fi
32
33		# read the pubkey
34		PUBKEY=
35		if [ -f $PUBKEY_PATH ]; then
36		PUBKEY=`cat $PUBKEY_PATH`
37		else
38		echo "File $PUBKEY_PATH does not exist."
39		exit 1
40		fi
41
42		# generate config for testcloud
43		mkdir -p $HOME/.config/testcloud
44		cat > $HOME/.config/testcloud/settings.py <<EOF
45		USER_DATA = """#cloud-config
46		users:
47		- default
48		- name: root
49		password: %s
50		chpasswd: { expire: False }
51		ssh-authorized-keys:
52		- $PUBKEY
53		"""
54		EOF
55
56		# setup groups
57		echo "Adding $USER to groups 'taskotron' and 'testcloud', will need superuser access..."
	kparalUnsubmitted Not Done Let's check the current groups first, and skip if taskotron group is already present for the user. If not, let's ask whether to run the command or skip (maybe the user wants to run it him/herself).
58		sudo gpasswd -a $USER testcloud
59		sudo gpasswd -a $USER taskotron
60		echo "User $USER has beed added to groups 'taskotron' and 'testcloud', relogin may be required"
	kparalUnsubmitted Not Done I'd say is required.
61
62		mkdir -p $HOME/.config/taskotron
63		touch $HOME/.config/taskotron/init_done

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	2466			Aug 10 2016, 2:28 PM	★	★