Differential D964

always use --nogpgcheck when installing packages
ClosedPublic
Actions

Authored by adamwill on Aug 9 2016, 5:43 PM.

Details

Reviewers
garretraziel
jskladan
Commits
rOPENQATESTSb7abdf81a93b: always use --nogpgcheck when installing packages
Summary

Except when running on the pre-upgrade release in the upgrade
tests (where GPG check should always be OK).

Currently we always need to use --nogpgcheck on Rawhide, and we
must also use it on Branched prior to the Bodhi activation
point. At present we don't really have any simple way to know
when the Bodhi activation point has kicked in. We could assume
that it's safe to do GPG checking for 'candidate' (not nightly)
composes, but even that isn't 100% safe and isn't really the
*right* thing to do. So I think for now it's best to just always
use --nogpgcheck , until we come up with a decent way to check
for Bodhi enablement, or releng figures things out so we can
rely on packages being signed in Rawhide and in Branched before
Bodhi enablement.

Test Plan

Check the tests all still run, make sure I didn't
miss any dnf calls.

Diff Detail

Repository
rOPENQATESTS os-autoinst-distri-fedora
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
adamwill retitled this revision from to always use --nogpgcheck when installing packages.Aug 9 2016, 5:43 PM
adamwill updated this object.
adamwill edited the test plan for this revision. (Show Details)
adamwill added reviewers: garretraziel, jskladan.
garretraziel accepted this revision.Aug 10 2016, 9:29 AM

Yeah, it looks like all necessary dnf runs were covered.

This revision is now accepted and ready to land.Aug 10 2016, 9:29 AM
Closed by commit rOPENQATESTSb7abdf81a93b: always use --nogpgcheck when installing packages (authored by adamwill). · Explain WhyAug 10 2016, 2:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

Diff 2467

View Options

tests/freeipa_password_change_postinstall.pm

Show All 35 Lines6sub run {
36 # we don't get back to a prompt instantly and keystrokes while X 36​ # we don't get back to a prompt instantly and keystrokes while X
37 # is still shutting down are swallowed, so wait_still_screen before 37​ # is still shutting down are swallowed, so wait_still_screen before
38 # finishing (and handing off to freeipa_client_postinstall) 38​ # finishing (and handing off to freeipa_client_postinstall)
39 wait_still_screen 5; 39​ wait_still_screen 5;
40 # check we can kinit with changed password 40​ # check we can kinit with changed password
41 assert_script_run 'printf "loremipsum" | kinit test1'; 41​ assert_script_run 'printf "loremipsum" | kinit test1';
42 # change password via CLI (back to batterystaple, as that's what 42​ # change password via CLI (back to batterystaple, as that's what
43 # freeipa_client test expects) 43​ # freeipa_client test expects)
44 assert_script_run 'dnf -y install freeipa-admintools'; 44​ assert_script_run 'dnf -y --nogpgcheck install freeipa-admintools';
45 assert_script_run 'printf "batterystaple\nbatterystaple" | ipa user-mod test1 --password'; 45​ assert_script_run 'printf "batterystaple\nbatterystaple" | ipa user-mod test1 --password';
46 # check we can kinit again 46​ # check we can kinit again
47 assert_script_run 'printf "batterystaple" | kinit test1'; 47​ assert_script_run 'printf "batterystaple" | kinit test1';
48 # we just stay here - freeipa_client will pick right up 48​ # we just stay here - freeipa_client will pick right up
49} 49​}
50 50​
51sub test_flags { 51​sub test_flags {
52 # without anything - rollback to 'lastgood' snapshot if failed 52​ # without anything - rollback to 'lastgood' snapshot if failed
53 # 'fatal' - whole test suite is in danger if this fails 53​ # 'fatal' - whole test suite is in danger if this fails
54 # 'milestone' - after this test succeeds, update 'lastgood' 54​ # 'milestone' - after this test succeeds, update 'lastgood'
55 # 'important' - if this fails, set the overall state to 'fail' 55​ # 'important' - if this fails, set the overall state to 'fail'
56 return {}; 56​ return {};
57} 57​}
58 58​
591; 59​1;
View Options

tests/role_deploy_domain_controller.pm

Show All 18 Lines7sub run {
19 # set up networking 19​ # set up networking
20 $self->setup_tap_static("10.0.2.100", "ipa001.domain.local"); 20​ $self->setup_tap_static("10.0.2.100", "ipa001.domain.local");
21 # clone host's resolv.conf to get name resolution 21​ # clone host's resolv.conf to get name resolution
22 $self->clone_host_file("/etc/resolv.conf"); 22​ $self->clone_host_file("/etc/resolv.conf");
23 # we don't want updates-testing for validation purposes 23​ # we don't want updates-testing for validation purposes
24 assert_script_run 'dnf config-manager --set-disabled updates-testing'; 24​ assert_script_run 'dnf config-manager --set-disabled updates-testing';
25 # we need a lot of entropy for this, and we don't care how good 25​ # we need a lot of entropy for this, and we don't care how good
26 # it is, so let's use haveged 26​ # it is, so let's use haveged
27 assert_script_run 'dnf -y install haveged', 300; 27​ assert_script_run 'dnf -y --nogpgcheck install haveged', 300;
28 assert_script_run 'systemctl start haveged.service'; 28​ assert_script_run 'systemctl start haveged.service';
29 # read DNS server IPs from host's /etc/resolv.conf for passing to 29​ # read DNS server IPs from host's /etc/resolv.conf for passing to
30 # rolectl 30​ # rolectl
31 my @forwards = $self->get_host_dns(); 31​ my @forwards = $self->get_host_dns();
32 # we are now gonna work around a stupid bug in rolekit. we want to 32​ # we are now gonna work around a stupid bug in rolekit. we want to
33 # pass it a list of ipv4 DNS forwarders and have no ipv6 DNS 33​ # pass it a list of ipv4 DNS forwarders and have no ipv6 DNS
34 # forwarders. but it won't allow you to have a dns_forwarders array 34​ # forwarders. but it won't allow you to have a dns_forwarders array
35 # with a "ipv4" list but no "ipv6" list, any values in the "ipv6" 35​ # with a "ipv4" list but no "ipv6" list, any values in the "ipv6"
▲ Show 20 Lines • Show All 82 Lines • Show Last 20 Lines
View Options

tests/server_cockpit_default_postinstall.pm

1use base "installedtest"; 1​use base "installedtest";
2use strict; 2​use strict;
3use testapi; 3​use testapi;
4 4​
5sub run { 5​sub run {
6 my $self=shift; 6​ my $self=shift;
7 # check cockpit appears to be enabled and running and firewall is setup 7​ # check cockpit appears to be enabled and running and firewall is setup
8 assert_script_run 'systemctl is-enabled cockpit.socket'; 8​ assert_script_run 'systemctl is-enabled cockpit.socket';
9 assert_script_run 'systemctl is-active cockpit.socket'; 9​ assert_script_run 'systemctl is-active cockpit.socket';
10 assert_script_run 'firewall-cmd --query-service cockpit'; 10​ assert_script_run 'firewall-cmd --query-service cockpit';
11 # we don't want updates-testing for validation purposes 11​ # we don't want updates-testing for validation purposes
12 assert_script_run 'dnf config-manager --set-disabled updates-testing'; 12​ assert_script_run 'dnf config-manager --set-disabled updates-testing';
13 # install a desktop and firefox so we can actually try it 13​ # install a desktop and firefox so we can actually try it
14 assert_script_run 'dnf -y groupinstall "base-x"', 300; 14​ assert_script_run 'dnf -y --nogpgcheck groupinstall "base-x"', 300;
15 assert_script_run 'dnf -y install firefox', 120; 15​ assert_script_run 'dnf -y --nogpgcheck install firefox', 120;
16 $self->start_cockpit(0); 16​ $self->start_cockpit(0);
17 # quit firefox (return to console) 17​ # quit firefox (return to console)
18 send_key "ctrl-q"; 18​ send_key "ctrl-q";
19} 19​}
20 20​
21sub test_flags { 21​sub test_flags {
22 # without anything - rollback to 'lastgood' snapshot if failed 22​ # without anything - rollback to 'lastgood' snapshot if failed
23 # 'fatal' - whole test suite is in danger if this fails 23​ # 'fatal' - whole test suite is in danger if this fails
24 # 'milestone' - after this test succeeds, update 'lastgood' 24​ # 'milestone' - after this test succeeds, update 'lastgood'
25 # 'important' - if this fails, set the overall state to 'fail' 25​ # 'important' - if this fails, set the overall state to 'fail'
26 return { fatal => 1 }; 26​ return { fatal => 1 };
27} 27​}
28 28​
291; 29​1;
30 30​
31# vim: set sw=4 et: 31​# vim: set sw=4 et:
View Options

tests/upgrade_run.pm

1use base "installedtest"; 1​use base "installedtest";
2use strict; 2​use strict;
3use testapi; 3​use testapi;
4 4​
5sub run { 5​sub run {
6 my $self = shift; 6​ my $self = shift;
7 my $release = lc(get_var("VERSION")); ​
8 # NOTE: this doesn't actually work yet, it's a FIXME in fedorabase ​
9 my $milestone = $self->get_milestone; ​
10 my $args = "--releasever=${release}"; ​
11 # This is excessive - after the Bodhi activation point we don't ​
12 # need --nogpgcheck for Branched. But that's hard to detect magically ​
13 if ($release eq 'rawhide' or $milestone eq 'branched') { ​
14 $args .= " --nogpgcheck"; ​
15 } ​
16 # disable screen blanking (download can take a long time) 7​ # disable screen blanking (download can take a long time)
17 script_run "setterm -blank 0"; 8​ script_run "setterm -blank 0";
18 9​
19 assert_script_run "dnf -y system-upgrade download ${args}", 6000; 10​ assert_script_run "dnf -y --nogpgcheck system-upgrade download", 6000;
20 11​
21 upload_logs "/var/log/dnf.log"; 12​ upload_logs "/var/log/dnf.log";
22 upload_logs "/var/log/dnf.rpm.log"; 13​ upload_logs "/var/log/dnf.rpm.log";
23 14​
24 script_run "dnf system-upgrade reboot"; 15​ script_run "dnf system-upgrade reboot";
25 # fail immediately if we see a DNF error message 16​ # fail immediately if we see a DNF error message
26 die "DNF reported failure" if (check_screen "upgrade_fail", 15); 17​ die "DNF reported failure" if (check_screen "upgrade_fail", 15);
27 if (get_var("ENCRYPT_PASSWORD")) { 18​ if (get_var("ENCRYPT_PASSWORD")) {
Show All 37 Lines