add a customize-vm option for libtaskotron
AbandonedPublic

Authored by lnie on Aug 5 2016, 8:38 AM.

Details

Summary

allow users to adjust their VM by adding a customize-vm option(https://phab.qadevel.cloud.fedoraproject.org/T675)

Test Plan

just run the common --libvirt task with --customize-vm setted

Diff Detail

Repository
rLTRN libtaskotron
Branch
customize-vm
Lint
Lint OK
Unit
Unit Test Errors
Build Status
Buildable 771
Build 771: arc lint + arc unit
lnie retitled this revision from to add a customize-vm option for libtaskotron.Aug 5 2016, 8:38 AM
lnie updated this object.
lnie edited the test plan for this revision. (Show Details)
lnie added reviewers: jskladan, kparal, lbrabec.
lbrabec requested changes to this revision.Aug 8 2016, 12:50 PM
lbrabec added inline comments.
libtaskotron/minion.py
45

No.
Break the line like this instead:

arg_data_exclude = ('task', 'libvirt', 'ssh', 'ssh_privkey', 'no_destroy', 'patch',
                    'customize_vm')
121

BaseMinion is for both PersistentMinion and DisposableMinion. The PersistentMinion is for the command line option --ssh, which could be any machine with running ssh (not just testcloud vm), such machine can be adjusted before runtask and doesn't need pausing.

This code should be moved to DisposableMinion.

This revision now requires changes to proceed.Aug 8 2016, 12:50 PM
kparal added a comment.Aug 8 2016, 3:36 PM

Please see my comment in T675#11623.

lnie added inline comments.Aug 9 2016, 5:19 AM
libtaskotron/minion.py
45

Yeah,much better:)

121

This code should be moved to DisposableMinion.

Really make sense for me.I haven't considered it thoroughly enough,just thought that users won't use --ssh and --customize-vm together.

T675 has been closed as wontfix, at least for now. Please set this revision as abandoned, thank you.

lnie abandoned this revision.Aug 10 2016, 9:10 AM
In D960#18181, @kparal wrote:

T675 has been closed as wontfix, at least for now. Please set this revision as abandoned, thank you.

My mistake ,I thought the decision is leaving it there,not apply ( apply it later if we need it),not abandon. Now I know we are supposed to abandon a patch if we don't need it for now.Gonna to do :)

We're leaving it here, it will not get lost, and can be searched. Marking it as abandoned only means it will not show up in Revisions Waiting on You section on Phab homepage either for me or you.