Differential D945

create_report_directive: don't crash when artifact is None
ClosedPublic
Actions

Authored by kparal on Jul 21 2016, 2:02 PM.

Details

Reviewers
mkrizek
Group Reviewers
libtaskotron
Commits
rLTRN52cde3cbf55f: create_report_directive: don't crash when artifact is None
Summary

This is a quick fix, a proper fix including a unit test will come later.

Test Plan

tested with task-pkg-gzip, no crash now

Diff Detail

Repository
rLTRN libtaskotron
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kparal retitled this revision from to create_report_directive: don't crash when artifact is None.Jul 21 2016, 2:02 PM
kparal updated this object.
kparal edited the test plan for this revision. (Show Details)
kparal added a reviewer: libtaskotron.
mkrizek accepted this revision.Jul 21 2016, 2:07 PM
mkrizek added a reviewer: mkrizek.
This revision is now accepted and ready to land.Jul 21 2016, 2:07 PM
Closed by commit rLTRN52cde3cbf55f: create_report_directive: don't crash when artifact is None (authored by kparal). · Explain WhyJul 21 2016, 2:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

Diff 2402

View Options

libtaskotron/directives/create_report_directive.py

Show First 20 Lines • Show All 83 Lines • ▼ Show 20 Line(s)75 def process(self, params, arg_data):
84 results = [] 84​ results = []
85 for detail in check_details: 85​ for detail in check_details:
86 results.append({ 86​ results.append({
87 'checkname': detail.checkname or arg_data['checkname'], 87​ 'checkname': detail.checkname or arg_data['checkname'],
88 'outcome': detail.outcome, 88​ 'outcome': detail.outcome,
89 'note': detail.note or '---', 89​ 'note': detail.note or '---',
90 'item': detail.item, 90​ 'item': detail.item,
91 'type': detail.report_type, 91​ 'type': detail.report_type,
92 'artifact': os.path.basename(detail.artifact), 92​ 'artifact': os.path.basename(detail.artifact) if detail.artifact else None,
93 }) 93​ })
94 94​
95 if 'path' in params: 95​ if 'path' in params:
96 report_fname = os.path.join(arg_data['artifactsdir'], params['path']) 96​ report_fname = os.path.join(arg_data['artifactsdir'], params['path'])
97 else: 97​ else:
98 report_fname = os.path.join(arg_data['artifactsdir'], 'report.html') 98​ report_fname = os.path.join(arg_data['artifactsdir'], 'report.html')
99 99​
100 if 'template' in params: 100​ if 'template' in params:
Show All 19 Lines