Differential D934

remove '--force' cmdline option
AbandonedPublic
Actions

Authored by kparal on Jul 14 2016, 11:48 AM.

Details

Reviewers
lbrabec
tflink
mkrizek
Group Reviewers
testcloud
Summary

Now with automatic VM stop during remove operation, the --force option
is not needed anymore.

Unless we want to keep it to safeguard against mistakes in CLI. See
discussion in D933. Note that --force was added a few months back and
was not yet part of a stable testcloud release, so this is not a UI
change.

Test Plan

start an instance, have it running, and try to remove it. It should be stopped and removed. Without this patch, you should see an error asking you to stop the instance first.

Diff Detail

Repository
rTCLOUD testcloud
Branch
feature/noforce (branched from dev)
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 727
Build 727: arc lint + arc unit
kparal retitled this revision from to remove '--force' cmdline option.Jul 14 2016, 11:48 AM
kparal updated this object.
kparal edited the test plan for this revision. (Show Details)
kparal added reviewers: testcloud, mkrizek, tflink, lbrabec.
tflink added a subscriber: roshi.Jul 15 2016, 3:25 PM

I'm slightly on the "keep --force" side of this but I'm not overly attached to it. If most folks want to remove it, I'm not going to say "no".

IIRC, @roshi was the one who wanted the "don't delete stuff by default" behavior, though.

kparal abandoned this revision.Aug 11 2016, 10:54 AM

There seems to be little support for this change, abandoning.

Revision Contents

PathCoverage (All)Coverage (Touched)Packages
Mtestcloud/cli.py (6 lines)0%0%

Diff 2378

View Options

testcloud/cli.py

Show First 20 Lines • Show All 148 Lines • ▼ Show 20 Line(s)143def _remove_instance(args):
149 log.debug("remove instance: {}".format(args.name)) 149​ log.debug("remove instance: {}".format(args.name))
150 150​
151 tc_instance = instance.find_instance(args.name) 151​ tc_instance = instance.find_instance(args.name)
152 152​
153 if tc_instance is None: 153​ if tc_instance is None:
154 raise TestcloudCliError("Cannot remove instance {} because it does " 154​ raise TestcloudCliError("Cannot remove instance {} because it does "
155 "not exist".format(args.name)) 155​ "not exist".format(args.name))
156 156​
157 tc_instance.remove(autostop=args.force) 157​ tc_instance.remove()
158 158​
159 159​
160def _reboot_instance(args): 160​def _reboot_instance(args):
161 """Handler for 'instance reboot' command. Expects the following elements in args: 161​ """Handler for 'instance reboot' command. Expects the following elements in args:
162 * name(str) 162​ * name(str)
163 163​
164 :param args: args from argparser 164​ :param args: args from argparser
165 """ 165​ """
▲ Show 20 Lines • Show All 71 Lines • ▼ Show 20 Line(s)202def get_argparser():
237 instarg_stop = instarg_subp.add_parser("stop", help="stop instance") 237​ instarg_stop = instarg_subp.add_parser("stop", help="stop instance")
238 instarg_stop.add_argument("name", 238​ instarg_stop.add_argument("name",
239 help="name of instance to stop") 239​ help="name of instance to stop")
240 instarg_stop.set_defaults(func=_stop_instance) 240​ instarg_stop.set_defaults(func=_stop_instance)
241 # instance remove 241​ # instance remove
242 instarg_remove = instarg_subp.add_parser("remove", help="remove instance") 242​ instarg_remove = instarg_subp.add_parser("remove", help="remove instance")
243 instarg_remove.add_argument("name", 243​ instarg_remove.add_argument("name",
244 help="name of instance to remove") 244​ help="name of instance to remove")
245 instarg_remove.add_argument("-f", ​
246 "--force", ​
247 help="Stop the instance if it's running", ​
248 action="store_true") ​
249 instarg_remove.set_defaults(func=_remove_instance) 245​ instarg_remove.set_defaults(func=_remove_instance)
250 # instance reboot 246​ # instance reboot
251 instarg_reboot = instarg_subp.add_parser("reboot", help="reboot instance") 247​ instarg_reboot = instarg_subp.add_parser("reboot", help="reboot instance")
252 instarg_reboot.add_argument("name", 248​ instarg_reboot.add_argument("name",
253 help="name of instance to reboot") 249​ help="name of instance to reboot")
254 instarg_reboot.add_argument("--timeout", 250​ instarg_reboot.add_argument("--timeout",
255 help="Time (in seconds) to wait for boot to " 251​ help="Time (in seconds) to wait for boot to "
256 "complete before completion, setting to 0" 252​ "complete before completion, setting to 0"
▲ Show 20 Lines • Show All 109 Lines • Show Last 20 Lines