Differential D921

do not submit CRASHED result to ResultsDB
ClosedPublic
Actions

Authored by kparal on Jul 4 2016, 2:04 PM.

Details

Reviewers
lbrabec
• ralph2
mkrizek
jskladan
Group Reviewers
task-rpmgrill
Maniphest Tasks
T812: koji directive: allow to download build logs
Commits
rRPMGR0708f16cbaa6: do not submit CRASHED result to ResultsDB
Summary

It seems better to only post functional results to ResultsDB (passed,
failed) and keep execution statuses in ExecDB only. By removing the
failsafe decorator, any error will crash the whole directive, which will
ensure that the crash is not sent to ResultsDB, but still reflected in
ExecDB.

Test Plan

tested manually

Diff Detail

Repository
rRPMGR task-rpmgrill
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kparal retitled this revision from to do not submit CRASHED result to ResultsDB.Jul 4 2016, 2:04 PM
kparal updated this object.
kparal edited the test plan for this revision. (Show Details)
kparal added reviewers: task-rpmgrill, • ralph2, mkrizek, lbrabec, jskladan.
mkrizek accepted this revision.Jul 7 2016, 9:00 AM

Agreed. LGTM

(I like the failsafe decorator though! ;)

This revision is now accepted and ready to land.Jul 7 2016, 9:00 AM
Closed by commit rRPMGR0708f16cbaa6: do not submit CRASHED result to ResultsDB (authored by kparal). · Explain WhyJul 7 2016, 1:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathPackages
Mrun_rpmgrill.py (29 lines)

Diff 2349

View Options

run_rpmgrill.py

1import logging 1​import logging
2if __name__ == '__main__': 2​if __name__ == '__main__':
3 # Set up logging ASAP to see potential problems during import. 3​ # Set up logging ASAP to see potential problems during import.
4 # Don't set it up when not running as the main script, someone else handles 4​ # Don't set it up when not running as the main script, someone else handles
5 # that then. 5​ # that then.
6 logging.basicConfig() 6​ logging.basicConfig()
7 7​
8import json 8​import json
9import functools ​
10import os 9​import os
11import re 10​import re
12import shutil 11​import shutil
13import subprocess 12​import subprocess
14import traceback ​
15 13​
16from libtaskotron import check 14​from libtaskotron import check
17 15​
18log = logging.getLogger('rpmgrill') 16​log = logging.getLogger('rpmgrill')
19log.setLevel(logging.DEBUG) 17​log.setLevel(logging.DEBUG)
20log.addHandler(logging.NullHandler()) 18​log.addHandler(logging.NullHandler())
21 19​
22 20​
23def camel_to_dashes(name): 21​def camel_to_dashes(name):
24 s1 = re.sub('(.)([A-Z][a-z]+)', r'\1-\2', name) 22​ s1 = re.sub('(.)([A-Z][a-z]+)', r'\1-\2', name)
25 return re.sub('([a-z0-9])([A-Z])', r'\1-\2', s1).lower() 23​ return re.sub('([a-z0-9])([A-Z])', r'\1-\2', s1).lower()
26 24​
27 25​
28class failsafe(object): ​
29 ''' Handle crashes in our main entrypoint. ''' ​
30 ​
31 def __init__(self, checkname, report_type, item_name): ​
32 self.checkname = checkname ​
33 self.report_type = report_type ​
34 self.item_name = item_name ​
35 ​
36 def __call__(self, fn): ​
37 @functools.wraps(fn) ​
38 def wrapper(**kwargs): ​
39 try: ​
40 return fn(**kwargs) ​
41 except Exception as e: ​
42 traceback.print_exc() ​
43 return check.export_YAML(check.CheckDetail( ​
44 item=kwargs[self.item_name], ​
45 report_type=self.report_type, ​
46 outcome='CRASHED', ​
47 note=str(e), ​
48 output=traceback.format_exc().split('\n'), ​
49 checkname=self.checkname, ​
50 )) ​
51 return wrapper ​
52 ​
53 ​
54@failsafe('rpmgrill', check.ReportType.KOJI_BUILD, 'koji_build') ​
55def run(koji_build, workdir='.', artifactsdir='artifacts'): 26​def run(koji_build, workdir='.', artifactsdir='artifacts'):
56 '''The main method to run from Taskotron''' 27​ '''The main method to run from Taskotron'''
57 28​
58 if not os.path.exists(artifactsdir): 29​ if not os.path.exists(artifactsdir):
59 os.makedirs(artifactsdir) 30​ os.makedirs(artifactsdir)
60 31​
61 workdir = os.path.abspath(workdir) 32​ workdir = os.path.abspath(workdir)
62 33​
▲ Show 20 Lines • Show All 120 Lines • Show Last 20 Lines