Differential D914

Remove the unnecessary constraint on RUNNING job
ClosedPublic
Actions

Authored by jskladan on Jun 30 2016, 7:20 AM.

Details

Reviewers
kparal
garretraziel
tflink
mkrizek
Commits
rRSDB5dc67d8382dd: Remove the unnecessary constraint on RUNNING job
Summary

Removes the unnecessary constraint on the job.status - it no longer needs to
be "running" in order to add results. This makes it into more of a group of
results, than "job execution status".

Test Plan

None

Diff Detail

Repository
rRSDB resultsdb
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jskladan retitled this revision from to Remove the unnecessary constraint on RUNNING job.Jun 30 2016, 7:20 AM
jskladan updated this object.
jskladan edited the test plan for this revision. (Show Details)
jskladan added reviewers: kparal, mkrizek, tflink, garretraziel.
garretraziel accepted this revision.Jun 30 2016, 7:23 AM

?????????? good shit go౦ԁ sHit? thats ✔ some good??shit right??there??? right✔there ✔✔if i do ƽaү so my self ? i say so ? thats what im talking about right there right there (chorus: ʳᶦᵍʰᵗ ᵗʰᵉʳᵉ) mMMMMᎷМ? ?? ?НO0ОଠOOOOOОଠଠOoooᵒᵒᵒᵒᵒᵒᵒᵒᵒ? ?? ? ? ? ? ? ? ??Good shit

This revision is now accepted and ready to land.Jun 30 2016, 7:23 AM
kparal accepted this revision.Jun 30 2016, 7:28 AM
Closed by commit rRSDB5dc67d8382dd: Remove the unnecessary constraint on RUNNING job (authored by Josef Skladanka <jskladan@redhat.com>). · Explain WhyJul 7 2016, 4:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathPackages
Mresultsdb/controllers/api_v1.py (8 lines)

Diff 2355

View Options

resultsdb/controllers/api_v1.py

Show First 20 Lines • Show All 555 Lines • ▼ Show 20 Line(s)539def create_result():
556 556​
557 # Fail early, if the job does not exist 557​ # Fail early, if the job does not exist
558 try: 558​ try:
559 job = q.one() 559​ job = q.one()
560 except orm_exc.NoResultFound: 560​ except orm_exc.NoResultFound:
561 return jsonify({'message': "Job not found" }), 404 561​ return jsonify({'message': "Job not found" }), 404
562 562​
563 if job.status != 'RUNNING': 563​ if job.status != 'RUNNING':
564 return jsonify({'message': "Job not running" }), 400 564​ # Side-effects based on status transitions
565​ if job.start_time is None or job.status == 'SCHEDULED':
566​ job.start_time = datetime.datetime.utcnow()
567​ job.status = 'RUNNING'
568​
569​ if job.end_time:
570​ job.end_time = datetime.datetime.utcnow()
565 571​
566 try: 572​ try:
567 testcase = Testcase.query.filter_by(name = args['testcase_name']).one() 573​ testcase = Testcase.query.filter_by(name = args['testcase_name']).one()
568 except orm_exc.NoResultFound: 574​ except orm_exc.NoResultFound:
569 if args['strict']: 575​ if args['strict']:
570 return jsonify({'message': "Testcase not found" }), 404 576​ return jsonify({'message': "Testcase not found" }), 404
571 else: 577​ else:
572 # TODO: add configurable default "empty" URL 578​ # TODO: add configurable default "empty" URL
▲ Show 20 Lines • Show All 207 Lines • Show Last 20 Lines