Differential D912

add a softfail workaround for RHBZ #1349721
ClosedPublic
Actions

Authored by adamwill on Jun 29 2016, 10:58 PM.

Details

Reviewers
garretraziel
Commits
rOPENQATESTS29c3fab71eb2: add a softfail workaround for RHBZ #1349721
Summary

try to catch a boot loop after dnf system-upgrade reboot, if
we do, set the test to soft_fail and pass enforcing=0 to work
around it.

Test Plan

Run the upgrade_foo tests and see that they now soft
fail instead of hard failing (unless there are any other issues).
Run the upgrade_2_foo tests and make sure they still pass (i.e.
we don't erroneously soft fail them).

Diff Detail

Repository
rOPENQATESTS os-autoinst-distri-fedora
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
adamwill retitled this revision from to add a softfail workaround for RHBZ #1349721.Jun 29 2016, 10:58 PM
adamwill updated this object.
adamwill edited the test plan for this revision. (Show Details)
adamwill added a reviewer: garretraziel.
adamwill added a comment.Jun 29 2016, 11:01 PM

oh, and I should say, the reason to do this (rather than just let the tests keep failing) is we know about the bug and it seems better to work around it so we can check for *other* bugs, rather than continuing to fail on one we already know about.

garretraziel accepted this revision.Jul 1 2016, 8:03 AM

Sure, looks OK.

This revision is now accepted and ready to land.Jul 1 2016, 8:03 AM
Closed by commit rOPENQATESTS29c3fab71eb2: add a softfail workaround for RHBZ #1349721 (authored by adamwill). · Explain WhyJul 1 2016, 3:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathPackages
Mtests/upgrade_run.pm (9 lines)

Diff 2335

View Options

tests/upgrade_run.pm

Show All 18 Lines5sub run {
19 assert_script_run "dnf -y system-upgrade download ${args}", 6000; 19​ assert_script_run "dnf -y system-upgrade download ${args}", 6000;
20 20​
21 upload_logs "/var/log/dnf.log"; 21​ upload_logs "/var/log/dnf.log";
22 upload_logs "/var/log/dnf.rpm.log"; 22​ upload_logs "/var/log/dnf.rpm.log";
23 23​
24 script_run "dnf system-upgrade reboot"; 24​ script_run "dnf system-upgrade reboot";
25 # fail immediately if we see a DNF error message 25​ # fail immediately if we see a DNF error message
26 die "DNF reported failure" if (check_screen "upgrade_fail"); 26​ die "DNF reported failure" if (check_screen "upgrade_fail");
27​ # try and catch if we hit RHBZ #1349721 and work around it
28​ if (check_screen "bootloader") {
29​ # wait some secs for the screen to clear
30​ sleep 10;
31​ if (check_screen "bootloader") {
32​ record_soft_failure;
33​ $self->do_bootloader(postinstall=>1, params=>"enforcing=0");
34​ }
35​ }
27} 36​}
28 37​
29 38​
30sub test_flags { 39​sub test_flags {
31 # without anything - rollback to 'lastgood' snapshot if failed 40​ # without anything - rollback to 'lastgood' snapshot if failed
32 # 'fatal' - whole test suite is in danger if this fails 41​ # 'fatal' - whole test suite is in danger if this fails
33 # 'milestone' - after this test succeeds, update 'lastgood' 42​ # 'milestone' - after this test succeeds, update 'lastgood'
34 # 'important' - if this fails, set the overall state to 'fail' 43​ # 'important' - if this fails, set the overall state to 'fail'
35 return { fatal => 1 }; 44​ return { fatal => 1 };
36} 45​}
37 46​
381; 47​1;
39 48​
40# vim: set sw=4 et: 49​# vim: set sw=4 et: