Differential D876

testcase_stats: show progress
ClosedPublic
Actions

Authored by adamwill on Jun 1 2016, 12:08 PM.

Details

Reviewers
kparal
Commits
rRELVAL2fd90c391bfa: testcase_stats: show progress
Summary

Show test type and page counters as a progress indication during
processing.

Test Plan

tested manually, works. looks like this now:

Processing type [1/6]: Cloud
Processing page [1/32]: Test Results:Fedora 24 Rawhide 20151117 Cloud
Processing page [2/32]: Test Results:Fedora 24 Rawhide 20151120 Cloud
...

Diff Detail

Repository
rRELVAL relval
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kparal retitled this revision from to testcase_stats: show progress.Jun 1 2016, 12:08 PM
kparal updated this object.
kparal edited the test plan for this revision. (Show Details)
kparal added a reviewer: adamwill.
adamwill accepted this revision.Jun 1 2016, 3:45 PM

Thanks, merged!

This revision is now accepted and ready to land.Jun 1 2016, 3:45 PM
adamwill commandeered this revision.Jun 1 2016, 3:45 PM
adamwill edited reviewers, added: kparal; removed: adamwill.
This revision now requires review to proceed.Jun 1 2016, 3:45 PM
adamwill abandoned this revision.Jun 1 2016, 3:46 PM

sigh, workflows - I think I should've accepted this before landing it, now I can't close it properly. oh well. it's merged!

Closed by commit rRELVAL2fd90c391bfa: testcase_stats: show progress (authored by adamwill). · Explain WhyJun 1 2016, 3:55 PM
This revision was automatically updated to reflect the committed changes.
kparal added a comment.Jun 2 2016, 8:26 AM
In D876#16553, @adamwill wrote:

sigh, workflows - I think I should've accepted this before landing it, now I can't close it properly. oh well. it's merged!

I think only the author and Phab can close diffs. So you can comandeer it and close it, if you don't want to wait for me, but it's enough to leave the Differential Request line in the commit message and Phab will close it itself.

Revision Contents

PathPackages
Mrelval/cli.py (9 lines)

Diff 2247

View Options

relval/cli.py

Show First 20 Lines • Show All 407 Lines • ▼ Show 20 Line(s)368def testcase_stats(args, site):
408 # its docs for details. 408​ # its docs for details.
409 # 409​ #
410 # A Test() object is generated for each result row from each result 410​ # A Test() object is generated for each result row from each result
411 # page for the test type, and added to the tests dict based on those 411​ # page for the test type, and added to the tests dict based on those
412 # three attributes (as the second field of a tuple, the first field 412​ # three attributes (as the second field of a tuple, the first field
413 # identifying the compose from which it comes). Result rows for which 413​ # identifying the compose from which it comes). Result rows for which
414 # all three attributes match are grouped together - they're considered 414​ # all three attributes match are grouped together - they're considered
415 # to be results for the same test in different composes. 415​ # to be results for the same test in different composes.
416 for (testtype, pages) in allpages.items(): 416​ for index, (testtype, pages) in enumerate(allpages.items()):
417​ print('Processing type [{0}/{1}]: {2}'.format(index + 1,
418​ len(allpages), testtype))
417 tests = OrderedDict() 419​ tests = OrderedDict()
418 # re-use the allcomposes sort to sort the pages. 420​ # re-use the allcomposes sort to sort the pages.
419 pages.sort(key=lambda x: allcomposes.index(x.shortver)) 421​ pages.sort(key=lambda x: allcomposes.index(x.shortver))
420 for page in pages: 422​ for index, page in enumerate(pages):
421 print("Processing: {0}".format(page.name)) 423​ print("Processing page [{0}/{1}]: {2}".format(index + 1,
424​ len(pages), page.name))
422 resultrows = page.get_resultrows( 425​ resultrows = page.get_resultrows(
423 statuses=['pass', 'warn', 'fail'], transferred=False) 426​ statuses=['pass', 'warn', 'fail'], transferred=False)
424 for row in resultrows: 427​ for row in resultrows:
425 tests.setdefault((row.name, row.testcase, row.section), 428​ tests.setdefault((row.name, row.testcase, row.section),
426 tcs.Test()) 429​ tcs.Test())
427 tests[(row.name, row.testcase, row.section)].update( 430​ tests[(row.name, row.testcase, row.section)].update(
428 page.shortver, row) 431​ page.shortver, row)
429 432​
▲ Show 20 Lines • Show All 94 Lines • Show Last 20 Lines