There should be always a .src.rpm, however some packages might not have
any binary rpms (openh264).
tested manually with openh264 and standard packages
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| Path | Packages | |||
|---|---|---|---|---|
| M | run_rpmlint.py (8 lines) |
| Commit | Tree | Parents | Author | Summary | Date |
|---|---|---|---|---|---|
| a2be5aefcbd7 | 8c2f5098ff23 | 2ce075e4284d | Kamil Páral | crash when no .src.rpm, don't crash when no binary rpms (Show More…) | May 25 2016, 1:59 PM |
| Show All 40 Lines | 35 | for file_ in files: | |||
|---|---|---|---|---|---|
| 41 | else: | 41 | else: | ||
| 42 | log.debug('Ignoring non-rpm file: %s', filepath) | 42 | log.debug('Ignoring non-rpm file: %s', filepath) | ||
| 43 | 43 | | |||
| 44 | # run rpmlint on SRPMs | 44 | # run rpmlint on SRPMs | ||
| 45 | if srpms: | 45 | if srpms: | ||
| 46 | command = ['rpmlint'] + srpms | 46 | command = ['rpmlint'] + srpms | ||
| 47 | srpm_result = run_rpmlint(command) | 47 | srpm_result = run_rpmlint(command) | ||
| 48 | else: | 48 | else: | ||
| 49 | log.warn('No .src.rpm files found in: %s', workdir) | 49 | log.critical('No .src.rpm files found in: %s', workdir) | ||
| 50 | srpm_result = Result('PASSED', [], None, None) | 50 | log.debug('Files available in the workdir:\n%s', '\n'.join(files)) | ||
| 51 | raise AssertionError('No .src.rpm files found. That should never happen, all Koji builds ' | ||||
| 52 | 'should have a source RPM.') | ||||
| 51 | 53 | | |||
| 52 | # run rpmlint on RPMs | 54 | # run rpmlint on RPMs | ||
| 53 | # disable network checks to avoid hitting websites too much (also the network checks were | 55 | # disable network checks to avoid hitting websites too much (also the network checks were | ||
| 54 | # already) performed on the SRPM. See https://phab.qadevel.cloud.fedoraproject.org/T760 | 56 | # already) performed on the SRPM. See https://phab.qadevel.cloud.fedoraproject.org/T760 | ||
| 55 | if rpms: | 57 | if rpms: | ||
| 56 | command = ['rpmlint', '-o', 'NetworkEnabled False'] + rpms | 58 | command = ['rpmlint', '-o', 'NetworkEnabled False'] + rpms | ||
| 57 | rpm_result = run_rpmlint(command) | 59 | rpm_result = run_rpmlint(command) | ||
| 58 | else: | 60 | else: | ||
| 59 | log.warn('No binary rpm files found in: %s', workdir) | 61 | log.warn('No binary rpm files found in: %s', workdir) | ||
| 60 | rpm_result = Result('PASSED', [], None, None) | 62 | rpm_result = Result('PASSED', [], 0, 0) | ||
| 61 | 63 | | |||
| 62 | # compute overall results | 64 | # compute overall results | ||
| 63 | detail = check.CheckDetail(koji_build, check.ReportType.KOJI_BUILD, srpm_result.outcome) | 65 | detail = check.CheckDetail(koji_build, check.ReportType.KOJI_BUILD, srpm_result.outcome) | ||
| 64 | detail.update_outcome(rpm_result.outcome) | 66 | detail.update_outcome(rpm_result.outcome) | ||
| 65 | errors = srpm_result.errors + rpm_result.errors | 67 | errors = srpm_result.errors + rpm_result.errors | ||
| 66 | warnings = srpm_result.warnings + rpm_result.warnings | 68 | warnings = srpm_result.warnings + rpm_result.warnings | ||
| 67 | detail.note = '%d errors, %d warnings' % (errors, warnings) | 69 | detail.note = '%d errors, %d warnings' % (errors, warnings) | ||
| 68 | 70 | | |||
| ▲ Show 20 Lines • Show All 63 Lines • Show Last 20 Lines | |||||