Differential D851

don't repeat information in CheckDetail.note
ClosedPublic
Actions

Authored by kparal on May 13 2016, 2:32 PM.

Details

Reviewers
mkrizek
Group Reviewers
libtaskotron
Commits
rDEPCK47bbec5dd111: don't repeat information in CheckDetail.note
Summary

Only print relevant information into resultyaml's note. Remove
item for Bodhi updates. Koji build results are unchanged (empty)
because it was non-trivial to add target repo information.

Bodhi update before:

note: FEDORA-2016-6dee20349d into F22 stable

and now:

note: F22 stable

This is slightly relevant to T794 and analogous to D850.

Test Plan

test manually and ran test suite

Diff Detail

Repository
rDEPCK task-depcheck
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kparal retitled this revision from to don't repeat information in CheckDetail.note.May 13 2016, 2:32 PM
kparal updated this object.
kparal edited the test plan for this revision. (Show Details)
kparal added a reviewer: libtaskotron.
mkrizek accepted this revision.May 13 2016, 2:54 PM
mkrizek added a reviewer: mkrizek.
This revision is now accepted and ready to land.May 13 2016, 2:54 PM
Closed by commit rDEPCK47bbec5dd111: don't repeat information in CheckDetail.note (authored by kparal). · Explain WhyMay 13 2016, 3:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathPackages
Mdepcheck/squash_results.py (11 lines)

Diff 2187

View Options

depcheck/squash_results.py

Show First 20 Lines • Show All 98 Lines • ▼ Show 20 Line(s)98 for bld in sorted(missing):
99 cd.store(' %s' % bld, printout=False) 99​ cd.store(' %s' % bld, printout=False)
100 else: 100​ else:
101 for build in builds: 101​ for build in builds:
102 if results_nvr[build]['result'] != Pass: 102​ if results_nvr[build]['result'] != Pass:
103 cd.update_outcome(results_nvr[build]['result']) 103​ cd.update_outcome(results_nvr[build]['result'])
104 cd.store('Build %s failed depcheck' % build, printout=False) 104​ cd.store('Build %s failed depcheck' % build, printout=False)
105 cd.output.extend(results_nvr[build]['details']) 105​ cd.output.extend(results_nvr[build]['details'])
106 106​
107 # set summary 107​ # set note
108 if update['request']: 108​ cd.note = '%s %s' % (update['release']['name'],
109 target = 'into %s %s' % (update['release']['name'], 109​ update['request'] if 'request' in update else update['status'])
110 update['request']) ​
111 else: ​
112 target = 'in %s %s' % (update['release']['name'], ​
113 update['status']) ​
114 cd.note = '%s %s' % (update_alias, target) ​
115 110​
116 return updates_results 111​ return updates_results
117 112​
118 113​
119def squash_results(run_result, bodhi_client = None, koji_client = None): 114​def squash_results(run_result, bodhi_client = None, koji_client = None):
120 per_nvr = _squash_rpms_to_builds(run_result, koji_client) 115​ per_nvr = _squash_rpms_to_builds(run_result, koji_client)
121 per_update = _squash_builds_to_updates(per_nvr, bodhi_client) 116​ per_update = _squash_builds_to_updates(per_nvr, bodhi_client)
122 117​
▲ Show 20 Lines • Show All 80 Lines • Show Last 20 Lines