Differential D847

Remove bodhi network unit test
ClosedPublic
Actions

Authored by mkrizek on May 9 2016, 5:39 AM.

Details

Reviewers
kparal
Commits
rLTRN499fd34d3319: Remove bodhi network unit tests
Summary

The test caused failures with recent version of python-fedora and
so libtaskotron couldn't be built. The unit tests is not relevant
anymore.

Test Plan

Unit test passes now with the recent version of python-fedora.

Diff Detail

Repository
rLTRN libtaskotron
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mkrizek retitled this revision from to Remove bodhi network unit tests.May 9 2016, 5:39 AM
mkrizek updated this object.
mkrizek edited the test plan for this revision. (Show Details)
mkrizek added a reviewer: kparal.
mkrizek retitled this revision from Remove bodhi network unit tests to Remove bodhi network unit test.May 9 2016, 5:40 AM
kparal accepted this revision.May 9 2016, 6:43 AM

The unit tests is not relevant anymore.

I'll add explanation: That unit test was to ensure that bodhi client doesn't make a network request during initialization to figure out whether it should return a Bodhi1 or Bodhi2 instance. That used to be the case and it made our unit tests very slow. Now the library doesn't seem to do that anymore and they even removed requests module (which we mocked in that unit test) from their code.

libtaskotron.spec
65

Please note this is not available in Fedora 22:

$ pkgwat releases python-fedora
+---------------+-----------------------+----------------------+
| release       | stable_version        | testing_version      |
+---------------+-----------------------+----------------------+
| Rawhide       | 0.8.0-1.fc25          | None                 |
| Fedora 24     | 0.8.0-1.fc24          | 0.8.0-1.fc24 3 karma |
| Fedora 23     | 0.8.0-1.fc23 (update) | None                 |
| Fedora 22     | 0.7.1-4.fc22 (update) | 0.8.0-1.fc22 0 karma |
| Fedora EPEL 7 | 0.7.1-2.el7           | None                 |
| Fedora EPEL 6 | 0.5.6-1.el6           | None                 |
| Fedora EPEL 5 | None                  | None                 |
+---------------+-----------------------+----------------------+

Just in case we want to support it, not sure.

This revision is now accepted and ready to land.May 9 2016, 6:43 AM
mkrizek added inline comments.May 9 2016, 6:59 AM
libtaskotron.spec
65

We already require pytest version which is not in Fedora 22 so I guess it doesn't matter much, also given that Fedora 22 will go EOL soon.

Closed by commit rLTRN499fd34d3319: Remove bodhi network unit tests (authored by mkrizek). · Explain WhyMay 9 2016, 7:13 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathPackages
Mlibtaskotron.spec (4 lines)
Mrequirements.txt (2 lines)
Mtesting/test_bodhi_utils.py (14 lines)

Diff 2174

View Options

libtaskotron.spec

Show First 20 Lines • Show All 56 Lines • ▼ Show 20 Line(s)
57%package -n libtaskotron-fedora 57​%package -n libtaskotron-fedora
58Summary: Fedora specific module for libtaskotron 58​Summary: Fedora specific module for libtaskotron
59 59​
60Requires: createrepo 60​Requires: createrepo
61Requires: dnf >= 0.6.4 61​Requires: dnf >= 0.6.4
62Requires: koji 62​Requires: koji
63Requires: libtaskotron-core = %{version}-%{release} 63​Requires: libtaskotron-core = %{version}-%{release}
64Requires: mash 64​Requires: mash
65Requires: python-fedora >= 0.5.5 65​Requires: python-fedora >= 0.8.0
kparalUnsubmitted
Not Done

Please note this is not available in Fedora 22:

$ pkgwat releases python-fedora
+---------------+-----------------------+----------------------+
| release       | stable_version        | testing_version      |
+---------------+-----------------------+----------------------+
| Rawhide       | 0.8.0-1.fc25          | None                 |
| Fedora 24     | 0.8.0-1.fc24          | 0.8.0-1.fc24 3 karma |
| Fedora 23     | 0.8.0-1.fc23 (update) | None                 |
| Fedora 22     | 0.7.1-4.fc22 (update) | 0.8.0-1.fc22 0 karma |
| Fedora EPEL 7 | 0.7.1-2.el7           | None                 |
| Fedora EPEL 6 | 0.5.6-1.el6           | None                 |
| Fedora EPEL 5 | None                  | None                 |
+---------------+-----------------------+----------------------+

Just in case we want to support it, not sure.

mkrizekAuthorUnsubmitted
Not Done

We already require pytest version which is not in Fedora 22 so I guess it doesn't matter much, also given that Fedora 22 will go EOL soon.

66Requires: python-hawkey >= 0.4.13-1 66​Requires: python-hawkey >= 0.4.13-1
67Requires: python-munch >= 2.0.2 67​Requires: python-munch >= 2.0.2
68Requires: rpm-python 68​Requires: rpm-python
69BuildRequires: koji 69​BuildRequires: koji
70BuildRequires: mash 70​BuildRequires: mash
71BuildRequires: python-fedora >= 0.5.5 71​BuildRequires: python-fedora >= 0.8.0
72BuildRequires: python-hawkey >= 0.4.13-1 72​BuildRequires: python-hawkey >= 0.4.13-1
73BuildRequires: python-munch >= 2.0.2 73​BuildRequires: python-munch >= 2.0.2
74 74​
75%description -n libtaskotron-fedora 75​%description -n libtaskotron-fedora
76Module for libtaskotron which contains all functionality which is fedora-only 76​Module for libtaskotron which contains all functionality which is fedora-only
77 77​
78%package -n libtaskotron-disposable 78​%package -n libtaskotron-disposable
79Summary: disposable client module for libtaskotron 79​Summary: disposable client module for libtaskotron
▲ Show 20 Lines • Show All 279 Lines • Show Last 20 Lines
View Options

requirements.txt

Show All 12 Lines
13configparser == 3.5.0b2 13​configparser == 3.5.0b2
14dingus == 0.3.4 14​dingus == 0.3.4
15Jinja2 == 2.8 15​Jinja2 == 2.8
16munch == 2.0.2 16​munch == 2.0.2
17mock == 1.0.1 17​mock == 1.0.1
18paramiko == 1.15.1 18​paramiko == 1.15.1
19pytest == 2.7.3 19​pytest == 2.7.3
20pytest-cov == 2.2.1 20​pytest-cov == 2.2.1
21python-fedora == 0.5.5 21​python-fedora == 0.8.0
22progressbar == 2.3 22​progressbar == 2.3
23requests == 2.7.0 23​requests == 2.7.0
24PyYAML == 3.11 24​PyYAML == 3.11
25resultsdb_api == 1.2.1 25​resultsdb_api == 1.2.1
26Sphinx == 1.2.3 26​Sphinx == 1.2.3
View Options

testing/test_bodhi_utils.py

Show All 13 Lines
14from libtaskotron.ext.fedora import bodhi_utils 14​from libtaskotron.ext.fedora import bodhi_utils
15from libtaskotron import exceptions as exc 15​from libtaskotron import exceptions as exc
16from libtaskotron import config 16​from libtaskotron import config
17 17​
18 18​
19class TestBodhiUtils(): 19​class TestBodhiUtils():
20 '''Test generic functionality''' 20​ '''Test generic functionality'''
21 21​
22 def test_nonetwork_on_creation(self, monkeypatch): ​
23 '''It's important that our stuff not attempt to access the network ​
24 during init so that %check doesn't fail during package build. At one ​
25 point, BodhiClient did ping bodhi production during init, so let's make ​
26 sure that doesn't happen''' ​
27 ​
28 assert hasattr(fedora.client.bodhi, 'requests') ​
29 stub_requests = Dingus() ​
30 monkeypatch.setattr(fedora.client.bodhi, 'requests', stub_requests) ​
31 ​
32 bu = bodhi_utils.BodhiUtils() ​
33 assert bu.client is not None ​
34 assert len(stub_requests.calls()) == 0 ​
35 ​
36 def test_staging_or_production(self, monkeypatch): 22​ def test_staging_or_production(self, monkeypatch):
37 '''Client should be correctly created when requested staging in config or not''' 23​ '''Client should be correctly created when requested staging in config or not'''
38 monkeypatch.setattr(config, '_config', None) 24​ monkeypatch.setattr(config, '_config', None)
39 conf = config.get_config() 25​ conf = config.get_config()
40 assert conf.bodhi_staging is False 26​ assert conf.bodhi_staging is False
41 bu = bodhi_utils.BodhiUtils() 27​ bu = bodhi_utils.BodhiUtils()
42 prod_url = bu.client.base_url 28​ prod_url = bu.client.base_url
43 29​
▲ Show 20 Lines • Show All 205 Lines • Show Last 20 Lines