Requires new needles and test suite and job template, plus a
few tweaks to handle 'switched' keyboard layouts (so we use the
switched layout in the username and password).
Details
Details
- Reviewers
garretraziel - Commits
- rOPENQATESTSa4f326753410: add Russian install test
Run the test and see that it...fails. But that's OK!
It's a genuine bug: RHBZ #1333998 . At least make sure it gets
to that point and no other tests have broken and all the needles
look sane.
Diff Detail
Diff Detail
- Repository
- rOPENQATESTS os-autoinst-distri-fedora
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Overall LGTM, but it fails on my machine. Reason? I'm in Czech Republic, so default language used in my VM in Anaconda is "Czech", therefore "filtered" needle looks different (it has "Pokračovat" instead of "Continue"). I can provide you with additional needle with Czech filtered version (as before), but this is becoming increasingly annoying. I know that this will never be a problem in production (because our servers are US-based), but still, can't we do something with our needles for them to be more location-independent?
| lib/anacondatest.pm | ||
|---|---|---|
| 145 | Just to verify my assumption - you can have only two layouts in Anaconda, right? If not, why not cycle between layouts until "anaconda_layout_$layout" appears? | |
| lib/fedorabase.pm | ||
| 67–77 | I was sure that this was incorrect (typing password twice), but then found out that you are deliberately setting password to this value. Please, document this. | |
| 184 | Why only restrict this to Russian? Shouldn't this be available also for e. g. French? I don't say that this is incorrect, but it looks weird. Why not use "SWITCHED_LAYOUT" as before? | |
Comment Actions
Now that I think more about this, I'm not sure what is clear solution. Remove "Continue" button from "filtered" needle (or is it necessary? no other "filtered" needle uses it) and that should solve it for this test (for every non-Russian deployment that is).
This doesn't solve problem with selected/filtered in different locations, but that's for another discussion.
Comment Actions
Move needles into subdirectories, fix 'filtered' needle
Add the LANGUAGE-russian tag that was missing, and drop the
unneeded 'Continue' button match.
Comment Actions
OK, I dropped the 'Continue' button area from that needle, I don't think it was needed for any reason. There is something we could possibly do here, btw: disable geolocation for the language tests. There's a kernel parameter for that. That should make it always start the Welcome screen in US English. WDYT?
| lib/anacondatest.pm | ||
|---|---|---|
| 145 | "Just to verify my assumption - you can have only two layouts in Anaconda, right?" No, you could have more, but anaconda will never I think configure more than two by default for any language. "If not, why not cycle between layouts until "anaconda_layout_$layout" appears?" Eh, we could, it just didn't seem necessary and is unlikely to be in future. | |
| lib/fedorabase.pm | ||
| 67–77 | Roger. | |
| 184 | Because the switcher combos are different for different languages, unfortunately. There is no standard. The idea is we add a new if block for each switched language we need to support, with the appropriate switcher combo for that language (of course if two languages use the same switcher combo we can have a ||). | |
Just to verify my assumption - you can have only two layouts in Anaconda, right? If not, why not cycle between layouts until "anaconda_layout_$layout" appears?