Differential D844

add needles to treat 'Custom Operating System' as minimal
ClosedPublic
Actions

Authored by adamwill on May 6 2016, 3:34 PM.

Details

Reviewers
garretraziel
jskladan
Commits
rOPENQATESTSa1d240b13537: add needles to treat 'Custom Operating System' as minimal
Summary

the Server DVD now just has 'Fedora Server' and 'Custom
Operating System' environments. Custom is basically minimal.
So we can use the DVD for 'universal' testing again, these
needles match the anaconda_minimal tags.

Test Plan

Run the 'universal' tests on a DVD ISO with these
needles added, test that they work OK and use the 'Custom' env.

Diff Detail

Repository
rOPENQATESTS os-autoinst-distri-fedora
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
adamwill retitled this revision from to add needles to treat 'Custom Operating System' as minimal.May 6 2016, 3:34 PM
adamwill updated this object.
adamwill edited the test plan for this revision. (Show Details)
adamwill added reviewers: jskladan, garretraziel.
adamwill updated this revision to Diff 2166.May 6 2016, 4:15 PM

correct language tag in French needles

adamwill updated this revision to Diff 2167.May 6 2016, 7:06 PM

add needed needles and set a repo for package_set_kde

adamwill updated this revision to Diff 2168.May 6 2016, 7:19 PM

clean up preselected needles, handle xfs already being selected

adamwill updated this revision to Diff 2169.May 6 2016, 7:26 PM

fix the custom_change_fs change

whoops, variable needs to be bracketed here

adamwill updated this revision to Diff 2171.May 6 2016, 8:44 PM

rebases

garretraziel accepted this revision.May 11 2016, 11:36 AM

Works OK after applying fix from 60ceeb469e6f44b7

This revision is now accepted and ready to land.May 11 2016, 11:36 AM
adamwill updated this revision to Diff 2201.May 19 2016, 3:18 PM

rebased on the move-needles-into-directories commit

this is a tricky rebase, so resubmitting for review. I *think* this is
right.

Revision Contents

PathPackages
Mlib/anacondatest.pm (2 lines)
AMneedles/anaconda/package_selection/french/minimal_highlighted_french-custom.json (18 lines)
AM(bin)needles/anaconda/package_selection/french/minimal_highlighted_french-custom.png
AMneedles/anaconda/package_selection/french/minimal_selected_french-custom.json (18 lines)
AM(bin)needles/anaconda/package_selection/french/minimal_selected_french-custom.png
AMneedles/anaconda/package_selection/minimal_highlighted-custom.json (18 lines)
AM(bin)needles/anaconda/package_selection/minimal_highlighted-custom.png
AMneedles/anaconda/package_selection/minimal_selected-custom.json (18 lines)
AM(bin)needles/anaconda/package_selection/minimal_selected-custom.png
AMneedles/anaconda/package_selection/russian/minimal_highlighted_russian-custom.json (16 lines)
AM(bin)needles/anaconda/package_selection/russian/minimal_highlighted_russian-custom.png
AMneedles/anaconda/package_selection/russian/minimal_selected_russian-custom.json (16 lines)
AM(bin)needles/anaconda/package_selection/russian/minimal_selected_russian-custom.png
DMneedles/anaconda/partitioning/fs_ext4_preselected-cantarell17.json (17 lines)
DM(bin)needles/anaconda/partitioning/fs_ext4_preselected-cantarell17.png
DMneedles/anaconda/partitioning/fs_ext4_preselected-cantarell18.json (17 lines)
DM(bin)needles/anaconda/partitioning/fs_ext4_preselected-cantarell18.png
DMneedles/anaconda/partitioning/fs_ext4_preselected-cantarell20.json (17 lines)
DM(bin)needles/anaconda/partitioning/fs_ext4_preselected-cantarell20.png
DMneedles/anaconda/partitioning/fs_ext4_preselected-freetype262.json (17 lines)
DM(bin)needles/anaconda/partitioning/fs_ext4_preselected-freetype262.png
DMneedles/anaconda/partitioning/fs_ext4_preselected-gtk3195.json (17 lines)
DM(bin)needles/anaconda/partitioning/fs_ext4_preselected-gtk3195.png
Vneedles/anaconda/partitioning/{fs_ext4_preselected-gtk3197bug.json → fs_xfs_preselected-gtk320.json}
DM(bin)needles/anaconda/partitioning/fs_ext4_preselected-gtk3197bug.png
Mneedles/anaconda/partitioning/fs_ext4_preselected-gtk3199.json (3 lines)
DMneedles/anaconda/partitioning/fs_ext4_preselected.json (16 lines)
DM(bin)needles/anaconda/partitioning/fs_ext4_preselected.png
DMneedles/anaconda/partitioning/fs_xfs_preselected-cantarell172.json (17 lines)
DM(bin)needles/anaconda/partitioning/fs_xfs_preselected-cantarell172.png
Vneedles/anaconda/partitioning/{fs_xfs_preselected-gtk320.json ← fs_ext4_preselected-gtk3197bug.json} (9 lines)
AM(bin)needles/anaconda/partitioning/fs_xfs_preselected-gtk320.png
DMneedles/anaconda/partitioning/fs_xfs_preselected.json (16 lines)
DM(bin)needles/anaconda/partitioning/fs_xfs_preselected.png
Mtemplates (1 line)

Diff 2208

View Options

lib/anacondatest.pm

Show First 20 Lines • Show All 122 Lines • ▼ Show 20 Line(s)116sub custom_change_type {
123 assert_and_click "anaconda_part_device_type_$type"; 123​ assert_and_click "anaconda_part_device_type_$type";
124 assert_and_click "anaconda_part_update_settings"; 124​ assert_and_click "anaconda_part_update_settings";
125} 125​}
126 126​
127sub custom_change_fs { 127​sub custom_change_fs {
128 my ($self, $fs, $part) = @_; 128​ my ($self, $fs, $part) = @_;
129 $part ||= "root"; 129​ $part ||= "root";
130 assert_and_click "anaconda_part_select_$part"; 130​ assert_and_click "anaconda_part_select_$part";
131​ # if fs is already set correctly, do nothing
132​ return if (check_screen "anaconda_part_fs_${fs}_selected", 5);
131 assert_and_click "anaconda_part_fs"; 133​ assert_and_click "anaconda_part_fs";
132 # Move the mouse away from the menu 134​ # Move the mouse away from the menu
133 mouse_set(10, 10); 135​ mouse_set(10, 10);
134 assert_and_click "anaconda_part_fs_$fs"; 136​ assert_and_click "anaconda_part_fs_$fs";
135 assert_and_click "anaconda_part_update_settings"; 137​ assert_and_click "anaconda_part_update_settings";
136} 138​}
137 139​
138sub custom_delete_part { 140​sub custom_delete_part {
Show All 19 Lines
View Options

needles/anaconda/package_selection/french/minimal_highlighted_french-custom.json

  • This file was added.
1​{
2​ "area": [
3​ {
4​ "height": 17,
5​ "type": "match",
6​ "width": 268,
7​ "xpos": 48,
8​ "ypos": 177
9​ }
10​ ],
11​ "properties": [],
12​ "tags": [
13​ "anaconda_minimal_highlighted",
14​ "ENV-DISTRI-fedora",
15​ "LANGUAGE-french",
16​ "ENV-FLAVOR-server"
17​ ]
18​}
View Options

needles/anaconda/package_selection/french/minimal_highlighted_french-custom.png

  • This binary file was added.
View Options

needles/anaconda/package_selection/french/minimal_selected_french-custom.json

  • This file was added.
1​{
2​ "area": [
3​ {
4​ "height": 16,
5​ "type": "match",
6​ "width": 162,
7​ "xpos": 28,
8​ "ypos": 177
9​ }
10​ ],
11​ "properties": [],
12​ "tags": [
13​ "anaconda_minimal_selected",
14​ "ENV-DISTRI-fedora",
15​ "LANGUAGE-french",
16​ "ENV-FLAVOR-server"
17​ ]
18​}
View Options

needles/anaconda/package_selection/french/minimal_selected_french-custom.png

  • This binary file was added.
View Options

needles/anaconda/package_selection/minimal_highlighted-custom.json

  • This file was added.
1​{
2​ "area": [
3​ {
4​ "height": 15,
5​ "type": "match",
6​ "width": 94,
7​ "xpos": 48,
8​ "ypos": 177
9​ }
10​ ],
11​ "properties": [],
12​ "tags": [
13​ "anaconda_minimal_highlighted",
14​ "ENV-DISTRI-fedora",
15​ "LANGUAGE-english",
16​ "ENV-FLAVOR-server"
17​ ]
18​}
19​No newline at end of file
View Options

needles/anaconda/package_selection/minimal_highlighted-custom.png

  • This binary file was added.
View Options

needles/anaconda/package_selection/minimal_selected-custom.json

  • This file was added.
1​{
2​ "area": [
3​ {
4​ "height": 14,
5​ "type": "match",
6​ "width": 114,
7​ "xpos": 28,
8​ "ypos": 177
9​ }
10​ ],
11​ "properties": [],
12​ "tags": [
13​ "anaconda_minimal_selected",
14​ "ENV-DISTRI-fedora",
15​ "LANGUAGE-english",
16​ "ENV-FLAVOR-server"
17​ ]
18​}
19​No newline at end of file
View Options

needles/anaconda/package_selection/minimal_selected-custom.png

  • This binary file was added.
View Options

needles/anaconda/package_selection/russian/minimal_highlighted_russian-custom.json

  • This file was added.
1​{
2​ "tags": [
3​ "LANGUAGE-russian",
4​ "anaconda_minimal_highlighted"
5​ ],
6​ "properties": [],
7​ "area": [
8​ {
9​ "xpos": 48,
10​ "type": "match",
11​ "height": 15,
12​ "ypos": 179,
13​ "width": 294
14​ }
15​ ]
16​}
17​No newline at end of file
View Options

needles/anaconda/package_selection/russian/minimal_highlighted_russian-custom.png

  • This binary file was added.
View Options

needles/anaconda/package_selection/russian/minimal_selected_russian-custom.json

  • This file was added.
1​{
2​ "area": [
3​ {
4​ "height": 15,
5​ "type": "match",
6​ "xpos": 31,
7​ "width": 310,
8​ "ypos": 179
9​ }
10​ ],
11​ "properties": [],
12​ "tags": [
13​ "LANGUAGE-russian",
14​ "anaconda_minimal_selected"
15​ ]
16​}
17​No newline at end of file
View Options

needles/anaconda/package_selection/russian/minimal_selected_russian-custom.png

  • This binary file was added.
View Options

needles/anaconda/partitioning/fs_ext4_preselected-cantarell17.json

  • This file was deleted.
This file was completely deleted. Show File Contents
View Options

needles/anaconda/partitioning/fs_ext4_preselected-cantarell17.png

  • This binary file was deleted.
View Options

needles/anaconda/partitioning/fs_ext4_preselected-cantarell18.json

  • This file was deleted.
This file was completely deleted. Show File Contents
View Options

needles/anaconda/partitioning/fs_ext4_preselected-cantarell18.png

  • This binary file was deleted.
View Options

needles/anaconda/partitioning/fs_ext4_preselected-cantarell20.json

  • This file was deleted.
This file was completely deleted. Show File Contents
View Options

needles/anaconda/partitioning/fs_ext4_preselected-cantarell20.png

  • This binary file was deleted.
View Options

needles/anaconda/partitioning/fs_ext4_preselected-freetype262.json

  • This file was deleted.
This file was completely deleted. Show File Contents
View Options

needles/anaconda/partitioning/fs_ext4_preselected-freetype262.png

  • This binary file was deleted.
View Options

needles/anaconda/partitioning/fs_ext4_preselected-gtk3195.json

  • This file was deleted.
This file was completely deleted. Show File Contents
View Options

needles/anaconda/partitioning/fs_ext4_preselected-gtk3195.png

  • This binary file was deleted.
View Options

needles/anaconda/partitioning/fs_ext4_preselected-gtk3197bug.json

  • This file was moved to needles/anaconda/partitioning/fs_xfs_preselected-gtk320.json.
View Options

needles/anaconda/partitioning/fs_ext4_preselected-gtk3197bug.png

  • This binary file was deleted.
View Options

needles/anaconda/partitioning/fs_ext4_preselected-gtk3199.json

1{ 1​{
2 "tags": [ 2​ "tags": [
3 "anaconda_part_fs", 3​ "anaconda_part_fs",
4​ "anaconda_part_fs_ext4_selected",
4 "ENV-DISTRI-fedora", 5​ "ENV-DISTRI-fedora",
5 "ENV-FLAVOR-server" 6​ "ENV-FLAVOR-server"
6 ], 7​ ],
7 "area": [ 8​ "area": [
8 { 9​ {
9 "ypos": 348, 10​ "ypos": 348,
10 "xpos": 376, 11​ "xpos": 376,
11 "type": "match", 12​ "type": "match",
12 "width": 73, 13​ "width": 73,
13 "height": 56 14​ "height": 56
14 } 15​ }
15 ], 16​ ],
16 "properties": [] 17​ "properties": []
17} 18​}
18No newline at end of file ​
View Options

needles/anaconda/partitioning/fs_ext4_preselected.json

  • This file was deleted.
This file was completely deleted. Show File Contents
View Options

needles/anaconda/partitioning/fs_ext4_preselected.png

  • This binary file was deleted.
View Options

needles/anaconda/partitioning/fs_xfs_preselected-cantarell172.json

  • This file was deleted.
This file was completely deleted. Show File Contents
View Options

needles/anaconda/partitioning/fs_xfs_preselected-cantarell172.png

  • This binary file was deleted.
View Options

needles/anaconda/partitioning/fs_xfs_preselected-gtk320.json

Loading...
View Options

needles/anaconda/partitioning/fs_xfs_preselected-gtk320.png

Loading...
View Options

needles/anaconda/partitioning/fs_xfs_preselected.json

Loading...
View Options

needles/anaconda/partitioning/fs_xfs_preselected.png

Loading...
View Options

templates

Loading...