Differential D843

workaround mcelog failing
ClosedPublic
Actions

Authored by garretraziel on May 6 2016, 2:33 PM.

Details

Reviewers
adamwill
jskladan
Commits
rOPENQATESTS05f33bbd3998: workaround mcelog failing
Summary

mcelog service is failing from time to time, but we've decided in
https://bugzilla.redhat.com/show_bug.cgi?id=1274193 that we don't mind. This
adds softfail when mcelog is only failing service in base_services_start.

Test Plan

Run base_services_start test.

Diff Detail

Repository
rOPENQATESTS os-autoinst-distri-fedora
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
garretraziel retitled this revision from to workaround mcelog failing.May 6 2016, 2:33 PM
garretraziel updated this object.
garretraziel edited the test plan for this revision. (Show Details)
garretraziel added reviewers: adamwill, jskladan.
jskladan accepted this revision.May 12 2016, 8:20 AM
This revision is now accepted and ready to land.May 12 2016, 8:20 AM
adamwill added a comment.May 19 2016, 2:10 PM

"we've decided in
https://bugzilla.redhat.com/show_bug.cgi?id=1274193 that we don't mind"

meh. that's not _exactly_ what we decided. The decision in that bug involved "as it seems pretty clearly limited to a specific processor family" - some specific AMD family. Our openQA runs on Intel, so I don't think it's running into that bug.

I think we should open a bug on the openQA case and actually figure out what's happening, before deciding this is a softfail.

adamwill requested changes to this revision.May 19 2016, 2:25 PM
This revision now requires changes to proceed.May 19 2016, 2:25 PM
adamwill accepted this revision.May 30 2016, 11:40 PM

So since the bug was now rejected as a release blocker, it's probably appropriate to merge this now.

This revision is now accepted and ready to land.May 30 2016, 11:40 PM
Closed by commit rOPENQATESTS05f33bbd3998: workaround mcelog failing (authored by garretraziel). · Explain WhyJun 1 2016, 6:13 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathPackages
Mtests/base_services_start.pm (7 lines)

Diff 2240

View Options

tests/base_services_start.pm

1use base "installedtest"; 1​use base "installedtest";
2use strict; 2​use strict;
3use testapi; 3​use testapi;
4 4​
5sub run { 5​sub run {
6 my $self=shift; 6​ my $self=shift;
7 if (get_var("ARCH") eq "arm") { 7​ if (get_var("ARCH") eq "arm") {
8 # we cannot use boot_to_login_screen, wait_still_screen is unusable during ARM boot (it shows black screen for first few minutes) 8​ # we cannot use boot_to_login_screen, wait_still_screen is unusable during ARM boot (it shows black screen for first few minutes)
9 assert_screen "text_console_login", 150; 9​ assert_screen "text_console_login", 150;
10 } else { 10​ } else {
11 # wait for boot to complete 11​ # wait for boot to complete
12 $self->boot_to_login_screen("", 30); 12​ $self->boot_to_login_screen("", 30);
13 } 13​ }
14 # switch to TTY3 for both, graphical and console tests 14​ # switch to TTY3 for both, graphical and console tests
15 $self->root_console(tty=>3); 15​ $self->root_console(tty=>3);
16 validate_script_output 'systemctl --failed', sub { $_ =~ m/0 loaded units/ }; 16​ my $output = script_output 'systemctl --failed';
17​ if ($output =~ /1 loaded units/ && $output =~ /mcelog.service/) {
18​ record_soft_failure;
19​ } elsif (! $output =~ /0 loaded units/) {
20​ die "Services other than mcelog failed to load";
21​ }
17} 22​}
18 23​
19 24​
20sub test_flags { 25​sub test_flags {
21 # without anything - rollback to 'lastgood' snapshot if failed 26​ # without anything - rollback to 'lastgood' snapshot if failed
22 # 'fatal' - whole test suite is in danger if this fails 27​ # 'fatal' - whole test suite is in danger if this fails
23 # 'milestone' - after this test succeeds, update 'lastgood' 28​ # 'milestone' - after this test succeeds, update 'lastgood'
24 # 'important' - if this fails, set the overall state to 'fail' 29​ # 'important' - if this fails, set the overall state to 'fail'
25 return { fatal => 1 }; 30​ return { fatal => 1 };
26} 31​}
27 32​
281; 33​1;
29 34​
30# vim: set sw=4 et: 35​# vim: set sw=4 et: