add desktop_terminal test, refactor test loading a bit
ClosedPublic

Authored by adamwill on May 4 2016, 11:33 PM.

Details

Summary

I really just want to add the desktop_terminal test, but I think
this refactor is in order now. It splits up loading of the
various test phases (much as SUSE do it) and allows us to run
the post-install tests without the install tests, for e.g. I
tweaked things to allow the upgrade tests to use the existing
_wait_login tests for final login and combine the two upgrade
postinstall tests into one simple one.

This comes with a bit of a behaviour change to make graphical
wait login behave the same as console wait login: it will log
in unless USER_LOGIN is set to 'false'. Previously it only
logged in if both USER_LOGIN and USER_PASSWORD were set, which
I don't think ever happened in a graphical test, so we never
actually did a graphical login. The intent here is we should do
a login on the default_install tests. That's going a bit beyond
the test case, but it seems like a reasonable thing to test. We
can set USER_LOGIN to false if we don't want to do it.

Test Plan

Do a full test run, make sure the new tests work and
no old tests break.

Diff Detail

Repository
rOPENQATESTS os-autoinst-distri-fedora
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
adamwill retitled this revision from to add desktop_terminal test, refactor test loading a bit.May 4 2016, 11:33 PM
adamwill updated this object.
adamwill edited the test plan for this revision. (Show Details)
adamwill added reviewers: jskladan, garretraziel.
adamwill updated this revision to Diff 2151.May 5 2016, 12:33 AM

Add the needles

adamwill updated this revision to Diff 2153.May 5 2016, 5:32 AM

tweak various things to fix upgrade tests etc

There's still an outstanding issue: the server upgrade test fails
because the username is 'ejohn' and that does not match the user_
logged_in needle. We either need to relax that needle, add a new
one for ejohn, or just change the damn user for the upgrade test
disk images to be 'test', not 'ejohn'...

adamwill updated this revision to Diff 2155.May 5 2016, 7:00 AM

update disk image names and templates for ejohn->test change

garretraziel accepted this revision.May 5 2016, 1:10 PM
This revision is now accepted and ready to land.May 5 2016, 1:10 PM
This revision was automatically updated to reflect the committed changes.