| tflink |
Tested locally by putting some non-ascii characters into the justification field, worked.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| Path | Packages | |||
|---|---|---|---|---|
| M | blockerbugs/controllers/main.py (10 lines) |
| Commit | Tree | Parents | Author | Summary | Date |
|---|---|---|---|---|---|
| 35d9169749b9 | 0e0e414b0cd5 | edca77e3f110 | Martin Krizek | Use unicode instead of str on data passed from forms (Show More…) | May 2 2016, 11:48 AM |
| Show First 20 Lines • Show All 383 Lines • ▼ Show 20 Line(s) | 379 | def propose_bug(): | |||
|---|---|---|---|---|---|
| 384 | bugform = BugProposeForm() | 384 | bugform = BugProposeForm() | ||
| 385 | bugform.bz_user.data = user_info.bz_user | 385 | bugform.bz_user.data = user_info.bz_user | ||
| 386 | bugform.milestone.choices = [(m.id, m.name) for m in Milestone.query.filter_by(active=True).all()] | 386 | bugform.milestone.choices = [(m.id, m.name) for m in Milestone.query.filter_by(active=True).all()] | ||
| 387 | 387 | | |||
| 388 | if bugform.validate_on_submit(): | 388 | if bugform.validate_on_submit(): | ||
| 389 | app.logger.debug('bugid: %i' % bugform.bugid.data) | 389 | app.logger.debug('bugid: %i' % bugform.bugid.data) | ||
| 390 | app.logger.debug('bz_user: %s' % user_info.bz_user) | 390 | app.logger.debug('bz_user: %s' % user_info.bz_user) | ||
| 391 | app.logger.debug('milestone: %i' % bugform.milestone.data) | 391 | app.logger.debug('milestone: %i' % bugform.milestone.data) | ||
| 392 | app.logger.debug('blocker: %s' % str(bugform.blocker.data)) | 392 | app.logger.debug('blocker: %s' % unicode(bugform.blocker.data)) | ||
| 393 | app.logger.debug('freeze_exception: %s' % str(bugform.freeze_exception.data)) | 393 | app.logger.debug('freeze_exception: %s' % unicode(bugform.freeze_exception.data)) | ||
| 394 | app.logger.debug('justification: %s' % str(bugform.justification.data)) | 394 | app.logger.debug('justification: %s' % unicode(bugform.justification.data)) | ||
| 395 | 395 | | |||
| 396 | selected_milestone = Milestone.query.filter_by(id=bugform.milestone.data).first() | 396 | selected_milestone = Milestone.query.filter_by(id=bugform.milestone.data).first() | ||
| 397 | bugid = bugform.bugid.data | 397 | bugid = bugform.bugid.data | ||
| 398 | 398 | | |||
| 399 | trackers = {'blocker': selected_milestone.blocker_tracker, | 399 | trackers = {'blocker': selected_milestone.blocker_tracker, | ||
| 400 | 'fe': selected_milestone.fe_tracker} | 400 | 'fe': selected_milestone.fe_tracker} | ||
| 401 | 401 | | |||
| 402 | app.logger.debug('selected trackers: %s' % str(trackers)) | 402 | app.logger.debug('selected trackers: %s' % unicode(trackers)) | ||
| 403 | 403 | | |||
| 404 | # The form does basic datatype validation but we need to check for valid | 404 | # The form does basic datatype validation but we need to check for valid | ||
| 405 | # data | 405 | # data | ||
| 406 | bz = get_bugzilla() | 406 | bz = get_bugzilla() | ||
| 407 | proposer = BlockerProposal(bz, bugid, trackers, bugform.blocker.data, | 407 | proposer = BlockerProposal(bz, bugid, trackers, bugform.blocker.data, | ||
| 408 | bugform.freeze_exception.data, user_info.bz_user) | 408 | bugform.freeze_exception.data, user_info.bz_user) | ||
| 409 | 409 | | |||
| 410 | # check bug to make sure it exists and that it isn't closed | 410 | # check bug to make sure it exists and that it isn't closed | ||
| Show All 20 Lines | 430 | try: | |||
| 431 | proposer.propose_bugs(user, selected_milestone.name, bugform.justification.data) | 431 | proposer.propose_bugs(user, selected_milestone.name, bugform.justification.data) | ||
| 432 | return render_template('thanks.html', bugid=bugid, | 432 | return render_template('thanks.html', bugid=bugid, | ||
| 433 | isblocker=bugform.blocker.data, | 433 | isblocker=bugform.blocker.data, | ||
| 434 | isfe=bugform.freeze_exception.data) | 434 | isfe=bugform.freeze_exception.data) | ||
| 435 | except BZInterfaceError, e: | 435 | except BZInterfaceError, e: | ||
| 436 | bugform.bugid.errors = [e.msg] | 436 | bugform.bugid.errors = [e.msg] | ||
| 437 | app.logger.info('bug proposal form errors: %s' % e.msg) | 437 | app.logger.info('bug proposal form errors: %s' % e.msg) | ||
| 438 | else: | 438 | else: | ||
| 439 | app.logger.info('bug proposal form errors: %s' % str(bugform.errors)) | 439 | app.logger.info('bug proposal form errors: %s' % unicode(bugform.errors)) | ||
| 440 | 440 | | |||
| 441 | # this assumes that the current milestone is the release against which the | 441 | # this assumes that the current milestone is the release against which the | ||
| 442 | # blocker is being proposed. It isn't an ideal assumption but it should hold | 442 | # blocker is being proposed. It isn't an ideal assumption but it should hold | ||
| 443 | # for most use cases. | 443 | # for most use cases. | ||
| 444 | 444 | | |||
| 445 | current_release = get_current_milestone().release.number | 445 | current_release = get_current_milestone().release.number | ||
| 446 | return render_template('propose_bug.html', title='Propose a Blocker or Freeze Exception', | 446 | return render_template('propose_bug.html', title='Propose a Blocker or Freeze Exception', | ||
| 447 | bugform=bugform, release=current_release) | 447 | bugform=bugform, release=current_release) | ||