Differential D815

handle 'weak password' due to dictionary load error
ClosedPublic
Actions

Authored by adamwill on Apr 15 2016, 6:23 AM.

Details

Reviewers
garretraziel
jskladan
Commits
rOPENQATESTS90b5acf72a7b: handle 'weak password' due to dictionary load error
Summary

Rawhide currently seems to have a bug in spell check dictionary
load, which causes the test to fail as it requires another Done
click. So add a workaround needle that handles this case.

Test Plan

Apply the patch, run some tests, see if they work. I
did a test run on staging:
https://openqa.stg.fedoraproject.org/tests/13331

Diff Detail

Repository
rOPENQATESTS os-autoinst-distri-fedora
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
adamwill retitled this revision from to handle 'weak password' due to dictionary load error.Apr 15 2016, 6:23 AM
adamwill updated this object.
adamwill edited the test plan for this revision. (Show Details)
adamwill added reviewers: jskladan, garretraziel.
This revision is now accepted and ready to land.Apr 15 2016, 6:32 AM
Closed by commit rOPENQATESTS90b5acf72a7b: handle 'weak password' due to dictionary load error (authored by adamwill). · Explain WhyApr 15 2016, 6:37 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

Diff 2076

View Options

needles/anaconda_install_password_dictionary_error.json

  • This file was added.
1​{
2​ "tags": [
3​ "ENV-DISTRI-fedora",
4​ "LANGUAGE-english",
5​ "anaconda_install_password_dictionary_error"
6​ ],
7​ "area": [
8​ {
9​ "xpos": 511,
10​ "ypos": 742,
11​ "width": 145,
12​ "height": 18,
13​ "type": "match"
14​ }
15​ ],
16​ "properties": [
17​ "workaround"
18​ ]
19​}
20​No newline at end of file
View Options

needles/anaconda_install_password_dictionary_error.png

  • This binary file was added.
View Options

tests/_do_install_and_reboot.pm

Show All 15 Lines5sub run {
16 # Set root password 16​ # Set root password
17 my $root_password = get_var("ROOT_PASSWORD") || "weakpassword"; 17​ my $root_password = get_var("ROOT_PASSWORD") || "weakpassword";
18 assert_and_click "anaconda_install_root_password"; 18​ assert_and_click "anaconda_install_root_password";
19 assert_screen "anaconda_install_root_password_screen"; 19​ assert_screen "anaconda_install_root_password_screen";
20 type_string $root_password; 20​ type_string $root_password;
21 send_key "tab"; 21​ send_key "tab";
22 type_string $root_password; 22​ type_string $root_password;
23 assert_and_click "anaconda_spoke_done"; 23​ assert_and_click "anaconda_spoke_done";
24​ if (check_screen "anaconda_install_password_dictionary_error", 10) {
25​ assert_and_click "anaconda_spoke_done";
26​ }
24 27​
25 # Set user details 28​ # Set user details
26 sleep 1; 29​ sleep 1;
27 my $user_login = get_var("USER_LOGIN") || "test"; 30​ my $user_login = get_var("USER_LOGIN") || "test";
28 my $user_password = get_var("USER_PASSWORD") || "weakpassword"; 31​ my $user_password = get_var("USER_PASSWORD") || "weakpassword";
29 assert_and_click "anaconda_install_user_creation"; 32​ assert_and_click "anaconda_install_user_creation";
30 assert_screen "anaconda_install_user_creation_screen"; 33​ assert_screen "anaconda_install_user_creation_screen";
31 type_string $user_login; 34​ type_string $user_login;
32 assert_and_click "anaconda_user_creation_password_input"; 35​ assert_and_click "anaconda_user_creation_password_input";
33 type_string $user_password; 36​ type_string $user_password;
34 send_key "tab"; 37​ send_key "tab";
35 type_string $user_password; 38​ type_string $user_password;
36 assert_and_click "anaconda_install_user_creation_make_admin"; 39​ assert_and_click "anaconda_install_user_creation_make_admin";
37 assert_and_click "anaconda_spoke_done"; 40​ assert_and_click "anaconda_spoke_done";
41​ # handle 'weak password' due to dictionary error: WORKAROUND
42​ if (check_screen "anaconda_install_password_dictionary_error", 10) {
43​ assert_and_click "anaconda_spoke_done";
44​ }
38 45​
39 # Check username (and hence keyboard layout) if non-English 46​ # Check username (and hence keyboard layout) if non-English
40 if (get_var('LANGUAGE')) { 47​ if (get_var('LANGUAGE')) {
41 assert_screen "anaconda_install_user_created"; 48​ assert_screen "anaconda_install_user_created";
42 } 49​ }
43 50​
44 # Wait for install to end. Give Rawhide a bit longer, in case 51​ # Wait for install to end. Give Rawhide a bit longer, in case
45 # we're on a debug kernel, debug kernel installs are really slow. 52​ # we're on a debug kernel, debug kernel installs are really slow.
Show All 21 Lines