removing python-daemon as a requirement. Fixes T768
ClosedPublic

Authored by tflink on Apr 14 2016, 2:25 PM.

Details

Summary

Removing daemon from requirements.txt, it was causing problems on package-based deployments

Test Plan

try new package, does it work when installed on a clean system?

Diff Detail

Repository
rTRGR taskotron-trigger
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tflink retitled this revision from to removing python-daemon as a requirement. Fixes T768.Apr 14 2016, 2:25 PM
tflink updated this object.
tflink edited the test plan for this revision. (Show Details)
tflink added reviewers: mkrizek, kparal.

More detailed testing suggestion:

  1. apply patch
  2. build package with make mockbuild
  3. spawn f23 vm
  4. install the freshly built package in that VM
  5. make sure that /etc/taskotron/trigger.cfg has type = StreamTrigger in it
  6. systemctl start fedmsg-hub
  7. look at /var/log/fedmsg/taskotron-trigger.log and make sure that there are no TBs from our modules loading
  8. watch /var/log/fedmsg/taskotron-trigger.log, if it responds to a koji build fedmsg, we have worky!

I really want a package built with this fix today and it looks like folks are offline until tomorrow.

I'm going to go ahead and build a package with this patch in COPR, assuming ACK on such a small change and discussion in the ticket. I will fix things if this patch is not acked in the end

mkrizek accepted this revision.Apr 15 2016, 7:25 AM
This revision is now accepted and ready to land.Apr 15 2016, 7:25 AM
kparal accepted this revision.Apr 15 2016, 12:06 PM

After some configuration pain it's working.

This revision was automatically updated to reflect the committed changes.