Differential D810

provide useful info if rpmlint stats are missing
ClosedPublic
Actions

Authored by kparal on Apr 12 2016, 1:28 PM.

Details

Reviewers
mkrizek
Maniphest Tasks
T763: rpmlint fails with "AttributeError: 'NoneType' object has no attribute 'group'"
Commits
rRPMLINTa432974c2be5: provide useful info if rpmlint stats are missing
Summary

A crash was reported which seemed to indicate that rpmlint stats line
was not present as the last line (T763). It is not reproducible, so at
least print useful debug info when that happens.

Test Plan

running manually works

Diff Detail

Repository
rRPMLINT task-rpmlint
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kparal retitled this revision from to provide useful info if rpmlint stats are missing.Apr 12 2016, 1:28 PM
kparal updated this object.
kparal edited the test plan for this revision. (Show Details)
kparal added a reviewer: mkrizek.
mkrizek accepted this revision.Apr 12 2016, 1:32 PM
This revision is now accepted and ready to land.Apr 12 2016, 1:32 PM
Closed by commit rRPMLINTa432974c2be5: provide useful info if rpmlint stats are missing (authored by kparal). · Explain WhyApr 12 2016, 1:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathPackages
Mrun_rpmlint.py (12 lines)

Diff 2067

View Options

run_rpmlint.py

Show First 20 Lines • Show All 104 Lines • ▼ Show 20 Line(s)90def run_rpmlint(command):
105 if proc.returncode == 0: 105​ if proc.returncode == 0:
106 outcome = 'PASSED' 106​ outcome = 'PASSED'
107 else: 107​ else:
108 if proc.returncode == 64 or proc.returncode == 66: 108​ if proc.returncode == 64 or proc.returncode == 66:
109 outcome = 'FAILED' 109​ outcome = 'FAILED'
110 else: 110​ else:
111 outcome = 'ABORTED' 111​ outcome = 'ABORTED'
112 112​
113​ errors = 0
114​ warnings = 0
113 match = re.search(r'(\d+) errors, (\d+) warnings', output[-1] if output else '') 115​ match = re.search(r'(\d+) errors, (\d+) warnings', output[-1] if output else '')
114 errors = int(match.group(1)) 116​ if match:
115 warnings = int(match.group(2)) 117​ errors = int(match.group(1))
118​ warnings = int(match.group(2))
119​ if not match and outcome != 'ABORTED':
120​ errmsg = ('No rpmlint stats on the last line, should not happen. Exit code %d, output:\n%s'
121​ % (proc.returncode, ''.join(output)))
122​ log.critical(errmsg)
123​ assert False, 'No rpmlint stats on the last line'
116 124​
117 result = Result(outcome=outcome, output=output, errors=errors, warnings=warnings) 125​ result = Result(outcome=outcome, output=output, errors=errors, warnings=warnings)
118 return result 126​ return result
119 127​
120 128​
121if __name__ == '__main__': 129​if __name__ == '__main__':
122 output = run('local-run') 130​ output = run('local-run')
123 print output 131​ print output